[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang abandoned this revision. weiwang added a comment. Diff has been split into 3 smaller ones: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization remarks

[PATCH] D85808: [remarks] Optimization remarks hotness filetering from profile summary

weiwang added reviewers: wenlei, hoyFB. weiwang added a comment. This is the the 3rd of 3 dependent patches: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks]

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang added reviewers: wenlei, hoyFB. weiwang added a comment. This is the the 2nd of 3 dependent patches: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks]

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. weiwang requested review of this revision. Propagate driver commandline remarks options to link. Pass-through happens when: 1. LTO is enabled; 2. Single arch target is specified; 3.

[PATCH] D85808: [remarks] Optimization remarks hotness filetering from profile summary

weiwang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, hiraditya, eraman, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. weiwang requested review of this

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ExprCXX.h:4582 +if (isLeftFold()) + return getEllipsisLoc(); +return getLHS()->getBeginLoc(); Can this

[PATCH] D85543: Limit Max Vector alignment on COFF targets to 8192

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85543/new/ https://reviews.llvm.org/D85543 ___ cfe-commits mailing list

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

craig.topper created this revision. craig.topper added reviewers: echristo, erichkeane, nickdesaulniers. Herald added a project: clang. craig.topper requested review of this revision. We can use this to remove some calls to initFeatureMap from Sema and CodeGen when a function doesn't have a

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert updated this revision to Diff 284961. jdoerfert added a comment. Update for @alokmishra.besu via arcanist as the webinterface doesn't allow patches over 2MB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Are you planning to add support for the actual OpenMP selectors as well? All the other traits, scoring, etc. I left a comment below that points you to the right place as we have almost all

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. @ychen Again, thanks for your comment! 1. Currently, `LoopInterchange` returns immediately if the loop is not a top-level one. The main purpose of the loop nest pass is to prevent situations like this and possibly save compiling time of uninteresting calls to `run`. 2.

[PATCH] D85806: [WebAssembly] Don't depend on the flags set by handleTargetFeatures in initFeatureMap.

craig.topper created this revision. craig.topper added a reviewer: tlively. Herald added subscribers: jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. craig.topper requested review of this revision. Herald added a subscriber: aheejin. Properly set "simd128" in the

[clang] 31e5f71 - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-08-11T20:22:11-07:00 New Revision: 31e5f7120bdd2f76337686d9d169b1c00e6ee69c URL: https://github.com/llvm/llvm-project/commit/31e5f7120bdd2f76337686d9d169b1c00e6ee69c DIFF: https://github.com/llvm/llvm-project/commit/31e5f7120bdd2f76337686d9d169b1c00e6ee69c.diff

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

rjmccall added a comment. I always imagined that we'd implement this by just inverting the emission: emit the RHS of the assignment and then pass a callback down to a function that descended into conditional operators and called the callback when it hit a leaf. Having an LValue case that's an

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert added a comment. I think the test fail because D85735 was not part of the build. Works locally just fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777

[PATCH] D85755: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I don't follow this logic but that is not going to change right now. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85755/new/

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny added a comment. In D74051#2211869 , @tstellar wrote: > In D74051#2017115 , @mgorny wrote: > >> Nevermind, I figured out good enough workaround. > > What was the workaround? Unpack

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert updated this revision to Diff 284954. jdoerfert added a comment. Reintroduce requires-target into tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

OikawaKirie updated this revision to Diff 284952. OikawaKirie marked an inline comment as done. OikawaKirie added a comment. Now it has a link to the `getEndPath`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85105/new/ https://reviews.llvm.org/D85105 Files:

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper added a comment. In D83273#2195033 , @nickdesaulniers wrote: > In D83273#2194869 , @echristo wrote: > >> That said, it's a 10% compile time regression for compiling something like >> the linux kernel

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rjmccall, rsmith, pcc, hansec. leonardchan added a project: clang. Herald added subscribers: dang, dschuff. leonardchan requested review of this revision. Herald added a subscriber: aheejin. This implements the flag

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang created this revision. akhuang added reviewers: dblaikie, aprantl, MaskRay. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. akhuang requested review of this revision. This adds a cc1 flag to enable constructor homing but doesn't turn on debug info if it wasn't

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ added a comment. Thanks!! I'm having second thoughts on re-using the existing builder. Most other `runCheckers...()` methods are building their own. Given how confusing this entire node builder business is, i believe we should not deviate from known working patterns. Please forgive me if

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210 GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File); + if (!Opts.ClangTidyOpts.Checks) { +// If the user hasn't configured clang-tidy checks at all, including

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

tra created this revision. tra added a reviewer: MaskRay. Herald added subscribers: sanjoy.google, mstorsjo, jfb, atanasyan, bixia, jrtc27, kbarton, krytarowski, nemanjai. Herald added a project: clang. tra requested review of this revision. Herald added a subscriber: wuzish. Some parts of the

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Reworked ;) Now it should ignore structs properly. ut 11. 8. 2020 o 22:03 Arthur O'Dwyer napísal(a): > > Dávid: Please just disable it for initializers of structs. That seems to be > the common denominator in all the false positives I've observed on this > thread. > > > On Tue, Aug 11, 2020 at

[clang] b9af72b - [Diagnostics] Reworked -Wstring-concatenation

Author: Dávid Bolvanský Date: 2020-08-12T02:18:01+02:00 New Revision: b9af72bffe5f2769f3a7858a785981f89137a0ce URL: https://github.com/llvm/llvm-project/commit/b9af72bffe5f2769f3a7858a785981f89137a0ce DIFF:

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM from me if XRay actually does work on non-x86_64 macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85773/new/

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added a comment. Looks good in general. Mostly C++ style comments below. Comment at: clang/include/clang/Basic/TargetID.h:30 +/// Returns canonical processor name or empty if the processor name is invalid. +llvm::StringRef getProcessorFromTargetID(const llvm::Triple , +

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. vrnithinkumar requested review of this revision. Fixing tests Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85796 Files:

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

tstellar added a comment. In D74051#2017115 , @mgorny wrote: > Nevermind, I figured out good enough workaround. What was the workaround? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 284926. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2787-2789 // Mimicking gcc's behavior, trigraphs are only enabled if -trigraphs - // is specified, or -std is set to a conforming mode. + // is specified, -std is set to a

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

guiand updated this revision to Diff 284922. guiand added a comment. Added `willreturn`. I think `nocapture` is probably best left to a future change since it's more invasive -- it would require keeping tabs of which arguments to each function is a pointer arg. Repository: rG LLVM Github

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand requested review of this revision. guiand added a comment. I think I'd like someone to take a look at the `llvm-lit` changes to see if this makes sense as an approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/

[PATCH] D85789: [Parser] Suppress -Wempty-translation-unit if this is a header file

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95. Herald added a project: clang. sammccall requested review of this revision. Herald added a subscriber: ilya-biryukov. This is motivated by tooling (clangd, libclang etc) -

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 284907. guiand added a comment. Herald added a subscriber: delcypher. To try to alleviate the tests issue, @eugenis and I discussed that it might be best to take it slow. So now this patch will mask off emitting the attribute on clang tests by default.

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. After discussing with @eugenis, for the meantime it might be best to do the following: - Change the masking attribute to be `-fdisable-noundef-analysis` (name notwithstanding), and have it completely turn off all `noundef`s - Change the llvm-lit configuration to use the

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06d100a69a08: [Analyzer] Support note tags for smart ptr checker (authored by vrnithinkumar). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 06d100a - [Analyzer] Support note tags for smart ptr checker

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-08-11T23:27:16+02:00 New Revision: 06d100a69a08632e6a553a7fb4d3750b55145946 URL: https://github.com/llvm/llvm-project/commit/06d100a69a08632e6a553a7fb4d3750b55145946 DIFF:

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert updated this revision to Diff 284898. jdoerfert added a comment. Update test and include mock `type_traits` header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 Files:

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

rsmith added a comment. In D85256#2211129 , @rsmith wrote: > This appears to be a general problem: the `GetExprRange` mechanism in > SemaChecking miscomputes the ranges for `+`, `*`, and `-` expressions, and > we'll get them wrong for all warnings that

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 284882. yaxunl added a comment. rebase to ToT and minor bug fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

rsmith created this revision. rsmith added reviewers: sberg, rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsmith requested review of this revision. Continue to heuristically pick the wider of the two operands for narrowing conversion warnings so that some_char +

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev. Herald added subscribers: guansong, bollu, yaxunl, mgorny. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. The last (big) missing piece

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 284875. aeubanks added a comment. Specify target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D85457 Files: clang/test/CodeGen/O0-no-skipped-passes.c

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Dávid: Please just disable it for initializers of structs. That seems to be the common denominator in all the false positives I've observed on this thread. On Tue, Aug 11, 2020 at 3:07 PM Dávid Bolvanský wrote: > Ok, I will bump that limit + 1. > > ut 11. 8. 2020 o 20:52 Arthur Eubanks via

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

azharudd created this revision. azharudd added a reviewer: arphaman. Herald added subscribers: cfe-commits, dexonsmith, dberris. Herald added a project: clang. azharudd requested review of this revision. For macOS, the code says, the XRay flag is only supported on x86_64. Updating the test and

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu updated this revision to Diff 284858. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[libunwind] 9b211a5 - [libunwind] Fix incorrect check for out-of-boundedness

Author: Louis Dionne Date: 2020-08-11T15:37:57-04:00 New Revision: 9b211a5076310f14081dd257b0cbac6857534bc3 URL: https://github.com/llvm/llvm-project/commit/9b211a5076310f14081dd257b0cbac6857534bc3 DIFF: https://github.com/llvm/llvm-project/commit/9b211a5076310f14081dd257b0cbac6857534bc3.diff

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

arsenm added a comment. In D84068#2210872 , @echristo wrote: > Hi All, > > I'd really like to avoid depending on any program other than clang installing > something into clang's working directory. I think this needs to be written > from the perspective

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert added a comment. In D85735#2210662 , @JonChesterfield wrote: > Nice. What makes it an extension? 5.0 / 2.3.5 claims "and where > variant-func-id is the name of a function variant that is either a base > language identifier or, for C++, a

[libunwind] e8dac8b - [libunwind][NFC] Fix typo in comment

Author: Louis Dionne Date: 2020-08-11T15:24:52-04:00 New Revision: e8dac8b3dbe7a31af291032f1f3e95e789200590 URL: https://github.com/llvm/llvm-project/commit/e8dac8b3dbe7a31af291032f1f3e95e789200590 DIFF: https://github.com/llvm/llvm-project/commit/e8dac8b3dbe7a31af291032f1f3e95e789200590.diff

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:209 // Update diag to point at include inside main file. D.File = SM.getFileEntryForID(SM.getMainFileID())->getName().str(); D.Range = std::move(R); can't we rather

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

rsmith added a comment. In D85256#2209211 , @sberg wrote: > I think this generates a false positive with `test.cc` > > enum E { E1 = 1, E2 = 2 }; > bool f(E e) { return ((e & E1) ? 1 : 0) + ((e & E2) ? 1 : 0) > 1; } > > and `clang++ -fsyntax-only

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Ok, I will bump that limit + 1. ut 11. 8. 2020 o 20:52 Arthur Eubanks via Phabricator napísal(a): > > aeubanks added a comment. > > In D85545#2211070 , @xbolva00 wrote: > > > I check if all elements of init list are strings, so this is not > > exactly

[clang] ec5f793 - [OpenMP] split execution of a long test into smaller parts.

Author: Artem Belevich Date: 2020-08-11T11:52:40-07:00 New Revision: ec5f793996f4dc86d339db88c0836e0cf4e8abea URL: https://github.com/llvm/llvm-project/commit/ec5f793996f4dc86d339db88c0836e0cf4e8abea DIFF:

[PATCH] D85695: [OpenMP] split execution of a long test into smaller parts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec5f793996f4: [OpenMP] split execution of a long test into smaller parts. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2211070 , @xbolva00 wrote: > I check if all elements of init list are strings, so this is not > exactly true "struct checker" (I have no such info in that part of > code..) but I consider it good enough. Your test case

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

ABataev updated this revision to Diff 284836. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85321/new/ https://reviews.llvm.org/D85321 Files: clang/lib/Sema/SemaOpenMP.cpp

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

I check if all elements of init list are strings, so this is not exactly true "struct checker" (I have no such info in that part of code..) but I consider it good enough. Your test case is based on real code? Does not seem so - well sure, we could construct many examples where warning fires

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. In D83360#2210630 , @nikic wrote: > D85684 has landed, so we can try reapplying > this change. I've put up D85765 with this patch and the follow ups

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

ABataev updated this revision to Diff 284830. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov added a comment. @NoQ > You're on the right track but your checker repeats `PthreadLockChecker` > word-by-word. Like, you can find answers to all your questions (eg., "how to > use `isLiveRegion`?") by reading that checker. C++ functions aren't any > different from C functions;

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

NoQ added a comment. Thanks!! Could you also unforget the diff context? >.< Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:270-272 +default: + llvm_unreachable("Invalid template argument for isa<> or " + "isa_and_nonnull<>");

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2201484 , @rsmith wrote: > I think it would be reasonable in general to guarantee that our `__builtin_` > functions have contracts at least as wide as the underlying C function, but > allow them to have extensions, and to

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:73 +Ty = STTPTy->getReplacementType(); + if (Ty->isPointerType()) +Ty = Ty->getPointeeType(); Is this doing what you intended? What about a reference to a

[PATCH] D84886: Create LoopNestPass

ychen added a comment. Hello, sorry for the late reply. I have some high-level questions - What are existing and future loop passes/analyses that could benefit from using LoopNestPass? - I'd feel more comfortable if existing loop pass/analysis managers could be extended to handle LoopNestPass,

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

NoQ added a comment. Yes, i completely agree that this is the right decision, thanks! Comment at: clang/lib/StaticAnalyzer/Core/DynamicType.cpp:71-72 +Ty = Ty.getNonReferenceType(); + if (const auto *STTPTy = dyn_cast(Ty.getTypePtr())) +Ty =

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

NoQ added a comment. You're on the right track but your checker repeats `PthreadLockChecker` word-by-word. Like, you can find answers to all your questions (eg., "how to use `isLiveRegion`?") by reading that checker. C++ functions aren't any different from C functions; that's an extremely

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. The base must be shared between the threads, threadprivates are not

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

echristo added a comment. Hi All, I'd really like to avoid depending on any program other than clang installing something into clang's working directory. I think this needs to be written from the perspective of specifying another directory to look for things. -eric CHANGES SINCE LAST ACTION

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. Actually sorry, it does still seem like there are false positives on structs. Reduced: $ cat /tmp/a.cpp struct A { const char* a; const char* b; const char* c; }; static constexpr A foo2 = A{"", ""

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 284815. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz added a reviewer: sammccall. adamcz added a comment. Hey Sam. What's your opinion on this? The options we have are: 1. Drop the diagnostics, like this change is doing 2. Relocate the diagnostic to the beginning of the "real" main file, like we do with SourceManager-less diagnostics 3.

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz updated this revision to Diff 284811. adamcz added a comment. log dropped dianostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85753/new/ https://reviews.llvm.org/D85753 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1024 + // representation of built-in and user-defined operators. + if (child->getBeginLoc() == S->getOperatorLoc()) +continue; eduucaldas wrote: > Here we want

[clang] b9aaf32 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2020-08-11T18:13:03+01:00 New Revision: b9aaf32f46494695d1b20c08730c536e17f8 URL: https://github.com/llvm/llvm-project/commit/b9aaf32f46494695d1b20c08730c536e17f8 DIFF: https://github.com/llvm/llvm-project/commit/b9aaf32f46494695d1b20c08730c536e17f8.diff

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1016 // operand because it does not correspond to anything written in source // code + if

[PATCH] D85755: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. If the arguments are mapped, but are actually not used in the target region, the compiler still adds attribute

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Sema/SemaInit.cpp:3088 // No structured initializer list to update if (!StructuredList) return; ArcsinX

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno updated this revision to Diff 284803. riccibruno added a comment. Remove the now-unused `const VarDecl *` parameter to `DiagnoseIfOdrUse`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85613/new/ https://reviews.llvm.org/D85613 Files:

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

baloghadamsoftware updated this revision to Diff 284801. baloghadamsoftware retitled this revision from "[Analyzer][WIP] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker" to "[Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker".

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This can happen when building implicit modules, as demonstrated

[PATCH] D85752: [Analyzer] Store the pointed/referenced type for dynamic casts

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Charusso. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet,

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

JonChesterfield added a comment. Nice. What makes it an extension? 5.0 / 2.3.5 claims "and where variant-func-id is the name of a function variant that is either a base language identifier or, for C++, a template-id." which suggests this could be always-on Comment at:

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3088 // No structured initializer list to update if (!StructuredList) return; aaron.ballman wrote: > I would move the check up to here as the only time we should get a null >

[clang-tools-extra] d8c1f43 - [libTooling] Move RewriteRule include edits to ASTEdit granularity.

Author: Yitzhak Mandelbaum Date: 2020-08-11T16:47:14Z New Revision: d8c1f43dcc949fda5ce37a122d1a0d92975de82c URL: https://github.com/llvm/llvm-project/commit/d8c1f43dcc949fda5ce37a122d1a0d92975de82c DIFF: https://github.com/llvm/llvm-project/commit/d8c1f43dcc949fda5ce37a122d1a0d92975de82c.diff

[PATCH] D85734: [libTooling] Move RewriteRule include edits to ASTEdit granularity.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8c1f43dcc94: [libTooling] Move RewriteRule include edits to ASTEdit granularity. (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1024 + // representation of built-in and user-defined operators. + if (child->getBeginLoc() == S->getOperatorLoc()) +continue;

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

nikic added a comment. D85684 has landed, so we can try reapplying this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

eduucaldas updated this revision to Diff 284794. eduucaldas added a comment. Add explanation comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85750/new/ https://reviews.llvm.org/D85750 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3088 // No structured initializer list to update if (!StructuredList) return; I would move the check up to here as the only time we should get a null expression is if

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb29c33984bf: [clangd][ObjC] Improve xrefs for protocols and classes (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] cb29c33 - [clangd][ObjC] Improve xrefs for protocols and classes

Author: David Goldman Date: 2020-08-11T12:36:31-04:00 New Revision: cb29c33984bf40beebd22edf80a5034cf8849307 URL: https://github.com/llvm/llvm-project/commit/cb29c33984bf40beebd22edf80a5034cf8849307 DIFF: https://github.com/llvm/llvm-project/commit/cb29c33984bf40beebd22edf80a5034cf8849307.diff

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. For an user define `<`, `x < y` would yield the syntax tree: BinaryOperatorExpression |-IdExpression | `-UnqualifiedId | `-x

[clang] 645dd1b - [libTooling] Cleanup and reorder `RewriteRule.h`.

Author: Yitzhak Mandelbaum Date: 2020-08-11T16:35:36Z New Revision: 645dd1b3bf8d976683c72b9faf501d6f0b16326e URL: https://github.com/llvm/llvm-project/commit/645dd1b3bf8d976683c72b9faf501d6f0b16326e DIFF: https://github.com/llvm/llvm-project/commit/645dd1b3bf8d976683c72b9faf501d6f0b16326e.diff

[PATCH] D85733: [libTooling] Cleanup and reorder `RewriteRule.h`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG645dd1b3bf8d: [libTooling] Cleanup and reorder `RewriteRule.h`. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85734: [libTooling] Move RewriteRule include edits to ASTEdit granularity.

ymandel updated this revision to Diff 284789. ymandel added a comment. reword comment per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85734/new/ https://reviews.llvm.org/D85734 Files:

  1   2   3   >