[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 302738. LuoYuanke added a comment. Removed tilezero support in this patch. Fixed some bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/cla

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 302733. erik.pilkington marked 20 inline comments as done. erik.pilkington added a comment. Address review comments, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files: clang/include/cla

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation Loc, aaron.ballman wrote: > Why is t

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 302731. ckennelly added a comment. Expand tests to cover value and default initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/c

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Remove compilicated logic from CompilerInstance::InitializeSourceManager to deal with named pipes, updating FileManager::getBuff

[PATCH] D90275: [clang][IR] Add support for leaf attribute

mcgrathr added a comment. The GCC documentation specifically gives the example of the standard C function `qsort` as one that does not qualify as `__attribute__((leaf))` because it uses a callback function (that presumably might be from the caller's own TU). AIUI the claim the attribute makes

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/lambda-conversion-op-cc.cpp:10 void usage() { auto lambda = [](int i, float f, double d) CC { return i + f + d; }; rsmith wrote: > Does lambda-to-function-pointer decay still work (eg, `+la

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2372554 , @rnk wrote: > In D90719#2372463 , @dblaikie wrote: > >> Does Chromium need this fixed in clang? Or if it were fixed in libc++ would >> that be adequate? (does Chromium'

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6pm PST. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] cb9d0e8 - [clangd][NFC] Make Located::operator->() use pointer sematics

Author: Nathan James Date: 2020-11-04T01:36:14Z New Revision: cb9d0e8819ad7ca2f349a57d62ea2af02d631dfa URL: https://github.com/llvm/llvm-project/commit/cb9d0e8819ad7ca2f349a57d62ea2af02d631dfa DIFF: https://github.com/llvm/llvm-project/commit/cb9d0e8819ad7ca2f349a57d62ea2af02d631dfa.diff LOG:

[PATCH] D90682: [clangd][NFC] Make Located::operator->() use pointer sematics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9d0e8819ad: [clangd][NFC] Make Located::operator->() use pointer sematics (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3910 +in library functions. Functions marked with the ``leaf`` attribute are not allowed +to jump back into the caller's translation unit, whether through invoking a +callback function, a direct exte

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 302716. gulfem added a comment. Add a target into the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. Hello @DmitryPolukhin , Sorry I missed to update 'SUMMARY' section of this review earlier! was not aware that that will be considered as commit message. I have now updated the 'SUMMARY', it is possible to revert this commit and then re-submit it with updated commit messag

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

rnk added a subscriber: EricWF. rnk added a comment. In D90719#2372463 , @dblaikie wrote: > Does Chromium need this fixed in clang? Or if it were fixed in libc++ would > that be adequate? (does Chromium's build need to work with old libc++s, or > does it

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. No, chromium doesn't need this fixed in clang, but I didn't see a clear way to fix this in libc++. Do you think it should be fixed as a bug in libc++? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://review

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added a comment. In D90704#2372303 , @ABataev wrote: > It would be good if you could identify the object which leads to a crash, I > mean a target region, variable, etc. 1void 2add_one(float *b, int dm) 3{ 4#pragma omp

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

kcc added a reviewer: morehouse. kcc added a comment. did you consider approaches where the emitted code doesn't change, but the binary contains a debug-like metadata that corresponds to the trap instructions? Matt (CC-ed) has a patch if this kind (for a different purpose) in the works . CHANGE

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. Does Chromium need this fixed in clang? Or if it were fixed in libc++ would that be adequate? (does Chromium's build need to work with old libc++s, or does it always build with a libc++ that matches the compiler? (in the latter case, a fix in libc++ would be as good as

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. Test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90714/new/ https://reviews.llvm.org/D90714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. There are some types in libcxx that are used but their constructors are not called (__hash_node, __hash_value_typ

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/test/CodeGen/BPF/atomics_2.ll:124 +; CHECK: r0 = r2 +; CHECK: r0 = cmpxchg_64(r1 + 0, r0, r3) +; CHECK: encoding: [0xdb,0x01,0x00,0x00,0xf1,0x03,0x00,0x00] ast wrote: > Looks like it's generating correct code

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1285 + /// that someone who intentionally places 'thiscall' on the lambda call + /// operator will still get that overload, since we don't have the a way of + /// detecting the attribute by the time we get

[clang] 09b54e2 - When re-checking an already-substituted template argument, don't lose

Author: Richard Smith Date: 2020-11-03T14:09:54-08:00 New Revision: 09b54e2799a11c6813796c70475d52e09898568b URL: https://github.com/llvm/llvm-project/commit/09b54e2799a11c6813796c70475d52e09898568b DIFF: https://github.com/llvm/llvm-project/commit/09b54e2799a11c6813796c70475d52e09898568b.diff

[clang] a6d15d4 - Undo Revert "Ignore template instantiations if not in AsIs mode"

Author: Matt Morehouse Date: 2020-11-03T13:59:01-08:00 New Revision: a6d15d40701ad38f29e4ff93703b3ffa7b204611 URL: https://github.com/llvm/llvm-project/commit/a6d15d40701ad38f29e4ff93703b3ffa7b204611 DIFF: https://github.com/llvm/llvm-project/commit/a6d15d40701ad38f29e4ff93703b3ffa7b204611.diff

[clang] 72531ae - Revert "Ignore template instantiations if not in AsIs mode"

Author: Matt Morehouse Date: 2020-11-03T13:57:31-08:00 New Revision: 72531ae6e64d4408f6e9aee8d5902f5d6b0ae519 URL: https://github.com/llvm/llvm-project/commit/72531ae6e64d4408f6e9aee8d5902f5d6b0ae519 DIFF: https://github.com/llvm/llvm-project/commit/72531ae6e64d4408f6e9aee8d5902f5d6b0ae519.diff

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added a comment. It would be good if you could identify the object which leads to a crash, I mean a target region, variable, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 ___

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/test/CodeGen/BPF/atomics_2.ll:124 +; CHECK: r0 = r2 +; CHECK: r0 = cmpxchg_64(r1 + 0, r0, r3) +; CHECK: encoding: [0xdb,0x01,0x00,0x00,0xf1,0x03,0x00,0x00] Looks like it's generating correct code without special handlin

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc created this revision. mibintc added a reviewer: majnemer. Herald added a project: clang. mibintc requested review of this revision. Fix off-by-one bug in determining the threshold for when want to shorten very large external names, Microsoft compatibility. This fixes the bug reported her

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:916-918 + virtual const CXXInheritedCtorInitExpr *getOriginExpr() const { +return cast(AnyFunctionCall::getOriginExpr()); + } steakhal wrote: > Why is

[PATCH] D90409: [HIP] Math Headers to use type promotion

tra added a comment. In D90409#2372042 , @yaxunl wrote: >> Practically the behavior is the same since they all promote integer types to >> double. This matches the C++ behavior. However the HIP change will make it >> conform to C++ for a target supportin

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added a comment. In D90704#2371938 , @jdoerfert wrote: > I do not understand the commit message. Can you try to make it clearer? Hi, sorry for the shabby commit message, I've updated it and use godbolt link instead of pasting the code snippet since

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

pcc added a comment. I agree with @MaskRay that this should be a binutils-specific option. The flag `-mlinker-version` seems to have been designed around macOS-specific assumptions i.e. there is a single linker (ld64) and that the linker and assembler are not version coupled. Having this option

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302672. cchen added a comment. Separate test to a independent file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/

[clang] daa127d - [PowerPC] Add MMA builtin decoding and definitions

Author: Baptiste Saleil Date: 2020-11-03T15:08:46-06:00 New Revision: daa127d77eab2547b1b7754939aa3f91fa8b1801 URL: https://github.com/llvm/llvm-project/commit/daa127d77eab2547b1b7754939aa3f91fa8b1801 DIFF: https://github.com/llvm/llvm-project/commit/daa127d77eab2547b1b7754939aa3f91fa8b1801.dif

[PATCH] D81748: [PowerPC] Add MMA builtin decoding and definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaa127d77eab: [PowerPC] Add MMA builtin decoding and definitions (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Ping @compnerd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added a comment. In D89980#2372102 , @hliao wrote: > In D89980#2371966 , @arsenm wrote: > >> In D89980#2371952 , @hliao wrote: >> >>> In D89980#2371850

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2371966 , @arsenm wrote: > In D89980#2371952 , @hliao wrote: > >> In D89980#2371850 , @arsenm wrote: >> >>> This should use byref, but I don'

[clang-tools-extra] 05e0a8e - [clangd] Fix missing override warnings in remote-index client

Author: Kadir Cetinkaya Date: 2020-11-03T21:46:44+01:00 New Revision: 05e0a8e519fd7dd73141b58a1a479a84a5ac1014 URL: https://github.com/llvm/llvm-project/commit/05e0a8e519fd7dd73141b58a1a479a84a5ac1014 DIFF: https://github.com/llvm/llvm-project/commit/05e0a8e519fd7dd73141b58a1a479a84a5ac1014.dif

[clang-tools-extra] 7f059a2 - [clangd] Handle absolute/relative path specifications in Config

Author: Kadir Cetinkaya Date: 2020-11-03T21:45:35+01:00 New Revision: 7f059a258a1dbfc240a8d526b5d23d238a3d84f7 URL: https://github.com/llvm/llvm-project/commit/7f059a258a1dbfc240a8d526b5d23d238a3d84f7 DIFF: https://github.com/llvm/llvm-project/commit/7f059a258a1dbfc240a8d526b5d23d238a3d84f7.dif

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f059a258a1d: [clangd] Handle absolute/relative path specifications in Config (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90682: [clangd][NFC] Make Located::operator->() use pointer sematics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Ah thanks for catching this. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90682/new/ https://reviews.llvm.org/D90682 ___

[PATCH] D90409: [HIP] Math Headers to use type promotion

yaxunl added a comment. In D90409#2372023 , @yaxunl wrote: > In D90409#2371987 , @tra wrote: > >> In D90409#2371969 , @yaxunl wrote: >> >>> nvcc does not support fma(float,fl

[clang] 96ed679 - [unittest][TrasnformerTest] Fix asan stack-use-after-return

Author: Fangrui Song Date: 2020-11-03T12:34:45-08:00 New Revision: 96ed6793b35e8267b0c94ebe69ae94f07024f476 URL: https://github.com/llvm/llvm-project/commit/96ed6793b35e8267b0c94ebe69ae94f07024f476 DIFF: https://github.com/llvm/llvm-project/commit/96ed6793b35e8267b0c94ebe69ae94f07024f476.diff

[PATCH] D90409: [HIP] Math Headers to use type promotion

yaxunl added a comment. In D90409#2371987 , @tra wrote: > In D90409#2371969 , @yaxunl wrote: > >> nvcc does not support fma(float,float,char) > > It does, it just needs an explicit flag to match clang's treatment of

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert planned changes to this revision. aaronpuchert added a comment. That's a good point, while `mu_` is public, `params` is a local variable. I need to take into account the left-hand side of a `til::Project`, which we're currently ignoring. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl updated this revision to Diff 302662. yaxunl marked 7 inline comments as done. yaxunl added a comment. revised manual by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 Files: clang/docs/LanguageExtensions.rst clang/do

[PATCH] D90409: [HIP] Math Headers to use type promotion

tra added a comment. In D90409#2371969 , @yaxunl wrote: > nvcc does not support fma(float,float,char) It does, it just needs an explicit flag to match clang's treatment of `constexpr` functions as HD. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as done. gulfem added a comment. In D90275#2371343 , @jdoerfert wrote: > The more I think about it, the more I think we should never create a > `leaf`/`nocallback` definition. Only declarations should carry that attribute.

[PATCH] D90409: [HIP] Math Headers to use type promotion

tra added a comment. In D90409#2371679 , @jlebar wrote: >> LGTM. I think the change would make sense for CUDA, too. @jlebar - WDYT? > > I agree that the C and C++ standard libraries should behave the same in CUDA > mode and host mode! > > But if doing so

[PATCH] D90409: [HIP] Math Headers to use type promotion

yaxunl added a comment. nvcc does not support fma(float,float,char) https://godbolt.org/z/zxbMhP clang's behavior was different from nvcc already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90409/new/ https://reviews.llvm.org/D90409 _

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added a comment. In D89980#2371952 , @hliao wrote: > In D89980#2371850 , @arsenm wrote: > >> This should use byref, but I don't think this should come at the cost of the >> promotion. I would still like to s

[PATCH] D89670: [clangd] Store the containing symbol for refs

kadircet accepted this revision. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:770 +EXPECT_TRUE(bool(Ref)); +if (!AllowNull) + EXPECT_FALSE(Ref->Container.isNull()); nit: instead of making thi

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2371850 , @arsenm wrote: > This should use byref, but I don't think this should come at the cost of the > promotion. I would still like to see this promotion occur for the in-memory > byref type Once we use `byref`, that

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

jdoerfert added a comment. I do not understand the commit message. Can you try to make it clearer? Comment at: clang/test/OpenMP/target_data_use_device_ptr_codegen.cpp:518 + #endif #endif Create a new file please. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clang now asserts for the below ca

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

lebedev.ri added a comment. I think for starters this patch needs a better description, explaining not *what* it does, but *why* it does what it does. Also, it is probably not good to change (break) existing test coverage. Instead, it is best to add new tests, and adjust existing check lines. R

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added a comment. This should use byref, but I don't think this should come at the cost of the promotion. I would still like to see this promotion occur for the in-memory byref type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ h

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2371764 , @aqjune wrote: > Hi, > > Naming is a hard thing... I have no special preference. :/ > > However, I'd like to understand the details of this attribute. > > Would LTO be affected because `leaf` is guaranteed to

[clang] 7ad6010 - Fix - [Clang] Add the ability to map DLL storage class to visibility

Author: Ben Dunbobbin Date: 2020-11-03T19:13:54Z New Revision: 7ad6010f58eac498896e601857ff7eda84466064 URL: https://github.com/llvm/llvm-project/commit/7ad6010f58eac498896e601857ff7eda84466064 DIFF: https://github.com/llvm/llvm-project/commit/7ad6010f58eac498896e601857ff7eda84466064.diff LOG:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aqjune added a comment. Hi, Naming is a hard thing... I have no special preference. :/ However, I'd like to understand the details of this attribute. Would LTO be affected because `leaf` is guaranteed to untouch the current translation unit only? // a.c int x; void f1() { f2(); }

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this LGTM aside from a few minor nits. Thank you for working on this! Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-sig30-c.rst:12-14 +This

[PATCH] D90570: [mips] Add a -mmips3d command line option to clang

michael-roe added a comment. The goal of this patch is that if you have some C code with inline MIPS assembly language that uses MIPS3D instructions, you can get it to compile by passing -mmips3d on the command line. (Without this command line option, there's an awkward workaround that involves

[PATCH] D90409: [HIP] Math Headers to use type promotion

jlebar added a comment. > LGTM. I think the change would make sense for CUDA, too. @jlebar - WDYT? I agree that the C and C++ standard libraries should behave the same in CUDA mode and host mode! But if doing so would make our behavior different than nvcc's, maybe we could emit a warning or so

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:830 + +let Predicates = [BPFHasAtomicExt] in { + def CMPXCHGD : CMPXCHG; ast wrote: > let Defs = [R0], Uses = [R0] > and

[clang] ca5b315 - [HIP] Math Headers to use type promotion

Author: Aaron En Ye Shi Date: 2020-11-03T18:40:26Z New Revision: ca5b31502c828f8e7160a77f54a5a131dc298005 URL: https://github.com/llvm/llvm-project/commit/ca5b31502c828f8e7160a77f54a5a131dc298005 DIFF: https://github.com/llvm/llvm-project/commit/ca5b31502c828f8e7160a77f54a5a131dc298005.diff LO

[PATCH] D90409: [HIP] Math Headers to use type promotion

This revision was automatically updated to reflect the committed changes. Closed by commit rGca5b31502c82: [HIP] Math Headers to use type promotion (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 302617. yonghong-song retitled this revision from "[WIP][BPF] support exchange/compare-and-exchange instruction" to "[BPF] support atomic instructions". yonghong-song edited the summary of this revision. yonghong-song added a comment. - remove RFC tag.

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdbf6bfdc7d1: [HIP] Use argv[0] as the default choice for the Executable name. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] cdbf6bf - [HIP] Use argv[0] as the default choice for the Executable name.

Author: Artem Belevich Date: 2020-11-03T10:31:39-08:00 New Revision: cdbf6bfdc7d15fc6a078c7773f142042a11d2c1b URL: https://github.com/llvm/llvm-project/commit/cdbf6bfdc7d15fc6a078c7773f142042a11d2c1b DIFF: https://github.com/llvm/llvm-project/commit/cdbf6bfdc7d15fc6a078c7773f142042a11d2c1b.diff

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe86b6773b6b: [CUDA] Allow local static variables with target attributes. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] be86b67 - [CUDA] Allow local static variables with target attributes.

Author: Artem Belevich Date: 2020-11-03T10:30:38-08:00 New Revision: be86b6773b6ba4d101a848e109540548181d2ed5 URL: https://github.com/llvm/llvm-project/commit/be86b6773b6ba4d101a848e109540548181d2ed5 DIFF: https://github.com/llvm/llvm-project/commit/be86b6773b6ba4d101a848e109540548181d2ed5.diff

[PATCH] D89980: [hip] Remove kernel argument coercion.

tra added a comment. In D89980#2371580 , @hliao wrote: > is that reported in bugs.llvm.org? It was exposed in our internal code, but the situation is almost identical to your IR example. https://godbolt.org/z/EPPn6h For NVPTX we lower byval arguments as

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. (If you tell GCC to respect the pragma via -std=c17 or similar, then -ffp-contract=fast overrides it just like clang's current behavior: https://godbolt.org/z/5dxxGb) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. GCC doesn't respect the pragma, so "what other compilers do" is not a particularly useful metric. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list c

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. In D90568#2370079 , @njames93 wrote: > Added JsonNodeDumper and argument comments. Thanks, I've no further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante marked 2 inline comments as done. Mordante added a comment. In D86559#2371058 , @aaron.ballman wrote: > In D86559#2369317 , @Mordante wrote: > >> Then me try to clear up the confusion. >> >>> However, I co

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. Hmm. Do we actually want this behavior of `fast` overriding pragmas? What do other compilers do here? It might be reasonable to just treat this as a bug. Comment at: clang/docs/LanguageExtensions.rst:3214 +should be noted that ``-ffp-contract=fast`

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2371526 , @tra wrote: > @jlebar -- FYI. This looks pretty similar to the issue you've reported > recently for NVPTX. is that reported in bugs.llvm.org? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302606. atmnpatel added a comment. Hopefully the unrelated hwasan test failure is now fixed on master, trying again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841

[PATCH] D89980: [hip] Remove kernel argument coercion.

tra added a subscriber: jlebar. tra added a comment. @jlebar -- FYI. This looks pretty similar to the issue you've reported recently for NVPTX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 _

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:715 + +let Predicates = [BPFHasAtomicExt, BPFHasALU32], DecoderNamespace = "BPFALU32" in { + def XFADDW32 : XFALU32; i think -mcpu=v4 should include alu32. Otherwise the test matrix will

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added a comment. In D90275#2371343 , @jdoerfert wrote: > The more I think about it, the more I think we should never create a > `leaf`/`nocallback` definition. Only declarations should carry that attribute. When talking about the IR that ge

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk accepted this revision. vsk added subscribers: kcc, eugenis. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm with two comments -- > Because of the extra traps there is a small code-size penalty, but it's > pretty small compared to what we accept just for th

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane added a comment. In D90634#2371436 , @aaron.ballman wrote: > This LGTM but you should wait a day or so in case @rjmccall has opinions. Thanks, will do! Comment at: clang/lib/Sema/SemaLambda.cpp:1281 + /// Additionally, we

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske added a comment. This is a very simplified form of the check that is implemented in D72705 but still may be useful in practical cases. This check could be a clang-tidy check but it is planned that the checker takes use of the planned new attributes to

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. > Hello @@DmitryPolukhin , > > When I submitted latest via 'arc diff' my commit-message was... > Can you please help to have following commit message? Below commit message is > more clear and helpful. > Sorry for inconvenience caused! It is not possible to update

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 ___ cfe-commits mailing list cfe-commit

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM but you should wait a day or so in case @rjmccall has opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 _

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske created this revision. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a reviewer: Szelethus. Herald added a pr

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. The code could be simply converted to a kernel one following the same pattern: struct S { float *p; float a[64]; int n; }; __global__ void kernel(S s) { *s.p = s.a[s.n]; } Here's the LLVM IR after frontend define protec

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302595. erichkeane marked 2 inline comments as done. erichkeane added a comment. Made another attempt at fixing the comment. Wordsmithing welcomed/encouraged :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D9

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. Hello @@DmitryPolukhin , When I submitted latest via 'arc diff' my commit-message was... Can you please help to have following commit message? Below commit message is more clear and helpful. Sorry for inconvenience caused! commit 653cb7912bbe4daabc8d6dd6dca71b2cf9a10365

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1282 + /// call-operator calling convention are generated as well. + /// NOTE: We intentionally generate a 'thiscall' (on Win32) despite MSVC not. + /// We do this in order to ensure that someone wh

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added subscribers: aqjune, fhahn, efriedma, reames. jdoerfert added a comment. The more I think about it, the more I think we should never create a `leaf`/`nocallback` definition. Only declarations should carry that attribute. I'm also still not convinced `nocallback` is a good name. @

[PATCH] D90419: [AMDGPU] Add gfx90c target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee3e64262757: [AMDGPU] Add gfx90c target (authored by tpr). Herald added a subscriber: emaste. Herald added a reviewer: espindola. Changed prior to c

[PATCH] D90447: [AMDGPU] Add gfx1033 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89d41f3a2b82: [AMDGPU] Add gfx1033 target (authored by tpr). Changed prior to commit: https://reviews.llvm.org/D90447?vs=301953&id=302591#toc Repo

  1   2   >