[PATCH] D75323: Support relative dest paths in headermap files

ashi009 added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] 2482648 - thinlto_embed_bitcode.ll: clarify grep should treat input as text

Author: Mircea Trofin Date: 2020-11-21T21:46:53-08:00 New Revision: 2482648a795afbe12774168bbbf70dc14c031267 URL: https://github.com/llvm/llvm-project/commit/2482648a795afbe12774168bbbf70dc14c031267 DIFF: https://github.com/llvm/llvm-project/commit/2482648a795afbe12774168bbbf70dc14c031267.diff

[clang] 1756d67 - [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

Author: Ella Ma Date: 2020-11-21T21:04:12-08:00 New Revision: 1756d67934bb5fe3b12bdb5fa55d61f61bd70bc5 URL: https://github.com/llvm/llvm-project/commit/1756d67934bb5fe3b12bdb5fa55d61f61bd70bc5 DIFF: https://github.com/llvm/llvm-project/commit/1756d67934bb5fe3b12bdb5fa55d61f61bd70bc5.diff LOG:

[PATCH] D91223: Support struct annotations in FuchsiaHandleChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG914f6c4ff8a4: [StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker (authored by haowei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: ht

[clang] 914f6c4 - [StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker

Author: Haowei Wu Date: 2020-11-21T19:59:51-08:00 New Revision: 914f6c4ff8a42d384cad0bbb07de4dd1a96c78d4 URL: https://github.com/llvm/llvm-project/commit/914f6c4ff8a42d384cad0bbb07de4dd1a96c78d4 DIFF: https://github.com/llvm/llvm-project/commit/914f6c4ff8a42d384cad0bbb07de4dd1a96c78d4.diff LOG

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added a comment. @craig.topper. Thank you for the good idea. I create another patch (https://reviews.llvm.org/D91927) to fix the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 _

[PATCH] D91927: [X86] Add x86_amx type for intel AMX. The x86_amx is used for AMX intrisics. <256 x i32> is bitcast to x86_amx when it is used by AMX intrinsics, and x86_amx is bitcast to <256 x i32>

LuoYuanke created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, pengfei, hiraditya, qcolombet. Herald added a reviewer: deadalnix. Herald added projects: clang, LLVM. LuoYuanke requested review of this revision. Herald added a subscriber: jdoerfert. ...only opera

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

njames93 updated this revision to Diff 306884. njames93 added a comment. Fix unittest failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91885/new/ https://reviews.llvm.org/D91885 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clan

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

brooksmoses added a comment. Aha, okay. I hadn't realized that this optimization had a `-fno-delete-null-pointer-checks` option to disable it. I agree that since that's available there's no call for a rollback. (I'll also make sure upstream bugs are filed for the cases in OpenJDK and Verilat

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 created this revision. njames93 added reviewers: sammccall, Bigcheese. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This should address the

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. @jwakely It looks like `UnsizedTail` causes a crash. Other than that all the tests in this PR pass. It also looks like there's (at least) some support for unions and bitfields. This patch doesn't support those but I'm planning to add support as a follow-up. Reposito

[libunwind] 3324fd8 - [libunwind] Delete unused handlerNotFound in unwind_phase1

Author: Fangrui Song Date: 2020-11-21T12:38:00-08:00 New Revision: 3324fd8a7b1ab011513017ed8fd81e06928526d5 URL: https://github.com/llvm/llvm-project/commit/3324fd8a7b1ab011513017ed8fd81e06928526d5 DIFF: https://github.com/llvm/llvm-project/commit/3324fd8a7b1ab011513017ed8fd81e06928526d5.diff

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

smhc updated this revision to Diff 306870. smhc added a comment. Thanks - I had it like that originally but was not sure how often MacroUsageCallbacks would be instantiated or whether there was a many-to-one relationship. I've now modified it to create and maintain the regex object as a member

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

brad added a comment. @efriedma Eli? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90329/new/ https://reviews.llvm.org/D90329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91859: [clangd] Fix shared-lib builds

nridge added a comment. I applied the patch locally and it fixes most of the linker errors but I'm still seeing one: [6/393] Linking CXX executable bin/clangd-index-server FAILED: bin/clangd-index-server : && /usr/bin/clang++-10 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=

[PATCH] D91918: Remove the IgnoreImplicitCastsAndParentheses traversal kind

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91918 Files: clang-tools-extra/clang-quer

[PATCH] D91916: Remove automatic traversal from forEach matcher

steveire updated this revision to Diff 306858. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91916/new/ https://reviews.llvm.org/D91916 Files: clang/docs/ReleaseNotes.rst clang/include/clang/ASTMatchers/ASTMatc

[PATCH] D91917: Update mode used in traverse() examples

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. traverse() predates the IgnoreUnlessSpelledInSource mode. Update example and test code to use the newer mode.

[PATCH] D91916: Remove automatic traversal from forEach matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91916 Files: clang/include/clang/ASTMatch

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Addresses https://bugs.llvm.org/show_bug.cgi?id=48230. Handle the case when the

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. In D91913#2409688 , @lebedev.ri wrote: > Then the comment needs to be fixed too i would think? It's the comment right above the code that I changed; I did fix that too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

lebedev.ri added a comment. > The associated comment suggested that GCC keeps this extension enabled in > C90/C++03 standard-conforming mode, but it actually does not, so rather than > adding a check for C++ language version, this change simply removes the check > for C language version. Then

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

jpienaar accepted this revision. jpienaar added a comment. LG MLIR changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze added a comment. Thanks for the review! I'll push this as soon as the updated version of D89649 is also accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89651/new/ https://reviews.llvm.org/D89651

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze added a comment. Pinging @rsmith - could you please check the updates to this patch? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89649/new/ https://reviews.llvm.org/D89649 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 306850. njames93 added a comment. Fix ChecksToDisable to actually disable the checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

njames93 added a comment. While I'm a fan of this change, I think this is the wrong way to do it. Leave the check the same, but build the regex in the pp callback constructor. That should only get called once for the lifetime of the check. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk created this revision. hvdijk added a reviewer: rsmith. hvdijk added a project: clang. Herald added a subscriber: cfe-commits. hvdijk requested review of this revision. The GNU token paste extension that removes the comma in , ## __VA_ARGS__ conflicts with C99/C++11's requirements when a v

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv closed this revision. faisalv added a comment. committed here: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a Thank you Aaron, Richard and Wyat!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91035/new

[clang] 9930d4d - [NFC, Refactor] Modernize enum FunctionDefinitionKind (DeclSpech.h) into a scoped enum

Author: Faisal Vali Date: 2020-11-21T09:49:52-06:00 New Revision: 9930d4dff31a130890f21a64f43d530a83ae3d0a URL: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a DIFF: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a.diff L

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

Eugene.Zelenko added a comment. Please add test case for new command-line option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91908/new/ https://reviews.llvm.org/D91908 ___ cfe-commits mailing list cfe

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:109 +/// Get call hierarchy information at \p Pos. +llvm::Optional> +prepareCallHierarchy(ParsedAST &AST, Position Pos, const SymbolIndex *Index, nridge wrote: > kadircet wrote: > > nrid

[PATCH] D90751: [clangd] Use ProjectAwareIndex

kadircet abandoned this revision. kadircet added a comment. Merged with https://reviews.llvm.org/D91860 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90751/new/ https://reviews.llvm.org/D90751 ___ cfe-co

[PATCH] D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain

kadircet updated this revision to Diff 306840. kadircet added a comment. - Merge with https://reviews.llvm.org/D90751 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91860/new/ https://reviews.llvm.org/D91860 Files: clang-tools-extra/clangd/CMakeL

[PATCH] D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain

kadircet updated this revision to Diff 306839. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91860/new/ https://reviews.llvm.org/D91860 Files: clang-tools-ex

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

xbolva00 added a comment. In that code there is a comment: >> These flags are required for GCC 6 builds as undefined behaviour in OpenJDK >> code So you should really fix UB... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://rev

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

bkramer added a comment. In D17993#2409401 , @brooksmoses wrote: > So, I have bad news: This causes OpenJDK to segfault. The relevant code is > here: > https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/arena.cpp#L311 > > void Arena::d

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695 +Callback>> CB) { + CB(clangd::incomingCalls(Item, Index)); +} nridge wrote: > kadirce

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91124/new/ https://reviews.llvm.org/D91124

[PATCH] D91868: [clangd] Mention when CXXThis is implicit in exposed AST.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/DumpAST.cpp:233 return CCO->getConstructor()->getNameAsString(); +if (const auto *CTE = dyn_cast(S)) { + bool Con

[PATCH] D91859: [clangd] Fix shared-lib builds

kadircet updated this revision to Diff 306830. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/ https://reviews.llvm.org/D91859 Files: clang-tools-ex

[PATCH] D91859: [clangd] Fix shared-lib builds

kadircet added a subscriber: nridge. kadircet added a comment. > I don't think that's how CMake works, the whole CMakeLists tree is parsed > before anything is compiled, so it shouldn't race like that. That was also my mental model, but it looks like `include_directories` statement within the `

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. (also please add "Fixes https://github.com/clangd/clangd/issues/598"; to the patch description to close the related issue on GH) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/ https://reviews.llvm.org/D91859 __