[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG085dcc82178f: [clang][Frontend] Fix a crash in DiagnosticRenderer. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 085dcc8 - [clang][Frontend] Fix a crash in DiagnosticRenderer.

Author: Balázs Kéri Date: 2021-02-17T09:02:49+01:00 New Revision: 085dcc82178f94b99783c5730e70a953e4105c00 URL: https://github.com/llvm/llvm-project/commit/085dcc82178f94b99783c5730e70a953e4105c00 DIFF: https://github.com/llvm/llvm-project/commit/085dcc82178f94b99783c5730e70a953e4105c00.diff L

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

teemperor added a comment. LGTM. Regarding the LLDB example: Given that the LLDB API is in theory not bound to the semantics a specific language, I think one can argue that `IsAnonymousType` could also return true for unnamed classes. The use case that triggered this whole discussion was someo

[PATCH] D96845: [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. This looks like an oversight. Repository: rG LLV

[clang] ab8a620 - [OpenMP] Fix a warning on an unused variable

Author: Kazu Hirata Date: 2021-02-16T23:46:21-08:00 New Revision: ab8a62057384e1bbfd528a4012cd898511c83b02 URL: https://github.com/llvm/llvm-project/commit/ab8a62057384e1bbfd528a4012cd898511c83b02 DIFF: https://github.com/llvm/llvm-project/commit/ab8a62057384e1bbfd528a4012cd898511c83b02.diff L

[PATCH] D96844: [clangd] Pass file when possible to resolve URI.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Some URI scheme needs the hint path to do a correct

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11127 +def err_riscvv_builtin_not_useable : Error< + "builtin requires 'V' extension support to be enabled">; } // end of sema component. Jim wrote: > Add blank line.

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

khchen created this revision. khchen added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, HsiangKai, evandro. Herald added subscribers: vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zz

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

ikudrin marked 2 inline comments as done. ikudrin added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3757-3771 + if (DwarfFormatArg && + DwarfFormatArg->getOption().matches(options::OPT_gdwarf64)) { +if (DwarfVersion < 3) + D.Diag(diag::err_dr

[PATCH] D96838: CodeGen: Set !retain metadata on UsedAttr definitions for Linux/FreeBSD

MaskRay created this revision. Herald added subscribers: krytarowski, arichardson, emaste. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC 11 will set SHF_GNU_RETAIN on the section of a `__attribute__((used))` function/variable,

[PATCH] D96835: [HIP] Support device sanitizer

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: jansvoboda11, dang, kerbowa, tpr, nhaehnle, jvesely. yaxunl requested review of this revision. Add option -fgpu-sanitize to enable sanitizer for AMDGPU target. Since it is experimental, it is off by default. h

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324173. vitalybuka added a comment. undo CodeGenOpts.ThinLTOIndexFile.empty() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324171. vitalybuka marked 4 inline comments as done. vitalybuka added a comment. fix language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/Code

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu created this revision. zequanwu added reviewers: ahatanak, aaron.ballman, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It would be beneficial to allow not_tail_called attribute to be applied to virtual functions. I

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" --

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic updated this revision to Diff 324153. rsanthir.quic added a comment. rebased due to merge issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp cla

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem added a comment. @lebedev.ri based on your feedback, I added it as a separate pass and added support for user-defined lookup tables. Please let me know if you have any comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94355/new/ https

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem updated this revision to Diff 324144. gulfem marked an inline comment as not done. gulfem added a comment. Herald added a subscriber: mgorny. Implement it as a separate pass and apply it to user-defined lookup tables as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies added a comment. Thanks for your response. Yes decl is too verbose in many cases. In fact I have tried another concise version, but I can not decide which one is better. Unit test in FindSymbolsTests.cpp is also done, but I would like upload them after we reach an agreement on wh

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324143. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/test/symbols.test Index: clang

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic added a comment. This is the final of three patches to address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 __

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, kevin.qin, labrinea, pbarrio, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thi

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2559476 , @thopre wrote: > In D96568#2559475 , @uweigand wrote: > >> In D96568#2559336 , @thopre wrote: >> >>> That's interesting. I presume

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel added a comment. In D96082#2566984 , @steveire wrote: > In D96082#2565339 , @aaron.ballman > wrote: > >> A somewhat similar check that would be interesting is a function that >> returns the same value o

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

steven_wu added a comment. In D93003#2566906 , @rprichard wrote: > Maybe this is blocked on someone from Apple reviewing the Mach-O parts? This is fine with me for how Apple builds libunwind. I am not sure if the open source libunwind build for MachO do

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 324132. LukasHanel added a comment. Handle the case of a global variable being the "return value" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96082/new/ https://reviews.llvm.org/D96082 Files: clang-tool

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:292 + /// nest would extend. + SmallVector OMPLoopNestStack; + Unless I missed something, the only accesses to `OMPLoopNestStack` are `push_back`, `clear`, `back`, and `size`. It's

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. You might want to test nested classes of class templates. I don't know if we encode nested classes in any reasonable way in the first place. I'm generally okay with being aggressive about

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire abandoned this revision. steveire added a comment. In D96142#2564265 , @njames93 wrote: > In D96142#2547418 , @steveire wrote: > >> In D96142#2545078 , @njames93 wro

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

steveire added a comment. In D96082#2565339 , @aaron.ballman wrote: > A somewhat similar check that would be interesting is a function that returns > the same value on all control paths I think we shouldn't try to design a new, different check in the co

[PATCH] D88220: [C++20] P1825R0: More implicit moves

aaronpuchert added a comment. In D88220#2566628 , @Quuxplusone wrote: > My concern was more that I'm much less of an expert on Clang than "most of > us." Understood, but Clang tries to closely follow the C++ standard in its implementation, and I'd say t

[PATCH] D96751: [clangd] Populate detail field in document symbols

sammccall added a comment. Thanks for doing this! I think this behavior is a great starting point. I suspect printing the decl is more verbose than desired in a lot of cases, at least avoiding repeating the identifier would be nice. e.g. x | int x --> x | int foo | void foo() --> foo | void() b

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. Herald added a subscriber: dang. So I'm running into issues with this patch, specifically the line annotated below. I'm trying to compile our CHERI-LLVM fork as a native pure-capability CHERI[1] binary (which eventually will mean compiling the Morello-LLVM fork of our CH

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:228 +Out << (Method->isInstanceMethod() ? '-' : '+'); +Method->getSelector().print(Out); +return Out.str(); sammccall wrote: > in t

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:224 + if (const auto *C = dyn_cast(&ND)) +return printObjCContainer(*C); sammccall wrote: > I'm not sure this fits with the contract of

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180 +for (auto &Mod : *Modules) + Mod.blockUntilIdle(Deadline::infinity()); + } kadircet wrote: > why is our contract saying that just calling `stop` is not enough? >

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

sammccall updated this revision to Diff 324120. sammccall marked 2 inline comments as done. sammccall added a comment. trim tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96755/new/ https://reviews.llvm.org/D96755 Files: clang-tools-extra/c

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak added a comment. This patch focuses only on reducing the encoded size of classes with template specialization, but if the information about pointed-to types isn't used at all, clang can always emit "^v" for C++ pointer types. Or it might make more sense to base the decision on whether

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard added a comment. Maybe this is blocked on someone from Apple reviewing the Mach-O parts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 ___ cfe-commits

[PATCH] D88220: [C++20] P1825R0: More implicit moves

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbee4a0c79cc: [C++20] [P1825] More implicit moves (authored by nullptr.cpp, committed by arthur.j.odwyer). Changed prior to commit: https://reviews.llvm.org/D88220?vs=318420&id=324115#toc Repository:

[clang] fbee4a0 - [C++20] [P1825] More implicit moves

Author: Yang Fan Date: 2021-02-16T17:24:20-05:00 New Revision: fbee4a0c79cc4ee87c34e51342742a5bc6fcf872 URL: https://github.com/llvm/llvm-project/commit/fbee4a0c79cc4ee87c34e51342742a5bc6fcf872 DIFF: https://github.com/llvm/llvm-project/commit/fbee4a0c79cc4ee87c34e51342742a5bc6fcf872.diff LOG:

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. In D95246#2566417 , @abhina.sreeskantharajan wrote: > I was curious if all of these modified testcases are now failing or only the > three you mentioned. Here is the list of the tests which fail after the patch (I haven't

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak created this revision. ahatanak added reviewers: rjmccall, theraven. ahatanak added a project: clang. Herald added subscribers: jansvoboda11, dexonsmith, dang, jkorous. ahatanak requested review of this revision. This helps reduce the size of the encoded C++ type strings in the binary. I

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

amyk added a comment. Thanks for answering the questions I previously had on this patch. Comment at: lld/ELF/Driver.cpp:763 +// Parses --power10-stubs= flags, to disable or enable Power 10 +// instructions in stubs. nit: remove the space after `=` and before

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

amyk added a comment. In addition to the nit comments, I also have the same question as Stefan for `getFPAs64BitIntHi`/`getFPAs64BitIntLo`. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8591 + // Only convert if it loses info, since XXSPLTIDP should + // handle the

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 324110. sammccall added a comment. fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://reviews.llvm.org/D96717 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/c

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/LSPBinder.h:88 + template + void outgoingMethod(llvm::StringLiteral Method, + OutgoingMethod &Handler) { kadircet wrote: > sa

[PATCH] D96244: [clangd] Introduce Modules

sammccall added a comment. In D96244#2566225 , @dblaikie wrote: > "modules" is a pretty overloaded term in Clang (between llvm Modules and > Clang Modules and now C++ standard Modules) - any chance of some other term > that might be less overloaded in th

[PATCH] D96512: [PowerPC] Add option for ROP Protection

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. I just have a small question about the patch but overall I think this LGTM. Comment at: llvm/lib/Target/PowerPC/PPC.td:317 // Power8 list P8AdditionalFeatures =

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a comment. In D88220#2566525 , @aaronpuchert wrote: > I think you're much more of an expert on implicit moves than most of us Short answer, yes. ;) My concern was more that I'm much less of an expert on Clang than "most of us." I'd rat

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

stefanp requested changes to this revision. stefanp added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:1321 bool convertToNonDenormSingle(APFloat &ArgAPFloat); + bool checkNonDenormCannotConvertToSingle(

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

aaron.ballman added a comment. Thank you for working on this! In general, I like the change. Comment at: clang/lib/AST/TypePrinter.cpp:1308 +} else if ((isa(D) && cast(D)->isAnonymousStructOrUnion()) || +isa(D)) { OS << "anonymous"; I think

[PATCH] D88220: [C++20] P1825R0: More implicit moves

aaronpuchert added a comment. In D88220#2565768 , @Quuxplusone wrote: >> either way I'm a dead end — I don't consider myself authorized to "accept" >> Clang changes. >> You're still going to have to attract the attention of someone with the >> authority

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy added a comment. In D96354#2566511 , @dblaikie wrote: > In D96354#2566502 , @hoy wrote: > >> In D96354#2554129 , @probinson >> wrote: >> the driver had a redundant

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

dblaikie added a comment. In D96354#2566502 , @hoy wrote: > In D96354#2554129 , @probinson wrote: > >>> the driver had a redundant pass-through of the option >> >> I could've sworn it worked to remove that, but it d

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + jlebar wrote: > aaronpuchert wrote: > > jlebar wrote: > > > aaronpuchert wrote: > > > > Why not in the following `if`? I as

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy added a comment. In D96354#2554129 , @probinson wrote: >> the driver had a redundant pass-through of the option > > I could've sworn it worked to remove that, but it didn't when I rebased, so > that's gone from the final patch (i.e, the explicit pass-

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

clementval added a comment. A fix is ready hereL https://reviews.llvm.org/D96808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. Hi Stefan, Thanks a lot for the details you shared. They are really helpful to me. In D96033#2565708 , @sgraenitz wrote: > Hi Vassil, thanks for upstreaming this! I think it goes into a good direction. > > The last time I lo

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

clementval added a comment. @Meinersbur This patch is making Flang buildbots failing. Since you have added a clause in `OMP.td` you have to add lines here as well -> https://github.com/llvm/llvm-project/blob/adfd3c7083f9808d145239153c10f72eece485d8/flang/lib/Semantics/check-omp-structure.cpp#L68

[clang-tools-extra] cdef5a7 - [clangd] Fix windows buildbots after ecea7218fb9b994b26471e9877851cdb51a5f1d4

Author: Kadir Cetinkaya Date: 2021-02-16T20:57:08+01:00 New Revision: cdef5a7161767c2c4b3b7cb2542cf1d29b6d4a09 URL: https://github.com/llvm/llvm-project/commit/cdef5a7161767c2c4b3b7cb2542cf1d29b6d4a09 DIFF: https://github.com/llvm/llvm-project/commit/cdef5a7161767c2c4b3b7cb2542cf1d29b6d4a09.dif

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik added a comment. Note: I am not fixing how we treat anonymous and unnamed enums, I could not find a way to figure out if an enum was anonymous or not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 __

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2566029 , @ASDenysPetrov wrote: > In D95246#2565351 , > @abhina.sreeskantharajan wrote: > >> > > > >> Do you know what is different between your environments whi

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik created this revision. shafik added reviewers: aaron.ballman, rsmith, teemperor. Herald added a subscriber: arphaman. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently `TypePrinter` lumps anonymous classes and unname

[PATCH] D46443: Add missing cstdalign header

hubert.reinterpretcast added a comment. Herald added a subscriber: wingo. The resolution of LWG 2828 means that `` exists in C++11 and C++14. The rationale from https://reviews.llvm.org/D96786#2566110 can be taken as saying that adding this

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96802/new/ https://reviews.llvm.org/D96802 ___

[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecea7218fb9b: [clangd] Treat paths case-insensitively depending on the platform (authored by kadircet). Changed prior to commit: https://reviews.l

[clang-tools-extra] ecea721 - [clangd] Treat paths case-insensitively depending on the platform

Author: Kadir Cetinkaya Date: 2021-02-16T20:20:53+01:00 New Revision: ecea7218fb9b994b26471e9877851cdb51a5f1d4 URL: https://github.com/llvm/llvm-project/commit/ecea7218fb9b994b26471e9877851cdb51a5f1d4 DIFF: https://github.com/llvm/llvm-project/commit/ecea7218fb9b994b26471e9877851cdb51a5f1d4.dif

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

aeubanks added a comment. why is this now a module pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96803/new/ https://reviews.llvm.org/D96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[libunwind] cddc53e - libunwind: Don't attempt to authenticate a null return address.

Author: Peter Collingbourne Date: 2021-02-16T11:18:02-08:00 New Revision: cddc53ef088b68586094c9841a76b41bee3994a4 URL: https://github.com/llvm/llvm-project/commit/cddc53ef088b68586094c9841a76b41bee3994a4 DIFF: https://github.com/llvm/llvm-project/commit/cddc53ef088b68586094c9841a76b41bee3994a4

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz created this revision. zatrazz added reviewers: lenary, ostannard, aeubanks. Herald added a subscriber: hiraditya. zatrazz requested review of this revision. Herald added projects: clang, LLVM. The function passes are disabled by default for optnone with the new pass manager. The pass is

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

aaron.ballman added a comment. In D93110#2560095 , @vsavchenko wrote: > In D93110#2534690 , @aaron.ballman > wrote: > >> In D93110#2529917 , @NoQ wrote: >> What I want

[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

dblaikie added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:396 + bool Dwarf64 = + (Asm->TM.Options.MCOptions.Dwarf64 || MMI->getModule()->isDwarf64()) && + DwarfVersion >= 3 && // DWARF64 was introduced in DWARFv3. ikudrin

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

dblaikie added a comment. @hoy Could you explain a bit further why these two features are incompatible/what the crash looks like? At first glance I wouldn't expect any debug info mode to be incompatible with any non-debug-info mode (maybe less useful, but not crashy levels of incompatible). R

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

abhinavgaba accepted this revision. abhinavgaba added a comment. This revision is now accepted and ready to land. Thanks for the changes, Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86119/new/ https://reviews.llvm.org/D86119

[PATCH] D96244: [clangd] Introduce Modules

dblaikie added a comment. "modules" is a pretty overloaded term in Clang (between llvm Modules and Clang Modules and now C++ standard Modules) - any chance of some other term that might be less overloaded in this space? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

ayermolo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96783/new/ https://reviews.llvm.org/D96783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: rjmccall. Herald added subscribers: dexonsmith, pengfei, kbarton, kristof.beyls, jgravelle-google, sbc100, nemanjai, dschuff. varungandhi-apple requested review of this revision. Herald added subscribers: cfe-commits, ahe

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

apazos added a comment. This looks like a straightforward implementation. The only caveat is that the XAR immediate does not represent a lane, and hence the need for a custom immediate range check. Looks sensible to me. @labrinea and others at ARM, do have any other comment before this is merg

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

dblaikie accepted this revision. dblaikie added a comment. Looks good to me - thanks Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3757-3771 + if (DwarfFormatArg && + DwarfFormatArg->getOption().matches(options::OPT_gdwarf64)) { +if (DwarfVersion < 3) + D.Dia

[PATCH] D88631: [X86] Support customizing stack protector guard

nickdesaulniers added a comment. Herald added a subscriber: jansvoboda11. Looks like there's also a `-mstack-protector-guard-symbol=` which Linux kernel developers are looking to use for 32b X86 kernels: https://bugs.llvm.org/show_bug.cgi?id=49209. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D67429: Improve code generation for thread_local variables:

wolfgangp added a comment. Ping. Just wondering if there are any new insights on the issue reported in PR48030 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Ping! Please, don't pass by this patch. I need your competent evaluation to load it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. In D95246#2565351 , @abhina.sreeskantharajan wrote: > > Do you know what is different between your environments which is causing the > spelling to be capitalized? This might help me determine how to fix the > current h

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! can't wait for the unique_function sfinae fix :) Comment at: clang-tools-extra/clangd/LSPBinder.h:185 + +LSPBinder::UntypedOutgoingNotification inline LSPBinder::

[clang] 1a323c8 - [analyzer] Fix a warning

Author: Kazu Hirata Date: 2021-02-16T09:12:07-08:00 New Revision: 1a323c8a96afc53ef965a4268cd419cfde2f1890 URL: https://github.com/llvm/llvm-project/commit/1a323c8a96afc53ef965a4268cd419cfde2f1890 DIFF: https://github.com/llvm/llvm-project/commit/1a323c8a96afc53ef965a4268cd419cfde2f1890.diff L

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2565945 , @Meinersbur wrote: > In D76342#2565686 , @ABataev wrote: > >> I can commit it as soon as you accepted it if you don't mind of course. > > I do not mind Ok, will commit i

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. In D76342#2565686 , @ABataev wrote: > I can commit it as soon as you accepted it if you don't mind of course. I do not mind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/ne

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

steakhal added a comment. What about analyzing a Sema translation unit? That should be beefy enough to have a longer runtime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87519/new/ https://reviews.llvm.org/D87519 ___

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 324025. sammccall added a comment. OK, the awful proxy object thing works :-) It requires a SFINAE fix to unique_function though, which i'll send separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh added inline comments. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) mantognini wrote: > I'm not sure we want that -- I'm actually fine if we don't -- but I se

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Needs an example in the "Creating new Command Line Option" section, but with that it looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal added a comment. It is because of how addClangTargetOptions is invoked. In case of save-temps, it is being invoked for all the actions resulting in target cc1 call. That's why all these invocations have -emit-llvm-bc. I guess we need Action as an argument to addClangTargetOptions. Al

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! You may wanna wait for someone more knowledgeable about CTU to give it another accept. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94673/new/ https://reviews.llvm.org/D

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

mantognini added a comment. I feel this would be a valuable addition, indeed. Only a minor question from me. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) I'm not s

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; awarzynski wrote: > Do we need to expose it? Shouldn't this be private? It will not compile if the variable is private as

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. > either way I'm a dead end — I don't consider myself authorized to "accept" > Clang changes. > You're still going to have to attract the attention of someone with the > authority an

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

jdoerfert added a comment. In D96769#2565751 , @pdhaliwal wrote: > emit-llvm-bc does not correctly solve the problem. It works because [input, > compile, assemble, backend] actions collapse to a single action by driver. > This single command handles emit

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske updated this revision to Diff 324013. balazske added a comment. Adding missed alias to CERT module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96719/new/ https://reviews.llvm.org/D96719 Files: clang-tools-extra/clang-tidy/bugprone/Bu

  1   2   >