[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. Hi @phosek , The only upstream bot that was broken by this change was clang-ppc64le-rhel, and I have notified the bot owner of the problem and said that I'm working on this within 15 minutes of the breakage. I posted a tentative fix for the testsuite several ho

[PATCH] D98923: [Driver] Pass -fexperimental-strict-floating-point to cc1 if it is specified

Jim created this revision. Jim added a reviewer: kpn. Jim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In my case, it has to enable strict floating-point by driver for default unsupported target. Repository: rG LLVM Github Monorepo

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. They're not part of buildbot but they're not internal, you can see the log here: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8852352747956966400/+/u/clang/test/stdout. I noticed D98862 , but it still hasn

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

kadircet added a comment. In D98824#2634715 , @jnykiel wrote: > I have addressed some of your comments. The second revision is good enough to > get the tests to pass - the `injectResourceDir` change was necessary for the > one clang-tidy test that starte

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov updated this revision to Diff 331784. maxim-kuvyrkov added a comment. Added more fixes to OpenMP/linking.c and Driver/msvc-link.c . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 Files: cl

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2636616 , @phosek wrote: > They're not part of buildbot but they're not internal, you can see the log > here: > https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8852352747956966400/+/

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov added a comment. Hi @amyk , thanks for testing -- I've updated two more places, which I missed on the first go. Would you please test the new version? Also, D98862 was reverted so you need to apply it manually. Thanks! Repository: rG LLVM G

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 331795. curdeius added a comment. - Accept but warn in pre-C++2b mode when lambda is missing '()' and have lambda-specifiers. - Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://revi

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Oh, wait a minute. The `config.host_cxx` was already there. Where is the symmetry :D It looks much better now, thanks. Regarding D83660 , I'm really looking

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

phosek added a comment. In D98493#2636648 , @maxim-kuvyrkov wrote: > In D98493#2636616 , @phosek wrote: > >> They're not part of buildbot but they're not internal, you can see the log >> here: >> https://logs.chr

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. I've tested this locally and it's working for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

OikawaKirie added a comment. In D98918#2636735 , @steakhal wrote: > > Oh, wait a minute. The `config.host_cxx` was already there. > Where is the symmetry :D It looks much better now, thanks. Sounds not bad if it matters to you :P > Regarding D83660 <

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov created this revision. maxim-kuvyrkov added reviewers: asl, phosek. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment "link.exe" is hard-coded as default linker in MSVC.cpp, so there's no way to use

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov abandoned this revision. maxim-kuvyrkov added a comment. This is now squashed into https://reviews.llvm.org/D98935 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 331817. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 331818. Max_S added a comment. I added more tests for the interaction between MaxEmptyLinesToKeep, EmptyLineBeforeAccessModifier and EmptyLineAfterAccessModifier. During these tests I recognized, that EmptyLineBeforeAccessModifier = Always,Leave will (should

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 +ELAAMS_Leave, +/// Always add empty line after access modifiers. +/// \code HazardyKnusperkeks wrote: > It does not always add, it does enforces one empty line, or am I

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 331820. sdesmalen added a comment. Rebased after D98736 already fixed one of the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https://reviews.llvm.org/D98

[PATCH] D98891: Automate common diagnostic checking for statement attributes

aaron.ballman updated this revision to Diff 331823. aaron.ballman set the repository for this revision to rG LLVM Github Monorepo. aaron.ballman removed a project: clang. aaron.ballman removed a subscriber: jdoerfert. aaron.ballman added a comment. Herald added a project: clang. Herald added a subs

[clang] 4f750f6 - [SystemZ][z/OS] Distinguish between text and binary files on z/OS

Author: Abhina Sreeskantharajan Date: 2021-03-19T08:09:57-04:00 New Revision: 4f750f6ebc412869ce6bb28331313a9c9a9d9af7 URL: https://github.com/llvm/llvm-project/commit/4f750f6ebc412869ce6bb28331313a9c9a9d9af7 DIFF: https://github.com/llvm/llvm-project/commit/4f750f6ebc412869ce6bb28331313a9c9a9d

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f750f6ebc41: [SystemZ][z/OS] Distinguish between text and binary files on z/OS (authored by abhina.sreeskantharajan). Repository: rG LLVM Github

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 __

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. Thank you for you reply Joachim, I see 3 options here: **OPTION 1:** make Clang accept these options This would be as simple as removing the `FlangOnlyOption` from the corresponding TableGen definitions in Options.td. However, since we added help texts to their defi

[PATCH] D98943: [clang][deps] NFC: Extract ModuleID struct

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: mgrang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extracts the `ModuleName` and `ContextHash`

[clang] fa4e729 - Automate common diagnostic checking for statement attributes

Author: Aaron Ballman Date: 2021-03-19T08:35:38-04:00 New Revision: fa4e72971e05e3c923e11a31e2025361e3425a8b URL: https://github.com/llvm/llvm-project/commit/fa4e72971e05e3c923e11a31e2025361e3425a8b DIFF: https://github.com/llvm/llvm-project/commit/fa4e72971e05e3c923e11a31e2025361e3425a8b.diff

[PATCH] D98891: Automate common diagnostic checking for statement attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting so I can close (the review was only created so I could run the CI and wasn't meant to be public in the first place). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D98891: Automate common diagnostic checking for statement attributes

aaron.ballman closed this revision. aaron.ballman added a comment. This was committed in fa4e72971e05e3c923e11a31e2025361e3425a8b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

steakhal added a comment. The assertion `areFeasible(Constraints)` triggered on trunk. More details in the Bugzilla ticket . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98341/new/ https://reviews.llvm

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. Ah, I wanted to give it a go, but the bots caught an assertion failure for the parent revision of this. See the details at the Bugzilla ticket . What is more concerning is that this patch resolves that assertion failure. I

[PATCH] D98514: [RGT] Fix ASTMatchersTest so all assertions are executed

probinson added a reviewer: gribozavr. probinson added a comment. +gribozavr who has been in this file most recently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98514/new/ https://reviews.llvm.org/D98514 _

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov updated this revision to Diff 331849. maxim-kuvyrkov added a comment. NFC: Make clang-format happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98935/new/ https://reviews.llvm.org/D98935 Files: clang/lib/Driver/ToolChains/MSVC.cp

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov accepted this revision. maxim-kuvyrkov added a comment. This revision is now accepted and ready to land. Herald added a subscriber: mstorsjo. This was reviewed in https://reviews.llvm.org/D98493 and https://reviews.llvm.org/D98862. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2049fe58903b: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2] (authored by maxim-kuvyrkov). Repository: rG LLVM Github M

[clang] 2049fe5 - [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

Author: Maxim Kuvyrkov Date: 2021-03-19T13:38:03Z New Revision: 2049fe58903b68f66872a18e608f40e5233b55fb URL: https://github.com/llvm/llvm-project/commit/2049fe58903b68f66872a18e608f40e5233b55fb DIFF: https://github.com/llvm/llvm-project/commit/2049fe58903b68f66872a18e608f40e5233b55fb.diff LOG

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. I did not follow the discussion closely but we (CodeChecker team) might have a similar problem. Consider this: https://godbolt.org/z/835P38 int do_bifurcation(int p) { return p < 0; } int b(int x, int y) { int tmp = 13 / y; // y can't be 0. (void)tmp;

[clang] a9fc44c - [TableGen] Improve handling of template arguments

Author: Paul C. Anagnostopoulos Date: 2021-03-19T09:57:53-04:00 New Revision: a9fc44c5573208859c2550382755098d750fc47d URL: https://github.com/llvm/llvm-project/commit/a9fc44c5573208859c2550382755098d750fc47d DIFF: https://github.com/llvm/llvm-project/commit/a9fc44c5573208859c2550382755098d750f

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:347 +// Checks whether ArgType converts implicitly to ParamType. +static bool areTypesCompatible(QualType ArgType, QualType ParamType, +

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

vsavchenko created this revision. vsavchenko added reviewers: steakhal, NoQ, xazax.hun, ASDenysPetrov. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

vsavchenko updated this revision to Diff 331863. vsavchenko added a comment. Fix typos in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManag

[PATCH] D98950: [clang][deps] NFC: Document collector, rename members

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch documents how `ModuleDepCollector{,PP}` work and what their members store. Als

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../include/flang/

[PATCH] D98746: [clang][amdgpu] Use implicit code object default

JonChesterfield added a comment. Great context, thanks guys. I had missed that part of the compiler. We presently have a dependency edge from clang to the amdgcn target in llvm. The drawback I noticed here is it stops clang unconditionally building a runtime library for amdgcn. This patch, or a

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 331871. arnamoy10 added a comment. Separating test cases for accepted input option and not accepted input option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *'.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There

[clang] 96e675b - [clang][ASTImporter] Add import support for SourceLocExpr.

Author: Balázs Kéri Date: 2021-03-19T16:33:04+01:00 New Revision: 96e675bdd5c8bfef34135fb50bcc7f570f073639 URL: https://github.com/llvm/llvm-project/commit/96e675bdd5c8bfef34135fb50bcc7f570f073639 DIFF: https://github.com/llvm/llvm-project/commit/96e675bdd5c8bfef34135fb50bcc7f570f073639.diff L

[PATCH] D98876: [clang][ASTImporter] Add import support for SourceLocExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG96e675bdd5c8: [clang][ASTImporter] Add import support for SourceLocExpr. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98876/new/ ht

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 331884. jnykiel edited the summary of this revision. jnykiel added a comment. I've addressed your comments (I agree with them, essentially). After implementing the insertion of '--' for problematic file names, I had to modify some interpolation unit tests to

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. @lebedev.ri do you have further comments? If not, I would like to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94355/new/ https://reviews.llvm.org/D94355 ___ c

[PATCH] D88220: [C++20] P1825R0: More implicit moves

sberg added a comment. This change causes #include std::shared_ptr x1; std::shared_ptr f() { std::shared_ptr & r = x1; r.reset(new int); return r; } int main() { std::shared_ptr x2 = f(); long n = x2.use_count(); return n; } when built with `-std=

[PATCH] D98890: [SystemZ][z/OS] Ignore leading zero width bitfield alignment on z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98890/new/ https://reviews.llvm.org/D98890 ___

[PATCH] D98867: [HIP] Fix ROCm detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:271 +} +if (LatestROCm < FileName) + LatestROCm = FileName.str(); tra wrote: > This will rank `rocm-3.9` higher than `rocm-3.10`

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331888. arnamoy10 added a comment. Using `llvm::sys::path::remove_filename` as per suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../include/flang/"

[PATCH] D98867: [HIP] Fix ROCm detection

yaxunl updated this revision to Diff 331889. yaxunl marked an inline comment as done. yaxunl added a comment. fix version comparison CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98867/new/ https://reviews.llvm.org/D98867 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Dri

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a comment. Confirmed: yikes. @nullptr.cpp, I'm going to open a new pull request to revert this, to poke the buildbot, just in case reverting it causes new failures. But I certainly don't object if someone wants to be more bold than me in reverting quickly. Here's a reduced tes

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

morehouse updated this revision to Diff 331895. morehouse marked an inline comment as done. morehouse added a comment. - Expand on lack of 32 bit support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98892/new/ https://reviews.llvm.org/D98892 Fil

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: whisperity. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. size_t and friends are built-in scalar data types and s6.4.4.2 of the OpenCL

[PATCH] D98868: [Driver] Add -print-runtime-dir

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I'm somewhat surprised this doesn't exist already, but I looked at the -print-* options and don't see anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

ctetreau accepted this revision. ctetreau added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { Out of curiosity, what is the

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

paulwalker-arm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5052-5055 + if (isa(JA)) { +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } Are there any concerns related to LTO here

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

shafik accepted this revision. shafik added a comment. Can we add a test for the `getCapturedVLAType` case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98951 ___ cf

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. Would it be possible to share this test with `f18`? Comment at: flang/test/Driver/std20

[clang] aafc3f7 - [Driver] Add -print-runtime-dir

Author: Markus Böck Date: 2021-03-19T17:48:03+01:00 New Revision: aafc3f7be804d117a632365489a18c3e484a3931 URL: https://github.com/llvm/llvm-project/commit/aafc3f7be804d117a632365489a18c3e484a3931 DIFF: https://github.com/llvm/llvm-project/commit/aafc3f7be804d117a632365489a18c3e484a3931.diff L

[PATCH] D98868: [Driver] Add -print-runtime-dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaafc3f7be804: [Driver] Add -print-runtime-dir (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9212 + StyleWithLine.EmptyLinesAfterAccessModifier = 1u; + EXPECT_EQ(test2NL, format(test0NL, StyleWithLine)); + EXPECT_EQ(test2NL, format(test1NL, StyleWithLine)); Max_S w

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. Btw, while this change does explain _what_ it does, it doesn't actually say the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case where e.g. some translations produce different error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:9392 + "};\n"; + EXPECT_EQ(NL_B_3_A_1_I_3, format(NL_B_3_

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. could you please mark your comments done when they are done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 ___ cfe-commits maili

[PATCH] D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable.

rupprecht added a comment. We're seeing a crash in the optimizer after this patch, with the following logged in assert builds: `assert.h assertion failed at llvm/include/llvm/Support/Casting.h:104 in static bool llvm::isa_impl_cl::doit(const From *) [To = llvm::InvokeInst, From = const llvm::I

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2132 +**EmptyLineAfterAccessModifier** (``EmptyLineAfterAccessModifierStyle``) + Defines in which cases to put empty line after access modifiers. + Comme

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2637826 , @mstorsjo wrote: > Btw, while this change does explain _what_ it does, it doesn't actually say > the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case > where e.g. some translations produc

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. enum { A, B, C, } ShortEnum1, ShortEnum2; I've seen this before maybe with regard to something else, but can't quite recall. (maybe a bug in the bug tracker) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D98867: [HIP] Fix ROCm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:267-268 +// rocm-{major}.{minor}.{subMinor}[-{build}] +auto Loc = StringRef(VerStr).rfind('_'); +if (Loc != StringRef::npos) + VerStr[Loc] = '.'; You don't need `String

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

josemonsalve2 added inline comments. Comment at: clang/test/OpenMP/nvptx_parallel_codegen.cpp:4 -// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s -fopenmp-is-device -fopenmp-host-ir-file-path %t-ppc-ho

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:298 + driverPath.append("/../include/flang/"); + return driverPath.str().str(); +} Given this [[ https://github.com/llvm/llvm-project/blob/987ee6e3cc1fb672b3ed201e72a5281c2

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tra added a comment. In D98902#2636308 , @jdoerfert wrote: > @tra, so you think we should not do this? The user will see a link error late > I assume, might be better. If I compile a `__device__ float foo(float f) { return sin(f); }` and it does compile

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > Does this need to be down here? Or would the code be a well exercise

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Aa, get it. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 __

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. In D98278#2637866 , @zero9178 wrote: > In D98278#2637826 , @mstorsjo wrote: > >> Btw, while this change does explain _what_ it does, it doesn't actually say >> the exact reason _why_. Clea

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. In D98278#2637866 , @zero9178 wrote: > In D98278#2637826 , @mstorsjo wrote: > >> Btw, while this change does explain _what_ it does, it doesn't actually say >> the exact reason _why_. Clea

[PATCH] D98923: [Driver] Pass -fexperimental-strict-floating-point to cc1 if it is specified

kpn added a comment. Test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98923/new/ https://reviews.llvm.org/D98923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > Does this need to be down here? Or would the code b

[PATCH] D98923: [Driver] Pass -fexperimental-strict-floating-point to cc1 if it is specified

craig.topper added a comment. Isn't OPT_fexperimental_strict_floating_point marked as a CC1Option in Options.td. Can the driver even recognize it? Can you use -Xclang -fexperimental-strict-floating-point for your use case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx updated this revision to Diff 331941. flx added a comment. Applied changes suggested by ymandel, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98738/new/ https://reviews.llvm.org/D98738 Files: clang-tools-extra/clang-tidy/utils/Match

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

Quuxplusone created this revision. Quuxplusone added reviewers: rsmith, nullptr.cpp, aaronpuchert, mizvekov, erik.pilkington, sberg, davidstone, david_stone. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. Review D88220

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a comment. To whom it may concern, see D98971 . I'm (unwisely?) trying a surgical fix rather than trying to revert the month-old thing. (Let's please discuss anything D98971 -specific over there.) Repository:

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx marked 6 inline comments as done. flx added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:52 AST_MATCHER_P(NamedDecl, matchesAnyListedName, std::vector, NameList) { hokein wrote: > worth some comments on this. Do

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

nick updated this revision to Diff 331945. nick retitled this revision from "[clang][AST] Add `CXXBaseSpecifier` matcher support" to "[ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)". nick edited the summary of this revision. nick added a reviewer: aaron.ballman. nick added a comment.

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

nick updated this revision to Diff 331955. nick added a comment. Forgot to remove a duplicated test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D98935: [WoA][MSVC] Use default linker setting in MSVC-compatible driver [take 2]

maxim-kuvyrkov added a subscriber: tstellar. maxim-kuvyrkov added a comment. @tstellar Hi Tom, This has passed buildbots, so I'll cherry-pick this to release/12.x to fix https://bugs.llvm.org/show_bug.cgi?id=49624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable.

rupprecht added a comment. The error message I posted earlier was when using O1 + new PM, but it crashes with the old one & no optimizations: $ cat /tmp/repro.cc void a() { for (; int b = 0;) continue; } $ clang -c /tmp/repro.cc -o /tmp/r

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable.

rupprecht added a comment. I tried creating an IR repro, but: running `-S -emit-llvm` with the old PM crashes before it can generate anything, and running with the new PM seems to generate invalid IR (branches to %for.inc, which does not exist). I suspect this is not an optimizer bug, but crash

[PATCH] D94355: [Passes] Add relative lookup table converter pass

lebedev.ri added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:390-391 + +if (!TM.getTargetTriple().isArch64Bit()) + return false; + gulfem wrote: > lebedev.ri wrote: > > 1. But all tests are using `x86_64` triple? > > 2. This is

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. awarzynski wrote: > Would it be possible to share this test with `f18`? Would you please elaborate on how d

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

Quuxplusone updated this revision to Diff 331973. Quuxplusone added a comment. Per @mizvekov, use `VDType` instead of `VD->getType()` wherever possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98971/new/ https://reviews.llvm.org/D98971 Files

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. arnamoy10 wrote: > awarzynski wrote: > > Would it be possible to share this test with `f18`? > Would you p

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3095 - // ...non-volatile... - if (VD->getType().isVolatileQualified()) -return false; - - // C++20 [class.copy.elision]p3: - // ...rvalue reference to a non-volatile... - if (VD->getType()->isRVal

  1   2   >