[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

HsiangKai added a comment. In D100823#2704120 , @craig.topper wrote: > I just posted https://reviews.llvm.org/D100889 which should allow the > frontend to treat all comparisons the same way. It also avoids using the long > expansion for vmsge.vx I wil

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 339484. bader marked 7 inline comments as done. bader added a comment. Applied more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/includ

[PATCH] D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument

njames93 added a comment. In D99924#2706181 , @aaron.ballman wrote: > Adding the CFE mailing list, which was not on the review previously. I think H744 needs updating to add cfe-commits. This used to be handled by the rul

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Nice idea to create `Function::createWithDefaultAttr` then reuse for multiple purposes! Comment at: llvm/lib/IR/Function.cpp:333 Function *Function::cre

[PATCH] D101020: clang-format: [JS] do not merge side-effect imports.

mprobst created this revision. mprobst added reviewers: krasimir, h-joo. mprobst requested review of this revision. Herald added a project: clang. The if condition was testing the current element, but forgot to check the previous element (doh), so it would fail depending on sort order of the impor

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG722d4d8e7585: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANG

[clang] 722d4d8 - [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

Author: Pushpinder Singh Date: 2021-04-22T05:20:28Z New Revision: 722d4d8e7585457d407d0639a4ae2610157e06a8 URL: https://github.com/llvm/llvm-project/commit/722d4d8e7585457d407d0639a4ae2610157e06a8 DIFF: https://github.com/llvm/llvm-project/commit/722d4d8e7585457d407d0639a4ae2610157e06a8.diff L

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

Meinersbur added a comment. thanks for the update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. For D89671 , Johannes had some comments which have been taken care of. I am just waiting for him to get back on it. I'll ping him there. This patch is done from my end unless someone has some comment/thought. Repository: rG LLVM Git

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

dongAxis1944 accepted this revision. dongAxis1944 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100298/new/ https://reviews.llvm.org/D100298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] 26f138e - [Debug-Info] implement -gstrict-dwarf

Author: Chen Zheng Date: 2021-04-22T00:41:25-04:00 New Revision: 26f138eed4af8ac7f12d2f11af1ba0f8aac68d4b URL: https://github.com/llvm/llvm-project/commit/26f138eed4af8ac7f12d2f11af1ba0f8aac68d4b DIFF: https://github.com/llvm/llvm-project/commit/26f138eed4af8ac7f12d2f11af1ba0f8aac68d4b.diff LO

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks created this revision. Herald added subscribers: wenlei, steven_wu, hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. A future change will cause fewer analyses to be invalidated. Currently, the p

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

MaskRay created this revision. MaskRay added reviewers: Sanitizers, nickdesaulniers. Herald added subscribers: dexonsmith, hiraditya. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The Linux kernel objtool diagnos

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

HsiangKai marked 3 inline comments as done. HsiangKai added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048 + return Cmp < 0; + // Some mask intrinsics use the same IRName as unmasked. + // Sor

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

HsiangKai updated this revision to Diff 339452. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100819/new/ https://reviews.llvm.org/D100819 Files: clang/include/clang/Basic/riscv_vector.td clang/test

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100830/new/ https://reviews.llvm.org/D100830 ___

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2dbfb6b72db: [OpenMP] Simplify offloading parallel call codegen (authored by ggeorgakoudis). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D100981: Delete le32/le64 targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77ac823fd285: Delete le32/le64 targets (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 77ac823 - Delete le32/le64 targets

Author: Fangrui Song Date: 2021-04-21T18:44:12-07:00 New Revision: 77ac823fd285973cfb3517932c09d82e6a32f46d URL: https://github.com/llvm/llvm-project/commit/77ac823fd285973cfb3517932c09d82e6a32f46d DIFF: https://github.com/llvm/llvm-project/commit/77ac823fd285973cfb3517932c09d82e6a32f46d.diff

[PATCH] D93031: Enable fexec-charset option

joerg added a comment. "Keeping the original spelling around" would assume that the input is not using a stateful encoding. That seems worse as assumption than giving the canonical output in UTF-8 and shifting the problem to the user's editor? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

lxfind added a comment. Thanks for working on this. I am still having a bit hard time understanding the solution. A few questions: 1. I assume this patch is to solve the problem where the promise object is not aligned according to its alignof annotation, right? The title/wording is a bit mislea

[PATCH] D100981: Delete le32/le64 targets

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. Thanks. I had heard in the past that there were some other folks who had used le32/le64 as a "generic" target (in fact that's why it's named so generically, rather than being called "pnacl"

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:368 + +In C++ files, declare these as ``extern "C"``. + vsk wrote: > I think we should leave a note about how to avoid pulling in unw

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

dexonsmith updated this revision to Diff 339423. dexonsmith added a comment. Incorporate feedback from @vsk: - a bit more explanatory text for the overall context - explicitly reference the static initializers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101000/new/ https://reviews.ll

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

This revision was automatically updated to reflect the committed changes. Closed by commit rG775a9483e55e: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 775a948 - [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2021-04-21T15:58:20-07:00 New Revision: 775a9483e55efb365691bc425ed107568ad6daf8 URL: https://github.com/llvm/llvm-project/commit/775a9483e55efb365691bc425ed107568ad6daf8 DIFF: https://github.com/llvm/llvm-project/commit/775a9483e55efb365691bc425ed107568ad6daf8.diff

[PATCH] D100869: [libcxx] Stop using use c++ subdirectory for libc++ library

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf749550cfe9f: [libcxx] Stop using use c++ subdirectory for libc++

[clang] f749550 - [libcxx] Stop using use c++ subdirectory for libc++ library

Author: Petr Hosek Date: 2021-04-21T15:39:03-07:00 New Revision: f749550cfe9f0bf2364abb2139835348587062ed URL: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed DIFF: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed.diff LO

[libunwind] f749550 - [libcxx] Stop using use c++ subdirectory for libc++ library

Author: Petr Hosek Date: 2021-04-21T15:39:03-07:00 New Revision: f749550cfe9f0bf2364abb2139835348587062ed URL: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed DIFF: https://github.com/llvm/llvm-project/commit/f749550cfe9f0bf2364abb2139835348587062ed.diff LO

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. In D4#2706515 , @Holman wrote: > Can someone help me get this checked in? Sure, I went ahead and pushed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77357208c46a: [CodeView] Add CodeView support for PGO debug information (authored by Holman, committed by rnk). Repository: rG LLVM Github Monorep

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

vsk added a subscriber: efriedma. vsk added a comment. Thanks for doing this! + Eli to comment on whether any workarounds documented in https://lists.llvm.org/pipermail/llvm-dev/2017-September/117156.html are still necessary. To my knowledge it's not currently necessary to explicitly pass -mll

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2147-2150 +This attribute can only be used to set up the aliases for certain RISC-V +C intrinsic functions; it is intended for use only inside ``riscv_*.h`` +and is not a general mechanism for decl

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

dexonsmith created this revision. dexonsmith added a reviewer: vsk. dexonsmith requested review of this revision. Herald added a project: clang. The profiling runtime was designed to work without static initializers or a a filesystem (see 117cf2bd1ff585f9754b5f30f5a4cfd65b230bbf and others). The n

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. I got LGTM for this before, but I'll leave it open for a few days to address any new comments folks might have. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3523 +else + Opts.CXXABI = TargetCXXABI::getKind(CXXABI); + } --

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 339400. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include

[PATCH] D93031: Enable fexec-charset option

cor3ntin added a comment. >> We should use the original source form of the string literal when >> pretty-printing a `StringLiteral` or `CharacterLiteral`; there are a bunch >> of UTF-8 assumptions baked into `StmtPrinter` that will need revisiting. And >> we'll need to modify the handful of pla

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. In D45639#2706589 , @dexonsmith wrote: > I'm not sure I'm totally following, but just want to double check that the > tests won't somehow use the libc++ from the SDK instead of ToT? I guess the > test uses `-nostdinc++` or someth

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

lxfind added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2689 - size_t __builtin_coro_size() + size_t __builtin_coro_size(bool alloc) void *__builtin_coro_frame() ChuanqiXu wrote: > ychen wrote: > > ChuanqiXu wrote: > > > ychen wrote: >

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

dexonsmith added a comment. > No, the bot is also meant to catch changes to libc++ breaking LLDB (or at > least making sure we update the corresponding data formatters). > Given that these tests are macOS specific and already require a specific SDK, > I'll just update them to use the compiler

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2706554 , @xbolva00 wrote: > In D100581#2706467 , @dblaikie > wrote: > >> FWIW, I'd love it if we could do a full dead-store warning, which would be a >> superset of this. I

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

MaskRay added a comment. Still LG:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100968/new/ https://reviews.llvm.org/D100968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2706467 , @dblaikie wrote: > FWIW, I'd love it if we could do a full dead-store warning, which would be a > superset of this. I think we have enough infrastructure in the analysis based > warnings (I think the suffic

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

JDevlieghere added a comment. In D45639#2706364 , @JDevlieghere wrote: > Given that these tests are macOS specific and already require a specific SDK, > I'll just update them to use the compiler from the SDK instead of the > just-built one. Done in 5d1

[clang] 6331680 - Re-land "[Driver] Support default libc++ library location on Darwin"

Author: Jonas Devlieghere Date: 2021-04-21T14:22:13-07:00 New Revision: 6331680ad2ad000fdaf7e72f3c1880c7908ffa25 URL: https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25 DIFF: https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25.d

[clang] 5a2d78b - [HIP] Add option -fgpu-inline-threshold

Author: Yaxun (Sam) Liu Date: 2021-04-21T17:18:18-04:00 New Revision: 5a2d78b1639738fbde85248413c1cfd2df55683a URL: https://github.com/llvm/llvm-project/commit/5a2d78b1639738fbde85248413c1cfd2df55683a DIFF: https://github.com/llvm/llvm-project/commit/5a2d78b1639738fbde85248413c1cfd2df55683a.dif

[PATCH] D99233: [HIP] Add option -fgpu-inline-threshold

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2d78b16397: [HIP] Add option -fgpu-inline-threshold (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CH

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman added a comment. Can someone help me get this checked in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D99983: Provide TreeTransform::TransformAttr the transformed statement; NFC

haberman accepted this revision. haberman added a comment. This revision is now accepted and ready to land. This seems fine to me, but I'll defer to @rsmith for final review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99983/new/ https://reviews.llvm.org/D99983 __

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. FWIW, I'd love it if we could do a full dead-store warning, which would be a superset of this. I think we have enough infrastructure in the analysis based warnings (I think the sufficiency of the infrastructure is demonstrated by the "may be used uninitialized" warning

[PATCH] D99299: Normalize interaction with boolean attributes

dblaikie added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:660-663 +bool AttributeImpl::getValueAsBool() const { + assert(getValueAsString().empty() || getValueAsString() == "false" || getValueAsString() == "true"); + return getValueAsString() == "true"; +} ---

[PATCH] D100466: clang-format: [JS] merge import lines.

jgorbe added a comment. Hi, one of our tests is failing because of this patch and it looks like an actual bug. clang-format now turns this file: import './a'; import {bar} from './a'; into this: barimport './a'; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

JDevlieghere added a comment. Given that these tests are macOS specific and already require a specific SDK, I'll just update them to use the compiler from the SDK instead of the just-built one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/n

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

aaron.ballman added a comment. In D98450#2699970 , @arphaman wrote: > Your argument makes sense. The problem right now is that clang doesn't allow > the name to be used even when the user marks up availability correctly trying > to guard the use of the d

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 339355. abhina.sreeskantharajan added a reviewer: ThePhD. abhina.sreeskantharajan added a comment. Thanks for catching that. This sets the __clang_literal_encoding__ to Opts.ExecCharset or defaults to SystemCharset. Repository: rG LLVM G

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl updated this revision to Diff 339353. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99233/new/ https://reviews.llvm.org/D99233 Files: clang

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser created this revision. jamieschmeiser added reviewers: rsmith, saar.raz. jamieschmeiser requested review of this revision. Herald added a project: clang. When vector is found as a type or non-type id, check if it is really the altivec vector token. Call TryAltiVecVectorToken when

[PATCH] D100000: [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO

mizvekov updated this revision to Diff 339349. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/DiagnosticSem

[PATCH] D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Adding the CFE mailing list, which was not on the review previously. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99924/new/ https://reviews.llvm.org/D99924 ___ cf

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ? (I actually should remove some extra includes and extra member fields) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-com

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini. Herald added subscribers: ebevhan, kristof.beyls, yaxunl. Anastasia requested review of this revision. This removed the pointless need for extension pragma since it doesn't disable anything properly and it doesn't nee

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 339334. ggeorgakoudis added a comment. Fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/

[PATCH] D100984: [OpenCL] Remove the need for subgroupd extension pragma in enqueue kernel builtins

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. There is no extension pragma requirement in the spec for these functions and all other builtin functions are available

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra added a comment. Do you know if any existing code already uses the `__nvvm_*` builtins for `cp.async`? In other words, does nvcc provide them already or is it something we're free to name as we wish? I do not see any relevant intrinsics mentioned in NVVM IR spec: https://docs.nvidia.com/cud

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

Meinersbur added a comment. What is the status of this? The parent D89671 has been accepted, but not committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:954 +def gpu_inline_threshold_EQ : Joined<["--"], "gpu-inline-threshold=">, + Flags<[CC1Option]>, + HelpText<"Inline threshold for device compilation for HIP

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Looks good, but please fix the clang-format notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, yaxunl. Herald added a subscriber: ebevhan. Anastasia requested review of this revision. This change allows the use of identifiers for image types from `cl_khr_gl_msaa_sharing` freely in the kernel code if the extensio

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); mibintc wrote: > mibintc wrote: > > kpn wrote:

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:300 + +std::string unescape(StringRef S) { + std::string Out; aganea wrote: > mstorsjo wrote: > > aganea wrote: > > > I would also need this fun

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

JDevlieghere added a comment. In D45639#2705919 , @phosek wrote: > In D45639#2705702 , @ldionne wrote: > >> In D45639#2703913 , @JDevlieghere >> wrote: >> >>> This breaks `T

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light added a comment. In D100834#2704330 , @fhahn wrote: > In D100834#2702550 , @kpn wrote: > >> I don't know the matrix implementation so I can't swear this hits every >> place needed, but the uses of

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 339325. effective-light added a comment. Add a test for compound operations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files: clang/lib/CodeGen/CGExprS

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

tra added a comment. > The planned new option for offloading will be a more generic solution, > however, I expect it will take time to develop and be adopted. Agreed. OK, let's use a hidden option until we have a better way of dealing with this. Comment at: clang/include/cla

[PATCH] D100981: Delete le32/le64 targets

MaskRay created this revision. MaskRay added a reviewer: dschuff. Herald added subscribers: dexonsmith, jfb, hiraditya, mgorny. MaskRay requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. They are unused now. Note: N

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In D45639#2705702 , @ldionne wrote: > In D45639#2703913 , @JDevlieghere > wrote: > >> This breaks `TestAppleSimulatorOSType.py ` on GreenDragon. First failed >> build: http://green.lab.llvm

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. This test seem to pass on Windows now. Please still fix the clang-format remarks, such as going over 80 characters on a line. Comment at: clang/lib/CodeGen/CGOpenMPR

[PATCH] D99983: Provide TreeTransform::TransformAttr the transformed statement; NFC

aaron.ballman updated this revision to Diff 339319. aaron.ballman added a comment. Now that [[clang::musttail]] has landed, I can show the refactoring I had in mind by implementing it myself. WDYT of this approach? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99983/new/ https://review

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2147-2150 +This attribute can only be used to set up the aliases for certain RISC-V +C intrinsic functions; it is intended for use only inside ``riscv_*.h`` +and is not a general mechanism for

[clang] 0798842 - [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

Author: Alexey Bataev Date: 2021-04-21T10:38:31-07:00 New Revision: 079884225a5571f4caf1a9c71b6748db8192e383 URL: https://github.com/llvm/llvm-project/commit/079884225a5571f4caf1a9c71b6748db8192e383 DIFF: https://github.com/llvm/llvm-project/commit/079884225a5571f4caf1a9c71b6748db8192e383.diff

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079884225a55: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault. (authored by ABataev). Repository: rG LLVM Github Monorepo CH

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. OpenCL specification doesn't require the pragma for the uses of `double` type when it is supported by the targets. The wording in

[PATCH] D100907: [lsan][docs] Clarify supported platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cbe4881882e: [lsan][docs] Clarify supported platforms (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100907/new/ https://reviews.llvm

[clang] 4cbe488 - [lsan][docs] Clarify supported platforms

Author: Fangrui Song Date: 2021-04-21T10:27:55-07:00 New Revision: 4cbe4881882edd64a7ff53da52970c4b6333de1c URL: https://github.com/llvm/llvm-project/commit/4cbe4881882edd64a7ff53da52970c4b6333de1c DIFF: https://github.com/llvm/llvm-project/commit/4cbe4881882edd64a7ff53da52970c4b6333de1c.diff

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. Thanks, looks really good. Meanwhile I collected some interesting testcases from gcc bugzilla (reported as false positives), please try: https://godbolt.org/z/747ndKEvd - No "unused-but-set" warnings expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. Clang's implementation of the extension pragma is broken because it doesn't respect the following requirement from OpenCL Ext

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan updated this revision to Diff 339293. urnathan added a comment. Updated to fix formatting etc (pretty sure I got clang-format to work this time). I changed the pre-c++20 behaviour to be a warning along the lines you suggested. Trying to move the qualifier checking until after generati

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. In D45639#2703913 , @JDevlieghere wrote: > This breaks `TestAppleSimulatorOSType.py ` on GreenDragon. First failed > build: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31346/ > [...] > > Based on your description abo

[PATCH] D100955: [-Wcalled-once] Do not run analysis on Obj-C++

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok then! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100955/new/ https://reviews.llvm.org/D100955 ___ c

[PATCH] D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks

mgartmann created this revision. mgartmann added reviewers: aaron.ballman, njames93, alexfh. mgartmann added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. mgartmann requested review of this revision. I added fixes to the existing checks of `cppcore

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

PaulkaToast added a comment. In D100968#2705598 , @MaskRay wrote: >> On newer Linux distributions > > Different distributions have different strategies migrating the > /usr/bin/python symlink. Debian and its derivatives provide python-is-python2 > and p

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > On newer Linux distributions Different distributions have different strategies migrating the /usr/bin/python symlink. Debian and its derivatives provide python-is-python2 and python-is-py

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen added a comment. > what assertion? $ ":" "RUN: at line 1" $ "/mnt/disks/ssd0/agent/llvm-project/build/./bin/clang" "-fopenmp" "-pthread" "-fno-experimental-isel" "-I" "/mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test" "-I" "/mnt/disks/ssd0/agent/llvm-project/build/projects/op

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

aganea added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:300 + +std::string unescape(StringRef S) { + std::string Out; mstorsjo wrote: > aganea wrote: > > I would also need this function in D43002 (see unescapeSlashes), do you > > think we can m

[PATCH] D100968: Update shebang for clang-format-diff script to python3.

PaulkaToast created this revision. PaulkaToast added reviewers: MaskRay, DavidSpickett. PaulkaToast requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On newer Linux distributions that don't have python2, the clang-format-diff script and cons

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2700083 , @xbolva00 wrote: > So I think we should put UnusedButSetParameter under -Wextra > > So I would just put UnusedButSetVariable under -Wunused (and -Wunused is part > of -Wall): > > WDYT? Sounds good; I've do

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 339275. mbenfield added a comment. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, joh

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 339265. ggeorgakoudis added a comment. Add tests, reduce microtask cases to avoid stack problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/li

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048 + return Cmp < 0; + // Some mask intrinsics use the same IRName as unmasked. + // Sort the unmasked intrinsics first.

  1   2   3   >