[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. @NoQ I figured out the tests but while testing against Z3, I mixed up constraints. I am changing those. Comment at: clang/test/Analysis/constant-folding.c:265 +if (a > INT_MAX) { + clang_analyzer_eval((a + b) <= 0); // expected-warning{{FALSE}}

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

RedDocMD added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:95 + /// This method is run once the \ref Stop method is called. + virtual void OnStop(const ExplodedNode *Curr, BugReporterContext , +

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

NoQ added a comment. Our pre-commit testing shows that the new tests fail, eg.: https://buildkite.com/llvm-project/premerge-checks/builds/41391#b557c86c-0587-4aee-a06b-8a4de6d771c4 Failed Tests (1): Clang :: Analysis/constant-folding.c Did you figure out how to *run* the tests locally?

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:95 + /// This method is run once the \ref Stop method is called. + virtual void OnStop(const ExplodedNode *Curr, BugReporterContext , +

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

xazax.hun added inline comments. Comment at: clang/test/Analysis/constant-folding.c:265 +if (a > INT_MAX) { + clang_analyzer_eval((a + b) <= 0); // expected-warning{{FALSE}} + clang_analyzer_eval((a + b) > 0); // expected-warning{{FALSE}} Since

[clang] 20797b1 - Revert "Fix tmp files being left on Windows builds." for now;

Author: Amy Huang Date: 2021-06-01T19:51:47-07:00 New Revision: 20797b129f844d4b12ffb2b12cf33baa2d42985c URL: https://github.com/llvm/llvm-project/commit/20797b129f844d4b12ffb2b12cf33baa2d42985c DIFF: https://github.com/llvm/llvm-project/commit/20797b129f844d4b12ffb2b12cf33baa2d42985c.diff

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail created this revision. lkail added reviewers: nemanjai, jsji, xingxue, hubert.reinterpretcast, cebowleratibm, PowerPC. Herald added subscribers: jfb, kbarton. Herald added a reviewer: jfb. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D103457: [analyzer] Add forwarding `addVisitor` method

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Excellent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103457/new/ https://reviews.llvm.org/D103457

[clang] 04caa7c - [CUDA][HIP] Promote const variables to constant

Author: Yaxun (Sam) Liu Date: 2021-06-01T21:28:41-04:00 New Revision: 04caa7c3e02f0e2f96881b2b9b5ae5fec6e59aa9 URL: https://github.com/llvm/llvm-project/commit/04caa7c3e02f0e2f96881b2b9b5ae5fec6e59aa9 DIFF:

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04caa7c3e02f: [CUDA][HIP] Promote const variables to constant (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang/test/Driver/aarch64-target-as-march.s:4 + +/// The last -march wins, and is handled before -Wa,march. All the values of -Wa,march options are added. +// RUN: %clang

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 updated this revision to Diff 349150. jcai19 added a comment. Limit the change to assembler files, and add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 Files:

[clang] f7e87dd - [CUDA][HIP] Change default lang std to c++14

Author: Yaxun (Sam) Liu Date: 2021-06-01T20:45:10-04:00 New Revision: f7e87dd6ff0c1c4a41a6b654d2460557ae97ab8d URL: https://github.com/llvm/llvm-project/commit/f7e87dd6ff0c1c4a41a6b654d2460557ae97ab8d DIFF:

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGf7e87dd6ff0c: [CUDA][HIP] Change default lang std to c++14 (authored by yaxunl). Herald added a project:

[PATCH] D100391: [RISCV][Clang] Add RVV miscellaneous intrinsic functions.

pshung added a comment. @khchen This patch doesn't generate the overloaded APIs for "vreinterpret". Any concern? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100391/new/ https://reviews.llvm.org/D100391

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin added a comment. Yes, a CMake option is a good idea for this. I'll update this change to add a new CMake option for who don't want all the headers (default OFF to follow exist behavior) . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. Thanks for taking a look, @rjmccall - I really appreciate it! Sorry I'm doing a bad job describing (admittedly I'm pretty confused about all this, which is most of the issue) the issue - I'll try to clarify as best I can. In D98799#2781200

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames updated this revision to Diff 349141. arames added a comment. Fix detail namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.h:81 + template void updateHash(HashT ) const { +Hash.updateRange([0], [0] + kNumElem); An alternative to having those in class would be to have helpers directly in

[clang] 7daa182 - Fix tmp files being left on Windows builds.

Author: Amy Huang Date: 2021-06-01T17:09:08-07:00 New Revision: 7daa18215905c831e130c7542f17619e9d936dfc URL: https://github.com/llvm/llvm-project/commit/7daa18215905c831e130c7542f17619e9d936dfc DIFF: https://github.com/llvm/llvm-project/commit/7daa18215905c831e130c7542f17619e9d936dfc.diff

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

crr0004 added a comment. Whoops. Hit close without adding this comment. Okay thank you for that @sammccall and @kadirect. Ultimately shared this patch was I found it useful but wasn't sure if it would fit with the project. Is there somewhere I can read about project direction/decisions? Like

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

arames updated this revision to Diff 349139. arames added a comment. Use `llvm::MD5`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

wolfgangp created this revision. wolfgangp added reviewers: rnk, jyu2. wolfgangp requested review of this revision. Commit c19f4f8069 caused some ordered dynamic initialization of static member variables to

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2792159 , @probinson wrote: > In D103131#2791881 , @dblaikie > wrote: > >> In D103131#2789493 , @probinson >> wrote: >> Mixed

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6f88dc01a72: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia (authored by leonardchan). Repository: rG LLVM Github Monorepo

[clang] e6f88dc - [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

Author: Leonard Chan Date: 2021-06-01T15:46:09-07:00 New Revision: e6f88dc01a7208b6f4671c4fcb5d9e68d0808a34 URL: https://github.com/llvm/llvm-project/commit/e6f88dc01a7208b6f4671c4fcb5d9e68d0808a34 DIFF: https://github.com/llvm/llvm-project/commit/e6f88dc01a7208b6f4671c4fcb5d9e68d0808a34.diff

[clang] cf49cae - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Author: Michael Benfield Date: 2021-06-01T15:38:48-07:00 New Revision: cf49cae278b4e972cd2547d72f9ee7d9d69a3af4 URL: https://github.com/llvm/llvm-project/commit/cf49cae278b4e972cd2547d72f9ee7d9d69a3af4 DIFF:

[clang] da1db49 - [Fuchsia] Add compat multilibs to cache file

Author: Leonard Chan Date: 2021-06-01T15:14:56-07:00 New Revision: da1db49409657d5212185ab9952ee35d99b773d4 URL: https://github.com/llvm/llvm-project/commit/da1db49409657d5212185ab9952ee35d99b773d4 DIFF: https://github.com/llvm/llvm-project/commit/da1db49409657d5212185ab9952ee35d99b773d4.diff

[PATCH] D103477: [Fuchsia] Add compat multilibs to cache file

This revision was automatically updated to reflect the committed changes. Closed by commit rGda1db4940965: [Fuchsia] Add compat multilibs to cache file (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103477/new/

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14921 + verifyFormat("unsigned int *a;\n" + "int*b;\n" "unsigned int Const *c;\n" MyDeveloperDay wrote: > I seem to

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I'm done with testing. The patch does not seem to break anything obvious. Tensorflow builds and works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103108/new/

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

MyDeveloperDay added a comment. It maybe that others think that the PAS_Right IS that option. If thats is the case I'm fine with that too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/aarch64-target-as-march.s:4 + +/// The last -march wins, and is handled before -Wa,march. All the values of -Wa,march options are added. +// RUN: %clang --target=aarch64-linux-gnueabi -### -c

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2792052 , @yaxunl wrote: > I think for intermediate outputs e.g. preprocessor expansion, IR, and > assembly, probably it makes sense not to bundle by default. Agreed. > However, for default action (emitting object), we

[PATCH] D103131: support debug info for alias variable

probinson added a comment. In D103131#2791881 , @dblaikie wrote: > In D103131#2789493 , @probinson > wrote: > >>> Mixed feelings - somewhat in favor of "do the thing that's probably already >>> fairly

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. Thanks for the comments. Please see my replies inlined. In D103184#2790486 , @DavidSpickett wrote: > Thanks for taking this up! I never got the time for it. > > I'd like to see the test check that there are no unused argument

[clang] d7f846f - Fix a Clang diagnostic to start with a lowercase letter; NFC

Author: Aaron Ballman Date: 2021-06-01T17:03:31-04:00 New Revision: d7f846fc6be14539fb0f5223eb08cb2235759897 URL: https://github.com/llvm/llvm-project/commit/d7f846fc6be14539fb0f5223eb08cb2235759897 DIFF: https://github.com/llvm/llvm-project/commit/d7f846fc6be14539fb0f5223eb08cb2235759897.diff

[PATCH] D103477: [Fuchsia] Add compat multilibs to cache file

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103477/new/ https://reviews.llvm.org/D103477

[PATCH] D103491: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

nikic created this revision. nikic added reviewers: lattner, RKSimon. Herald added subscribers: foad, dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst,

[PATCH] D102507: [HIP] Support in device code

rsmith added a comment. @ldionne How should we go about establishing whether libc++ would be prepared to officially support CUDA? Right now, Clang's CUDA support is patching in attributes onto libc++ functions from the outside, which doesn't seem like a sustainable model. CHANGES SINCE LAST

[PATCH] D90188: Add support for attribute 'using_if_exists'

ldionne updated this revision to Diff 349087. ldionne added a comment. Fix CI issues (hopefully - at least everything runs locally). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2791734 , @tra wrote: > In D101630#2787714 , @yaxunl wrote: > >> How does nvcc --genco behave when there are multiple GPU arch's? Does it >> output a fat binary containing

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/asm_delayed_diags.cu:31 static __device__ __host__ double t3(double x) { - register long double result; + register long double result; // expected-warning {{'register'

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl updated this revision to Diff 349080. yaxunl marked an inline comment as done. yaxunl added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103221/new/ https://reviews.llvm.org/D103221 Files: clang/include/clang/Basic/LangStandards.def

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

bruno added inline comments. Comment at: clang/lib/Lex/HeaderMap.cpp:265 + } + return ReverseMap.lookup(DestPath); +} How about something along the lines of: ``` ... StringRef Key; for (unsigned i = 0; i != NumBuckets; ++i) { HMapBucket B = getBucket(i);

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ah! Thats what I missed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103485/new/ https://reviews.llvm.org/D103485

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman added a comment. In D103485#2791940 , @erichkeane wrote: > The patch looks fine to me, though I don't particularly get the test changes > that move a diagnostic by 1 line? The `global-vs-module.cpp` test had a line removed from it for

[PATCH] D103258: [clang] Fix ICE with typeid & polymorphic class (pr50497)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc138f3ce5c70: [clang] Fix ICE with typeid polymorphic class (pr50497) (authored by urnathan). Herald added a project: clang. Herald added a

[clang] c138f3c - [clang] Fix ICE with typeid & polymorphic class (pr50497)

Author: Nathan Sidwell Date: 2021-06-01T12:55:29-07:00 New Revision: c138f3ce5c70ff87a35d77e11f77a77d9d539b49 URL: https://github.com/llvm/llvm-project/commit/c138f3ce5c70ff87a35d77e11f77a77d9d539b49 DIFF:

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen added a comment. In D101775#2791938 , @dexonsmith wrote: > @zahen , what author information should I use for the Git commit? Zachary Henkel, za...@microsoft.com (GitHub username ZacharyHenkel) Thanks Duncan! Repository: rG LLVM Github

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

erichkeane added a comment. The patch looks fine to me, though I don't particularly get the test changes that move a diagnostic by 1 line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103485/new/ https://reviews.llvm.org/D103485

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

dexonsmith added a comment. @zahen , what author information should I use for the Git commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101775/new/ https://reviews.llvm.org/D101775 ___ cfe-commits

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; thanks for you patience. I've been a bit paralyzed, thinking about whether we could/should add a remark, something like `-Rtemp-file` or `-Routput-file`, which could be

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

tra added inline comments. Comment at: clang/test/SemaCUDA/asm_delayed_diags.cu:31 static __device__ __host__ double t3(double x) { - register long double result; + register long double result; // expected-warning {{'register' storage class specifier is deprecated and

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. The following was found by a customer and is accepted by the other primary C++ compilers, but fails to compile in

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. Hello, this patch introduces a regression in one of our codebases. The compilation of several TUs fails with the following callstack: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14921 + verifyFormat("unsigned int *a;\n" + "int*b;\n" "unsigned int Const *c;\n" I seem to remember in the past there

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

tra added a comment. LGTM. I would like to test the patch on our code first. Please wait a bit before landing the patch. I should be able to have the results tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103108/new/ https://reviews.llvm.org/D103108

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2789493 , @probinson wrote: >> Mixed feelings - somewhat in favor of "do the thing that's probably already >> fairly tested/known to work" (GCC's thing). But open to the idea that that >> approach has problems, for

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Will do on Thursday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 ___ cfe-commits mailing list

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103108/new/ https://reviews.llvm.org/D103108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:196-197 // CUDA LANGSTANDARD(cuda, "cuda", CUDA, "NVIDIA CUDA(tm)", LineComment | CPlusPlus | Digraphs) tra wrote: >

[PATCH] D103221: [CUDA][HIP] Change default lang std to c++14

yaxunl updated this revision to Diff 349052. yaxunl retitled this revision from "[HIP] Change default lang std to c++14" to "[CUDA][HIP] Change default lang std to c++14". yaxunl edited the summary of this revision. yaxunl added a comment. revised by Artem's comments, and fix tests CHANGES

[PATCH] D103461: [clang][deps] NFC: Do not adjust the original action

dexonsmith added a comment. Is there (or could there be) a mode where `clang-scan-deps` prints out the command-lines it sends to the dependency scanning action (maybe instead of actually scanning), so this could be tested? Comment at:

[PATCH] D102923: [clang][lex] Remark for used header search paths

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:427 +def remark_pp_include_header_search_usage : Remark< + "user-provided search path used: '%0'">, + InGroup>; jansvoboda11 wrote: > dexonsmith wrote: > > I suggest,

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2787714 , @yaxunl wrote: > How does nvcc --genco behave when there are multiple GPU arch's? Does it > output a fat binary containing multiple ISA's? Also, does it support > device-only compilation for intermediate

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 349045. urnathan added a comment. rebase and fix conflict CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 349044. urnathan added a comment. Rebase and fix conflict CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:594 +if (CondInfo.FoundElse) + Diag(Tok, diag::pp_err_elif_after_else) << PED_Elif; bjope wrote: > aaron.ballman wrote: > > bjope wrote: > > > Hi @aaron.ballman >

[clang] 13a8aa3 - [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

Author: David Goldman Date: 2021-06-01T14:45:25-04:00 New Revision: 13a8aa3ee15a67048deeb193fe8b86005fdf9d10 URL: https://github.com/llvm/llvm-project/commit/13a8aa3ee15a67048deeb193fe8b86005fdf9d10 DIFF: https://github.com/llvm/llvm-project/commit/13a8aa3ee15a67048deeb193fe8b86005fdf9d10.diff

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

This revision was automatically updated to reflect the committed changes. Closed by commit rG13a8aa3ee15a: [clang] RecursiveASTVisitor visits ObjCPropertyRefExprs class receiver (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101192: Add support for #elifdef and #elifndef

bjope added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:594 +if (CondInfo.FoundElse) + Diag(Tok, diag::pp_err_elif_after_else) << PED_Elif; aaron.ballman wrote: > bjope wrote: > > Hi @aaron.ballman > > > > This change is

[PATCH] D103477: [Fuchsia] Add compat multilibs to cache file

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103477 Files:

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

zhaomo updated this revision to Diff 349030. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103195/new/ https://reviews.llvm.org/D103195 Files: clang/include/clang/ASTMatchers/GtestMatchers.h clang/lib/ASTMatchers/GtestMatchers.cpp clang/unittests/ASTMatchers/GtestMatchersTest.cpp

[PATCH] D103476: [clangd] TUScheduler uses last active file for file-less queries

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, jfb, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This enables

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); Anastasia

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:594 +if (CondInfo.FoundElse) + Diag(Tok, diag::pp_err_elif_after_else) << PED_Elif; bjope wrote: > Hi @aaron.ballman > > This change is missing from >

[clang] baa2b8d - Fix a git apply that went bad somehow.

Author: Aaron Ballman Date: 2021-06-01T14:06:39-04:00 New Revision: baa2b8d08502acfa91a8dfd699d25f7b4e25edbb URL: https://github.com/llvm/llvm-project/commit/baa2b8d08502acfa91a8dfd699d25f7b4e25edbb DIFF: https://github.com/llvm/llvm-project/commit/baa2b8d08502acfa91a8dfd699d25f7b4e25edbb.diff

[PATCH] D103472: [clang] Fix a crash during code completion

adamcz added a reviewer: kadircet. adamcz added a comment. This is https://github.com/clangd/clangd/issues/771 Sending for review mostly to see if you have any comments on this approach. Trying to reproduce this without , or something like this didn't work for me so far, I must be holding it

[PATCH] D103472: [clang] Fix a crash during code completion

adamcz created this revision. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During code completion, lookupInDeclContext() calls CodeCompletionDeclConsumer::FoundDecl(),which can mutate StoredDeclsMap, over which

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG2a030e680e08: [clangd][ObjC] Fix issue completing a method decl by name (authored by dgoldman).

[clang-tools-extra] 2a030e6 - [clangd][ObjC] Fix issue completing a method decl by name

Author: David Goldman Date: 2021-06-01T13:35:05-04:00 New Revision: 2a030e680e0812c652ed4ae2b012e285a5514ffa URL: https://github.com/llvm/llvm-project/commit/2a030e680e0812c652ed4ae2b012e285a5514ffa DIFF: https://github.com/llvm/llvm-project/commit/2a030e680e0812c652ed4ae2b012e285a5514ffa.diff

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:160 + // + // e.g. to complete `- (void)doSomething:(id)argument`: + // - Completion name: `doSomething:`

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 349014. dgoldman added a comment. Add another test for a simple method decl (no arg selector) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files:

[PATCH] D90188: Add support for attribute 'using_if_exists'

ldionne updated this revision to Diff 349010. ldionne added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

bruno added a comment. @yln sorry, I didn't get notifications for this somehow. This got fixed as part of the more general support in https://github.com/llvm/llvm-project/commit/819e0d105e84c6081cfcfa0e38fd257b6124553a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

eddy-geek added a subscriber: Eugene.Zelenko. eddy-geek added a comment. @Eugene.Zelenko wrote: > Frankly, I don't think that length-based criteria is reasonable one. > Readability of code is much more important than line/file length. It provides an added configuration flexibility without

[PATCH] D103131: support debug info for alias variable

probinson added a comment. Of course, if it turns out that gdb can't handle the imported_declaration, we might end up having to do this two different ways under the tuning option. I'd *really* prefer not to do that though, and I'd argue it's a gdb bug if it cannot understand

[PATCH] D103131: support debug info for alias variable

probinson added a comment. In D103131#2789493 , @probinson wrote: >> Mixed feelings - somewhat in favor of "do the thing that's probably already >> fairly tested/known to work" (GCC's thing). But open to the idea that that >> approach has problems, for

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 349002. cor3ntin added a comment. Move tests to SemaCXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

dblaikie added a comment. The changes look like the right direction to me - though I don't know/couldn't confirm whether more changes will be needed in other places. Comment at: clang/lib/CodeGen/Address.h:29-30 public: Address(llvm::Value *pointer, CharUnits alignment) -

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 349000. cor3ntin added a comment. Typos, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

zhaomo added inline comments. Comment at: clang/lib/ASTMatchers/GtestMatchers.cpp:41 } - llvm_unreachable("Unhandled GtestCmp enum"); } hokein wrote: > zhaomo wrote: > > hokein wrote: > > > why remove this `llvm_unreachable`? I think this is a common

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

zhaomo updated this revision to Diff 348998. zhaomo marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103195/new/ https://reviews.llvm.org/D103195 Files: clang/include/clang/ASTMatchers/GtestMatchers.h clang/lib/ASTMatchers/GtestMatchers.cpp

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. bumping for review (or suggestions of additional reviewers) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103048/new/ https://reviews.llvm.org/D103048 ___ cfe-commits

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

efriedma added a comment. I think I'm fine with the general direction, but it would be nice to have a CMake option to force the headers for all targets to be built if someone needs them. For static analysis or something like that, I can imagine someone building LLVM without any backends at

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { olestrohm wrote: > Anastasia wrote: > > olestrohm wrote: > > > Anastasia wrote: >

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103097/new/ https://reviews.llvm.org/D103097 ___ cfe-commits mailing

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann updated this revision to Diff 348988. mgartmann added a comment. - added fixes for private destructors - separated fixes for private destructors into notes - added a test case for a `= default;` constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

aeubanks created this revision. aeubanks added reviewers: dblaikie, rsmith. aeubanks published this revision for review. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is definitely WIP, but I'd like to make sure that this is the right

  1   2   >