[PATCH] D110051: [clangd] Deduplicate inlay hints

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! > I don't think we're likely to get a parameter hint and a type hint at the > same location, but if you're concerned, I could revise the patch to ignore > the hint kind duri

[clang-tools-extra] d87d1aa - [clangd] Deduplicate inlay hints

Author: Nathan Ridge Date: 2021-09-21T03:23:04-04:00 New Revision: d87d1aa07612116a5c2a660f678856d3bda94f46 URL: https://github.com/llvm/llvm-project/commit/d87d1aa07612116a5c2a660f678856d3bda94f46 DIFF: https://github.com/llvm/llvm-project/commit/d87d1aa07612116a5c2a660f678856d3bda94f46.diff

[PATCH] D110051: [clangd] Deduplicate inlay hints

This revision was automatically updated to reflect the committed changes. Closed by commit rGd87d1aa07612: [clangd] Deduplicate inlay hints (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D110051?vs=373782&id=373790#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D110130: [clangd] Semantic highlighting for lambda init-capture

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D110130: [clangd] Semantic highlighting for lambda init-capture

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:522 + // is the same as the location of the declared name itself. + if (StartLoc != D->getLocation()) { +auto &Tok = Note, I initially tried `D->getTypeS

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373795. MyDeveloperDay marked 11 inline comments as done. MyDeveloperDay added a comment. Address review comments. - reorder functions to match header Fix an overlapping replacement issue when going from Right to Left (just jump past the token once d

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373802. MyDeveloperDay added a comment. Allow the use of "TypenameMacros" to allow for Capitialized types (be aware they should be non pointer types and don't have to be macros, so may need its own future "NonPtrTypes" setting) CHANGES SINCE LAST AC

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay added a comment. mark the comments as done once addressed please Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 ___ cfe-commits mailing list cfe

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This seems ok, might be worth adding a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.ll

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:28 + +static void replaceToken(const SourceManager &SourceMgr, + tooling::Replacements &Fixes, HazardyKnusperkeks wrote: > Out of curiosity, on

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru closed this revision. sylvestre.ledru added a comment. it landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109023/new/ https://reviews.llvm.org/D109023 ___ cfe-commits mailing list cf

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 373801. serge-sans-paille added a comment. Herald added a subscriber: whisperity. Update formatting / extra comments Update test to be more explicit about their intent / run them through update_cc_test_checks CHANGES SINCE LAST ACTION https://r

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

sylvestre.ledru updated this revision to Diff 373804. sylvestre.ledru added a comment. Herald added a project: clang. Rebase of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53014/new/ https://reviews.llvm.org/D53014 Files: clang/CMake

[clang] eccd477 - Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

Author: Sylvestre Ledru Date: 2021-09-21T10:44:08+02:00 New Revision: eccd477ce312c54e317876ca714c661325f3e318 URL: https://github.com/llvm/llvm-project/commit/eccd477ce312c54e317876ca714c661325f3e318 DIFF: https://github.com/llvm/llvm-project/commit/eccd477ce312c54e317876ca714c661325f3e318.dif

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables (authored by sylvestre.ledru). Repository: rG LLVM Githu

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru added a comment. it landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://reviews.llvm.org/D109642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. https://github.com/llvm/llvm-project/blob/release/13.x/clang/docs/ReleaseNotes.rst#new-compiler-flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://review

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille marked 6 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s +//

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. Look good! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109608/new/ https://reviews.llvm.org/D109608 ___

[clang] 57b8b5c - [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test

Author: Justas Janickas Date: 2021-09-21T10:27:46+01:00 New Revision: 57b8b5c114b6e595f8d9118807d741ef30518777 URL: https://github.com/llvm/llvm-project/commit/57b8b5c114b6e595f8d9118807d741ef30518777 DIFF: https://github.com/llvm/llvm-project/commit/57b8b5c114b6e595f8d9118807d741ef30518777.dif

[PATCH] D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b8b5c114b6: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test (authored by Topotuna). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373817. MyDeveloperDay added a comment. If we don't specify types in the QualifierOrder (say static or inline as in default Left/Right) then don't push const through them just because they can be a type of qualifier we support. i.e. only push through

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Anastasia added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1366 + /// Returns default address space based on OpenCL version and enabled features + inline LangAS getDefaultOpenCLAddrSpace() { +return LangOpts.OpenCLGenericAddressSpace ? LangAS::opencl

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10221 +ABIArgInfo SPIRABIInfo::classifyKernelArgumentType(QualType Ty) const { + if (getContext().getLangOpts().HIP && getTarget().getTriple().isSPIRV()) { +// Coerce pointer arguments with default

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On armv8l and arm (armv7) the architecture in the library path will be "armhf" if we have hard floa

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

DavidSpickett added a reviewer: MaskRay. DavidSpickett added a comment. `getRuntimePath` seems like the place to fix it given that https://reviews.llvm.org/D50547 calls it. This fixes the tests but I'm not sure if there's other places to consider. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

DavidSpickett added a comment. I should probably *add* a test somewhere for this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110142/new/ https://reviews.llvm.org/D110142 ___ cfe-commits mailing li

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna updated this revision to Diff 373834. Topotuna edited the summary of this revision. Topotuna added a comment. Helper function renamed for clarity. Additional check added to `if` statement to ensure it is only carried out in OpenCL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna marked 2 inline comments as done. Topotuna added a comment. Both comments addressed. Personally, I would shuffle words around to rename helper function as `getDefaultOpenCLPointeeAddrSpace` or `getOpenCLDefaultPointeeAddrSpace`. Although I am not sure if there are some assumed naming c

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109865/new/ https://reviews.llvm.org/D109865 ___

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in linjam

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Anastasia added a comment. In D109874#3011792 , @Topotuna wrote: > Both comments addressed. Personally, I would shuffle words around to rename > helper function as `getDefaultOpenCLPointeeAddrSpace` or > `getOpenCLDefaultPointeeAddrSpace`. Although I am

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Feel free to adjust the naming scheme either in the same commit or separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109874/new/ https://reviews.llvm.org/D

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108359/new/ https://reviews.llvm.org/D108359 _

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1696 + const llvm::APSInt &Idx = CI->getValue(); + const uint64_t I = static_cast(Idx.getExtValue()); + // Use `getZExtValue` because array extent

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

DavidSpickett updated this revision to Diff 373854. DavidSpickett added a comment. Added a test. I have not checked what adding an -mfloat-abi that doesn't match the ABI part of the triple does because then we'd need to modify the ABI part of the triple as well. Which might be the correct thing

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D110044: Print nullptr_t namespace qualified within std::

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Type.cpp:3045 case NullPtr: -return "nullptr_t"; +return "std::nullptr_t"; case Overload: dblaiki

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373861. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373862. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang builtin utility `__remove_address_space` now works if generic add

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added a comment. Thanks, I think this is getting close! There are two more test cases that I think are interesting (and should cause any issues, hopefully): // NOLINTEND // CHECK-MESSAGES: for diagnostic on the previous line and // CHECK-MESSAGES: for diagnostic on the subs

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

aaron.ballman added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { ASDenysPetrov wrote: >

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch uses a different command-line arguments to test `clang::tooling::ToolInvocatio

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 373877. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/For

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3011516 , @MyDeveloperDay wrote: > This seems ok, might be worth adding a release note Done. I don't have commit access, so please submit this change on my behalf. Thanks for all the help! Repository: rG LLVM

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8132 +case ParsedAttr::AT_BTFTag: + // FIXME: Linux kernel may also use this attribute for type casting check, Errr, this attribute isn't a type attribute in the first place,

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list cfe-com

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

aaron.ballman added a comment. > First, to build linux kernel with btf_tag annotated user pointer, we have > > #define __user __attribute__((btf_tag("user"))) > and the linux kernel contains code like below ([2]) > > typedef __signalfn_t __user *__sighandler_t; > and the user attribute applies to

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { aaron.ballman wrote: >

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

aaron.ballman added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { ASDenysPetrov wrote: >

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov updated this revision to Diff 373895. ASDenysPetrov added a comment. Fixed nits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/initialization.c clan

[clang] ee31ad0 - [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

Author: Saiyedul Islam Date: 2021-09-21T19:24:44+05:30 New Revision: ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0 URL: https://github.com/llvm/llvm-project/commit/ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0 DIFF: https://github.com/llvm/llvm-project/commit/ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0.diff

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. saiislam marked an inline comment as done. Closed by commit rGee31ad0ab5f7: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation (authored by saiisla

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 373908. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/initialization.cpp Index:

[PATCH] D110129: [DebugInfo] Support typedef with btf_tag attributes

probinson added inline comments. Comment at: clang/test/CodeGen/attr-btf_tag-typedef.c:2 +// REQUIRES: x86-registered-target +// RUN: %clang -target x86_64 -g -S -emit-llvm -o - %s | FileCheck %s + Outside of clang/test/Driver, tests should use `%clang_cc1` to ru

[clang] 32b994b - [OpenCL] Defines helper function for OpenCL default address space

Author: Justas Janickas Date: 2021-09-21T15:12:08+01:00 New Revision: 32b994bca66641cdac8586f25315daf349921ebc URL: https://github.com/llvm/llvm-project/commit/32b994bca66641cdac8586f25315daf349921ebc DIFF: https://github.com/llvm/llvm-project/commit/32b994bca66641cdac8586f25315daf349921ebc.dif

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32b994bca666: [OpenCL] Defines helper function for OpenCL default address space (authored by Topotuna). Changed prior to commit: https://reviews.l

[clang] 744ec74 - [NFC] `goto fail` has failed us in the past...

Author: Chris Bieneman Date: 2021-09-21T09:18:37-05:00 New Revision: 744ec74b305a5039dc74e2d043e1c136e06beac1 URL: https://github.com/llvm/llvm-project/commit/744ec74b305a5039dc74e2d043e1c136e06beac1 DIFF: https://github.com/llvm/llvm-project/commit/744ec74b305a5039dc74e2d043e1c136e06beac1.diff

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

This revision was automatically updated to reflect the committed changes. Closed by commit rG744ec74b305a: [NFC] `goto fail` has failed us in the past... (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109865/new/ https://reviews.

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske updated this revision to Diff 373922. balazske added a comment. Dump to 'llvm::nulls()'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109608/new/ https://reviews.llvm.org/D109608 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/A

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

jdoerfert added a comment. Just more style things, I think the rest is fine. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:134 + SPMD = 0x2, +}; + If you copy the LLVM_MARK_AS_BITMASK_ENUM stuff you can actually use the enum class as bitmask w/

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1696 + const llvm::APSInt &Idx = CI->getValue(); + const uint64_t I = static_cast(Idx.getExtValue()); + // Use `getZExtValue` because array extent can n

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Topotuna added a comment. Changes rG054e331d9dbd and rG37cdc7ebd9a3 contain test cases that display C++ for OpenCL version 2021 in diagnostics. Reposito

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types require

[PATCH] D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110084/new/ https://reviews.llvm.org/D110084 _

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. > What folks are thinking about writing less in METHOD_POOL? I prefer the idea of it, but I think the `ReadMethodPoolVisitor` also has to be changed for this to work. When it finds a selector in a module it will return true, which causes the search to stop descending into

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 373932. salman-javed-nz added a comment. Updated according to review comments. - `test/clang-tidy/infrastructure/nolintbeginend-begin-at-eof.cpp`: new test - `test/clang-tidy/infrastructure/nolintbeginend-end-at-sof.cpp`: new test - Use `llvm::ErrorOr

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

kamaub added a reviewer: kamaub. kamaub added a comment. This patch seems almost ready to land to me, I'm just a bit concerned about the testing coverage, is the little endian testing case suppose to target `pwr7` as the big endian test does? The default FileCheck line seems redundant to me, d

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373936. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[clang] 9ae4275 - [clang][NFC] Fix needless double-parenthisation

Author: Andy Wingo Date: 2021-09-21T17:03:23+02:00 New Revision: 9ae4275557ca10f79af91ca99a2aa79d5dfd7ed3 URL: https://github.com/llvm/llvm-project/commit/9ae4275557ca10f79af91ca99a2aa79d5dfd7ed3 DIFF: https://github.com/llvm/llvm-project/commit/9ae4275557ca10f79af91ca99a2aa79d5dfd7ed3.diff LO

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae4275557ca: [clang][NFC] Fix needless double-parenthisation (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108359/new/ https://reviews

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 373943. vhscampos added a comment. 1. Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos requested review of this revision. vhscampos added a comment. Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D110130: [clangd] Semantic highlighting for lambda init-capture

kadircet added a comment. Naming of the patch is a little bit confusing. We're actually dropping the semantic highlighting for the type of lambdacaptures, which was showing up in the declarator names since there was no explicit type spelled in the source code. This turns on highlighting for the

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added a comment. Sorry for not thinking of this sooner, but there is another diagnostic we might want to consider. // NOLINTBEGIN(check) // NOLINTEND(other-check) where the file does not contain a `NOLINTEND(check)` comment anywhere. In this case, the markers are not actually

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 373944. salman-javed-nz marked 6 inline comments as done. salman-javed-nz added a comment. `lineIsWithinNolintBegin()`: - If the search through the preceding lines returns no active `NOLINTBEGINs`, carry on reading the rest of the file anyway. Repo

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://reviews.llvm.org/D110155 _

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz added a comment. In D108560#3012057 , @aaron.ballman wrote: > Thanks, I think this is getting close! There are two more test cases that I > think are interesting (and should cause any issues, hopefully): > > // NOLINTEND > // CHECK-M

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

dexonsmith added inline comments. Comment at: clang/unittests/Tooling/ToolingTest.cpp:238-245 Args.push_back("tool-executable"); - Args.push_back("-target"); - // Invalid argument that by default results in an error diagnostic: - Args.push_back("i386-apple-ios14.0-simulator

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 373955. gAlfonso-bit added a comment. Rebased to upstream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cp

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373954. MyDeveloperDay added a comment. Its no longer essential to compare the fixes against the original code, as this was needed because of an artifact with adding double spaces and was resolved with checking for if the previous token already ended

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

tianshilei1992 updated this revision to Diff 373961. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:134 + SPMD = 0x2, +}; + jdoerfert wrote: > If you copy the LLVM_MARK_AS_BITMASK_ENUM stuff you can actually use th

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:132 +enum class OMPTargetExecutionModeMaskType : int8_t { + Generic = 0x1, + SPMD = 0x2, Do we want to set a `NON

[PATCH] D108032: [analyzer] Retrieve a character from CompoundLiteralExpr as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 373964. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108032/new/ https://reviews.llvm.org/D108032 Files: clang/lib/StaticAnalyzer/Core/RegionStore.c

[clang] 5793930 - [PowerPC] Fix signature of lxvp and stxvp builtins

Author: Quinn Pham Date: 2021-09-21T11:19:29-05:00 New Revision: 57939309501c33b264b777e04186c7747ebc3de1 URL: https://github.com/llvm/llvm-project/commit/57939309501c33b264b777e04186c7747ebc3de1 DIFF: https://github.com/llvm/llvm-project/commit/57939309501c33b264b777e04186c7747ebc3de1.diff LO

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG57939309501c: [PowerPC] Fix signature of lxvp and stxvp builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/ https://rev

[clang] 73a8bcd - Revert "Diagnose -Wunused-value based on CFG reachability"

Author: Aaron Ballman Date: 2021-09-21T12:25:13-04:00 New Revision: 73a8bcd78921d38130fc42c90fd75d47b05b063d URL: https://github.com/llvm/llvm-project/commit/73a8bcd78921d38130fc42c90fd75d47b05b063d DIFF: https://github.com/llvm/llvm-project/commit/73a8bcd78921d38130fc42c90fd75d47b05b063d.diff

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman added a comment. In D103938#3012910 , @gulfem wrote: > We also started seeing similar `libc++` test failures in our Fuchsia builds: > https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8835548361443044001/+/u/clang/test/stdout

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

gulfem added a comment. We also started seeing similar `libc++` test failures in our Fuchsia builds: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8835548361443044001/+/u/clang/test/stdout Failed Tests (89): libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/assign.

[clang] 8c68bd4 - [OpenMP][NFC] Add declare variant and metadirective to support page

Author: cchen Date: 2021-09-21T11:28:13-05:00 New Revision: 8c68bd480f3d8a5bf6087f47837d320f9d6dba2d URL: https://github.com/llvm/llvm-project/commit/8c68bd480f3d8a5bf6087f47837d320f9d6dba2d DIFF: https://github.com/llvm/llvm-project/commit/8c68bd480f3d8a5bf6087f47837d320f9d6dba2d.diff LOG: [O

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen added a comment. @uabelho @gulfem Thanks for the remainder. I could not reproduce the issue with my Ubuntu box. Could you please attach a reproducer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen added a comment. In D103938#3012940 , @ychen wrote: > @uabelho @gulfem Thanks for the remainder. I could not reproduce the issue > with my Ubuntu box. Could you please attach a reproducer? Never mind, I think I need "-Werror" to reproduce these.

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reuses C++ for OpenCL constructor address space test so that it support

[PATCH] D110185: [OpenCL] Reuse C++ for OpenCL 1.0 address space tests for version 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `RUN` lines in C++ for OpenCL address space tests to cover version

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g updated this revision to Diff 373977. guitard0g added a comment. Add test case for space between directives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 Files: clang/lib/Format/UnwrappedLi

  1   2   >