[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

FreddyYe added a subscriber: RKSimon. FreddyYe added a comment. As mentioned before: In D108422#2957528 , @RKSimon wrote: > There's nothing later than CannonLake here - does Intel need to at least > reference up to Tiger/Rocketlake? I met some issues t

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. To me you should be doing /*bitcode SDL=*/true It looks like its still failing clang-format might I suggest making the changes to the comment, git adding the file

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

MyDeveloperDay added a comment. @roligugus I can land this for you, please rebase the review then please add your name and email here so we can ensure you get the credit. https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen added a comment. In D109825#3060796 , @mubashar_ wrote: > Added crypto and non-crypto related tests for mcpu in aarch64-cpus.c Thanks, but did this change miss being updated in the review? Comment at: clang/docs/ReleaseNotes.r

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev updated this revision to Diff 379625. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Stash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111698/new/ https://reviews.llvm.org/D111698 Files: clang-tools-extra/clangd/

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

tschuett added a comment. It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL kernels the only approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm.org/D71016 _

[PATCH] D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

fcambus created this revision. fcambus added reviewers: sbc100, aheejin. Herald added subscribers: ecnelises, sunfish, jgravelle-google, dschuff. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. > The you quoted would, in my mind, be formatted like this: > > void foo() { > if ( > quitelongarg != (alsolongarg - 1) > ) { // ABC is a very long comment > return; > } > } > > This is because I don't allow br

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev updated this revision to Diff 379661. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111698/new/ https://reviews.llvm.org/D111698 Files: clang-

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, sdesmalen. Herald added subscribers: ctetreau, dexonsmith, dang, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. bsmith requested review of this revision. Herald added a project: clang. Heral

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

kbobyrev updated this revision to Diff 379663. kbobyrev added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111698/new/ https://reviews.llvm.org/D111698 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-ext

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3063563 , @MyDeveloperDay wrote: >> The you quoted would, in my mind, be formatted like this: >> >> void foo() { >> if ( >> quitelongarg != (alsolongarg - 1) >> ) { // ABC is a very longgg

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. Do you think this is going to need some other capability to put the break after the opening paren? e.g. `BreakAfterOpeningParen` if ( ^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://rev

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. Personally I'm not convinced there wouldn't be people who want this for function declarations and definitions Function( param1, param2, param3 ); but don't want this if ( foo() ) Repository: rG LLVM Github Monorepo CHAN

[PATCH] D111711: [clangd] IncludeCleaner: ReferencedLocationCrawler should handle FunctionDecls

kbobyrev updated this revision to Diff 379664. kbobyrev added a comment. Only get function redecls as used for definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111711/new/ https://reviews.llvm.org/D111711 Files: clang-tools-extra/clangd

[clang-tools-extra] 0ce3c71 - [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

Author: Kirill Bobyrev Date: 2021-10-14T13:36:37+02:00 New Revision: 0ce3c7111e909faa0202358bcfd6a46e3ace58b5 URL: https://github.com/llvm/llvm-project/commit/0ce3c7111e909faa0202358bcfd6a46e3ace58b5 DIFF: https://github.com/llvm/llvm-project/commit/0ce3c7111e909faa0202358bcfd6a46e3ace58b5.diff

[PATCH] D111698: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce3c7111e90: [clangd] IncludeCleaner: Handle macros coming from ScratchBuffer (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 379530. gandhi21299 added a comment. add a restrictions to what architecture AlwaysInliner should run on, updated the inline-calls.ll test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https:/

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. Passed ePSDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a subscriber: csmulhern. MyDeveloperDay added a comment. I understand the frustration (I'm not convinced that its Phabricators fault to be honest, that's our process and plenty of people follow it without issues) , Our incredible original code owners have moved on to do I as

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

paulwalker-arm added a comment. Are the references to "128-bit chunks" for the vscale flags necessary? That's really a nuisance of SVE that LLVM IR should not need to worry about. Can we speak exclusively in terms of vscale or is the "multiples of 128" required somewhere? Perhaps we're missi

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

pchaigno added a comment. @efriedma @rsmith Did you get a chance to take a look? This regression is still affecting LLVM, including the recently released v13.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D

[clang] b577126 - [clang][sema] instantiateOMPDeclareVariantAttr - merge repeated VariantFuncRef.get() calls. NFCI.

Author: Simon Pilgrim Date: 2021-10-14T12:51:34+01:00 New Revision: b577126d626855fabc11a203e7a7e0187d48c227 URL: https://github.com/llvm/llvm-project/commit/b577126d626855fabc11a203e7a7e0187d48c227 DIFF: https://github.com/llvm/llvm-project/commit/b577126d626855fabc11a203e7a7e0187d48c227.diff

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added a comment. In D71016#3063457 , @tschuett wrote: > It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL > kernels the only approach. We need to update the description of the patch to clarify that it applies to other GPU prog

[PATCH] D111792: [ObjC-GNUstep] Fix ivars for dll{im,ex}ported classes.

theraven created this revision. theraven requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a class is dllexported or imported then the ivar offset variables must be as well. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

fcambus created this revision. fcambus added reviewers: arphaman, vsk, ahatanak, thakis. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111793 Files: clang/lib/Dri

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

tschuett added a comment. In D71016#3063706 , @bader wrote: > In D71016#3063457 , @tschuett wrote: > >> It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL >> kernels the only approach. > > We ne

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

lebedev.ri added a reviewer: rsmith. lebedev.ri added a comment. Doesn't this make AST non-representable of the reality, shouldn't the lowering happen in codegen, not in sema? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith added a comment. In D111790#3063698 , @paulwalker-arm wrote: > Are the references to "128-bit chunks" for the vscale flags necessary? > That's really a nuisance of SVE that LLVM IR should not need to worry about. > Can we speak exclusively in

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110669/new/ https://reviews.llvm.org/D110669

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added a comment. In D71016#3063762 , @tschuett wrote: > Would a codegenSYCL directory help you to separate Sema from code generation? Moving wrapper kernel function generation to CodeGen library make sense to me. > Doesn't this make AST non-represe

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. In D110258#3057380 , @david-arm wrote: > In D110258#3055488 , @dmgreen wrote: > >> If D111551 was folded into this patch, >> would it be possible to add

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus created this revision. fcambus added a reviewer: brad. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111797 Files: clang/tools/scan-build/libexec/ccc-anal

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. In D109144#3063255 , @linjamaki wrote: >> Can you explain what does this mean > > It was trying to clarify a potential misunderstanding of how programs are > compiled when HIPSPV is targeted: For HIPSPV, the SPIR-V code genera

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 379682. hsmhsm added a comment. Fix review comments by @rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/Cod

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm marked 2 inline comments as done. hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:115 +if (AllocaInsertedAtAllocaInsertPt) + AllocaAddrSpaceInsertPt = dyn_cast(V)->getIterator(); } arichardson wrote: > Shouldn't this use

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

erichkeane added a comment. Supporting these types requires changes to the library so that we can check these, right? Do you have the library changes for these as well? The constants used to check for these features/etc needs to be present in the glibc library. Repository: rG LLVM Github

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I love this! The coverage is great and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110913/new/ https://reviews.llvm.org/D11091

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2126-2130 + // Initiate the reorganization of the equality information. E.g., if we + // have `c + 1 == 0` then we'd like to express that `c == -1`. It makes + // s

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith updated this revision to Diff 379701. bsmith added a comment. - Remove mention of 128-bit chunks from help texts - Allow any positive integer value for -mvscale-{min,max}, not just powers of 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

fcambus created this revision. fcambus added reviewers: krytarowski, mgorny. Herald added a subscriber: fedor.sergeev. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. In D111443#3062139 , @eugenis wrote: > Right, but a cache for SanitizerArgs is not enough to avoid repeated > diagnostics, is it? Ex. if I request a non-existing sanitizer, I think I > would get errors from host arg parsing, as w

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added a comment. In D107769#2967565 , @Anastasia wrote: > In D107769#2960441 , @svenvh wrote: > >> I have done an alternative spin of this patch: instead of introducing >> `RequireDisabledExtension`, simpl

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379713. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Added crypto and no-crypto tests for -mcpu and added new section for Arm and AArch64 support in release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. Ping! Does anyone have any feedback on this? I'd really like to start getting us caught up on standards implementation, and this seems like it might be an easy win (unless someone on the list knows why it is just plain wrong/more complicated than I think!). CHANG

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379717. mubashar_ marked an inline comment as done. mubashar_ added a comment. Corrected PAUTH duplication mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ marked an inline comment as done. mubashar_ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:86 +- Support has been added for the following processors (command-line identifiers in parentheses): + - Arm Cortex-A510 (cortex-a510) dmgreen

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the changes. Nice working pulling this into shape. LGTM Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:149 + (AArch64::AEK_BF16 |

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

MyDeveloperDay added a comment. @thakis , At the back of my mind is those people who always say "Measure, Measure, Measure"... This issue still plagues us, we constantly get bugs reported that come back to this. (https://bugs.llvm.org/show_bug.cgi?id=52021,https://bugs.llvm.org/show_bug.cgi?i

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida updated this revision to Diff 379721. cishida added a comment. Fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111468/new/ https://reviews.llvm.org/D111468 Files: clang/lib/Lex/HeaderSearch.cpp clang/unittests/Lex/Head

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. Passed internal CI, still working on a Sema test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing list cfe-

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

FreddyYe added a comment. In D111778#3063891 , @erichkeane wrote: > Supporting these types requires changes to the library so that we can check > these, right? Do you have the library changes for these as well? The > constants used to check for these

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. When reaching the end of a function body, we need to ensure that the `ExitFunctionBodyRAII` object is destroyed before

[PATCH] D111815: [clang-format] [PR42014,PR52021] don't let clang-format assert/crash when file being formatted is read-only/locked

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, curdeius, HazardyKnusperkeks. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. This is a bug which gets reported from time to time and we've had multiple attempts to

[clang] ac3edc5 - [analyzer][solver] Handle simplification to ConcreteInt

Author: Gabor Marton Date: 2021-10-14T17:53:29+02:00 New Revision: ac3edc5af09947210d8f8d25ddd7e42379ef6454 URL: https://github.com/llvm/llvm-project/commit/ac3edc5af09947210d8f8d25ddd7e42379ef6454 DIFF: https://github.com/llvm/llvm-project/commit/ac3edc5af09947210d8f8d25ddd7e42379ef6454.diff

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

This revision was automatically updated to reflect the committed changes. Closed by commit rGac3edc5af099: [analyzer][solver] Handle simplification to ConcreteInt (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110913/new/ https

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

craig.topper added a comment. In D111778#3064287 , @FreddyYe wrote: > In D111778#3063891 , @erichkeane > wrote: > >> Supporting these types requires changes to the library so that we can check >> these, right?

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14839 if (!IsInstantiation) PopDeclContext(); so the only real change here is that `ExitFunctionBodyRAII` ends here, instead of the end of the function? I guess this SEEMS pre

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:35 const Driver &D = ToolChain.getDriver(); + const llvm::Triple &T = ToolChain.getTriple(); Is there a specific reason to choose the name `T`? FWICS different drivers use dif

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2089 else return Error(ValueExprLoc, "bad arch string " + Arch); } maybe we could have a NFC patch later to add ``` // Emit the arch string if needed. if

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ba572483dd: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11066

[clang] f7ba572 - [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

Author: Craig Topper Date: 2021-10-14T09:25:03-07:00 New Revision: f7ba572483dd424c6235901d1c6cb3650c46b477 URL: https://github.com/llvm/llvm-project/commit/f7ba572483dd424c6235901d1c6cb3650c46b477 DIFF: https://github.com/llvm/llvm-project/commit/f7ba572483dd424c6235901d1c6cb3650c46b477.diff

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. 🙄 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. It seems that Clang 11 regressed functionality that was working in Clang 10 regarding calling a few overloaded operator

[clang] b6c218d - [libTooling] Add "switch"-like Stencil combinator

Author: Yitzhak Mandelbaum Date: 2021-10-14T16:45:37Z New Revision: b6c218d4fdb74c0ee467e078721438c3396dc599 URL: https://github.com/llvm/llvm-project/commit/b6c218d4fdb74c0ee467e078721438c3396dc599 DIFF: https://github.com/llvm/llvm-project/commit/b6c218d4fdb74c0ee467e078721438c3396dc599.diff

[PATCH] D111708: [libTooling] Add "switch"-like Stencil combinator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c218d4fdb7: [libTooling] Add "switch"-like Stencil combinator (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

erichkeane added a comment. In D111778#3064439 , @craig.topper wrote: > In D111778#3064287 , @FreddyYe > wrote: > >> In D111778#3063891 , @erichkeane >> wrote: >> >>> S

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14839 if (!IsInstantiation) PopDeclContext(); erichkeane wrote: > so the only real change here is that `ExitFunctionBodyRAII` ends here, > instead of the end of the function?

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3062608 , @vsapsai wrote: > I can be wrong but I like writing less data as it can result in savings for > more projects. For example, if compile time is dominated by method > deserialization and not by `Sema::addMethodTo

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

erichkeane added a comment. This seems like two places this was missed in: https://reviews.llvm.org/D63960 however I see a another place grepping around we might have missed too? Can you find a way to write tests for that? Also, perhaps 1 more cleanup? Comment at: clang/lib

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:13800 ExprResult R = MaybeBindToTemporary(TheCall); if (R.isInvalid()) erichkeane wrote: > Wonder if as a 'while we're here' we should make this the same as the o

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } aaron.ballman wrote: > erichkeane wrote: >

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } rsmith wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Was this one missed too? > > I c

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } erichkeane wrote: > rsmith wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > Was this one missed too? > > > I could

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111793/new/ https://reviews.llvm.org/D111793

[PATCH] D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a3214306cb: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[clang] f7a3214 - [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

Author: Frederic Cambus Date: 2021-10-14T19:43:59+02:00 New Revision: f7a3214306cb83c350a89e2247f67983dbd792ea URL: https://github.com/llvm/llvm-project/commit/f7a3214306cb83c350a89e2247f67983dbd792ea DIFF: https://github.com/llvm/llvm-project/commit/f7a3214306cb83c350a89e2247f67983dbd792ea.dif

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song updated this revision to Diff 379772. yonghong-song retitled this revision from "[POC][BTF] support btf_type_tag attribute" to "[Clang][LLVM][Attr] support btf_type_tag attribute". yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added subscrib

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

efriedma added a comment. I don't think my opinion has changed here. I'm against the solution proposed in this patch. The other solutions discussed in the review seem fine. (The simplest is just to make the bpf backend ignore stacksave/stackrestore calls.) Repository: rG LLVM Github Monor

[PATCH] D110898: Pass template parameters when printing template argument lists for function templates

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110898/new/ https://reviews.llvm.org/D110898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356 + if (CodeGenOpts.ClearASTBeforeBackend) { +// The ASTContext may be unusable after this. +C.cleanup(); C.getAllocator().Reset(); dblaikie wrote:

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379787. noajshu added a comment. rebase against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp l

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

dblaikie accepted this revision. dblaikie added subscribers: aaron.ballman, rsmith. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK, thanks! Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356 + if (CodeGenOpts.ClearASTBeforeBackend

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } aaron.ballman wrote: > erichkeane wrote: > > rsmith wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > > > Was thi

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman updated this revision to Diff 379795. aaron.ballman added a comment. Updated the patch to add new test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111817/new/ https://reviews.llvm.org/D111817 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/cxx2a-con

[clang] b9941de - Fix a rejects-valid with consteval on overloaded operators

Author: Aaron Ballman Date: 2021-10-14T14:47:29-04:00 New Revision: b9941de0bfac4bad93e11dff26396e34a53e3891 URL: https://github.com/llvm/llvm-project/commit/b9941de0bfac4bad93e11dff26396e34a53e3891 DIFF: https://github.com/llvm/llvm-project/commit/b9941de0bfac4bad93e11dff26396e34a53e3891.diff

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman closed this revision. aaron.ballman added a comment. I landed the non-pmf changes in b9941de0bfac4bad93e11dff26396e34a53e3891 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111817/new/ https://reviews.ll

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58 + // Ensure the reported context hash is strict. + CI.getHeaderSearchOpts().ModulesStrictContextHash = true; + dexonsmith wrote: > IIUC, explicit m

[clang] 8ecbcd0 - [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

Author: Frederic Cambus Date: 2021-10-14T21:30:39+02:00 New Revision: 8ecbcd058fbd552375fda614f36a1e01755c2620 URL: https://github.com/llvm/llvm-project/commit/8ecbcd058fbd552375fda614f36a1e01755c2620 DIFF: https://github.com/llvm/llvm-project/commit/8ecbcd058fbd552375fda614f36a1e01755c2620.dif

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecbcd058fbd: [Driver][Darwin] Use T reference instead of getToolChain().getTriple(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + I'm pretty sure there was a reason we stopped doing this. There should be some discussion a

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D111270#3062802 , @aeubanks wrote: > In D111270#3060484 , @dblaikie > wrote: > >> Plan is still to ad

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. > I took a look and in its simplest form moving TextDiagnosticPrinter.cpp to > lib/Basic but also requires DiagnosticRender.cpp and TextDiagnostic.cpp to > also move to lib/Basic too, > > But DiagnosticRender.cpp has a dependency on lib/Edit so clang-format now > needs t

[clang] 68157fe - Fix a crash on valid consteval code.

Author: Aaron Ballman Date: 2021-10-14T15:48:10-04:00 New Revision: 68157fe15b238428d0fdbeb38c14afd5bda574da URL: https://github.com/llvm/llvm-project/commit/68157fe15b238428d0fdbeb38c14afd5bda574da DIFF: https://github.com/llvm/llvm-project/commit/68157fe15b238428d0fdbeb38c14afd5bda574da.diff

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song updated this revision to Diff 379807. yonghong-song added a comment. - fix clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/ https://reviews.llvm.org/D99 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D111830: [clang] fix typo correction not looking for candidates in base classes.

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. RecordMemberExprValidator was not looking through ElaboratedType nodes when looking for candidates which occur in base classes. Signed-off-by: Matheus

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl updated this revision to Diff 379806. yaxunl edited the summary of this revision. yaxunl added a comment. diagnose sanitizer args only once. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 Files: clang/include/clang/Basic/DiagnosticDr

[PATCH] D111830: [clang] fix typo correction not looking for candidates in base classes.

mizvekov updated this revision to Diff 379810. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111830/new/ https://reviews.llvm.org/D111830 Files: clang/lib/Sema/SemaExprMember.cpp clang/test/CXX/drs/dr1xx.cpp Index

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield created this revision. mbenfield added reviewers: enh, gbiv. Herald added a reviewer: george.burgess.iv. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11

  1   2   >