[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

salman-javed-nz added a comment. Thanks for the patch. Just a little bit of feedback but overall I'm happy with the approach taken. Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:99-106 + CharSourceRange ReplaceRange; + if (isa(CastExpr)) +Repl

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

whisperity accepted this revision. whisperity added a comment. I'm not sure if it is a good idea to merge things on a Friday, but I am comfortable with this, let's get the check crash less. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113558/new/ https://reviews.llvm.org/D113558

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Hi, Could anyone please review this diff? @whisperity, @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:100-104 + if (isa(CastExpr)) +ReplaceRange = CharSourceRange::getCharRange( +CastExpr->getLParenLoc(), +CastExpr->getSubExprAsWritten()->getBegin

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity added a comment. Thank you, this is getting much better! Comment at: clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp:105-108 + const auto *PositiveCheck = Result.Nodes.getNodeAs("positive"); + const auto *NegativeCheck = Result.Nodes.getNodeAs(

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389931. lh123 added a comment. Herald added a reviewer: gkistanova. Move some `desugared type` to `Definition`. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files:

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

whisperity added a comment. This generally looks fine for me, but I'd rather have other people who are more knowledgeable about the standard's intricacies looked at it too. AFAIK Aaron is busy this week and the next (?) due to C++ Committee meetings, or something like that. And I bet after such

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. In D107450#3155019 , @whisperity wrote: > This generally looks fine for me, but I'd rather have other people who are > more knowledgeable about the standard's intricacies looked at it too. > > AFAIK Aaron is busy this week and th

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:691 } else { HI.Definition = printType(QT, PP); sammccall wrote: > This seems like a pretty important case to handle. > A wrinkle is that this gets treated as C++ code (e.g. cli

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. In D114320#3154544 , @jessesna wrote: > Thanks a lot for your time and help @MyDeveloperDay No problem, come play some more! We need people to help and review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. I believe this is worth a note in the `ReleaseNotes.rst` file. People who might have disabled the check specifically for the reason outlined in the PR would get to know it's

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

whisperity edited reviewers, added: Quuxplusone; removed: carlosgalvezp, whisperity. whisperity added subscribers: carlosgalvezp, whisperity. whisperity added a comment. This revision now requires review to proceed. (@carlosgalvezp Removing you from reviewers so the patch shows up as not yet rev

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

carlosgalvezp added a comment. Thanks for the finding and sorry for delaying the review, I didn't know that :( Do you know if there's an option for signaling "LGTM but I want someone else to review?". Otherwise I can just leave a comment and don't accept the revision. CHANGES SINCE LAST ACTION

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

whisperity added a comment. In D113518#3155040 , @carlosgalvezp wrote: > Thanks for the finding and sorry for delaying the review, I didn't know that > :( Do you know if there's an option for signaling "LGTM but I want someone > else to review?". Other

[clang] bad8977 - [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

Author: Kirill Bobyrev Date: 2021-11-26T10:10:52+01:00 New Revision: bad8977786382739256f4bd966fb4cdcfd50be2a URL: https://github.com/llvm/llvm-project/commit/bad8977786382739256f4bd966fb4cdcfd50be2a DIFF: https://github.com/llvm/llvm-project/commit/bad8977786382739256f4bd966fb4cdcfd50be2a.diff

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad897778638: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced… (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114609: [clang] Fix crash on broken parameter declarators

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Parser/cxx-decltype-parameter.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s + I'd place this test in `Parser/cxx-keyword-

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } It seems we lost `namespace qualifiers`. It always display `std::string` as `basic_string` Repository:

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong updated this revision to Diff 389935. martong marked an inline comment as done. martong added a comment. - Add new test case (for no-crash) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/ https://reviews.llvm.org/D103317 Files:

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong updated this revision to Diff 389936. martong added a comment. - Remove superfluous param (int a) from the new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/ https://reviews.llvm.org/D103317 Files: clang/lib/StaticAn

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp resigned from this revision. carlosgalvezp added a comment. This revision now requires review to proceed. I just learned that by approving this patch I make it not visible for other reviewers that they should still review, so I'll remove my vote. LGTM though. Repository: rG LLVM

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added a comment. I've added a new test case that triggers an assertion. That problem is getting fixed in a new parent patch, which I am about to add to the stack very soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/ https://

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } lh123 wrote: > It seems we lost `namespace qualifiers`. > It always display `std::string` as `basic_string`

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Hi there, Yes, sorry for the long silence, I ended up not having time to come back to this anymore for personal reasons. I also lack familiarity with the codebase and tests, and I couldn't invest more time into it; I had the impression that this last failing test would r

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } lh123 wrote: > lh123 wrote: > > It seems we lost `namespace qualifiers`. > > It always display `std::string

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

whisperity added a comment. `hasParent()` is the //direct// upwards traversal, right? I remember some discussion about matchers like that being potentially costly. But I can't find any description of this, so I guess it's fine, rewriting the matcher to have the opposite logic (`decl(hasDescend

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389946. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address review comments. Next step: split this patch into two, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389947. kbobyrev added a comment. Leave the feature changes (IncludeCleaner bits) out of this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-to

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389950. kbobyrev added a comment. [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents When a symbol comes from the non self-contained header, we recursively uplift the file we consider used to the first includer that

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

lebedev.ri resigned from this revision. lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:40 const MacroDirective *MD) override { if (SM.isWrittenInBuiltinFile(MD->getLocation()) ||

[clang] d026f2f - [clang] Fix crash on broken parameter declarators

Author: Kadir Cetinkaya Date: 2021-11-26T10:56:54+01:00 New Revision: d026f2f7c688b326eae429286a06bf4080c8b527 URL: https://github.com/llvm/llvm-project/commit/d026f2f7c688b326eae429286a06bf4080c8b527 DIFF: https://github.com/llvm/llvm-project/commit/d026f2f7c688b326eae429286a06bf4080c8b527.dif

[PATCH] D114609: [clang] Fix crash on broken parameter declarators

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rGd026f2f7c688: [clang] Fix crash on broken parameter declarators (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D114609?vs=389851&id=

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389952. kbobyrev added a comment. Change base to D114370 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-ext

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-narrowingintegertofloatingpoint-option.cpp:12 + // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:14: warning: narrowing conversion from 'unsigned long l

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389953. kbobyrev added a comment. Get the changes back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-extra/clangd/CodeComplete.

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-narrowingintegertofloatingpoint-option.cpp:12 + // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:14: warning: narrowing conversion from 'unsigned long l

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested review of

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added a comment. > Please repeat the measurement for `openssl`. There must have been some > interference in the memory consumption. Aside from that the results look > great. I did. Average memory usage is unaffected. F20722167: svalbuilder_improvements_openssl.png

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet added a comment. LGTM once tests are passing. Maybe wait a bit for a comment from @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 ___ cfe-commits mailing list cfe-commits@

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

danielkiss added a comment. In D109856#3154763 , @mstorsjo wrote: > Looks reasonable I think. Is this a deficiency in the EHABI implementation > only, i.e. this aspect works as it should in the regular dwarf implementation? Yes, it works on dwarf alread

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Show parameters for construct.

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal created this revision. steakhal added reviewers: aaron.ballman, alexfh, hokein, courbet, NoQ, xazax.hun, martong, whisperity, davrec. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsof

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/unittest

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When a symbol comes f

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added a comment. In D103317#3155191 , @martong wrote: >> Please repeat the measurement for `openssl`. There must have been some >> interference in the memory consumption. Aside from that the results look >> great. > > I did. Average memory usag

[clang] d8a3538 - [clang][deps] NFC: Remove else after early return

Author: Jan Svoboda Date: 2021-11-26T12:18:37+01:00 New Revision: d8a35387881bf408c19deeba7b5e3648dbbf467c URL: https://github.com/llvm/llvm-project/commit/d8a35387881bf408c19deeba7b5e3648dbbf467c DIFF: https://github.com/llvm/llvm-project/commit/d8a35387881bf408c19deeba7b5e3648dbbf467c.diff L

[clang] 12eafd9 - [clang][deps] NFC: Clean up wording (ignored vs minimized)

Author: Jan Svoboda Date: 2021-11-26T12:18:37+01:00 New Revision: 12eafd944e0ffccae93402ddbe2855beb7a939ff URL: https://github.com/llvm/llvm-project/commit/12eafd944e0ffccae93402ddbe2855beb7a939ff DIFF: https://github.com/llvm/llvm-project/commit/12eafd944e0ffccae93402ddbe2855beb7a939ff.diff L

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

steakhal added a comment. I see. Simplification is always good. Let's measure and compare the runtime characteristics before moving forward. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2226 + // + // Empirical measurements show that if we rel

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + could consi

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D109856#3155235 , @danielkiss wrote: > In D109856#3154763 , @mstorsjo > wrote: > >> Looks reasonable

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with a couple of readability things Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:259 +for (const FileEntry *FE = SM.getFileEntryForID(ID); + I

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 389983. skc7 added a comment. Updated diff with changes suggested by jrtc27 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst llvm/include/llvm/

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added a comment. It's annoying that we see comments and inclusion directives out-of-order, we can try fixing it on the parser side (I think it is incidental that these are issued in that order currently, they are eagerly trying to generate a fix/diagnostic for tokens after a pp-directi

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

sammccall added a comment. Sorry for forgetting about this one. Hopefully I can still help now by disagreeing with Kadir and creating an awkward stalemate instead. I agree that the ownership situation is ugly, but I think a single object here is still simpler. Partly because the ordering isn't

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + sammccall wrote: > could consider `friend class RecordHeaders`, either is ugly, up to you That was

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG632acec73776: [libunwind][ARM] Handle end of stack during unwind (authored by danielkiss). Herald added projects: libc++abi, libunwind. Herald added 1 blocking reviewer(s): libc++abi. Repository: rG LLV

[libunwind] 632acec - [libunwind][ARM] Handle end of stack during unwind

Author: Daniel Kiss Date: 2021-11-26T13:26:49+01:00 New Revision: 632acec73776c4d6f7073d6de04ed6b8bfd36e6d URL: https://github.com/llvm/llvm-project/commit/632acec73776c4d6f7073d6de04ed6b8bfd36e6d DIFF: https://github.com/llvm/llvm-project/commit/632acec73776c4d6f7073d6de04ed6b8bfd36e6d.diff L

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

whisperity added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:8-10 Calls to ``new`` can throw exceptions of type ``std::bad_alloc`` that should be handled by the code. Alternatively, the nonthrowing form of ``new

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

BHUMITRAM created this revision. BHUMITRAM added reviewers: aaron.ballman, xgupta. BHUMITRAM requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D93458 removed the /Zd flag as MSVC doesn't support that syntax. Instead

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

whisperity added a comment. I haven't looked at the patch in detail yet, but I know I've run into the issue this aims to fix when developing a Tidy check! There is a `// NOLINTNEXTLINE(misc-redundant-expression)` directive in the source file `clang-tools-extra/clang-tidy/bugprone/EasilySwappab

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114632/new/ https://reviews.llvm.org/D114632 __

[clang] a3b099b - [Docs] Removed /Zd flag still mentioned in documentation

Author: Bhumitram Kumar Date: 2021-11-26T18:08:06+05:30 New Revision: a3b099b68c0c156aa8ed9ec81c5dfdf150c6329c URL: https://github.com/llvm/llvm-project/commit/a3b099b68c0c156aa8ed9ec81c5dfdf150c6329c DIFF: https://github.com/llvm/llvm-project/commit/a3b099b68c0c156aa8ed9ec81c5dfdf150c6329c.dif

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b099b68c0c: [Docs] Removed /Zd flag still mentioned in documentation (authored by BHUMITRAM, committed by xgupta). Repository: rG LLVM Github Mo

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

sammccall added a comment. Didn't really address this part > But I don't think it matters in the long run especially when we want to > handle different types of pragmas in the future > So I'd suggest just building a side table information That's a more general approach for sure. But it does see

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + kbobyrev wrote: > sammccall wrote: > > could consider `friend class RecordHeaders`, either is ugly

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:54-55 const NestedNameSpecifier *Right) { - llvm::FoldingSetNodeID LeftID, RightID; - Left->Profile(LeftID); - Right->Profile(Ri

[clang] 97e504c - [clang][deps] NFC: Extract function

Author: Jan Svoboda Date: 2021-11-26T14:01:24+01:00 New Revision: 97e504cff956b7120da9bd932644b00a853ee68a URL: https://github.com/llvm/llvm-project/commit/97e504cff956b7120da9bd932644b00a853ee68a DIFF: https://github.com/llvm/llvm-project/commit/97e504cff956b7120da9bd932644b00a853ee68a.diff L

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp:151 + using Alias3 = TemplateTypeAlias; + Alias3 &operator=(int) { return *this; } +}; This is a no-warn due to the parameter being

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390021. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td c

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal added a comment. In D114622#3155605 , @whisperity wrote: > I haven't looked at the patch in detail yet, but I know I've run into the > issue this aims to fix when developing a Tidy check! > > There is a `// NOLINTNEXTLINE(misc-redundant-express

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal updated this revision to Diff 390023. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114622/new/ https://reviews.llvm.org/D114622 Files: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp c

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 390024. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Get rid of the setter in IncludeStructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D11437

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + sammccall wrote: > kbobyrev wrote: > > sammccall wrote: > > > could consider `friend class RecordHe

[clang-tools-extra] cd0ca5a - [clangd] Record information about non self-contained headers in IncludeStructure

Author: Kirill Bobyrev Date: 2021-11-26T14:12:54+01:00 New Revision: cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c URL: https://github.com/llvm/llvm-project/commit/cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c DIFF: https://github.com/llvm/llvm-project/commit/cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c.diff

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0ca5a0eaa1: [clangd] Record information about non self-contained headers in IncludeStructure (authored by kbobyrev). Repository: rG LLVM Github

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 390029. sgatev marked 3 inline comments as done. sgatev added a comment. Replace "Dynamic" with "TypeErased" in the names of types and their members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ htt

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal updated this revision to Diff 390032. steakhal marked 3 inline comments as done. steakhal added a comment. Fixing nits: renaming variables, etc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114622/new/ https://reviews.llvm.org/D114622 Files: clang-tools-extra/clang-tidy/bug

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:54-55 const NestedNameSpecifier *Right) { - llvm::FoldingSetNodeID LeftID, RightID; - Left->Profile(LeftID); - Right->Profile(Righ

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added a comment. > Sorry for forgetting about this one. Hopefully I can still help now by > disagreeing with Kadir and creating an awkward stalemate instead. Haha, always welcome! > Partly because the ordering isn't some weird coincidence (see below) Right, I suppose it makes sense wh

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 390034. sgatev added a comment. Minor tweaks to documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/FlowSensitive/Data

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev added a comment. Thanks Gábor and Dmitri! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: xazax.hun

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon created this revision. RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson, Meinersbur, jansvoboda11, gbedwell. Herald added subscribers: dexonsmith, mstorsjo, mgorny. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 16 2019" -T LLVM .. Maybe make this VS2022 instead, to help it last longer? Comment at

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

steakhal added a comment. In D113558#3154967 , @whisperity wrote: > I'm not sure if it is a good idea to merge things on a Friday, but I am > comfortable with this, let's get the check crash less. I've run this on a few projects and it did not introduc

[PATCH] D114522: [clangd] Add desugared type to hover

sammccall added a comment. This looks pretty good in terms of behavior, some impl comments but we should land this. My main remaining concern is just that this will trigger too often when there's no confusion over types, and clutter the display. Some common cases I'm worried about: - std::stri

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal added a comment. I plan to commit this stack on Monday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114256/new/ https://reviews.llvm.org/D114256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske updated this revision to Diff 390048. balazske added a comment. Apply of review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114602/new/ https://reviews.llvm.org/D114602 Files: clang-tools-extra/docs/clang-tidy/checks/bugpro

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske marked 5 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:19-20 The check assumes that any user-defined ``operator new`` is either ``noexcept`` or may throw an excepti

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 390051. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114623/new/ https://reviews.llvm.org/D114623 Files: clang-

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 390052. kbobyrev added a comment. Add some docs for the helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114623/new/ https://reviews.llvm.org/D114623 Files: clang-tools-extra/clangd/IncludeCle

[clang-tools-extra] 34cc210 - [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

Author: Kirill Bobyrev Date: 2021-11-26T16:20:48+01:00 New Revision: 34cc210aa8af2fd33598e5559d0f5b51f9423dd6 URL: https://github.com/llvm/llvm-project/commit/34cc210aa8af2fd33598e5559d0f5b51f9423dd6 DIFF: https://github.com/llvm/llvm-project/commit/34cc210aa8af2fd33598e5559d0f5b51f9423dd6.diff

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34cc210aa8af: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to… (authored by kbobyrev). Repository: rG LLVM Github Mo

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek updated this revision to Diff 390057. klimek marked 49 inline comments as done. klimek added a comment. Work in review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 Files: clang/lib/For

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/atomic-ops.cu:14 +// CHECK: load atomic i32, i32* {{%[0-9]+}} syncscope("singlethread-one-as") monotonic, align 4 +// CHECK: store i32 {{%[0-9]+}}, i32* %{{.*}}, align 4 +// CHECK: cmpxchg weak i32* {{%[0-9]+}}, i3

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

labrinea accepted this revision. labrinea added a comment. This revision is now accepted and ready to land. Looks like you've addressed Oliver's comments. I don't have any new suggestions from my end. Just make sure you've removed the test xfail before merging. Comment at: cla

[PATCH] D114621: [clangd] Show parameters for construct.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1065 + if (Parameters && !Parameters->empty()) { +Output.addParagraph().appendText("Parameters: "); it's a subtle invariant that we only have parameters for functions (which has

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not MS

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390082. RKSimon added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/UsersMa

[PATCH] D114522: [clangd] Add desugared type to hover

kadircet added a comment. > My main remaining concern is just that this will trigger too often when > there's no confusion over types, and clutter the display. > Some common cases I'm worried about: > > - std::string -> basic_string. Maybe we should special-case this to > hide the aka? > - int64

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 390085. avogelsgesang marked 7 inline comments as done. avogelsgesang added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 F

  1   2   >