[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

ebrevnov added a comment. In D102090#3169726 , @rnk wrote: > In D102090#3169439 , @ebrevnov > wrote: > >> While -Bsymbolic-funtions brings nice performance improvements it also >> changes symbol resolution order

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

hollinsky added a comment. This change breaks return value deduction of template instantiations that first occur within a discarded context. template class Foo { public: constexpr Foo(const char str[S]) : buf(str[0]) {} char get() const { return buf; } char buf; }

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

khchen added a comment. In D70401#3172457 , @zixuan-wu wrote: > Hi, all. Why is it not continued? Sorry, I have to work on other tasks so stop the rv32e implementation work. Are you interest to finish it? I could share my patches to you. Repository: r

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:154-172 + // Find the length delimiter. + const size_t LengthDelimiter = LineRef.find(':'); + if (StringRef::npos == LengthDelimiter) +return false; + + // Parse the length of LookupNam

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

ebrevnov added a comment. In D102090#3172538 , @MaskRay wrote: > To add on rnk's comment (deduplication of vague linkage data which may be > included in multiple shared objects), another big reason is -Bsymbolic data > does not work with copy relocation

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 391990. MyDeveloperDay added a comment. This fix has to go super specific to range for loops or we start manipulating pointer alignment all over the place in places perhaps we don't want to CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050

[PATCH] D114510: [analyzer] Ignore flex generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rG9873ef409c4a: [analyzer] Ignore flex generated files (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 9873ef4 - [analyzer] Ignore flex generated files

Author: Balazs Benics Date: 2021-12-06T10:20:17+01:00 New Revision: 9873ef409c4a937c566e20e7a88af049d212ce03 URL: https://github.com/llvm/llvm-project/commit/9873ef409c4a937c566e20e7a88af049d212ce03 DIFF: https://github.com/llvm/llvm-project/commit/9873ef409c4a937c566e20e7a88af049d212ce03.diff

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added a comment. You have reverted some of your changes. Including all the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 391993. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Fix the merge and add the tests back (which missed the patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay added a comment. In D115050#3172842 , @HazardyKnusperkeks wrote: > You have reverted some of your changes. Including all the tests. Yes oops! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D1

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

MyDeveloperDay added a comment. Even if you choose a number, beyond that number it behaves like a vector (just without the data being on the stack), its really good for small vectors but its not bad for large ones. I'm not sure what the default N is if you don't specify a number? (0?) CHANGES

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3172860 , @MyDeveloperDay wrote: > Even if you choose a number, beyond that number it behaves like a vector > (just without the data being on the stack), its really good for small vectors > but its not bad

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114418/new/ https://reviews.llvm.org/D114418 _

[PATCH] D115103: Leak Sanitizer port to Windows

MyDeveloperDay added inline comments. Comment at: compiler-rt/lib/lsan/lsan.h:20 +#elif SANITIZER_WINDOWS +# include "lsan_win.h" #endif clang-format? Comment at: compiler-rt/lib/lsan/lsan_common.h:48 +#elif SANITIZER_NETBSD || SANITIZER_FUCH

[PATCH] D115103: Leak Sanitizer port to Windows

MyDeveloperDay added a comment. You need to add some reviewers to this revision. check out the CODE_OWNERS.txt or what I sometimes do is to `git log` one of the files you are changing and see who is a major contributor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https:/

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin, LangOpts

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

peter.smith added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114124/new/ https://reviews.llvm.org/D114124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 391998. simoll marked an inline comment as done. simoll added a comment. Simplified empty-string check as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 Fil

[clang] e403f4f - [clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

Author: Kristina Bessonova Date: 2021-12-06T12:19:09+02:00 New Revision: e403f4fdc88322201040f2bee7b328e8a78e2f7f URL: https://github.com/llvm/llvm-project/commit/e403f4fdc88322201040f2bee7b328e8a78e2f7f DIFF: https://github.com/llvm/llvm-project/commit/e403f4fdc88322201040f2bee7b328e8a78e2f7f.

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

This revision was automatically updated to reflect the committed changes. Closed by commit rGe403f4fdc883: [clang][DebugInfo] Allow function-local statics and types to be scoped within a… (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

simon.giesecke added a comment. Thanks a lot for addressing this issue! I am just trying it on our codebase. > The problem actually has nothing to do with the out-of-line definition being > inline; the problem is that hasDeclaration() of the memberExpr() will match > the out-of-line definition,

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu added a comment. @aaron.ballman @urnathan @rsmith ping. Might you take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D114527: [VE] Support multiple architectures installation

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. I will configure the `clang-ve-staging` bot to start testing libcxx/libcxxabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 392002. c-rhodes added a comment. Revert `LangOpt.VScaleMin` default to 0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:154-172 + // Find the length delimiter. + const size_t LengthDelimiter = LineRef.find(':'); + if (StringRef::npos == LengthDelimiter) +return false; + + // Parse the length of Lookup

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using -mbranch-protection=pac-ret+b-key, macro __ARM_FEATURE_PAC_DEFAULT should still have the value correspon

[clang] 83f5725 - [VE] Support multiple architectures installation

Author: Kazushi (Jam) Marukawa Date: 2021-12-06T19:56:41+09:00 New Revision: 83f572527e0fcc1cd0be8ee23bc12abf27027daf URL: https://github.com/llvm/llvm-project/commit/83f572527e0fcc1cd0be8ee23bc12abf27027daf DIFF: https://github.com/llvm/llvm-project/commit/83f572527e0fcc1cd0be8ee23bc12abf27027

[PATCH] D114527: [VE] Support multiple architectures installation

This revision was automatically updated to reflect the committed changes. Closed by commit rG83f572527e0f: [VE] Support multiple architectures installation (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews

[PATCH] D115141: [ARM][clang] Add back branch protection tests

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When committing the PACBTI-M frontend support patch (https://reviews.llvm.org/D112421), the tests in arm-invalid-br

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

gribozavr2 added inline comments. Comment at: clang/docs/DataFlowAnalysisIntro.md:279 +``` +out = transfer(basic_block, join(in_1, in_2, ..., in_n)) +``` xazax.hun wrote: > gribozavr2 wrote: > > xazax.hun wrote: > > > While I agree that this is the general formul

[clang] 0fbb174 - [ARM] Implement setjmp BTI placement for PACBTI-M

Author: Ties Stuij Date: 2021-12-06T11:07:10Z New Revision: 0fbb17458a01a6b388fc67661ffb92969503e977 URL: https://github.com/llvm/llvm-project/commit/0fbb17458a01a6b388fc67661ffb92969503e977 DIFF: https://github.com/llvm/llvm-project/commit/0fbb17458a01a6b388fc67661ffb92969503e977.diff LOG: [A

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fbb17458a01: [ARM] Implement setjmp BTI placement for PACBTI-M (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij added a comment. @erichkeane : thanks so much for going through the trouble to see what the problem is! I've put up a fix with your suggested change at https://reviews.llvm.org/D115141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a comment. Please mark comments 'done' if they are done. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:154-172 + // Find the length delimiter. + const size_t LengthDelimiter = LineRef.find(':'); + if (StringRef::npos == LengthDelimiter) +return fa

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 392013. stuij added a comment. tickling the commit so the buildbot picks up the dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targ

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 392015. MattDevereau added a comment. replace numbers in BuiltinsAArch64NeonSVEBridge_cg.def with SVETypeFlags enum values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.or

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau marked an inline comment as done. MattDevereau added a comment. clang-format is upset about this ordering: #include "clang/Basic/arm_sve_builtin_cg.inc" #include "clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def" but swapping the order causes all SVE tests to fail. I'm ignoring the

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 392017. clemenswasser added a comment. Remove wrong interceptors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compiler-rt/cmake/config-ix.cmake co

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 392021. stuij added a comment. another tickle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/Preprocessor/arm-tar

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

danielkiss added a comment. I think rejecting\warning the `b-key` from the command line maybe a more developer friendly way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 __

[clang] 34a43f2 - [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

Author: Simon Moll Date: 2021-12-06T13:31:51+01:00 New Revision: 34a43f2115af79f896c889433c57f3b400e9f2c6 URL: https://github.com/llvm/llvm-project/commit/34a43f2115af79f896c889433c57f3b400e9f2c6 DIFF: https://github.com/llvm/llvm-project/commit/34a43f2115af79f896c889433c57f3b400e9f2c6.diff LO

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

This revision was automatically updated to reflect the committed changes. Closed by commit rG34a43f2115af: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains (authored by simoll). Changed prior to commit: https://reviews.llvm.org/D115045?vs=391998&id=392022#toc Repository: rG L

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. In D114413#3166979 , @Meinersbur wrote: > In D114413#3160044 , @peixin wrote: > >> In D114413#3159095 , @Meinersbur >> wrote: >> >>> In D114413#3

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:154-172 + // Find the length delimiter. + const size_t LengthDelimiter = LineRef.find(':'); + if (StringRef::npos == LengthDelimiter) +return false; + + // Parse the length of Lookup

[PATCH] D115147: clang-format: [JS] test case for numeric separators.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst requested review of this revision. Herald added a project: clang. ES2021 allows numeric literals using `_` as a separator. This already works, but had no test. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

aaron.ballman added a comment. Just a few minor nits from me. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11395-11396 InGroup; +def err_sycl_zero_array_size : Error< + "zero-length arrays are not permitted in SYCL device code">; We should

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:154-172 + // Find the length delimiter. + const size_t LengthDelimiter = LineRef.find(':'); + if (StringRef::npos == LengthDelimiter) +return false; + + // Parse the length of LookupNam

[PATCH] D115147: clang-format: [JS] test case for numeric separators.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115147/new/ https://reviews.llvm.org/D115147 ___

[PATCH] D115141: [ARM][clang] Add back branch protection tests

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm quite sure this is the right fix, the 'requires' clause missing is, I believe, the problems that caused us to revert this test. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D115153: clang/AMDGPU: Don't set implicit arg attribute to default size

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield. Herald added subscribers: jdoerfert, kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. Herald added a reviewer: jdoerfert.

[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:75 - auto HandleTemporaryCXXStaticCastExpr = makeRule( - cxxStaticCastExpr( - hasSourceExpression(StringViewConstructingFromNullExpr)), - changeTo(nod

[clang] 5032467 - Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after par

Author: James Farrell Date: 2021-12-06T14:57:47Z New Revision: 50324670342d9391f62671685f4d6b4880a4ea9a URL: https://github.com/llvm/llvm-project/commit/50324670342d9391f62671685f4d6b4880a4ea9a DIFF: https://github.com/llvm/llvm-project/commit/50324670342d9391f62671685f4d6b4880a4ea9a.diff LOG:

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

This revision was automatically updated to reflect the committed changes. Closed by commit rG50324670342d: Use VersionTuple for parsing versions in Triple, fixing issues that caused the… (authored by jamesfarrell). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

ronlieb added a comment. Hi Simon, i am seeing a failure in our amdgpu buildbot after this patch . https://lab.llvm.org/staging/#/builders/200/builds/1407 we do depend on the cmake flag you removed. we specify this -DCLANG_DEFAULT_LINKER=lld FAILED: openmp/libomptarget/libomptarget.rtl.x86_64.s

[PATCH] D115141: [ARM][clang] Add back branch protection tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG53154a83aee0: [ARM][clang] Add back branch protection tests (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115141/new/ https://reviews.l

[clang] 53154a8 - [ARM][clang] Add back branch protection tests

Author: Ties Stuij Date: 2021-12-06T15:03:33Z New Revision: 53154a83aee0ce969dc07e7168b3914ca1025030 URL: https://github.com/llvm/llvm-project/commit/53154a83aee0ce969dc07e7168b3914ca1025030 DIFF: https://github.com/llvm/llvm-project/commit/53154a83aee0ce969dc07e7168b3914ca1025030.diff LOG: [A

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Aaron, have you had any chance to look at this yet? I added you as a reviewer because you expressed interest in something like this in this discussion: https://lists.llvm.org/pipermail/cfe-dev/2021-October/069097.html Is there someone else who would be more appropriate

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

JonChesterfield created this revision. JonChesterfield added reviewers: ronlieb, jhuber6, jdoerfert, pdhaliwal. Herald added subscribers: dang, kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. If it works on your end it's good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115157/new/ https://reviews.llvm.org/D115157 ___

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added a comment. Friendly ping to reviewers. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

JonChesterfield added a comment. It's a bit hard to tell. Definitely might work. I'm hoping someone will feed this into the internal CI infra. @ronlieb any objection to making this change on trunk and reverting it internally if things break there? Repository: rG LLVM Github Monorepo CHANGES

[clang] f6ba645 - Revert "[Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains"

Author: Simon Moll Date: 2021-12-06T16:44:36+01:00 New Revision: f6ba6450396ce58212f247c72d84a54efd748b38 URL: https://github.com/llvm/llvm-project/commit/f6ba6450396ce58212f247c72d84a54efd748b38 DIFF: https://github.com/llvm/llvm-project/commit/f6ba6450396ce58212f247c72d84a54efd748b38.diff LO

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll reopened this revision. simoll added a comment. This revision is now accepted and ready to land. I've reverted the patch for now, this may show up for other toolchains, too. This patch has pushed down the responsibility for handling `-DCLANG_DEFAULT_LINKER` to the toolchains. However, I d

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

ronlieb added a comment. fyi: if i remove the now 'dead' use of the CMAKE variable from my cmake , then i am able to build. so i see you reverted, thx. i guess some coordination amongst buildbot maintainers who might use this option checking zorg: the last two are me: not sure who owns the 1

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. One minor issue but otherwise looks good. Comment at: clang/lib/Basic/Targets/AArch64.cpp:482 +return std::pair( +LangOpts.VScaleMin ? LangOpts.VS

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 392067. simoll added a comment. Herald added subscribers: abrachet, kerbowa, ormris, atanasyan, jrtc27, aheejin, jgravelle-google, sbc100, nhaehnle, jvesely, sdardis, dschuff. Use the `-DCLANG_DEFAULT_LINKER` linker in all toolchains but VE. Since toolchains

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:482 +return std::pair( +LangOpts.VScaleMin ? LangOpts.VScaleMin : 1, 16); + paulwalker-arm wrote: > This part is no longer needed because to get here you already know > `

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 392071. jozefl marked an inline comment as done. jozefl added a comment. Thanks, good point, fixed in the attached patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D10830

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a comment. In D114235#3173549 , @mboehme wrote: > Aaron, have you had any chance to look at this yet? > > I added you as a reviewer because you expressed interest in something like > this in this discussion: > https://lists.llvm.org/

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon updated this revision to Diff 392080. Fznamznon added a comment. Applied suggestions from Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. ping: This is ready for review now. Thanks for your patience with the review as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 __

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 _

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:724 + "attribute %0 does not support pack expansion in the last argument">; +def err_attribute_parm_pack_last_argument_only : Error< + "pack expansion in attributes is restricted to

[clang] 6bb2a4f - [openmp] Default to new rtl for amdgpu

Author: Jon Chesterfield Date: 2021-12-06T16:56:14Z New Revision: 6bb2a4f3e6546dc854a6f0dd37d81590e0b2990e URL: https://github.com/llvm/llvm-project/commit/6bb2a4f3e6546dc854a6f0dd37d81590e0b2990e DIFF: https://github.com/llvm/llvm-project/commit/6bb2a4f3e6546dc854a6f0dd37d81590e0b2990e.diff L

[PATCH] D115157: [openmp] Default to new rtl for amdgpu

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bb2a4f3e654: [openmp] Default to new rtl for amdgpu (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This looks good to me! I agree, an `enum class` would be cleaner though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/ https://r

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added a comment. In D114966#3168108 , @dexonsmith wrote: > Thanks for working on this; seems like a great start. Thanks a lot for the extensive feedback! I'll work through it and create prep p

[clang] 4cb7929 - Revert "[clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block"

Author: Jonas Devlieghere Date: 2021-12-06T09:34:53-08:00 New Revision: 4cb79294e8df8c91ae15264d1014361815d34a53 URL: https://github.com/llvm/llvm-project/commit/4cb79294e8df8c91ae15264d1014361815d34a53 DIFF: https://github.com/llvm/llvm-project/commit/4cb79294e8df8c91ae15264d1014361815d34a53.d

[clang] 63a6348 - Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" a

Author: James Farrell Date: 2021-12-06T17:35:26Z New Revision: 63a6348cad6caccf285c1661bc60d8ba5a40c972 URL: https://github.com/llvm/llvm-project/commit/63a6348cad6caccf285c1661bc60d8ba5a40c972 DIFF: https://github.com/llvm/llvm-project/commit/63a6348cad6caccf285c1661bc60d8ba5a40c972.diff LOG:

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

JDevlieghere added a comment. Hey Kristina, this broke TestSetData.py on GreenDragon: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39089/ Since the bot has been red for several hours I went ahead and reverted your change in 4cb79294e8df8c91ae15264d1014361815d34a53

[clang] a6816b9 - [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

Author: Balazs Benics Date: 2021-12-06T18:38:58+01:00 New Revision: a6816b957d28ab7855f2af1277c72a6d65b600b4 URL: https://github.com/llvm/llvm-project/commit/a6816b957d28ab7855f2af1277c72a6d65b600b4 DIFF: https://github.com/llvm/llvm-project/commit/a6816b957d28ab7855f2af1277c72a6d65b600b4.diff

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6816b957d28: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan, njames93. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=49298 clang-format does not respect ra

[PATCH] D115169: Create a generic ABI document for _BitInt

aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, erichkeane, rsmith. Herald added a subscriber: arphaman. aaron.ballman requested review of this revision. Herald added a project: clang. This document describes a generic ABI for targets to opt into if they wish. It was

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

thakis added a comment. Either this or D115139 broke check-llvm on arm macs: http://45.33.8.238/macm1/23120/step_11.txt getMacOSHostVersion sounds kind of triple-related, so I'm guessing it's this one. Please take a look, and revert for now if it takes a whil

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3173981 , @JDevlieghere wrote: > Hey Kristina, this broke TestSetData.py on GreenDragon: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39089/ > > Since the bot has been red for several hours I went ahead a

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

thakis added a comment. Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 min or so then. Something to keep in mind for relanding though :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114885/new/ https://reviews.llvm.

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks all! I've commit the renaming in 6c75ab5f66b403f7ca67e86aeed3a58abe10570b and have started a new review for the generic ABI document in https://review

[clang] 327d966 - clang-format: [JS] test case for numeric separators.

Author: Martin Probst Date: 2021-12-06T19:01:24+01:00 New Revision: 327d966365d7b34abd25a920e1f7b5aecfa5c70f URL: https://github.com/llvm/llvm-project/commit/327d966365d7b34abd25a920e1f7b5aecfa5c70f DIFF: https://github.com/llvm/llvm-project/commit/327d966365d7b34abd25a920e1f7b5aecfa5c70f.diff

[PATCH] D115147: clang-format: [JS] test case for numeric separators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG327d966365d7: clang-format: [JS] test case for numeric separators. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115147/new/ https://

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

MyDeveloperDay added a comment. I recently reviewed this item, but I wonder what the overlap with D94661: [clang-format] [PR19056] Add support for access modifiers indentation is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 1feb8ab - Update the status of N2412 in C (we do not implement large parts of it)

Author: Aaron Ballman Date: 2021-12-06T13:14:13-05:00 New Revision: 1feb8ab0d350640058ffa764e0aeeda2480d6302 URL: https://github.com/llvm/llvm-project/commit/1feb8ab0d350640058ffa764e0aeeda2480d6302 DIFF: https://github.com/llvm/llvm-project/commit/1feb8ab0d350640058ffa764e0aeeda2480d6302.diff

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Note to self: don't forget to hit "submit". The comments below have been left unsubmitted for two weeks. Sorry about that. The patch looks OK for the time being. That said, I do have concerns that w

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2597 +// or we will sort the contents of the string. +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { "we we"? C

[clang] 1f257ac - Speculatively fix the LLDB build bots from 6c75ab5f66b403f7ca67e86aeed3a58abe10570b

Author: Aaron Ballman Date: 2021-12-06T13:30:15-05:00 New Revision: 1f257accd713a8e302d3fdd2cac615a303295c42 URL: https://github.com/llvm/llvm-project/commit/1f257accd713a8e302d3fdd2cac615a303295c42 DIFF: https://github.com/llvm/llvm-project/commit/1f257accd713a8e302d3fdd2cac615a303295c42.diff

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell added a comment. In D114885#3174074 , @thakis wrote: > Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 > min or so then. Something to keep in mind for relanding though :) Yeah, I'm currently trying to build and

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

tra added a comment. > Put __hip_gpubin_handle in comdat when it has linkonce_odr linkage. I wonder when would this happen? I'm not sure we ever want gpubin handles from different TUs merged. I think it may result in different TUs attempting to load/init the same GPU binary multiple times. C

  1   2   >