[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added a comment. I am not sure that the choice of `isOSBinFormatELF` to (afaik) primarily scope this change from affecting AIX (where we know the library calls are not implemented to be lock-free yet) is better than alternative where the condition is for little-endian

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

Amir added inline comments. Comment at: bolt/lib/Core/DebugData.cpp:823 Hasher.update(AbbrevData); -StringRef Key = Hasher.final(); +auto Hash = Hasher.final(); +StringRef Key((const char *)Hash.data(), Hash.size()); I think it would be more in

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// TODO: when clang allows c++17, use std::clamp instead +uint32_t clamp(uint64_t value, uint32_t hi, uint32_t low) { + if (value > hi) Nit: seems more intuitive to pass

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi updated this revision to Diff 420378. akyrtzi added a comment. Also revert the `README` changes to the previous version of `BLAKE3` class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123100/new/ https://reviews.llvm.org/D123100 Files:

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi added inline comments. Comment at: llvm/include/llvm/Support/BLAKE3.h:38 +/// A class that wraps the BLAKE3 algorithm. +template class BLAKE3 { public: dexonsmith wrote: > The visual noise of `BLAKE3<>` everywhere is a bit unfortunate. > > Another

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi updated this revision to Diff 420377. akyrtzi added a comment. - Move `BLAKE3` back to templated sizes for `final()` and `result()` and add `TruncatedBLAKE3` that has the size parameter on the class. - Make `MD5Result` inherit from `std::array` which both simplifies its API and makes it

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz updated this revision to Diff 420376. beanz added a comment. Updating based on feedback from @aaron.ballman I think this covers all the cases for parsing as a function parameter. I haven't added the code to parse these in structure definitions or globals yet. If it is okay I'd like to do

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 420375. abrachet added a comment. Actually clang-format... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/include/clang/Driver/Options.h

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:443 -// PPC64 supports atomics up to 8 bytes. -MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; +// PPC64 supports atomics up to 16 bytes. +MaxAtomicPromoteWidth = 128;

[clang] 4875ff1 - [RISCV] Remove redundant enabling of IAS for Clang, NFC

Author: Brad Smith Date: 2022-04-04T23:44:49-04:00 New Revision: 4875ff1dc90bba089a5a14023d5eec69490b0422 URL: https://github.com/llvm/llvm-project/commit/4875ff1dc90bba089a5a14023d5eec69490b0422 DIFF: https://github.com/llvm/llvm-project/commit/4875ff1dc90bba089a5a14023d5eec69490b0422.diff

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123097/new/

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:448 + void setMaxAtomicWidth() override { +// For layout on ELF targets, we support up to 16 bytes. +if (getTriple().isOSBinFormatELF()) hubert.reinterpretcast

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:448 + void setMaxAtomicWidth() override { +// For layout on ELF targets, we support up to 16 bytes. +if (getTriple().isOSBinFormatELF()) lkail wrote: >

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur updated this revision to Diff 420371. Meinersbur marked an inline comment as done. Meinersbur added a comment. - Rebase - Fix convertOmpAtomicUpdate, convertOmpAtomicCapture, and convertOmpOrdered Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:74-75 + // for the allocs. + // TODO: Create a dedicated alloca BasicBlock at function creation such that + // we do

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/BLAKE3.h:38 +/// A class that wraps the BLAKE3 algorithm. +template class BLAKE3 { public: The visual noise of `BLAKE3<>` everywhere is a bit unfortunate. Another option: ``` lang=c++ //

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. (Forgot to click "accept".) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/new/ https://reviews.llvm.org/D123104

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added reviewers: benlangmuir, bruno. dexonsmith added a comment. This LGTM, with a couple of comments (on the comments!) inline. > Upstreamed from apple#llvm-project 72cf785051fb1b3ef22eee4dd33366e41a275981. Note, for some extra background: - This was out-of-tree because it seemed

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29444f0444c6: [modules] Merge ObjC interface ivars with anonymous

[clang] 29444f0 - [modules] Merge ObjC interface ivars with anonymous types.

Author: Volodymyr Sapsai Date: 2022-04-04T18:48:30-07:00 New Revision: 29444f0444c6d3586969fd6fbe49c8188c02c244 URL: https://github.com/llvm/llvm-project/commit/29444f0444c6d3586969fd6fbe49c8188c02c244 DIFF:

[PATCH] D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D123103#3428298 , @bnbarham wrote: > This broke crash reproducers in very specific circumstances, see > https://reviews.llvm.org/D123104.

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi updated this revision to Diff 420359. akyrtzi added a comment. Adjust `ASTFileSignature` to accept only the array hash bytes and directly from the `final()` call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123100/new/

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added a comment. Thanks everyone for the feedback! Especially valuable is opinion on making `ObjCContainerDecl` a lexical decl context. As discussed earlier, not many people can provide feedback on Objective-C-related code and I'm still responsible for any problems caused by this

[PATCH] D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"

bnbarham added a comment. This broke crash reproducers in very specific circumstances, see https://reviews.llvm.org/D123104. I'll re-commit with adding `ExposesExternalVFSPath` instead of replacing `IsVFSMapped`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham created this revision. bnbarham added a reviewer: dexonsmith. Herald added a project: All. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prevent possible modulemap collisions by making sure to always use the looked-up

[PATCH] D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"

bnbarham created this revision. bnbarham added a reviewer: dexonsmith. Herald added a subscriber: hiraditya. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao updated this revision to Diff 420350. ayzhao added a comment. Herald added a subscriber: dexonsmith. Extract logic into a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files:

[PATCH] D123101: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao abandoned this revision. ayzhao added a comment. Accidental duplicate of D122766 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123101/new/ https://reviews.llvm.org/D123101 STAMPS actor(@ayzhao)

[PATCH] D123101: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao created this revision. Herald added a subscriber: dexonsmith. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting Windows, the path separator used when targeting Windows depends on the

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

akyrtzi created this revision. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added a comment. In D118948#3427401 , @hctim wrote: > In D118948#3427344 , @tschuett > wrote: > >> Is `-fsanitize=memtag-heap` Android specific or target independent? It >> passes Android flags to the

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. This makes sense to me! A few comments inline. Also, the description doesn't talk about timeline for removing the wrapper. Ideally we wouldn't leave behind the wrapper

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. It's conventional to add NFC to the subject line to indicate "no functional change". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang

brad created this revision. brad added a reviewer: kito-cheng. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added a comment. In D123045#3427992 , @zixuw wrote: > In D123045#3427699 , > @QuietMisdreavus wrote: > >> After a quick scan comparing the current output of these symbol graphs with >> the

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 420336. FabioRS added a comment. Thanks! I removed the excess setting/resseting of the SyntacticDC and SemanticDC ExtractedFunc.SyntacticDC = ExtZone.EnclosingFunction->getLexicalDeclContext(); ExtractedFunc.SemanticDC =

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } zixuw wrote: > QuietMisdreavus wrote: > > zixuw wrote: > > > What's the

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:765 + + ExtractedFunc.ForwardDeclarationSyntacticDC = ExtractedFunc.SemanticDC = + ExtractedFunc.SyntacticDC = ExtZone.EnclosingFunction->getDeclContext();

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS marked 2 inline comments as done. FabioRS added a comment. In D122698#3426237 , @sammccall wrote: > Thanks, this looks great! Just a couple of nits left. > Appreciate you fixing the out-of-line `ns::f()` case too. It's easier to > understand the

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw updated this revision to Diff 420333. zixuw marked an inline comment as done. zixuw added a comment. Address review comment: - Use `llvm_unreachable` for the Objective-C category case in `serializeSymbolKind` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw marked an inline comment as done. zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:396 break; + case APIRecord::RK_ObjCCategory: +Kind["identifier"] = AddLangPrefix("category"); dang wrote: >

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } QuietMisdreavus wrote: > zixuw wrote: > > What's the cost/would it worth it

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

zixuw added a comment. In D123045#3427699 , @QuietMisdreavus wrote: > After a quick scan comparing the current output of these symbol graphs with > the primary library used for reading them > , the last

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420332. void added a comment. Second attempt to fix Windows errors. Expecting one more iteration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files:

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this change, we're almost ready to drop the entire table out of MemoryBuiltins.cpp and rely solely on attributes to

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420319. cor3ntin added a comment. Add Unit tests for nameToCodepoint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files:

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:513 + const RecordDecl *RD = BaseTy->getDecl(); + if (RD->getIdentifier() == nullptr || RD->getName() != "Message") +return false; Not sure how often is

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420312. void added a comment. First pass at fixing the Windows unit test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added a comment. After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them , the last thing i can spot that's "off" is that the "function signature" is currently being

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420307. void added a comment. - Add an entry in the Release Notes. - Change the command line flags to better match the attribute naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

hubert.reinterpretcast added a comment. In D122983#3426716 , @erichkeane wrote: > We typically avoid doing -verify in CodeGen (unless the diagnostic is > ACTUALLY in CodeGen) as a matter of business. I hope that `-verify` and `//

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

tahonermann added a comment. > but I DO have the opposite problem: Figuring out what the associated tests > are for a patch I also have that issue, but I don't see the relevance here. The changes in D122958 that fixes the issues revealed by these tests

[PATCH] D123019: [clang][extract-api] Add support for typedefs

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:15 +#include "TypedefUnderlyingTypeResolver.h" + #include "clang/ExtractAPI/DeclarationFragments.h" Empty line Comment at:

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:17 #include "clang/ExtractAPI/API.h" +#include "clang/ExtractAPI/DeclarationFragments.h" #include "llvm/Support/JSON.h" Not needed Comment

[PATCH] D121556: [randstruct] Add randomize structure layout support

nickdesaulniers added a comment. In D121556#3427620 , @void wrote: > In D121556#3419184 , @aaron.ballman > wrote: > >> Generally I think things are looking pretty good, but there's still an open >> question and

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3427604 , @xbolva00 wrote: > Release note is missing Sorry about that. I'll add one with the next update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D122008: [flang][driver] Add support for generating executables

tschuett added a comment. https://reviews.llvm.org/D54604 used a really ugly flag: `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 420299. abrachet added a comment. Fixing failing tests in Modules/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3419184 , @aaron.ballman wrote: > Generally I think things are looking pretty good, but there's still an open > question and Precommit CI is still failing on Windows: > > Failed Tests (7): > Clang-Unit :: >

[PATCH] D121556: [randstruct] Add randomize structure layout support

xbolva00 added a comment. Release note is missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal created this revision. AaronSiddharthaMondal added a reviewer: aaron.ballman. AaronSiddharthaMondal added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. AaronSiddharthaMondal requested review of this revision.

[PATCH] D122008: [flang][driver] Add support for generating executables

klausler added a comment. There's 128037 lines of code and documentation outside of lowering and drivers in flang/, and "git blame" tells me that I wrote 63% of them, including most of the Fortran semantics and nearly all of the Fortran parsing and runtime. Based on my knowledge of the code

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420294. void marked an inline comment as done. void added a comment. Simplify the attributes by using an accessor instead of a separate "no_ranomize_layout" attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123056: [clang][extract-api] Undefining macros should not result in a crash

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. Ha! Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123056/new/ https://reviews.llvm.org/D123056

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

xbolva00 added a comment. Could you please check that https://github.com/llvm/llvm-test-suite is buildable with your patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 ___ cfe-commits mailing

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

aaron.ballman added a comment. In D122954#3427422 , @erichkeane wrote: > In D122954#3427406 , @tahonermann > wrote: > >>> FWIW, I dislike this idea of doing tests in separate commits from the patch >>> itself,

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420290. aaron.ballman added a comment. Fixed a failing test case caught by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri added a comment. This patch is the result of discussions in https://reviews.llvm.org/D122542 There are probably a developer or two on the clang side that ought to have a say on this. I do not know the community that well, could you please help me with adding the appropriate people?

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri created this revision. ekieri added reviewers: awarzynski, thakis. Herald added a reviewer: sscalpone. Herald added a project: All. ekieri requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420286. cor3ntin added a comment. Fix generator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm ok with treating the COMDAT issue on non-resolvers as a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122952/new/

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. In D122954#3427406 , @tahonermann wrote: >> FWIW, I dislike this idea of doing tests in separate commits from the patch >> itself,

[PATCH] D122008: [flang][driver] Add support for generating executables

sscalpone added a comment. As I said this morning, I prefer to wait with this patch until the upstreaming is finished. The reason is not only to do with upstreaming, but also with a concurrent effort to button up any assertion and runtime errors so the initial user experience is better.

[PATCH] D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions.

tahonermann added a comment. > FWIW, I dislike this idea of doing tests in separate commits from the patch > itself, it makes the review of the patch more difficult, and makes looking > through history more difficult. Here is my perspective on this. When adding a new feature, I agree that

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked an inline comment as done. hctim added a comment. In D118948#3427344 , @tschuett wrote: > Is `-fsanitize=memtag-heap` Android specific or target independent? It passes > Android flags to the linker?!? The frontend flag should be

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

bernhardmgruber added a comment. I did not base this revision on my latest main (422d05e792dbd6a97f5afd4cdd5e8aa677e97444 ) since I could not run the python scripts with the changes introduced in

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

bernhardmgruber created this revision. bernhardmgruber added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, mgehre, xazax.hun. Herald added a project: All. bernhardmgruber requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 420278. cor3ntin added a comment. Herald added a subscriber: mgrang. Committed the wrong file! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files:

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin created this revision. Herald added subscribers: dexonsmith, hiraditya, mgorny, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. ! Missing tests, some cleanup still

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

tschuett added a comment. Is `-fsanitize=memtag-heap` Android specific or target independent? It passes Android flags to the linker?!? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/test/Driver/memtag-ld.c:36 + +// CHECK-ASYNC: ld{{.*}} "-memtag-mode=async" +// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode= MaskRay wrote: > This will be easier

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 420274. hctim marked 2 inline comments as done. hctim added a comment. (comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files:

[PATCH] D122008: [flang][driver] Add support for generating executables

clementval added a comment. In D122008#3426847 , @awarzynski wrote: > We discussed this patch in our community call today and some people expressed > their reservations about merging this just now. As I mentioned, I would like > to have this merged to

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3419184 , @aaron.ballman wrote: > Generally I think things are looking pretty good, but there's still an open > question and Precommit CI is still failing on Windows: > > Failed Tests (7): > Clang-Unit :: >

[PATCH] D123059: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".""

devin.jeanpierre created this revision. devin.jeanpierre added a reviewer: gribozavr2. Herald added subscribers: dexonsmith, pengfei. Herald added a reviewer: aaron.ballman. Herald added a project: All. devin.jeanpierre requested review of this revision. Herald added a project: clang. Herald added

[clang-tools-extra] 6f3f1e9 - [clangd] Remove trivial uses of FileEntry::getName

Author: Sam McCall Date: 2022-04-04T20:59:51+02:00 New Revision: 6f3f1e98686575004bef4257cbc6c825de5382af URL: https://github.com/llvm/llvm-project/commit/6f3f1e98686575004bef4257cbc6c825de5382af DIFF: https://github.com/llvm/llvm-project/commit/6f3f1e98686575004bef4257cbc6c825de5382af.diff

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added a comment. In D122808#3425703 , @antoniofrighetto wrote: > Looks definitely better! How about this slightly changed version protecting > the interface? > > /// Helper which adds two underlying types of enumeration type. >

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 ___ cfe-commits

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

aaron.ballman added a comment. In D119609#3426279 , @erichkeane wrote: > I think LGTM on technical perspective, Please don't commit until > @aaron.ballman confirms he is OK with the direction, or would like to wait > longer for GCC. I spotted some

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa updated this revision to Diff 420254. yihanaa added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422d05e792db: [clang][extract-api][NFC] Add documentation (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 422d05e - [clang][extract-api][NFC] Add documentation

Author: Daniel Grumberg Date: 2022-04-04T18:59:44+01:00 New Revision: 422d05e792dbd6a97f5afd4cdd5e8aa677e97444 URL: https://github.com/llvm/llvm-project/commit/422d05e792dbd6a97f5afd4cdd5e8aa677e97444 DIFF:

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

dang added a comment. In D122798#3427004 , @zixuw wrote: > Has this landed yet? Doing it now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122798/new/ https://reviews.llvm.org/D122798

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420242. aaron.ballman added a comment. Herald added subscribers: kbarton, nemanjai. Updated the release note and hopefully addressed the remaining test failures found by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/

[PATCH] D123056: [clang][extract-api] Undefining macros should not result in a crash

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes the situation where a undefining a not previously defined

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

zixuw added a comment. Has this landed yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122798/new/ https://reviews.llvm.org/D122798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 LValue RecordLV, CharUnits Align, - llvm::FunctionCallee Func, int Lvl) { + bool dumpTypeName,

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. I pushed 5d90004874c7b040cd43597826aabb34757d25ab to hopefully address the lion's share of the currently failing precommit CI tests. I'll address the remaining few as an update to this patch.

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

yaxunl added a comment. LGTM since currently there is only one HIP/SPIRV implementation. If in the future there is another HIP/SPIRV implementation that does not need this, it could disable it by triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao added a comment. In D123049#3426849 , @yaxunl wrote: > Is this because your HIP threadIdx etc are implemented using OpenCL builtins > so that the emitted LLVM IR contains calls of OpenCL builtins? Yes, that's correct. Repository: rG LLVM

  1   2   >