[clang-tools-extra] 3219783 - [clang][clang-tools-extra] LLVM_NODISCARD => [[nodiscard]]. NFC

Author: Fangrui Song Date: 2022-08-09T07:11:18Z New Revision: 32197830ef5990d31b5582c9d497b2a96a1a381f URL: https://github.com/llvm/llvm-project/commit/32197830ef5990d31b5582c9d497b2a96a1a381f DIFF: https://github.com/llvm/llvm-project/commit/32197830ef5990d31b5582c9d497b2a96a1a381f.diff LOG:

[PATCH] D131468: [WIP][BPF]: Force sign/zero extension for arguments in callee and return values in caller

yonghong-song added a comment. In D131468#3708977 , @pengfei wrote: > D124435 is going to change the assumption > :) Thanks for the pointer. So looks like there is an effort to always do sign/zero-extension in callee.

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko added a comment. In D130847#3693668 , @aaron.ballman wrote: > These changes look reasonable, but I verified that the precommit CI failures > are valid -- it looks like this change broke a test somehow; perhaps a caller > was relying on the

[clang] d4ff9ef - [clang][ASTImporter] Improve import of functions with auto return type.

Author: Balázs Kéri Date: 2022-08-09T09:20:06+02:00 New Revision: d4ff9eff767c24716b5654780bc2e48c2017b4c5 URL: https://github.com/llvm/llvm-project/commit/d4ff9eff767c24716b5654780bc2e48c2017b4c5 DIFF: https://github.com/llvm/llvm-project/commit/d4ff9eff767c24716b5654780bc2e48c2017b4c5.diff L

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ff9eff767c: [clang][ASTImporter] Improve import of functions with auto return type. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:138 /// + /// `Call` must be either a `CallExpr` or a `CXXConstructExpr`. + /// How about we define overloads that take these types instead of taking

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added a comment. In D105255#3708258 , @abidmalikwaterloo wrote: > In D105255#3707533 , @clementval > wrote: > >> In D105255#3707495 , @raghavendhra >> wrote:

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

kadircet added a comment. looks like you've uploaded the diff without context, can you upload it again with full context? also the changes to `MaybeAddResult` seem to be missing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131088/new/ https://reviews.llvm.org/D131088 ___

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo created this revision. Herald added a project: All. dongjunduo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change the default storing path of `-ftime-trace`. We can use `-ftime-trace` or `-ftime-trace=` to switch on

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. I don't really want to bike-shed about the presentation for too long... I'm fine with just removing the parens, since we present it like that in the error message as well anyway: ./assert.cpp:6:1: error: static assertion failed due to requirement ''c' == 'a'' stati

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong marked an inline comment as done. ShawnZhong added a comment. In D131255#3706784 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? If so, what name and > email address would you like used for patch attribution? I'

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

sylvestre.ledru added a comment. We have this error in OpenMP: https://github.com/llvm/llvm-project/issues/57022 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___

[PATCH] D130689: [LLVM] Update C++ standard to 17

glandium added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) You didn't update llvm/cmake/platfo

[clang] af0052e - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2022-08-09T09:55:57+01:00 New Revision: af0052ef741f9bcfa3c7f0038d49f0cb1eaa59a4 URL: https://github.com/llvm/llvm-project/commit/af0052ef741f9bcfa3c7f0038d49f0cb1eaa59a4 DIFF: https://github.com/llvm/llvm-project/commit/af0052ef741f9bcfa3c7f0038d49f0cb1eaa59a4.diff

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > You didn't update l

[PATCH] D130689: [LLVM] Update C++ standard to 17

glandium added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) thieta wrote: > glandium wrote: > >

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > thieta wrote: > > g

[clang-tools-extra] d9e5462 - [clang-pseudo] Forest.h - don't inherit from std::iterator

Author: Simon Pilgrim Date: 2022-08-09T10:18:53+01:00 New Revision: d9e5462da61c3e2137a21a868a36f7022a39b59e URL: https://github.com/llvm/llvm-project/commit/d9e5462da61c3e2137a21a868a36f7022a39b59e DIFF: https://github.com/llvm/llvm-project/commit/d9e5462da61c3e2137a21a868a36f7022a39b59e.diff

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch updated this revision to Diff 451072. t-8ch added a comment. Rework tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews.llvm.org/D131067 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp clang/tes

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131479 Files: clang/lib/Sema/SemaDeclCXX.cpp clang

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson updated this revision to Diff 451085. Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112049/new/ https://reviews.llvm.org/D112049 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib

[clang] 0752999 - [Sema] Merge variable template specializations

Author: Ilya Biryukov Date: 2022-08-09T12:17:41+02:00 New Revision: 07529996d92b9fc0cc760f4e98d88b607f66e747 URL: https://github.com/llvm/llvm-project/commit/07529996d92b9fc0cc760f4e98d88b607f66e747 DIFF: https://github.com/llvm/llvm-project/commit/07529996d92b9fc0cc760f4e98d88b607f66e747.diff

[PATCH] D131258: [Sema] Merge variable template specializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ilya-biryukov marked 2 inline comments as done. Closed by commit rG07529996d92b: [Sema] Merge variable template specializations (authored by ilya-biryukov). Changed pr

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman updated this revision to Diff 451094. aaron.ballman added a comment. Herald added a project: clang-tools-extra. Rebased and fixing up clang-tools-extra tests caught by the precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131351/new/ https://reviews.llvm.org/D131

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D131307#3709083 , @sylvestre.ledru wrote: > We have this error in OpenMP: > https://github.com/llvm/llvm-project/issues/57022 That bug looks to be a true positive from this change. Repository: rG LLVM Github Monorep

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default dialect

aaron.ballman added a comment. I'm not opposed to this, but it should have a community RFC to give people notice that we'd like to change the default in case this will cause issues and people need a bit more time. It's also worth pointing out that GCC has already switched to gnu++17 as their de

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D131067#3705783 , @t-8ch wrote: > In D131067#3702044 , @steakhal > wrote: > >> Please, consider stati

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman added a comment. In D130894#3709027 , @tbaeder wrote: > I don't really want to bike-shed about the presentation for too long... I understand the desire, but at the same time, the whole goal of this patch is to improve the presentation of t

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch added a comment. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:537 + CallExpr::const_arg_range Args) { +for (const auto It : llvm::zip(FD->parameters(), Args)) { + if (!std::get<0>(It)->getType()->isReferenceTyp

[PATCH] D130974: [analyzer] Fix for the crash in #56873

steakhal added a comment. Some checker should have caught the uninitialized value earlier than the `defaultEvalCall()`. I guess, the `MallocCkecher` could have checked for it in `PreStmt`. Or alternatively, the `CallAndMessageChecker::preCall()` already does something like this in the `PreVisitP

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

JonChesterfield added a comment. Did some digging here. The function hsa_agent_get_info takes an argument of type hsa_agent_info_t, which has declared values in the range [0 24]. The implementation of that (in amd_gpu_agent fwiw) casts that argument to a size_t and then switches on it, checking

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D131307#3709494 , @JonChesterfield wrote: > Did some digging here. The function hsa_agent_get_info takes an argument of > type hsa_agent_info_t, which has declared values in the range [0 24]. The > implementation of th

[PATCH] D130974: [analyzer] Fix for the crash in #56873

isuckatcs added a comment. > Some checker should have caught the uninitialized value earlier than the > defaultEvalCall(). > I guess, the MallocCkecher could have checked for it in PreStmt. > Or alternatively, the CallAndMessageChecker::preCall() already does something > like this in the PreVisi

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch updated this revision to Diff 451117. t-8ch added a comment. - Inline tiny functions - Use structured binding - Rename findReferenceParameter -> findReferenceParameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https://reviews

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

aaron.ballman added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:882-884 const SrcMgr::SLocEntry &E = getLoadedSLocEntry(I); +if (E.getOffset() == 0) + return FileID(); // invalid entry. This looks incorrect to me -- I don't think

[clang] 1d1a569 - Clang: fix AST representation of expanded template arguments.

Author: Matheus Izvekov Date: 2022-08-09T14:26:16+02:00 New Revision: 1d1a56929b725f9a79d98877f12d0a14f8418b38 URL: https://github.com/llvm/llvm-project/commit/1d1a56929b725f9a79d98877f12d0a14f8418b38 DIFF: https://github.com/llvm/llvm-project/commit/1d1a56929b725f9a79d98877f12d0a14f8418b38.dif

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d1a56929b72: Clang: fix AST representation of expanded template arguments. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! LG with comment. Comment at: clang/lib/Driver/Driver.cpp:1638 llvm::opt::ArgStringList ArgList = NewLLDInvocation.getArguments(); -ArgList.push_back(Saver.sa

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default dialect

probinson added a comment. What Aaron said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10702 + +// If SafeStack or !StackProtector, kill_canary is not supported. +if (MF.getFunction().hasFnAttribute(Attribute::SafeStack) || Again, this comment is nothing

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:202 +class ForestNode::RecursiveIterator +: public std::iterator { + llvm::DenseSet Seen; tschuett wrote: > `std::iterator` is deprecated in C++17 and creates wa

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:882-884 const SrcMgr::SLocEntry &E = getLoadedSLocEntry(I); +if (E.getOffset() == 0) + return FileID(); // invalid entry. aaron.ballman wrote: > This looks incorrect t

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

zatrazz added a comment. This commit seems to have broken test-suite on aarch64 [1]. The warning shows: FAILED: MultiSource/Benchmarks/PAQ8p/CMakeFiles/paq8p.dir/paq8p.cpp.o /home/adhemerval.zanella/projects/llvm/test-suite-build/tools/timeit --summary MultiSource/Benchmarks/PAQ8p/CMakeFiles

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

aaron.ballman added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:882-884 const SrcMgr::SLocEntry &E = getLoadedSLocEntry(I); +if (E.getOffset() == 0) + return FileID(); // invalid entry. ivanmurashko wrote: > aaron.ballman wrote: >

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4739 + // set data storing path of the options `-ftime-trace`, `-ftime-trace=` + bool TimeTrace = C.getArgs().getLastArg(options::OPT_ftime_trace) != nullptr; It would be cleaner if all th

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:4371 +TEST(TransferTest, ContextSensitiveConstructorBody) { + std::string Code = R"(

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4786 +const std::string::size_type size = arg.size(); +char *buffer = new char[size + 1]; +memcpy(buffer, arg.c_str(), size + 1); Assert size not 0. Repository: rG

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D131307#3709595 , @zatrazz wrote: > This commit seems to have broken test-suite on aarch64 [1]. The warning shows: > > FAILED: MultiSource/Benchmarks/PAQ8p/CMakeFiles/paq8p.dir/paq8p.cpp.o > /home/adhemerval.zanella/proj

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm/prefer-isa-or-dyn-cast-in-conditionals.cpp:12-13 template bool isa(Y *); template Will the tests pass properly once the fixes are applied, even though the repla

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

whisperity removed a reviewer: bzcheeseman. whisperity added a comment. This revision now requires review to proceed. In D131319#3708667 , @bzcheeseman wrote: > This is great, thank you for doing this! I'm not a competent reviewer for the > actual clang

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 451133. pscoro added a comment. Small revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Ta

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:138 /// + /// `Call` must be either a `CallExpr` or a `CXXConstructExpr`. + /// sgatev wrote: > How about we define overloads that take these types

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep updated this revision to Diff 451134. samestep added a comment. Address Yitzie's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131438/new/ https://reviews.llvm.org/D131438 Files: clang/include/clang/Analysis/FlowSensitive/Dataf

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706424 , @aaron.ballman wrote: > In D130689#3706377 , @thieta wrote: > >> In D130689#3706336 , >> @aaron.ballman wrote: >> >>>

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple x86_64-unknown

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder updated this revision to Diff 451143. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel updated this revision to Diff 451144. ymandel marked an inline comment as done. ymandel added a comment. respond to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131280/new/ https://reviews.llvm.org/D131280 Files: clang/include

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel updated this revision to Diff 451145. ymandel marked 9 inline comments as done. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131280/new/ https://reviews.llvm.org/D131280 Files: clang/include/clang/Analy

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel added a comment. In D131280#3706988 , @xazax.hun wrote: > In D131280#3706915 , @ymandel wrote: > >> Sure. This is probably worth some discussion. Fully qualified names, however >> we define them, will not

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5445 + } +} + This function copies the two conditions for the if-statements from `evaluateTypeTrait()`. Is just doing it in `evaluateTypeTrait()` too late? Duplicating that seems bad.

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5445 + } +} + tbaeder wrote: > This function copies the two conditions for the if-statements from > `evaluateTypeTrait()`. Is just doing it in `evaluateTypeTrait()` too late? > Duplicatin

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

balazske added a comment. Another functions that can be added to the list: `atoi()`, `atol()`, `atoll()`, `atof()`. These are unsafe according to https://wiki.sei.cmu.edu/confluence/display/c/ERR34-C.+Detect+errors+when+converting+a+string+to+a+number. CHANGES SINCE LAST ACTION https://revie

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3709742 , @aaron.ballman wrote: > One thing I think would be a definite improvement is to have done an RFC on > Discourse for these changes so that downstreams have a chance to weigh in on > the impact. The patch was

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 __

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5445 + } +} + inclyc wrote: > tbaeder wrote: > > This function copies the two conditions for the if-statements from > > `evaluateTypeTrait()`. Is just doing it in `evaluateTypeTrait()` too

[PATCH] D131499: Change prototype merging error into a warning for builtins

aaron.ballman created this revision. aaron.ballman added reviewers: efriedma, jyknight, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. As was observed in https://reviews.llvm.org/D123627#3707635, it's confusing that

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3707789 , @aaron.ballman wrote: > In D123627#3707635 , @efriedma > wrote: > >> If the declaration we're redeclaring is a builtin, should the diagnostic be >> in the "-W

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

bzcheeseman added a comment. In D131319#3709671 , @whisperity wrote: > In D131319#3708667 , @bzcheeseman > wrote: > >> This is great, thank you for doing this! I'm not a competent reviewer for >> the actual cla

[clang] f53f2f2 - Extend ptr32 support to be applied on typedef

Author: Ariel Burton Date: 2022-08-09T11:08:52-04:00 New Revision: f53f2f232f794a257c270f4c273b9c9000421c81 URL: https://github.com/llvm/llvm-project/commit/f53f2f232f794a257c270f4c273b9c9000421c81 DIFF: https://github.com/llvm/llvm-project/commit/f53f2f232f794a257c270f4c273b9c9000421c81.diff

[PATCH] D130123: Extend ptr32 support to be applied on typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rGf53f2f232f79: Extend ptr32 support to be applied on typedef (authored by Ariel-Burton, committed by muiez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130

[PATCH] D131499: Change prototype merging error into a warning for builtins

erichkeane added inline comments. Comment at: clang/test/Sema/prototype-redecls.c:32 // clear that the previous declaration was a builtin. -float rintf() { // expected-error {{conflicting types for 'rintf'}} \ +float rintf() { // expected-warning {{incompatible redeclaration of

[PATCH] D131499: Change prototype merging error into a warning for builtins

aaron.ballman added inline comments. Comment at: clang/test/Sema/prototype-redecls.c:32 // clear that the previous declaration was a builtin. -float rintf() { // expected-error {{conflicting types for 'rintf'}} \ +float rintf() { // expected-warning {{incompatible redeclaration

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:70-76 +* Primary module interface unit. + +* Module implementation unit. + +* Module partition interface unit. + +* Module partition implementation unit. The terminology here is a bit diff

[PATCH] D131499: Change prototype merging error into a warning for builtins

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Agree with backporting to Clang15, that'll break the fewest users. Comment at: clang/test/Sema/prototype-redecls.c:32 // clear that the previous declaration was a bu

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

fcambus added a comment. Agreed, that makes sense. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128757/new/ https://reviews.llvm.org/D128757 ___ cfe-commits mailing list cfe-commits

[PATCH] D131499: Change prototype merging error into a warning for builtins

aaron.ballman added inline comments. Comment at: clang/test/Sema/prototype-redecls.c:32 // clear that the previous declaration was a builtin. -float rintf() { // expected-error {{conflicting types for 'rintf'}} \ +float rintf() { // expected-warning {{incompatible redeclaration

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

Hahnfeld added a comment. FWIW this also causes a `static_assert` failure while building ROOT : In file included from /home/jhahnfel/ROOT/src/tmva/tmva/src/DNN/Architectures/Cpu/CpuBuffer.cxx:17: In file included from /opt/rh/gcc-toolset-11/root/usr/l

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

xazax.hun added a comment. In D131280#3709781 , @ymandel wrote: > Thanks. That looks good, but I'm concerned that it only counts the arguments > and doesn't look at their types. I'd imagine this will be a limitation down > the line when we want to deal

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:225 + +It is possible to generate a module file for an importable module unit by specifying the ``--precompile`` option. + Likewise, here the term "Built Module Interface file", with the

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko updated this revision to Diff 451166. ivanmurashko added a comment. Use Invalid flag to detect invalid SLocEntry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/lib/Basic/Sourc

[clang] 4c02ab8 - Change prototype merging error into a warning for builtins

Author: Aaron Ballman Date: 2022-08-09T11:36:48-04:00 New Revision: 4c02ab8c9742f6c32b17f49a306b3b072486f5c5 URL: https://github.com/llvm/llvm-project/commit/4c02ab8c9742f6c32b17f49a306b3b072486f5c5 DIFF: https://github.com/llvm/llvm-project/commit/4c02ab8c9742f6c32b17f49a306b3b072486f5c5.diff

[PATCH] D131499: Change prototype merging error into a warning for builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c02ab8c9742: Change prototype merging error into a warning for builtins (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:70-76 +* Primary module interface unit. + +* Module implementation unit. + +* Module partition interface unit. + +* Module partition implementation unit. ruoso wrote: > The terminology

[clang] e486e48 - [clang] fix deprecation

Author: Thorsten Schütt Date: 2022-08-09T17:42:55+02:00 New Revision: e486e48c3d9e99e4c17d365bbc4b429c8e5b5999 URL: https://github.com/llvm/llvm-project/commit/e486e48c3d9e99e4c17d365bbc4b429c8e5b5999 DIFF: https://github.com/llvm/llvm-project/commit/e486e48c3d9e99e4c17d365bbc4b429c8e5b5999.dif

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

This revision was automatically updated to reflect the committed changes. Closed by commit rG82afc9b169a6: Fix -Wbitfield-constant-conversion on 1-bit signed bitfield (authored by ShawnZhong, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 82afc9b - Fix -Wbitfield-constant-conversion on 1-bit signed bitfield

Author: Shawn Zhong Date: 2022-08-09T11:43:50-04:00 New Revision: 82afc9b169a67e8b8a1862fb9c41a2cd974d6691 URL: https://github.com/llvm/llvm-project/commit/82afc9b169a67e8b8a1862fb9c41a2cd974d6691 DIFF: https://github.com/llvm/llvm-project/commit/82afc9b169a67e8b8a1862fb9c41a2cd974d6691.diff L

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. @aaron.ballman is this something you're comfortable reviewing or could recommend anyone else who might be suitable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ htt

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel added a comment. In D131280#3709964 , @xazax.hun wrote: > In D131280#3709781 , @ymandel wrote: > >> Thanks. That looks good, but I'm concerned that it only counts the arguments >> and doesn't look at thei

[PATCH] D122139: [pseudo] Introduce parse forest.

RKSimon added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:158 + size_t nodeCount() const { return NodeCount; } + size_t bytes() const { return Arena.getBytesAllocated() + sizeof(this); } + @hokein Static analysis is warni

[PATCH] D131388: [docs] Add "C++20 Modules"

dblaikie added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:31 + +This document was intended to be a manual first and foremost, however, we consider it helpful to +introduce some language background here for readers who are not familiar with

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm/prefer-isa-or-dyn-cast-in-conditionals.cpp:12-13 template bool isa(Y *); template whisperity wrote: > Will the tests pass properly once the fixes are applied, even

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

aaron.ballman added a comment. Oh wow that's an awful lot of pings without any response; I'm very sorry you had that experience, so thank you for tagging me to try to get this unstuck! The precommit CI test failures definitely look relevant and should be fixed up. Comment at:

[PATCH] D130894: [clang] Print more information about failed static assertions

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. In D130894#3709431 , @aaron.ballman wrote: > In D130894#3709027 , @tbaeder wrote: > >> I don't really want to bi

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:96 + } + Buf.LayoutStruct = llvm::StructType::get(EltTys[0]->getContext(), EltTys); +} Why are you manually inserting padding? IR level accesses don't require explicit layout, and we

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

aaron.ballman added a comment. Can you add test coverage for these changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131466/new/ https://reviews.llvm.org/D131466 ___ cfe-commits mailing list cfe-com

[PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. In D130689#3709834 , @thieta wrote: > In D130689#3709742 , @aaron.ballman > wrote: > >> One thing I think would be a definite improvement is to have done an RFC on >> Discourse for t

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3710281 , @royjacobson wrote: > In D130689#3709834 , @thieta wrote: > >> In D130689#3709742 , >> @aaron.ballman wrote: >> >>> O

[PATCH] D130894: [clang] Print more information about failed static assertions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for working on this, it's a great usability enhancement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 ___ cfe-c

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

inclyc updated this revision to Diff 451195. inclyc added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131466/new/ https://reviews.llvm.org/D131466 Files: clang/lib/AST/APValue.cpp clang/test/SemaCXX/try-print-as-s

[PATCH] D131314: [clang] format string checks for `InitListExpr`

aaron.ballman added a comment. In D131314#3707131 , @inclyc wrote: > ping FWIW, we usually only ping a review that hasn't had any activity in a week or more (it's not uncommon for reviews to sit for a few days while people think about them or reviewers

  1   2   3   >