[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

2022-09-18 Thread Lu Weining via Phabricator via cfe-commits
SixWeining created this revision. SixWeining added reviewers: xen0n, MaskRay, xry111, rengolin, myhsu, wangleiat, gonglingqin. Herald added subscribers: StephenFan, JDevlieghere, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang,

[clang] 981cbfb - [clang] Don't include StringSwitch.h (NFC)

2022-09-18 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-09-18T22:21:32-07:00 New Revision: 981cbfb5923139f7deff312ff3d2312bba0ce3d2 URL: https://github.com/llvm/llvm-project/commit/981cbfb5923139f7deff312ff3d2312bba0ce3d2 DIFF: https://github.com/llvm/llvm-project/commit/981cbfb5923139f7deff312ff3d2312bba0ce3d2.diff

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

2022-09-18 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 461131. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/clang/Sema/HLSLExternalSemaSource.h

[PATCH] D132285: [Clang][LoongArch] Implement ABI lowering

2022-09-18 Thread Lu Weining via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7d88a05cc01c: [Clang][LoongArch] Implement ABI lowering (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/

[clang] 7d88a05 - [Clang][LoongArch] Implement ABI lowering

2022-09-18 Thread Weining Lu via cfe-commits
Author: Weining Lu Date: 2022-09-19T12:05:00+08:00 New Revision: 7d88a05cc01c8d8950d88e96fd8516af67b10b8e URL: https://github.com/llvm/llvm-project/commit/7d88a05cc01c8d8950d88e96fd8516af67b10b8e DIFF: https://github.com/llvm/llvm-project/commit/7d88a05cc01c8d8950d88e96fd8516af67b10b8e.diff

[clang] b76da14 - [C++] [Modules] Generate the initializer for modules if we compile a

2022-09-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2022-09-19T11:30:34+08:00 New Revision: b76da14b3bfc1768d3dc9478b167b402a9ec308f URL: https://github.com/llvm/llvm-project/commit/b76da14b3bfc1768d3dc9478b167b402a9ec308f DIFF: https://github.com/llvm/llvm-project/commit/b76da14b3bfc1768d3dc9478b167b402a9ec308f.diff

[PATCH] D134007: [Clang][CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in DeviceActionBuilder.

2022-09-18 Thread WangLian via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed25e4df6a7: [CUDA][NFC] Rename addDeviceDepences to addDeviceDependences in… (authored by Jimerlife). Repository: rG LLVM Github Monorepo

[clang] 5ed25e4 - [CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in DeviceActionBuilder.

2022-09-18 Thread via cfe-commits
Author: wanglian Date: 2022-09-19T10:43:09+08:00 New Revision: 5ed25e4df6a705d63b4e81c274f8385a0a1188f9 URL: https://github.com/llvm/llvm-project/commit/5ed25e4df6a705d63b4e81c274f8385a0a1188f9 DIFF: https://github.com/llvm/llvm-project/commit/5ed25e4df6a705d63b4e81c274f8385a0a1188f9.diff

[clang] 298d08d - [NFC] Move the position of CodeGen/module-initializer*.cpp

2022-09-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2022-09-19T10:36:28+08:00 New Revision: 298d08dfa5509b5fa6595c297c7f9c878b460d29 URL: https://github.com/llvm/llvm-project/commit/298d08dfa5509b5fa6595c297c7f9c878b460d29 DIFF: https://github.com/llvm/llvm-project/commit/298d08dfa5509b5fa6595c297c7f9c878b460d29.diff

[PATCH] D134052: [clang-format] Disallow requires clauses to become function declarations

2022-09-18 Thread Emilia Dreamer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8dab45274000: [clang-format] Disallow requires clauses to become function declarations (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Emilia Dreamer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf63f0d1b6b: [clang-format] Disallow trailing return arrows to be operators (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/

[clang] 8dab452 - [clang-format] Disallow requires clauses to become function declarations

2022-09-18 Thread Emilia Dreamer via cfe-commits
Author: Emilia Dreamer Date: 2022-09-19T04:04:31+03:00 New Revision: 8dab452740007e03c963b349e716068eac2b25a0 URL: https://github.com/llvm/llvm-project/commit/8dab452740007e03c963b349e716068eac2b25a0 DIFF:

[clang] 0bf63f0 - [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Emilia Dreamer via cfe-commits
Author: Emilia Dreamer Date: 2022-09-19T04:04:31+03:00 New Revision: 0bf63f0d1b6b860a7134d668d3a28104c5c9afc1 URL: https://github.com/llvm/llvm-project/commit/0bf63f0d1b6b860a7134d668d3a28104c5c9afc1 DIFF:

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel added a comment. Thank you for the vote of confidence!! It went way more quickly than I expected; I now already have commit access! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

2022-09-18 Thread Xiang Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGedbf36c5e9e8: [HLSL] [clang] Add vector version of abs for HLSL (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/

[clang] edbf36c - [HLSL] [clang] Add vector version of abs for HLSL

2022-09-18 Thread Xiang Li via cfe-commits
Author: Xiang Li Date: 2022-09-18T14:59:30-07:00 New Revision: edbf36c5e9e84bb0e70ddbcacc20b14217688cba URL: https://github.com/llvm/llvm-project/commit/edbf36c5e9e84bb0e70ddbcacc20b14217688cba DIFF: https://github.com/llvm/llvm-project/commit/edbf36c5e9e84bb0e70ddbcacc20b14217688cba.diff

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

2022-09-18 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:4206 + else if (Arg.isZero()) +Result.makeInf(/* Negative = */ true); + else if (Arg.isInfinity()) This is the format as documented by clang-tidy bugprone argument comment see here:

[PATCH] D134146: [clang-format] Update removed brace's next token's WhitespaceRange

2022-09-18 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D134049#3798389 , @rymiel wrote: > In D134049#3798366 , @owenpan wrote: > >> Would you like to get commit access? See >>

[PATCH] D134145: [Clang] Implement fix for DR2628

2022-09-18 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement suggested fix for DR2628. Coulnd't update the DR docs because there hasn't been a new DRs index, but the

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

2022-09-18 Thread Dave Green via Phabricator via cfe-commits
dmgreen added reviewers: danielkiss, ilinpv. dmgreen added a comment. This looks like a subset of D133359 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134127/new/ https://reviews.llvm.org/D134127

[PATCH] D134143: [clang] Misc type sugar preservation improvements

2022-09-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WIP - Not ready for review Missing standalone tests. Signed-off-by: Matheus Izvekov Depends on D134115

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

2022-09-18 Thread Mészáros Gergely via Phabricator via cfe-commits
Maetveis requested changes to this revision. Maetveis added a comment. As discussed with @jamieschmeiser on D133662 , I have left suggestions regarding the approach I took for handling `-o` and passing the option to the jobs. I'm really happy to see this area

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D134049#3798389 , @rymiel wrote: > In D134049#3798366 , @owenpan wrote: > >> Would you like to get commit access? See >>

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

2022-09-18 Thread Shafik Yaghmour via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a37a6ce674: [Clang] Fix compat diagnostic to detect a nontype template parameter has a… (authored by shafik). Herald added a project: clang.

[clang] f8a37a6 - [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

2022-09-18 Thread Shafik Yaghmour via cfe-commits
Author: Shafik Yaghmour Date: 2022-09-18T11:54:32-07:00 New Revision: f8a37a6ce67470f9f6b3a4dacb65c637c2958b8d URL: https://github.com/llvm/llvm-project/commit/f8a37a6ce67470f9f6b3a4dacb65c637c2958b8d DIFF:

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel added a comment. In D134049#3798366 , @owenpan wrote: > Would you like to get commit access? See > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. I must humbly say that I do not think I qualify under "a track record of

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

2022-09-18 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 461088. shafik marked an inline comment as done. shafik added a comment. - Update wording in release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132990/new/ https://reviews.llvm.org/D132990 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

2022-09-18 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. In D133052#3792121 , @ilya-biryukov wrote: > It seems wrong to change semantics of initialization when instantiating > concept requirements. It implies that semantic checking may behave > differently inside requires expressions,

[PATCH] D133329: [Driver] Add --gcc-install-dir=

2022-09-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. I think you misunderstood me. The aforementioned tests fail if I put `--gcc-install-dir=` in the config file. There is no way to put it in the config file that wouldn't affect these tests right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

2022-09-18 Thread Mészáros Gergely via Phabricator via cfe-commits
Maetveis added a comment. In D133662#3798276 , @jamieschmeiser wrote: > I had an email exchange with @dongjunduo about this situation. He was a GSoC > student that @Whitney and I were mentoring for the past summer. He agrees > that your approach is

[PATCH] D134103: [clang-format] Skip token annotation in passes that don't need it

2022-09-18 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG93fcc80d1ceb: [clang-format] Skip token annotation in passes that dont need it (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D134103?vs=460966=461086#toc Repository: rG

[clang] 93fcc80 - [clang-format] Skip token annotation in passes that don't need it

2022-09-18 Thread via cfe-commits
Author: owenca Date: 2022-09-18T11:19:40-07:00 New Revision: 93fcc80d1ceba3a28f1aff402a91e1a427e66688 URL: https://github.com/llvm/llvm-project/commit/93fcc80d1ceba3a28f1aff402a91e1a427e66688 DIFF: https://github.com/llvm/llvm-project/commit/93fcc80d1ceba3a28f1aff402a91e1a427e66688.diff LOG:

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

2022-09-18 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. Would you like to get commit access? See https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049

[clang] abbe9c5 - [clang] Use x.empty() instead of llvm::empty(x) (NFC)

2022-09-18 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-09-18T11:07:50-07:00 New Revision: abbe9c561db3abccd00936f6b2fc5a8b7b5486bb URL: https://github.com/llvm/llvm-project/commit/abbe9c561db3abccd00936f6b2fc5a8b7b5486bb DIFF: https://github.com/llvm/llvm-project/commit/abbe9c561db3abccd00936f6b2fc5a8b7b5486bb.diff

[PATCH] D133329: [Driver] Add --gcc-install-dir=

2022-09-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D133329#3798166 , @mgorny wrote: > Hmm, apparently this could be achieved by making it a "CoreOption". I don't think it is appropriate to have `CoreOption`. The Windows dxc support appears to have nothing to do with gcc

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a subscriber: hubert.reinterpretcast. ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5455-5456 if (!ClangABICompat15) { - // Consider this a fix for CWG1432. Similar to the fix for CWG1395. auto *TST1 =

[clang-tools-extra] 3e720fa - Use std::decay_t (NFC)

2022-09-18 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-09-18T10:25:08-07:00 New Revision: 3e720fa9dce6cf4020c498c1e75be4c94dd5075d URL: https://github.com/llvm/llvm-project/commit/3e720fa9dce6cf4020c498c1e75be4c94dd5075d DIFF: https://github.com/llvm/llvm-project/commit/3e720fa9dce6cf4020c498c1e75be4c94dd5075d.diff

[clang] 5e5a6c5 - Use std::conditional_t (NFC)

2022-09-18 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-09-18T10:25:06-07:00 New Revision: 5e5a6c5b076046f546323dad68a3438b0c89a9e9 URL: https://github.com/llvm/llvm-project/commit/5e5a6c5b076046f546323dad68a3438b0c89a9e9 DIFF: https://github.com/llvm/llvm-project/commit/5e5a6c5b076046f546323dad68a3438b0c89a9e9.diff

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5179-5231 if (!Better1 && !Better2) // Neither is better than the other return JudgeByConstraints(); // C++ [temp.deduct.partial]p11: // ... and if G has a trailing function

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5179-5231 if (!Better1 && !Better2) // Neither is better than the other return JudgeByConstraints(); // C++ [temp.deduct.partial]p11: // ... and if G has a trailing function

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5455-5456 if (!ClangABICompat15) { - // Consider this a fix for CWG1432. Similar to the fix for CWG1395. auto *TST1 = T1->castAs(); auto *TST2 = T2->castAs(); +

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5455-5456 if (!ClangABICompat15) { - // Consider this a fix for CWG1432. Similar to the fix for CWG1395. auto *TST1 = T1->castAs(); auto *TST2 = T2->castAs(); + const

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5179-5231 if (!Better1 && !Better2) // Neither is better than the other return JudgeByConstraints(); // C++ [temp.deduct.partial]p11: // ... and if G has a trailing function

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

2022-09-18 Thread Jamie Schmeiser via Phabricator via cfe-commits
jamieschmeiser added a comment. I had an email exchange with @dongjunduo about this situation. He was a GSoC student that @Whitney and I were mentoring for the past summer. He agrees that your approach is cleaner. There appears to be two parts to your work. First, you implemented the

[PATCH] D134137: [clangd] Return earlier when snippet is empty

2022-09-18 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5455-5456 if (!ClangABICompat15) { - // Consider this a fix for CWG1432. Similar to the fix for CWG1395. auto *TST1 = T1->castAs(); auto *TST2 = T2->castAs(); +

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

2022-09-18 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron added inline comments. Comment at: clang/test/Sema/constant-builtins-math.cpp:16-17 + +// TODO: investigate why this is `INT_MIN + 1` instead of `INT_MIN` +static_assert(__builtin_ilogb(0.0) == -2147483647); +static_assert(__builtin_ilogb(__builtin_inf()) == 2147483647);

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

2022-09-18 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron added inline comments. Comment at: clang/test/Sema/constant-builtins-math.cpp:16-17 + +// TODO: investigate why this is `INT_MIN + 1` instead of `INT_MIN` +static_assert(__builtin_ilogb(0.0) == -2147483647); +static_assert(__builtin_ilogb(__builtin_inf()) == 2147483647);

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

2022-09-18 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron added a comment. libc++ doesn't support constexpr-related patches from C++20 in ``: see issue https://github.com/llvm/llvm-project/issues/55370 I reviewed the code in `` and found out that since we use a dozen of math functions, we need to support more constexpr builtin math function.

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

2022-09-18 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron created this revision. Izaron added reviewers: cor3ntin, aaron.ballman. Herald added a subscriber: hiraditya. Herald added a project: All. Izaron requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Support constexpr

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

2022-09-18 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 461072. pengfei added a comment. Missing a `!`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

2022-09-18 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 461071. pengfei added a comment. Address review comments. Thanks @rnk! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920 Files: clang/docs/ReleaseNotes.rst

[clang] 2f8a4ac - [Clang][NFC] update predicate and reduce redundant check

2022-09-18 Thread Phoebe Wang via cfe-commits
Author: Phoebe Wang Date: 2022-09-18T21:56:31+08:00 New Revision: 2f8a4acf1ad7790a82619932b198b7b7d07cd027 URL: https://github.com/llvm/llvm-project/commit/2f8a4acf1ad7790a82619932b198b7b7d07cd027 DIFF: https://github.com/llvm/llvm-project/commit/2f8a4acf1ad7790a82619932b198b7b7d07cd027.diff

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

2022-09-18 Thread Liming Liu via Phabricator via cfe-commits
lime added a comment. In D134128#3798127 , @cor3ntin wrote: > Thanks for working on this. > I'll be honest though, I still have absolutely no understanding what the use > cases or intents of this features are. I think we were waiting for core to >

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

2022-09-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stddef.h:12 + +using size_t = long long unsigned; + barcisz wrote: > njames93 wrote: > > If this is all the file is used for, and it's only used for this

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

2022-09-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134112/new/ https://reviews.llvm.org/D134112

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

2022-09-18 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders abandoned this revision. tom-anders added a comment. Split up into 3 smaller patches: https://reviews.llvm.org/D134130, https://reviews.llvm.org/D134131 and https://reviews.llvm.org/D134132 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134132: [clangd] Add doxygen parsing for Hover [3/3]

2022-09-18 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders created this revision. Herald added subscribers: wenlei, kadircet, arphaman. Herald added a project: All. tom-anders added reviewers: nridge, sammccall, kadircet. tom-anders published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D134131: [clangd] Use doxygen parsing for Hover [2/3]

2022-09-18 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders added reviewers: nridge, sammccall, kadircet. tom-anders published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D133329: [Driver] Add --gcc-install-dir=

2022-09-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Hmm, apparently this could be achieved by making it a "CoreOption". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 ___ cfe-commits

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

2022-09-18 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders added reviewers: nridge, sammccall, kadircet. tom-anders published this revision for review. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

2022-09-18 Thread Jun Zhang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG303526ef3aa2: [Docs] Add a link that refers to C++ standard modules in Clang modules doc (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D134105?vs=461040=461058#toc

[clang] 303526e - [Docs] Add a link that refers to C++ standard modules in Clang modules doc

2022-09-18 Thread Jun Zhang via cfe-commits
Author: Jun Zhang Date: 2022-09-18T18:31:49+08:00 New Revision: 303526ef3aa211c1930be2885deae15eeeda3b18 URL: https://github.com/llvm/llvm-project/commit/303526ef3aa211c1930be2885deae15eeeda3b18 DIFF: https://github.com/llvm/llvm-project/commit/303526ef3aa211c1930be2885deae15eeeda3b18.diff

[PATCH] D133329: [Driver] Add --gcc-install-dir=

2022-09-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. Unfortunately, we have some test failures after this change, e.g.: FAIL: Clang :: CodeGenHLSL/basic_types.hlsl (6525 of 15795) TEST 'Clang ::

[clang] 490de4a - [Clang][NFC] update obsolete check predicate

2022-09-18 Thread Phoebe Wang via cfe-commits
Author: Phoebe Wang Date: 2022-09-18T18:00:36+08:00 New Revision: 490de4ab47c8e22f7a48d9da785390e23df9e25f URL: https://github.com/llvm/llvm-project/commit/490de4ab47c8e22f7a48d9da785390e23df9e25f DIFF: https://github.com/llvm/llvm-project/commit/490de4ab47c8e22f7a48d9da785390e23df9e25f.diff

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

2022-09-18 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Thanks for working on this. I'll be honest though, I still have absolutely no understanding what the use cases or intents of this features are. I think we were waiting for core to clarify and I'm not sure they did. This does seem to implement the wording though...

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

2022-09-18 Thread Liming Liu via Phabricator via cfe-commits
lime created this revision. lime added reviewers: aaron.ballman, h-vetinari, erichkeane, cor3ntin, tahonermann. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. This function had been submitted by

[clang] 7629621 - [Modules] Don't judge if we're compiling a module unit by LangOpts::CurrentModule.empty()

2022-09-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2022-09-18T16:43:30+08:00 New Revision: 762962174e3adab1a0d744fe2636d4d9fb373c53 URL: https://github.com/llvm/llvm-project/commit/762962174e3adab1a0d744fe2636d4d9fb373c53 DIFF: https://github.com/llvm/llvm-project/commit/762962174e3adab1a0d744fe2636d4d9fb373c53.diff

[PATCH] D133329: [Driver] Add --gcc-install-dir=

2022-09-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Ok, this works fine for me (though I haven't run the tests yet). If D109621 and this one lands, I think the old Gentoo logic can be removed. We'll still

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

2022-09-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 461054. mgorny added a comment. Fix documentation formatting. While at it, fix a doc mistake that referenced `x86_64-cl.cfg` instead of the correct `x86_64-clang-cl.cfg`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5455-5456 if (!ClangABICompat15) { - // Consider this a fix for CWG1432. Similar to the fix for CWG1395. auto *TST1 = T1->castAs(); auto *TST2 = T2->castAs(); + const

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

2022-09-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: DavidSpickett, dmgreen, john.brawn. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

2022-09-18 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 461051. ychen added a comment. - address comments - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

2022-09-18 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

2022-09-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/Modules.rst:107-108 + +.. note:: + This pages mainly talks about the Clang modules extension and describes some

[PATCH] D133329: [Driver] Add --gcc-install-dir=

2022-09-18 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. At a first glance, it works. I'm now building GCC:11 here to test it against two real installations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329

[clang] 4667821 - [NFC] Typo fix in ARCMTActions.h

2022-09-18 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2022-09-18T12:34:24+05:30 New Revision: 46678211512238159199a5857e9f9d774016060c URL: https://github.com/llvm/llvm-project/commit/46678211512238159199a5857e9f9d774016060c DIFF: https://github.com/llvm/llvm-project/commit/46678211512238159199a5857e9f9d774016060c.diff