[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

pengfei abandoned this revision. pengfei added a comment. This is not needed anymore, thanks @RKSimon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 ___ cfe-co

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. @dblaikie I am confusing about your concern. For the test coverage example, on the one hand, it is completely different from the case the coverage report was generated in the runtime instead of the compile time. On the other hand, it also provides a `-fprofile-dir` op

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:1071 return 1; // Check for AVX-512 scatter which has a TIED_TO in the second to last // operand. craig.topper wrote: > This comment is out of da

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

xen0n added a comment. I've formatted the patch summary for you. Please familiarize yourself with Markdown syntax so next time your rendering would look better. In D136413#3873317 , @tangyouling wrote: > Do we need to add the definition of the `__loong

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

MaskRay added inline comments. Comment at: clang/test/Driver/x86-march.c:120 +// RUN: | FileCheck %s -check-prefix=meteorlake +// meteorlake: "-target-cpu" "meteorlake" // RKSimon wrote: > Move these after alderlake instead of the old atom cores? And use `--ta

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining updated this revision to Diff 469472. SixWeining added a comment. Add tests for more `-mfpu` and `-mabi` combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136413/new/ https://reviews.llvm.org/D136413 Files: clang/lib/Basic/T

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34020d39b8a1: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C… (authored by mwyman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[clang] 34020d3 - Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

Author: Michael Wyman Date: 2022-10-20T22:42:24-07:00 New Revision: 34020d39b8a116770aad0b5ad1a450e6e22da5cd URL: https://github.com/llvm/llvm-project/commit/34020d39b8a116770aad0b5ad1a450e6e22da5cd DIFF: https://github.com/llvm/llvm-project/commit/34020d39b8a116770aad0b5ad1a450e6e22da5cd.diff

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

NoQ added a comment. Yay I'm glad that you got to implement that!! > I'd appreciate if the "storing uninitialized value" was placed inside the > notes about the call to QScopedArrayPointer's constructor. It should not be placed inside the notes about the call to constructor, because it doesn't

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe marked 4 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:1026 +let Predicates = [HasCMPCCXADD, In64BitMode], Defs = [EFLAGS], +Constraints = "$dstsrc2 = $dst" in { craig.topper wrote: >

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

NoQ added inline comments. Comment at: clang/test/Analysis/region-store.c:66 + // expected-warning@+1 {{passing arguments to 'b' without a prototype is deprecated in all versions of C and is not supported in C2x}} + b(&buffer); +} steakhal wrote: > tomasz-kami

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

NoQ added a comment. Ok so you're saying that it's not just a wrong Decl but there's like an entire cast-expression missing in the AST? This fix is probably good enough for us but it begs a question, what does CodeGen do in such cases? Does it also need to emit a cast instruction into LLVM IR t

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:970 .Case("xsaveopt", true) + .Case("cmpccxadd", true) .Default(false); This list is alphabetized or was supposed to be Comment at: clang/lib/Bas

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

luojia added a comment. Hello! Any further updates to this patch? It seems like all the inline comments have been resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 _

[PATCH] D136416: [AST] Support Bool type in va_arg

Qfrost911 created this revision. Qfrost911 added reviewers: aaron.ballman, shafik. Herald added a project: All. Qfrost911 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. void test(int place_holder, ...) { va_list args; v

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. > Its not a priority, but if you are ever bored and want to do some cleaning > then it help! I see. Then we are on the same side. I'll clean if I had time after landing these patches. Repository: rG LLVM Github Monorepo C

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

tangyouling added a comment. Do we need to add the definition of the `__loongarch64` macro? gcc has that definition (but it is not recommended to use it, just for compatibility with previous code). It has been used in some projects before, such as linux kernel, libunwind etc. Repository: rG

[PATCH] D136343: [Lex] Add compatibility with MSVC

Qfrost911 added a comment. I understand you mean, but I can't get function name at macro expedition stage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136343/new/ https://reviews.llvm.org/D136343 ___ c

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:259 +"Support CMPCCXADD instructions", +[FeatureAVX2]>; def FeatureINVPCID : SubtargetFeature<"invpcid", "HasINVPCID", "true", -

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining added a comment. In D136413#3873216 , @xry111 wrote: > Do we support `--target=loongarch64 -mabi=ilp32d` or `-mfpu=64 -mabi=lp64s` > combinations now? If true I think we'll need test cases for such > combinations. For `--target=loongarch64

[PATCH] D136397: [Clang] Change AnonStructIds in MangleContext to per-function based

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/include/clang/AST/Mangle.h:97 + +// If FunctionDecl is passed in, the anonnousstructID will be per-function +// based. ---

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:110 INTEL_COREI7_ROCKETLAKE, + ZHAOXIN_FAM7H_LUJIAZUI, + INTEL_COREI7_RAPTORLAKE, skan wrote: > typo ? (ZHAOXIN_FAM7H_LUJIAZUI) I thin

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

xry111 added a comment. Do we support `--target=loongarch64 -mabi=ilp32d` or `-mfpu=64 -mabi=lp64s` combinations now? If true I think we'll need test cases for such combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136413/new/ https://r

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

0x59616e added a comment. I can only nitpick some of the peripheral issues since I have no knowledge in most of the part of clang. Perhaps implementing the new standard feature is too arduous for a tyro like me. It's great to see the real expert to complete this. Comment at:

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

skan added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:110 INTEL_COREI7_ROCKETLAKE, + ZHAOXIN_FAM7H_LUJIAZUI, + INTEL_COREI7_RAPTORLAKE, typo ? (ZHAOXIN_FAM7H_LUJIAZUI) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, tangyouling, wangleiat, gonglingqin. Herald added a subscriber: StephenFan. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth updated this revision to Diff 469446. paulkirth added a comment. Code Cleanups and Test Cases - Replace SmallVector with SmallPtrSet - Add some comments/clarification - Add a larger, more flexible test case There's still room for improvement for both testing and documentation. Reposi

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. Thanks for the latest updates. The duplication is still my main concern here. See below. Comment at: openmp/libomptarget/src/api.cpp:343 +static int __kmpc_target_memcpy_rect_async_helper(kmp_int32 Gtid, +

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai updated this revision to Diff 469444. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/AST/ODRDiag

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 469443. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130326/new/ https://reviews.llvm.org/D130326 Files: clang/include/clang/AST/ODRDiagsEmitter.h clang/include/clang/Basi

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

dmaclach accepted this revision. dmaclach added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 ___ cfe-commits mailing list cfe-commi

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

qiongsiwu1 updated this revision to Diff 469428. qiongsiwu1 added a comment. Rebase and cleanup some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135885/new/ https://reviews.llvm.org/D135885 Files: clang/test/Driver/lto-aix.c Inde

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D136399: [clang-tidy][modernize-use-equals-default] Avoid adding unnecessary semicolon

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: gribozavr2, ymandel, alexfh, LegalizeAdulthood. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-s

[PATCH] D136397: [Clang] Change AnonStructIds in MangleContext to per-function based

xur created this revision. xur added reviewers: rsmith, davidxl. Herald added a subscriber: wenlei. Herald added a project: All. xur requested review of this revision. Clang is generating different mangled names for the same lambda function in build that are slightly different (like from non-rela

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Friendly ping for reviewers since (I think) this is more or less complete. Additionally, I found out that the GCC implementation [0] allows references to aggregates to be paren-initialized - i.e. it accepts the following: struct A { int a; int b; }; const A

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 469411. ayzhao added a comment. Update ReleaseNotes.rst and cxx_status.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6052 +} else if (S.getLangOpts().CPlusPlus20 && !TopLevelOfInitList) + TryOrBuildParenListInitialization(S, Entity, Kind, Args, *this, +/*VerifyOnly=*/true); ---

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 469406. ayzhao added a comment. add test for p1975r0 static_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136017/new/ https://reviews.llvm.org/D136017 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:574 +/// 3) Initialized global with index \I with that +template ::T> +bool InitGlobalTemp(InterpState &S, CodePtr OpPC, uint32_t I, tbaeder wrote: > shafik wrote: > > Is `Name` really a `Typ

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

shafik accepted this revision. shafik added a comment. LGTM, thanks for explaining what I was missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136036/new/ https://reviews.llvm.org/D136036 ___ cfe-c

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. In D135920#3872705 , @shafik wrote: > Apologies for the late reply but after the last changes to the diagnostic > messages are much better. Thanks! Sorry I jumped the gun and submitted before your reply... Repository: rG LLVM G

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

shafik added a comment. Apologies for the late reply but after the last changes to the diagnostic messages are much better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 ___

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 469393. ayzhao added a comment. Add test for p1975r0 and add fix (hack?) for IK_COPY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Ind

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde9731b7033f: [clang][lex] Avoid `DirectoryLookup` copies (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] de9731b - [clang][lex] Avoid `DirectoryLookup` copies

Author: Jan Svoboda Date: 2022-10-20T16:12:34-07:00 New Revision: de9731b7033f0393144299d19765a16cb6ae331f URL: https://github.com/llvm/llvm-project/commit/de9731b7033f0393144299d19765a16cb6ae331f DIFF: https://github.com/llvm/llvm-project/commit/de9731b7033f0393144299d19765a16cb6ae331f.diff L

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG283e0a81ef35: [clang] Correct sanitizer behavior in union FAMs (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews

[clang] 283e0a8 - [clang] Correct sanitizer behavior in union FAMs

Author: Bill Wendling Date: 2022-10-20T16:08:11-07:00 New Revision: 283e0a81ef35deec46aa231cb8b9d826060f532a URL: https://github.com/llvm/llvm-project/commit/283e0a81ef35deec46aa231cb8b9d826060f532a DIFF: https://github.com/llvm/llvm-project/commit/283e0a81ef35deec46aa231cb8b9d826060f532a.diff

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

This revision was automatically updated to reflect the committed changes. Closed by commit rG464926ef4484: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for… (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D133668?vs=469373&id=469387#toc R

[clang] 464926e - [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

Author: Xiang Li Date: 2022-10-20T16:06:25-07:00 New Revision: 464926ef4484e4cb2d410fd2e959a296d7b8d58e URL: https://github.com/llvm/llvm-project/commit/464926ef4484e4cb2d410fd2e959a296d7b8d58e DIFF: https://github.com/llvm/llvm-project/commit/464926ef4484e4cb2d410fd2e959a296d7b8d58e.diff LOG:

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

kees added a comment. This looks great to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019 ___

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 updated this revision to Diff 469385. jansvoboda11 added a comment. Remove regression tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019 Files: clang/lib/Lex/HeaderSearch.cpp Index: c

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 469373. python3kgae added a comment. Fix clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/include/clang/AST/ASTContext.h clang/inclu

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6052 +} else if (S.getLangOpts().CPlusPlus20 && !TopLevelOfInitList) + TryOrBuildParenListInitialization(S, Entity, Kind, Args, *this, +/*VerifyOnly=*/true); ---

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6052 +} else if (S.getLangOpts().CPlusPlus20 && !TopLevelOfInitList) + TryOrBuildParenListInitialization(S, Entity, Kind, Args, *this, +/*VerifyOnly=*/true); ---

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rG90d42b1cab04: [clang-tidy] Skip private default ctors in modernize-use-equals-default (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] 90d42b1 - [clang-tidy] Skip private default ctors in modernize-use-equals-default

Author: Alexander Shaposhnikov Date: 2022-10-20T22:04:33Z New Revision: 90d42b1cab04b76e9e934f1e5076f014d1195e72 URL: https://github.com/llvm/llvm-project/commit/90d42b1cab04b76e9e934f1e5076f014d1195e72 DIFF: https://github.com/llvm/llvm-project/commit/90d42b1cab04b76e9e934f1e5076f014d1195e72.d

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. >> (I'd still sort of lean towards "make it the same as the .o, but with the >> .pcm suffix" and if the build system wants to put things in other places, it >> can move them around - but I understand why that's not something everyone's >> on board with) > > Actually, I

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added a comment. I would be more comfortable with exposing something like `clang_CXXRecord_hasAnyNonDeletedDefaultConstructor`. It's better than the confusing `clang_CXXRecord_needsImplicitDefaultConstructor` but it would still be different from the usual type traits in a subtle way

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void updated this revision to Diff 469360. void added a comment. Add "real" FAM to testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 Files: clang/lib/AST/Expr.cpp clang/test/CodeGen/bounds-che

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. > you would get something like `S int, Length>{.value = 50}}, .width = Width{StrongTypedef Width>{.value = 70}}}>` (inspired by this GCC output), which is truly > verbose. However, the current way of printing (assuming member names are > printed) it would print somethin

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void updated this revision to Diff 469355. void added a comment. Update to support SemaCXX tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 Files: clang/lib/AST/Expr.cpp clang/test/CodeGen/bound

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added a comment. In D135557#3871803 , @aaron.ballman wrote: > In D135557#3871716 , @dblaikie > wrote: > >> (I'm still sort of curious how the AST matchers deal with all this - I guess >> they must have

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (auto

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (auto

[clang] a7183a1 - [NFC] [DirectX backend] move ResourceClass into llvm.

Author: Xiang Li Date: 2022-10-20T13:26:56-07:00 New Revision: a7183a158d68d97902aeb2015a5cac5e36ae84c5 URL: https://github.com/llvm/llvm-project/commit/a7183a158d68d97902aeb2015a5cac5e36ae84c5 DIFF: https://github.com/llvm/llvm-project/commit/a7183a158d68d97902aeb2015a5cac5e36ae84c5.diff LOG:

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7183a158d68: [NFC] [DirectX backend] move ResourceClass into llvm. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D

[clang] 922f42d - [clang][AIX] Fix mcount name and call arguments

Author: Michael Francis Date: 2022-10-20T16:20:00-04:00 New Revision: 922f42d531b873db59fce81aefa4dcaae999d5ce URL: https://github.com/llvm/llvm-project/commit/922f42d531b873db59fce81aefa4dcaae999d5ce DIFF: https://github.com/llvm/llvm-project/commit/922f42d531b873db59fce81aefa4dcaae999d5ce.dif

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 469334. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

carlocab added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2136 +} else { +sdk = "macosx"; +} Since we’re already doing a bunch of triple checks above, it probably doesn’t hurt to check that we really are targeting macOS h

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void added a comment. @kees @serge-sans-paille I think this is ready for another go. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 ___ cfe-commits maili

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void updated this revision to Diff 469332. void added a comment. Update testcases to pass tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 Files: clang/lib/AST/Expr.cpp clang/test/CodeGen/bounds

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn updated this revision to Diff 469329. fhahn added a comment. Rebased on current main In D122573#3630767 , @rui.zhang wrote: > I like the direction where this change is leading to and hope there is some > way to land it incrementally. Since Builtin

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469328. jz10 added a comment. redo the proper patch, i.e. get rid of content related to clang/doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/libomptarget/include/interop.h openmp/libomp

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

rjmccall accepted this revision. rjmccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

This revision was automatically updated to reflect the committed changes. Closed by commit rGf911598bd440: [clang][AIX] Omitting Explicit Debugger Tuning Option (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] f911598 - [clang][AIX] Omitting Explicit Debugger Tuning Option

Author: Qiongsi Wu Date: 2022-10-20T15:16:31-04:00 New Revision: f911598bd440182b1383aa570de66a574d468a42 URL: https://github.com/llvm/llvm-project/commit/f911598bd440182b1383aa570de66a574d468a42 DIFF: https://github.com/llvm/llvm-project/commit/f911598bd440182b1383aa570de66a574d468a42.diff LO

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb76219b59020: [clang][Sema] Use correct array size for diagnostic (authored by void). Repository: rG LLVM Github Monore

[clang] b76219b - [clang][Sema] Use correct array size for diagnostic

Author: Bill Wendling Date: 2022-10-20T11:56:49-07:00 New Revision: b76219b590208c1b539e614247f91481900bd7a1 URL: https://github.com/llvm/llvm-project/commit/b76219b590208c1b539e614247f91481900bd7a1 DIFF: https://github.com/llvm/llvm-project/commit/b76219b590208c1b539e614247f91481900bd7a1.diff

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. Just in case you assume that I have push permission, unfortunately I do not. Could you help me merge the patch in? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136203/new/ https://reviews.llvm.org/D136203 ___

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, tblah wrote: > vzakhari wrote: > > tblah wrote: > > > awarzynski wrote: > > > > What are these pragmas? Perhaps you c

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

reames added a comment. Just want to note that I have no strong opinion on this patch. It doesn't seem unreasonable, and I'm comfortable with this being an empirically driven decision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ ht

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron added inline comments. Comment at: clang/unittests/Support/TimeProfilerTest.cpp:197-198 + + // NOTE: If this test is failing, run this test with + // `llvm::errs() << TraceGraph;` and change the assert above. +} aaron.ballman wrote: > This bit worries me

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" beanz wrote: > python3kgae wrote: > > python3kgae wrote: > > > beanz wrote: > > > > You need

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae updated this revision to Diff 469302. python3kgae marked an inline comment as done. python3kgae added a comment. Add FrontendHLSL to Sema link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136134/new/ https://reviews.llvm.org/D136134 F

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. Looks like binutils-gdb commit 329e276daf98fb4c8b3770a6c2f02fd22472a638 ("Add support for a -g switch to GAS") added support for -g. (I think the 2.15 release) But that was in 2004; llvm commit 3db3a3b0d5c56dc7da843236e244307c4ac64860 was in 2016... Repositor

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers updated this revision to Diff 469300. nickdesaulniers added a comment. - delete test from clang/test/Driver/gcc_forward.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llvm.org/D136309 Files: clang/lib

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. Hmm... looks like this regresses 3db3a3b0d5c56dc7da843236e244307c4ac64860; I wonder what PR it was referring to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llvm.org/D136309 _

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a naming quirk, LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:726 + } else if (const auto *IVIE = dyn_cast(Initializer)) { +const Ar

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

beanz added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" python3kgae wrote: > python3kgae wrote: > > beanz wrote: > > > You need to add FrontendHLSL to the

[PATCH] D136022: [clang] Add time profile for constant evaluation

aaron.ballman added inline comments. Comment at: clang/unittests/Support/TimeProfilerTest.cpp:197-198 + + // NOTE: If this test is failing, run this test with + // `llvm::errs() << TraceGraph;` and change the assert above. +} This bit worries me because I suspe

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" python3kgae wrote: > beanz wrote: > > You need

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

aaron.ballman added a comment. Thank you for the fix! Can you add test coverage to show the behavioral change? You can either position the problematic null argument on its own line (so you can validate the correct position) or use `-fdiagnostics-print-source-range-info` to check a specific ran

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added a comment. In D135557#3871716 , @dblaikie wrote: > (I'm still sort of curious how the AST matchers deal with all this - I guess > they must have Sema available, because I'd assume they make all sorts of > queries like "is this constr

[PATCH] D136090: Handle errors in expansion of response files

sepavloff updated this revision to Diff 469286. sepavloff added a comment. Make UTF-16 string properly aligned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/ https://reviews.llvm.org/D136090 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. In D136309#3871769 , @MaskRay wrote: > (Note that assembler synthesized debug info for assembly files is a very > minor feature. I don't know why the Linux kernel is so fond of it..). This is _required_ for symbolicating

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

MaskRay added a comment. (Note that assembler synthesized debug info for assembly files is a very minor feature. I don't know why the Linux kernel is so fond of it..). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llvm.

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

MaskRay added inline comments. Comment at: clang/test/Driver/as-options.s:120 + +// Test that -g is passed through to GAS. +// RUN: %clang -fno-integrated-as -g %s -### 2>&1 | \ nickdesaulniers wrote: > MaskRay wrote: > > -g can be tested along with other pass-th

  1   2   >