[PATCH] D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

brad created this revision. brad added a reviewer: atanasyan. brad added a project: clang. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: All. brad requested review of this revision. Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I Repository: r

[PATCH] D140970: [BPF] preserve btf_decl_tag for parameters of extern functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG58bdf8f9a8c3: [BPF] preserve btf_decl_tag for parameters of extern functions (authored by eddyz87, committed by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D140970?vs=486295&id=487

[clang] 58bdf8f - [BPF] preserve btf_decl_tag for parameters of extern functions

Author: Eduard Zingerman Date: 2023-01-06T22:48:52-08:00 New Revision: 58bdf8f9a8c3331c6c4d5f631395fb6f786d1e9c URL: https://github.com/llvm/llvm-project/commit/58bdf8f9a8c3331c6c4d5f631395fb6f786d1e9c DIFF: https://github.com/llvm/llvm-project/commit/58bdf8f9a8c3331c6c4d5f631395fb6f786d1e9c.di

[PATCH] D140970: [BPF] preserve btf_decl_tag for parameters of extern functions

yonghong-song accepted this revision. yonghong-song added a comment. This revision is now accepted and ready to land. LGTM. I will add `// REQUIRES: bpf-registered-target` in the test to ensure it only executed with bpf target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140073/new/ https://reviews.llvm.org/D140073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 487045. vsapsai added a comment. Serialize/deserialize `ObjCInterfaceTypeLoc::NameEndLoc` as it is used in diagnostic about a mismatching superclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140073/new/ h

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. Thank you for reviewing and giving suggestions! @cjdb Hope there are enough test cases now, and not too many tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/ne

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry updated this revision to Diff 487044. v1nh1shungry added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107 Files: clang-tools-extra/clang-tidy/bugprone/StandaloneEmp

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 487043. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140073/new/ https://reviews.llvm.org/D140073 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/AST/ODRDiag

[PATCH] D141050: [standalone-build] outsource, simplify and unify repetitive CMake code

phosek added inline comments. Comment at: clang/CMakeLists.txt:35 + include(StandaloneBuildHelpers) + get_llvm_utility_binary_path("llvm-tblgen" "LLVM_TABLEGEN_EXE") It's somewhat unusual to quote output variable names in our CMake files, I'd prefer to follo

[clang] faa29ee - [Clang] Fix warning on unused varaible

Author: Joseph Huber Date: 2023-01-06T21:14:31-06:00 New Revision: faa29ee0f9c941b193161ad48a46713a04a81163 URL: https://github.com/llvm/llvm-project/commit/faa29ee0f9c941b193161ad48a46713a04a81163 DIFF: https://github.com/llvm/llvm-project/commit/faa29ee0f9c941b193161ad48a46713a04a81163.diff

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

rymiel added a comment. > I think we should combine `DeriveLineEnding` and `UseCRLF` Do you mean a single `LineEnding` options which is an enum with `LF`, `CRLF` and `Derive`, or similar? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw created this revision. theo-lw added a reviewer: aaron.ballman. Herald added a project: All. theo-lw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This changes the diagnostic for _Alignas so it no longer tells people to place _Al

[clang] cf97ee7 - [Clang] Fix mispelled option passed to the linker wrapper

Author: Joseph Huber Date: 2023-01-06T20:02:23-06:00 New Revision: cf97ee75f080579d2bbf2a559ec5d46ee00d828d URL: https://github.com/llvm/llvm-project/commit/cf97ee75f080579d2bbf2a559ec5d46ee00d828d DIFF: https://github.com/llvm/llvm-project/commit/cf97ee75f080579d2bbf2a559ec5d46ee00d828d.diff

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added a comment. In D139168#4030425 , @ChuanqiXu wrote: > BTW, if you are interested, it should be possible to use clang-scan-deps to > get the make-style format information. I want a *single* depfile for *anything* scanned by the `clang-sca

[PATCH] D141158: [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5f746f1efd4: [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] f5f746f - [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading

Author: Joseph Huber Date: 2023-01-06T20:01:41-06:00 New Revision: f5f746f1efd45a6e9ed8ca9be26e8c01c5aa00b1 URL: https://github.com/llvm/llvm-project/commit/f5f746f1efd45a6e9ed8ca9be26e8c01c5aa00b1 DIFF: https://github.com/llvm/llvm-project/commit/f5f746f1efd45a6e9ed8ca9be26e8c01c5aa00b1.diff

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

owenpan added a comment. In D141098#4030426 , @rymiel wrote: > The LLVM Coding Standard apparently doesn't mention line endings..? Line endings probably should never be specified in coding standards, but the default should match the majority, and in the

[PATCH] D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:169 +unsigned Offset = MD->getZExtValue(); +if (Offset) + F.addFnAttr("patchable-function-prefix", st

[PATCH] D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions

samitolvanen created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. samitolvanen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When -fpatchable-function-entry is used to emit prefix nop

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

rsmith added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated -

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek added inline comments. Comment at: runtimes/CMakeLists.txt:168 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) + execute_process(COMMAND ${CXX_TARGET_TRIPLE} --

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

Arthapz added a comment. Hi, just wanted to say that i added support of these patch to XMake and it work pretty well :) > xmake b -vD [ 0%]: generating.module.deps src

[clang] 5be422b - [Fix][-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations

Author: ziqingluo-90 Date: 2023-01-06T14:38:12-08:00 New Revision: 5be422b49288d7b9394312ad5ccba1fef42116e6 URL: https://github.com/llvm/llvm-project/commit/5be422b49288d7b9394312ad5ccba1fef42116e6 DIFF: https://github.com/llvm/llvm-project/commit/5be422b49288d7b9394312ad5ccba1fef42116e6.diff

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141158/new/ https://reviews.llvm.org/D141158 ___

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jhuber6 updated this revision to Diff 486991. jhuber6 added a comment. Adding an error print and some tests for it. We error if the user specified any `-foffload-lto` optoins that don't result in full LT.O Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

xazax.hun accepted this revision. xazax.hun added a comment. I think in these cases you can recommit without waiting for a new round of reviews, but I hit accept just in case :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://rev

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

vvereschaka added a comment. Hi @brad, thank you for fixing the broken tests. There is still a problem with `netbsd.c` test: https://lab.llvm.org/buildbot/#/builders/60/builds/10135/steps/9/logs/FAIL__Clang__netbsd_c Here: // DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-isystem" "[[RESOURCE]]

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

adriandole updated this revision to Diff 486980. adriandole added a comment. Add test and release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:730 + ? LTOK_Full + : OffloadLTOMode; } jdoerfert wrote: > Should we overwrite unconditionally or warn/error if the combination is > nonsensic

[clang] 42b1d08 - Revert "[Fix][-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations"

Author: ziqingluo-90 Date: 2023-01-06T13:37:13-08:00 New Revision: 42b1d08b955d6cfa0b78ceca62605bddc905461a URL: https://github.com/llvm/llvm-project/commit/42b1d08b955d6cfa0b78ceca62605bddc905461a DIFF: https://github.com/llvm/llvm-project/commit/42b1d08b955d6cfa0b78ceca62605bddc905461a.diff

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4030782 , @nridge wrote: > It's true that there is an ambiguity between `<` and `>` as operators, vs. > template arg/param list delimiters, but, at least in terms of user > understanding of code, my sense is that th

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jdoerfert added inline comments. Comment at: clang/lib/Driver/Driver.cpp:730 + ? LTOK_Full + : OffloadLTOMode; } Should we overwrite unconditionally or warn/error if the combination is nonsensical? Repository:

[PATCH] D141158: [OpenMP] Introduce '-f[no]-openmp-target-jit' flag to control JIT for offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, MaskRay, ggeorgakoudis, tianshilei1992. Herald added subscribers: StephenFan, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added a comment. BTW, the naming of the enums sucks. Feel free to offer alternatives. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 ___ cfe-commits m

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-capture-this-with-capture-default.cpp:1 +// RUN: %check_clang_tidy -std=c++11-or-later %s cppcoreguidelines-avoid-capture-this-with-capture-default %t + -

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-capture-this-with-capture-default.cpp:9 +auto explicit_this_capture = [=, this]() { }; +// CHECK-MESSAGES: :[[@LINE-1]]:35: warning: lambdas that capture t

[clang] 6d140b9 - [Fix][-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations

Author: ziqingluo-90 Date: 2023-01-06T12:32:35-08:00 New Revision: 6d140b952805bd9277fba666520ce46c19f2c637 URL: https://github.com/llvm/llvm-project/commit/6d140b952805bd9277fba666520ce46c19f2c637 DIFF: https://github.com/llvm/llvm-project/commit/6d140b952805bd9277fba666520ce46c19f2c637.diff

[clang] 87fe37d - [-Wunsafe-buffer-usage] Changing the use of None with std::nullopt to address a warning.

Author: MalavikaSamak Date: 2023-01-06T12:31:14-08:00 New Revision: 87fe37d9f8b668f537006a2bf6921cf2ad3fb2a2 URL: https://github.com/llvm/llvm-project/commit/87fe37d9f8b668f537006a2bf6921cf2ad3fb2a2 DIFF: https://github.com/llvm/llvm-project/commit/87fe37d9f8b668f537006a2bf6921cf2ad3fb2a2.diff

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

benlangmuir added a comment. > Sorry for missing these. I think I addressed all of them now. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 ___

[PATCH] D140062: [-Wunsafe-buffer-usage] Safe-buffers re-architecture to introduce Fixable gadgets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50d4a1f70e11: [-Wunsafe-buffer-usage] Safe-buffers re-architecture to introduce Fixable… (authored by malavikasamak). Herald added a project: clang.

[clang] 50d4a1f - [-Wunsafe-buffer-usage] Safe-buffers re-architecture to introduce Fixable gadgets

Author: MalavikaSamak Date: 2023-01-06T11:45:23-08:00 New Revision: 50d4a1f70e111cd41b1a94d95fd06b5691aa2643 URL: https://github.com/llvm/llvm-project/commit/50d4a1f70e111cd41b1a94d95fd06b5691aa2643 DIFF: https://github.com/llvm/llvm-project/commit/50d4a1f70e111cd41b1a94d95fd06b5691aa2643.diff

[PATCH] D136565: [clang] Instantiate alias templates with sugar

erichkeane added a comment. Note that the Clang 16 branch is coming up approximately on January 24, and this needs to be reverted or perf-regression fixed by then. @mizvekov : If you or someone else don't have a solution/revert to this by January 13th, @aaron.ballman and I will begin the proce

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Note that the Clang 16 branch is coming up approximately on January 24, and this needs to be reverted or have the issue reported by @steven_wu fixed by then. @mizvekov : If you or someone else don't have a solution/revert to this by January 13th, @aaron.ballman and

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13402 + // intergral operands. + if (E->getLHS()->getType()->isIntegerType() && + E->getRHS()->getType()->isIntegerType() && !E->isShiftAssignOp()) arichardson wrote: > Why is t

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. See @aaron.ballman 's comment here: https://github.com/llvm/llvm-project/issues/59271 Since the release branch is pending, if we don't have a solution or a revert by the 13th, Aaron or I will revert this patch. Reposito

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb added a comment. LGTM, thanks for fixing! Please be sure to have your commit message have `Fixes #59517` instead of a link to the issue, as this will close the bug upon merging. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/standalone-empty.cpp:586-590

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

arichardson added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13402 + // intergral operands. + if (E->getLHS()->getType()->isIntegerType() && + E->getRHS()->getType()->isIntegerType() && !E->isShiftAssignOp()) Why is this restricted to int

[clang] 7d0d34f - Re-land "[-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips callable declarations"

Author: ziqingluo-90 Date: 2023-01-06T10:33:21-08:00 New Revision: 7d0d34fbb153ef044b254d41ae91fc57efbdc77d URL: https://github.com/llvm/llvm-project/commit/7d0d34fbb153ef044b254d41ae91fc57efbdc77d DIFF: https://github.com/llvm/llvm-project/commit/7d0d34fbb153ef044b254d41ae91fc57efbdc77d.diff

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 486930. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Added summary in clang release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D1

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. But will be good idea to wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llv

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp marked 2 inline comments as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:142 e.g. --config-file=/some/path/myTidyConfigFile -This option

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486926. ymandel added a comment. fix use-after-free bug in test. Possible cause of buildbot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files: clang/i

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

smeenai added a comment. In D127812#4031849 , @ilinpv wrote: > In D127812#4031313 , @smeenai wrote: > >> We can use `-mno-fmv` to avoid that dependency, right? We're interested in >> using that for our own code (

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

Eugene.Zelenko accepted this revision. Eugene.Zelenko added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:142 e.g. --config-file=/some/path/myTidyConfigFile -

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486922. carlosgalvezp added a comment. Fix alignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cp

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486921. carlosgalvezp added a comment. Remove colon after the config options, for consistency with the command-line options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486916. carlosgalvezp added a comment. Fix incorrect dash in key/value pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-ti

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486915. carlosgalvezp added a comment. Remove wrong dash in key/value options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 486913. carlosgalvezp added a comment. Remove extra newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/tool/ClangTidy

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp created this revision. Herald added subscribers: arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Specify that the

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

dblaikie added a comment. The risk now is that this might significantly regress/add new findings for this warning that may not be sufficiently bug-finding to be worth immediate cleanup, causing users to have to choose between extensive lower-value cleanup and disabling the warning entirely. Ha

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 updated this revision to Diff 486901. jhuber6 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141105/new/ https://reviews.llvm.org/D141105 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4031313 , @smeenai wrote: > We can use `-mno-fmv` to avoid that dependency, right? We're interested in > using that for our own code (where we don't make use of function > multi-versioning), and want to prevent the com

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar marked 2 inline comments as done. fahadnayyar added a comment. In D139114#4023456 , @aaron.ballman wrote: > It looks like this change breaks libc++ (see the precommit CI failures) by > making more changes than expected. I'm now seeing `impli

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 486897. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. Fixed libcxx failure and added test case for expected warni

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

carlosgalvezp added a comment. > Therefore does it make sense to also do the same with the IncludeStyle as > lots of checks add new includes. Sure, that could also be done, though I think it'd be preferable to do it in a separate patch. Personally I'm a bit reluctant to having formatting option

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

njames93 added a comment. You do raise a good point about duplication, Therefore does it make sense to also do the same with the IncludeStyle as lots of checks add new includes. Though there is a precedent to do away with LLVM/Google style, as clang-format should be responsible for reordering in

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

emmenlau added a comment. Herald added a project: All. I can confirm that the problem in OpenSSL is resolved as of OpenSSL 1.1.1s and ClangCl 15.0.6. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112081/new/ https://reviews.llvm.org/D112081 _

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 486873. ccotter marked an inline comment as done. ccotter added a comment. - docs feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files: clang-tools-extra

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Anastasia added a comment. Can you link relevant LLVM reviews or documentation and perhaps add some more details into the description? It's a bit suboptimal though to emit this form of types as SPIR-V specific. Ideally Clang should worry as less as possible about target specifics. So it woul

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#4031503 , @hbae wrote: > In D139287#4031473 , @jhuber6 wrote: > >> In D139287#4031469 , @hbae wrote: >> >>> Looks like GCC 7.5 cannot b

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

hbae added a comment. In D139287#4031473 , @jhuber6 wrote: > In D139287#4031469 , @hbae wrote: > >> Looks like GCC 7.5 cannot build LLVM after this change. Could you please >> take a look? >> >> In file include

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:115 + Warns when lambda specify a capture default and capture ``this``. The check also + offers FixIts. + `fix-it`. Comment at: clang-tools-extra/docs

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. In D139287#4031469 , @hbae wrote: > Looks like GCC 7.5 cannot build LLVM after this change. Could you please take > a look? > > In file included from > /localdisk/hbae/LLVM/llvm-base/openmp/libomptarget/plugins-nextgen/common/

[PATCH] D141118: [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but please wait for more active developers' opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141118/new/

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

hbae added a comment. Looks like GCC 7.5 cannot build LLVM after this change. Could you please take a look? In file included from /localdisk/hbae/LLVM/llvm-base/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:11:0: /localdisk/hbae/LLVM/llvm-base/openmp/libomp

[PATCH] D140843: [clang-format] fix template closer followed by >

This revision was automatically updated to reflect the committed changes. Closed by commit rGb62906b0d10f: [clang-format] fix template closer followed by > (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140843/new/ https://re

[clang] b62906b - [clang-format] fix template closer followed by >

Author: Backl1ght Date: 2023-01-06T22:50:48+08:00 New Revision: b62906b0d10fb7a6cd2e2ceb0f350cec326540d7 URL: https://github.com/llvm/llvm-project/commit/b62906b0d10fb7a6cd2e2ceb0f350cec326540d7 DIFF: https://github.com/llvm/llvm-project/commit/b62906b0d10fb7a6cd2e2ceb0f350cec326540d7.diff LOG

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel abandoned this revision. ymandel added a comment. Abandoning in favor of https://reviews.llvm.org/D140694. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123032/new/ https://reviews.llvm.org/D123032

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4022493 , @awarzynski wrote: > Hi @madanial , thanks for posting this! > >> This patch adds user option -funderscoring/-fnounderscoring which behaves >> similar to the gfortran option be enabling/disabling the >> Exte

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

erichkeane added a comment. Done, though I think it is more than time for you to ask for commit permissions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 ___

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

This revision was automatically updated to reflect the committed changes. Closed by commit rG051cc460ba91: [C++20] Determine the dependency of unevaluated lambdas more accurately (authored by lime, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 051cc46 - [C++20] Determine the dependency of unevaluated lambdas more accurately

Author: Liming Liu Date: 2023-01-06T05:56:25-08:00 New Revision: 051cc460ba9117c9f62c09235bdf6f5ae1248dd4 URL: https://github.com/llvm/llvm-project/commit/051cc460ba9117c9f62c09235bdf6f5ae1248dd4 DIFF: https://github.com/llvm/llvm-project/commit/051cc460ba9117c9f62c09235bdf6f5ae1248dd4.diff LO

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

smeenai added a comment. In D127812#4031101 , @ilinpv wrote: > In D127812#4030881 , @smeenai wrote: > >> We're not actually using multi-versioning anywhere, but we're still paying >> the size cost for it as a res

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:482-484 +BUILTIN(__builtin_issubnormal, "i.", "FnctE") +BUILTIN(__builtin_iszero, "i.", "FnctE") +BUILTIN(__builtin_issignaling, "i.", "FnctE") Sorry, I should have clarified, a

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 added a comment. In D141105#4031103 , @JonChesterfield wrote: > Possible naming hazard here. march=native means target the local processor > architecture, zen2 or whatever, and we have the host CPU as an offloading > target already. So what I'd

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

JonChesterfield added a comment. Possible naming hazard here. march=native means target the local processor architecture, zen2 or whatever, and we have the host CPU as an offloading target already. So what I'd expect this to do is host offloading with the openmp runtime compiled for the local v

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4030881 , @smeenai wrote: > We're not actually using multi-versioning anywhere, but we're still paying > the size cost for it as a result. Would we consider moving the newly added > functions into their own file (or pe

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime added a comment. Could you please help to commit this? My name and email are `Liming Liu ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:13 +#include "clang/AST/APValue.h" #include "clang/AST/ASTContext.h" Do we actually need that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks. I think this looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 ___ cfe-co

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

hazohelet added a comment. > So, so long as a string literal still does the suppression, it's probably > fine. I agree with you. I now also think that integer literals _should not_ do the warning suppression because programmers are sometimes unsure of the expansion result of predefined macros

[PATCH] D140395: [clang][analyzer] Extend StreamChecker with some new functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cf85323a078: [clang][analyzer] Extend StreamChecker with some new functions. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D140395?vs=485928&id=486797#toc Repository: rG

[clang] 5cf8532 - [clang][analyzer] Extend StreamChecker with some new functions.

Author: Balázs Kéri Date: 2023-01-06T12:22:21+01:00 New Revision: 5cf85323a0788ee5666099d6a34c55f70edbc934 URL: https://github.com/llvm/llvm-project/commit/5cf85323a0788ee5666099d6a34c55f70edbc934 DIFF: https://github.com/llvm/llvm-project/commit/5cf85323a0788ee5666099d6a34c55f70edbc934.diff L

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/D140290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

hazohelet updated this revision to Diff 486793. hazohelet added a comment. add up the former 2 commits into 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140860/new/ https://reviews.llvm.org/D140860 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/logical-op-parentheses.c Inde

[PATCH] D141118: [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It's not used anywhere. R

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >