[clang] 0aaeb25 - [include-mapping] Fix gen_std.py test

Author: Viktoriia Bakalova Date: 2023-01-18T13:07:41Z New Revision: 0aaeb25525ecbc667a9029a4be0d87085392954a URL: https://github.com/llvm/llvm-project/commit/0aaeb25525ecbc667a9029a4be0d87085392954a DIFF: https://github.com/llvm/llvm-project/commit/0aaeb25525ecbc667a9029a4be0d87085392954a.diff

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:646 // "" for global namespace, "ns::" for normal namespace. + std::vector QueryScopes; + // Like QueryScopes, but also contains inline namespaces. could you actually chang

[PATCH] D142007: [NFC] Fix "form/from" typos

pfusik created this revision. Herald added subscribers: Moerafaat, zero9178, steakhal, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rridd

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein added a comment. In D141580#4061205 , @aeubanks wrote: > apologies for reverting this, but > https://reviews.llvm.org/rGf1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee is broken > and doesn't revert cleanly without this also being reverted, could you re

[clang] 6898d84 - Reland "nullptr returned from ActOnTag() is not a valid result"

Author: Haojian Wu Date: 2023-01-18T12:41:44+01:00 New Revision: 6898d8413ff4af205000eab1db3fa900b39c6097 URL: https://github.com/llvm/llvm-project/commit/6898d8413ff4af205000eab1db3fa900b39c6097 DIFF: https://github.com/llvm/llvm-project/commit/6898d8413ff4af205000eab1db3fa900b39c6097.diff LO

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490100. tblah marked 4 inline comments as done. tblah added a comment. Clarified a comment in stack-arrays.f90 and clarified the choice of FileCheck prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

jryans added a comment. @calebzulawski This looks ready to land to me! 🙂 Do you have commit access? If not, I can land it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

iains updated this revision to Diff 490099. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140927/new/ https://reviews.llvm.org/D140927 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Parser.cpp clang/lib

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff added a comment. In D141765#4059214 , @kpn wrote: > Are we testing _Complex multiply or subtraction anywhere? I have a vague > memory of multiply not working correctly. There is a test `clang/test/CodeGen/complex-math.c` that checks complex o

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff updated this revision to Diff 490088. sepavloff added a comment. Updated comment in test as proposed by Kevin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 Files: clang/lib/CodeGen/CGExprCom

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:977 +llvm::SmallVector RVVIntrinsic::getSupportedUnMaskedPolicies() { + return { craig.topper wrote: > Possible improvement for a different patch: > > Could these policy lists

[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

sepavloff created this revision. sepavloff added reviewers: rjmccall, kpn, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D14

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:1032 +if (IsMasked) { + if (PolicyAttrs.isTUMAPolicy() && !HasMaskPolicy) +appendPolicySuffix("_tum"); craig.topper wrote: > If you hadn't just removed Omit, it s

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:159 inline void createDefaultFIROptimizerPassPipeline( -mlir::PassManager &pm, llvm::OptimizationLevel optLevel = defaultOptLevel) { +mlir::PassManager &pm, bool stackArrays = false, l

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains added a comment. In D141908#4061451 , @ChuanqiXu wrote: >> Well.. we have time for another iteration, > > I am going to take a vacation for the Chinese New Year since tomorrow to > February. So I am a little bit hurried : ) (I added the FIXME) Hav

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains updated this revision to Diff 490079. iains marked 5 inline comments as done. iains added a comment. address review commments, add an assert and a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141908/new/ https://reviews.llvm.org/D1419

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

hokein added a comment. mostly good, just nits. Comment at: clang/tools/include-mapping/gen_std.py:31 // Generate C++ symbols python3 gen_std.py -cppreference cppreference/reference -language=cpp > StdSymbolMap.inc // Generate C symbols

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

v.g.vassilev added a comment. In D119708#4060336 , @jansvoboda11 wrote: > In D119708#4059254 , @Hahnfeld > wrote: > >> Hello, sorry for the late heads-up, but this functionality is used by ROOT: >> https://gith

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

ChuanqiXu added a comment. > Well.. we have time for another iteration, I am going to take a vacation for the Chinese New Year since tomorrow to February. So I am a little bit hurried : ) Comment at: clang/lib/Sema/SemaDecl.cpp:15258 + // units. Deleted and Defaulted functi

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Herald added a subscriber: luke. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commi

[PATCH] D133574: [C2x] reject type definitions in offsetof

mstorsjo added a subscriber: aeubanks. mstorsjo added a comment. For clarity in the review - the relanded commit ended up reverted by @aeubanks in 39da55e8f548a11f7dadefa73ea73d809a5f1729 . The relanded commit triggers failed

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains marked 2 inline comments as done. iains added a comment. In D141908#4061409 , @ChuanqiXu wrote: > LGTM basically. I still feel we need a FIXME there. But I don't want to block > this for this reason especially we need to land this before the branch

[PATCH] D141577: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:921 PolicyAttrs.TailPolicy = Policy::PolicyType::Agnostic; // TAMA - if (PolicyAttrs.isUnspecified()) { -if (!IsMasked) { craig.topper wrote: > I guess removing this neg

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM basically. I still feel we need a FIXME there. But I don't want to block this for this reason especially we need to land this before the branch. Comment at: clang

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15258 + // units. Deleted and Defaulted functions are implicitly inline (but the + // inline state is not set at this point, so check the BodyKind explicitly). if (getLangOpts().CPlusPlusModules && current

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains updated this revision to Diff 490062. iains added a comment. rebased, address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141908/new/ https://reviews.llvm.org/D141908 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/mo

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

kadircet added a comment. regarding testing, i think updating all tests that we have in `IncludeCleanerTests` that call `computeUnusedIncludes` to also call the new function that'll use include-cleaner library should be enough. Comment at: clang-tools-extra/clangd/CMakeLists.

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 490056. eklepilkina added a comment. - Updated I extension verson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 Files: clang/lib/Driver/ToolChains/Arch/RISCV.

<    1   2   3