[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added a comment. I am implementing the `StorePreamblesInMemory` bool option discussed earlier. It would be nice to be able to modify it at any time, because it can be an option in an IDE's UI and requiring to restart an IDE for the option change to take effect is undesirable. In order

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. In D145228#4174829 , @sammccall wrote: > I think this is a bit abstract though. Concretely, what API do you need here? > e.g. which headers do you want to include, to what end? If we consider the bare minimum with the only

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503046. michaelplatings added a comment. - Make "experimental" more obvious. - Demonstrate using a Clang-generated flag directly in Flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503045. VitaNuo added a comment. Rebase to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503043. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files:

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan added a comment. In D144864#4175332 , @agozillon wrote: > In D144864#4175257 , > @kiranchandramohan wrote: > >> LG. See one minor comment in the tests. >> >> I would prefer having an Interface

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. In D144864#4175257 , @kiranchandramohan wrote: > LG. See one minor comment in the tests. > > I would prefer having an Interface for Target Modules if that could be made > to work. I guess this can be taken up separately after

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note about the fix when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145397/new/

[PATCH] D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to isolate the lax vector conversions warning only for PPC,

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for bearing with me, let's ship it! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:456 + tooling::IncludeStyle IncludeStyle; + auto DefaultStyle =

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

MattDevereau created this revision. MattDevereau added reviewers: sdesmalen, CarolineConcatto, peterwaller-arm. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of this revision. Herald added a

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. Hi, Alan. Thanks for your review again! With regard to middle, the patch sent in D145269 may answer your questions. Basically functions like: int* f(void) __attribute__((unused)); would be output as int*

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. See one minor comment in the tests. I would prefer having an Interface for Target Modules if that could be made to work. I guess this can be taken up separately after https://reviews.llvm.org/D144883.

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503033. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files:

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. In D143418#4175188 , @vedgy wrote: > Thank you for the quick build fix. You're welcome! > KDevelop's CMakeLists.txt disables this warning by adding the > `-Wno-missing-field-initializers` flag. That's why I haven't

[PATCH] D129951: adds `__disable_adl` attribute

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5756 + if (FunctionDecl *F = D->getAsFunction(); + F->isOverloadedOperator() || F->isCXXClassMember()) { +S.Diag(AL.getLoc(), diag::err_disable_adl_no_operators) aaron.ballman

[PATCH] D129951: adds `__disable_adl` attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5756 + if (FunctionDecl *F = D->getAsFunction(); + F->isOverloadedOperator() || F->isCXXClassMember()) { +S.Diag(AL.getLoc(), diag::err_disable_adl_no_operators) cor3ntin

[PATCH] D129951: adds `__disable_adl` attribute

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5756 + if (FunctionDecl *F = D->getAsFunction(); + F->isOverloadedOperator() || F->isCXXClassMember()) { +S.Diag(AL.getLoc(), diag::err_disable_adl_no_operators) aaron.ballman

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added a comment. Thank you for the quick build fix. KDevelop's CMakeLists.txt disables this warning by adding the `-Wno-missing-field-initializers` flag. That's why I haven't noticed the warning while building KDevelop. Either I missed the warning while building LLVM or it is also

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

probinson abandoned this revision. probinson added a comment. I think the GC behavior with explicit section names is currently a little peculiar. For functions without a section name, -ffunction-sections allows GC to happen at the individual function level. With a section name, GC would happen

[PATCH] D129951: adds `__disable_adl` attribute

aaron.ballman added reviewers: erichkeane, clang-language-wg. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4132 +def DisableADL : InheritableAttr { + let Spellings = [Keyword<"__disable_adl">]; + let Subjects = SubjectList<[Function]>;

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07158c54add9: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES

[clang] 07158c5 - [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

Author: Sander de Smalen Date: 2023-03-07T14:43:50Z New Revision: 07158c54add927057690aa8c073d35d42eac7006 URL: https://github.com/llvm/llvm-project/commit/07158c54add927057690aa8c073d35d42eac7006 DIFF: https://github.com/llvm/llvm-project/commit/07158c54add927057690aa8c073d35d42eac7006.diff

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1171 + /// attribute + void markEmpty() { data().Empty = true; } This change looks not related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3897 + if (Err) +return std::move(Err); ToField->setAccess(D->getAccess()); kpdev42 wrote: > balazske wrote: > > I am not familiar with this use case, is there a path where the

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. In D143418#4175128 , @vedgy wrote: > A clang-ppc64le-rhel build > failed: > > 54.897 [28/169/148] Building CXX object >

[clang] df8f8f7 - Fix build failures with libclang unittest; NFC

Author: Aaron Ballman Date: 2023-03-07T09:32:51-05:00 New Revision: df8f8f76207df40dca11c9c0c2328d6b3dfba9ca URL: https://github.com/llvm/llvm-project/commit/df8f8f76207df40dca11c9c0c2328d6b3dfba9ca DIFF: https://github.com/llvm/llvm-project/commit/df8f8f76207df40dca11c9c0c2328d6b3dfba9ca.diff

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added a comment. A clang-ppc64le-rhel build failed: 54.897 [28/169/148] Building CXX object tools/clang/unittests/libclang/CMakeFiles/libclangTests.dir/LibclangTest.cpp.o FAILED:

[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

erichkeane added a comment. Other than the two auto's missing a *, I think this is alright. I want to think about it/give others a chance to review, so please ping this in a few days if it hasn't been accepted by then. Comment at: clang/lib/Sema/TreeTransform.h:2808 +

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:456 + auto IncludeStyle = + clang::format::getLLVMStyle().IncludeStyle; + auto DefaultStyle = clang::format::getStyle( creating a copy of LLVM style unnecessarily all

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1338 + hwcap = getauxval(AT_HWCAP); + hwcap2 = getauxval(AT_HWCAP2); +#endif // defined(__FreeBSD__) nikic wrote: > This breaks the build with glibc 2.17. Thanks for

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ vedgy wrote: > collinbaker wrote:

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon updated this revision to Diff 503020. Fznamznon added a comment. Rebase and update test comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/ https://reviews.llvm.org/D145486 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

jmmartinez added a comment. Sorry for the delay, I was out-of-office. Patches 1 to 4 look good to me. If nobody raises concerns this week I'll mark them as accepted. I'm currently reviewing patch 5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:712 + for (auto *Inc : ConvertedIncludes.match(H)) { +if (Pragmas == nullptr || Pragmas->getPublic(Inc->Resolved).empty()) +

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503012. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files:

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:52-58 +enum AttrPrintLoc { + SIDE_NONE = 0, + SIDE_LEFT = 1, + SIDE_MIDDLE = 2, + SIDE_RIGHT = 4, + SIDE_ANY = SIDE_LEFT |

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. The recent update removed the added offload related code from Flang.h/.cpp and removed the related test. Would it be possible to have an extra sign-off as requested by @awarzynski (or more review points to correct/discuss if we aren't happy with the state/direction

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 503008. agozillon added a comment. - [Flang][ToolChain][OpenMP][Driver] Reduce changes to only add -fc1 support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Please be sure to file an issue to backport this to the 16.x branch (https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches).

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

nikic added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1338 + hwcap = getauxval(AT_HWCAP); + hwcap2 = getauxval(AT_HWCAP2); +#endif // defined(__FreeBSD__) This breaks the build with glibc 2.17. Repository: rG LLVM Github Monorepo

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#4174513 , @stuij wrote: > FWIW, at Arm we decided to keep the old name mangling to minimise friction > with existing code/libraries, but allow more operations with this same > name-mangling. We also discussed with

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. In D143418#4174521 , @vedgy wrote: > In D143418#4172587 , @aaron.ballman > wrote: > >> Thank you, this LGTM! I have to head out shortly, so I'll land this on your >> behalf

[PATCH] D143418: [libclang] Add API to override preamble storage path

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc929590ad30: [libclang] Add API to override preamble storage path (authored by vedgy, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] cc92959 - [libclang] Add API to override preamble storage path

Author: Igor Kushnir Date: 2023-03-07T08:25:38-05:00 New Revision: cc929590ad305f0d068709c7c7999f5fc6118dc9 URL: https://github.com/llvm/llvm-project/commit/cc929590ad305f0d068709c7c7999f5fc6118dc9 DIFF: https://github.com/llvm/llvm-project/commit/cc929590ad305f0d068709c7c7999f5fc6118dc9.diff

[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

lime created this revision. lime added reviewers: aaron.ballman, cor3ntin, erichkeane, clang-language-wg. lime added projects: All, clang, clang-language-wg. lime requested review of this revision. Herald added a subscriber: cfe-commits. This patch replace member accesses to declaration

[clang] 533997b - Fix DISABLE-NOT: cc1 check in debug-info-codeview-buildinfo.c test

Author: Matt Devereau Date: 2023-03-07T13:22:18Z New Revision: 533997b026bab9994209d07ab6297d1482289f2d URL: https://github.com/llvm/llvm-project/commit/533997b026bab9994209d07ab6297d1482289f2d DIFF: https://github.com/llvm/llvm-project/commit/533997b026bab9994209d07ab6297d1482289f2d.diff

[PATCH] D145228: [clangd] Add clangd headers to install targets

aaron.ballman added a comment. In D145228#4174829 , @sammccall wrote: > @aaron.ballman > > If someone wants to work on producing a more modular, component-based design, > that's probably a good idea (but tricky to get right). Probably a good place > to

[PATCH] D145228: [clangd] Add clangd headers to install targets

sammccall added a comment. @aaron.ballman If someone wants to work on producing a more modular, component-based design, that's probably a good idea (but tricky to get right). Probably a good place to start is working out what pieces can be moved into separate libraries with e.g. a coherent

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon updated this revision to Diff 502992. Fznamznon added a comment. Check FinalSize instead of N since it is probably more obvious Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/ https://reviews.llvm.org/D145486 Files:

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised awarzynski wrote: > agozillon wrote: > >

[PATCH] D145228: [clangd] Add clangd headers to install targets

aaron.ballman added a comment. In D145228#4170864 , @sammccall wrote: > Clangd isn't designed as a collection of libraries. clangd is not my area of expertise, so I don't intend to step into the middle of this with my comment, but: one of the tenants

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D130791 added an improvement that in case array element has a trivial constructor, it is

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502977. john.brawn added a comment. Ran clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang/lib/Serialization/ASTReader.cpp

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. In D145228#4174543 , @kadircet wrote: > I understand concerns about maintenance cost for the change. But I dare to ask why you think it is so high? Perhaps there are different expectations from the feature. I’m not

[PATCH] D145435: Choose style (file) from within code for use in IDEs

MyDeveloperDay added a comment. This is going to need unit tests A full context diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 ___ cfe-commits mailing

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

MyDeveloperDay added a comment. The upshot of this is better TT_FunctionLBrace/TT_ClassLBrace detection, which is great becuase if a class `{` or function `{` is incorrectly detected we are then in unknown territory as to how it might become formatted, since you introduced these Annotator

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. Thanks for the update and the replies. See comments inline. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + ///

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > >

[PATCH] D145228: [clangd] Add clangd headers to install targets

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. i agree with Sam's concerns here. clangd isn't designed to be consumed as a library, but rather as a binary through LSP. increasing surface are here and letting people build

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb marked an inline comment as done. krisb added inline comments. Comment at: llvm/include/llvm/IR/DIBuilder.h:76 -/// Each subprogram's preserved labels. -DenseMap> PreservedLabels; +SmallVectorImpl & +getSubprogramNodesTrackingVector(const DIScope *S) {

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added a comment. In D143418#4172587 , @aaron.ballman wrote: > Thank you, this LGTM! I have to head out shortly, so I'll land this on your > behalf tomorrow when I have the time to babysit the postcommit build farm. > However, if you'd like to

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

stuij added a comment. FWIW, at Arm we decided to keep the old name mangling to minimise friction with existing code/libraries, but allow more operations with this same name-mangling. We also discussed with Red Hat and they were ok with this. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

foad added a comment. Just my 2p: it feels a bit premature to commit patches for this. It feels more like something you could prototype on a branch somewhere and come back when you have more experience with how it all works out in practice. But I don't actually object to the patch, if the

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18116 +case NVPTX::BI__nvvm_ldu_h: + BuiltinName = "__nvvm_ldu_h"; + break; tra wrote: > Can we use the standard `StringRef Name = >

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 502948. jchlanda marked 3 inline comments as done. jchlanda added a comment. Address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files:

[PATCH] D145149: [UTC] Enable --function-signature by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb309041f0c3: [UTC] Enable --function-signature by default (authored by nikic). Herald added a project: clang. Herald added a subscriber:

[clang] fb30904 - [UTC] Enable --function-signature by default

Author: Nikita Popov Date: 2023-03-07T10:27:52+01:00 New Revision: fb309041f0c37fa2798305ae02cf6910bf0b402b URL: https://github.com/llvm/llvm-project/commit/fb309041f0c37fa2798305ae02cf6910bf0b402b DIFF: https://github.com/llvm/llvm-project/commit/fb309041f0c37fa2798305ae02cf6910bf0b402b.diff

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. The original issue has been fixed by the mentioned LLVM changes. As such, I don't think we need to actually do anything on the Clang side. Please let me know if you're still seeing

[PATCH] D145477: run-clang-tidy.py should only search for the clang-apply-replacements if really needed

This revision was automatically updated to reflect the committed changes. Closed by commit rG144e2364410c: run-clang-tidy.py should only search for the clang-apply-replacements if really… (authored by Anonymous, committed by aabhinavg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 144e236 - run-clang-tidy.py should only search for the clang-apply-replacements if really needed

Author: Anonymous Date: 2023-03-07T14:52:34+05:30 New Revision: 144e2364410cc57e919eee38402bc5347f1d57b8 URL: https://github.com/llvm/llvm-project/commit/144e2364410cc57e919eee38402bc5347f1d57b8 DIFF: https://github.com/llvm/llvm-project/commit/144e2364410cc57e919eee38402bc5347f1d57b8.diff

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ collinbaker wrote: > vedgy wrote:

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:97 + const auto CharToIntCastExpr = implicitCastExpr( + hasSourceExpression(expr(hasType(qualType(isAnyCharacter(), +

[PATCH] D145479: [clang][ASTImporter] Import typedefs to distinct records as distinct nodes.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D145477: run-clang-tidy.py should only search for the clang-apply-replacements if really needed

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, `clang_apply_replacements_binary` is only used in a `if args.fix` block. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145477: run-clang-tidy.py should only search for the clang-apply-replacements if really needed

aabhinavg created this revision. aabhinavg added a reviewer: keith. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. aabhinavg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

<    1   2