[PATCH] D148260: [clang] Mark CWG2331 as N/A

Endill added a comment. In D148260#4266802 , @shafik wrote: > The defect report has two examples even though the first one is commented > incorrectly considering the final resolution. I am sure they are covered in > the test suite in other places but wh

[clang-tools-extra] 3f6a904 - [clangd] Inactive regions support via dedicated protocol

Author: Nathan Ridge Date: 2023-04-14T03:12:36-04:00 New Revision: 3f6a904b2f3d8e974b223097956bb1ea51822782 URL: https://github.com/llvm/llvm-project/commit/3f6a904b2f3d8e974b223097956bb1ea51822782 DIFF: https://github.com/llvm/llvm-project/commit/3f6a904b2f3d8e974b223097956bb1ea51822782.diff

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6a904b2f3d: [clangd] Inactive regions support via dedicated protocol (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill updated this revision to Diff 513457. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148136/new/ https://reviews.llvm.org/D148136 Files: clang/test/CXX/drs/dr18xx.cpp clang/test/CXX/drs/dr21xx.cpp clang/t

[clang] 576c752 - [clang] Add test for CWG1894 and CWG2199

Author: Vlad Serebrennikov Date: 2023-04-14T10:15:21+03:00 New Revision: 576c752410e71229f271ec7defb22f3596338c00 URL: https://github.com/llvm/llvm-project/commit/576c752410e71229f271ec7defb22f3596338c00 DIFF: https://github.com/llvm/llvm-project/commit/576c752410e71229f271ec7defb22f3596338c00.

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG576c752410e7: [clang] Add test for CWG1894 and CWG2199 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. The patch is causing `initialize-params.test` to fail, fix coming right up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D143974 ___ cfe-comm

[clang-tools-extra] 28575f4 - [clangd] Fix test failure in initialize-params.test

Author: Nathan Ridge Date: 2023-04-14T03:26:36-04:00 New Revision: 28575f41cd7df98012fb15f18434411a941ec228 URL: https://github.com/llvm/llvm-project/commit/28575f41cd7df98012fb15f18434411a941ec228 DIFF: https://github.com/llvm/llvm-project/commit/28575f41cd7df98012fb15f18434411a941ec228.diff

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. In D143974#4267320 , @nridge wrote: > The patch is causing `initialize-params.test` to fail, fix coming right up. Fixed in https://github.com/llvm/llvm-project/commit/28575f41cd7df98012fb15f18434411a941ec228. Repository: rG L

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

MyDeveloperDay added a comment. In D137327#4267239 , @thieta wrote: > In D137327#4235255 , > @MyDeveloperDay wrote: > >> In D137327#4234463 , @thieta wrote: >> >>> This w

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. In D147176#4266496 , @owenpan wrote: > In D147176#4265130 , > @MyDeveloperDay wrote: > >> we should be good now > > Thanks! I really like these new rules! Yeah sorry for the Spam,

[clang] 104cd74 - Revert "[clang-format] Handle object instansiation in if-statements"

Author: Tobias Hieta Date: 2023-04-14T09:48:24+02:00 New Revision: 104cd749f5cca609a79303c0dad22bc041b5448a URL: https://github.com/llvm/llvm-project/commit/104cd749f5cca609a79303c0dad22bc041b5448a DIFF: https://github.com/llvm/llvm-project/commit/104cd749f5cca609a79303c0dad22bc041b5448a.diff

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. In D137327#4267342 , @MyDeveloperDay wrote: > You have commit rights correct? you really need to own your change especially > if it causes a regression. Alright - I did that now. Sorry I am just used to be on the other side as m

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 513464. 4vtomat added a comment. Herald added a subscriber: arphaman. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/includ

[PATCH] D148308: [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito

[PATCH] D148240: [Coroutines] Directly remove unnecessary lifetime intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG243e62b9d876: [Coroutines] Directly remove unnecessary lifetime intrinsics (authored by nikic). Herald added a project: clang. Herald added a subscri

[clang] 243e62b - [Coroutines] Directly remove unnecessary lifetime intrinsics

Author: Nikita Popov Date: 2023-04-14T10:22:30+02:00 New Revision: 243e62b9d8760cdf12cb2f0a0c49f41aa50b3b6f URL: https://github.com/llvm/llvm-project/commit/243e62b9d8760cdf12cb2f0a0c49f41aa50b3b6f DIFF: https://github.com/llvm/llvm-project/commit/243e62b9d8760cdf12cb2f0a0c49f41aa50b3b6f.diff

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:340 +// is not installed. +if (Lang == "objective-c++-header") { + Lang = "c++-header"; nridge wrote: > kadircet wrote: > > this feels like too much of a

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. dougpuob requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improve the (`D144510`)[https://reviews.llvm.org/D144510]

[PATCH] D78644: [LSan] Enable for SystemZ

jonpa added a comment. Update clang/docs/LeakSanitizer.rst (Supported Platforms). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 ___ cfe-commits mailing list cfe

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

foad added a comment. Changing the existing intrinsics to use type mangling could break clients like LLPC and Mesa. I've put up a patch for LLPC to protect it against this change: https://github.com/GPUOpen-Drivers/llpc/pull/2404 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon updated this revision to Diff 513497. Fznamznon added a comment. Rebase, fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sem

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

PiotrZSL requested changes to this revision. PiotrZSL added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264-267 +- Improved readability for hungarian notation in + :doc:`readability-identifier-naming + ` by

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

PiotrZSL added a comment. And you forget to attach changes in unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 ___ cfe-commits mailing list cfe-commi

[PATCH] D148308: [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td

kito-cheng added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:15 -//===--===// -// Instruction definitions -//===--=

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Michael137 w

[clang] 62ef97e - [llvm-c] Remove PassRegistry and initialization APIs

Author: Nikita Popov Date: 2023-04-14T12:12:48+02:00 New Revision: 62ef97e0631ff41ad53436477cecc7d3eb244d1b URL: https://github.com/llvm/llvm-project/commit/62ef97e0631ff41ad53436477cecc7d3eb244d1b DIFF: https://github.com/llvm/llvm-project/commit/62ef97e0631ff41ad53436477cecc7d3eb244d1b.diff

[PATCH] D145043: [llvm-c] Remove PassRegistry and initialization APIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62ef97e0631f: [llvm-c] Remove PassRegistry and initialization APIs (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

AMS21 created this revision. AMS21 added a reviewer: PiotrZSL. Herald added subscribers: ChuanqiXu, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

AMS21 added a comment. This check is mostly working. Added notes about problems I know about. Comment at: clang-tools-extra/clang-tidy/performance/DontUseEndlCheck.cpp:44 + Diag << FixItHint::CreateReplacement( + CharSourceRange::getCharRange(EndlCall->getSourceRange()),

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

mboehme updated this revision to Diff 513515. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148110/new/ https://reviews.llvm.org/D148110 Files: clang-tools-extra/clang-tidy/utils/E

[clang] 4b0a253 - [AIX] enable the cases that are excluded by XCOFF 64 integrated-as support

Author: Chen Zheng Date: 2023-04-14T06:24:57-04:00 New Revision: 4b0a25375e9006ef82cc51119ff223a28bb15646 URL: https://github.com/llvm/llvm-project/commit/4b0a25375e9006ef82cc51119ff223a28bb15646 DIFF: https://github.com/llvm/llvm-project/commit/4b0a25375e9006ef82cc51119ff223a28bb15646.diff LO

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1163 +namespace { + njames93 wrote: > Whats with this namespace addition? looks unnecessary and should b

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

carlosgalvezp added a comment. For consistency with other checks, please rename it to `performance-avoid-endl`. You can use the `rename_check.py` to easily do this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.o

[PATCH] D143260: [clangd] Add semantic token for labels

kadircet added a comment. sorry for long silence. > But access specifiers are a completely different thing semantically, that's > the point: The user does not tell the client: "I want everything that is > followed by a single colon in this color"; that would be silly. They say "I > want goto

Re: [clang] c1f7636 - [C++20] [Modules] Continue parsing after we found reserved module names

Hi Aaron, I don't think we need to backport this to 16.x. Since the previous patch https://reviews.llvm.org/D146986 doesn't get backported too. The patch itself is mainly for the implementation of std modules in libcxx. And the std modules in libcxx should target 17.x as far as I know. So it lo

[clang] b0e61de - Model list initialization more directly; fixes an assert with coverage mapping

Author: Aaron Ballman Date: 2023-04-14T07:19:33-04:00 New Revision: b0e61de7075942ef5ac8af9ca1ec918317f62152 URL: https://github.com/llvm/llvm-project/commit/b0e61de7075942ef5ac8af9ca1ec918317f62152 DIFF: https://github.com/llvm/llvm-project/commit/b0e61de7075942ef5ac8af9ca1ec918317f62152.diff

[PATCH] D148245: Model list initialization more directly; fixes an assert with coverage mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0e61de70759: Model list initialization more directly; fixes an assert with coverage mapping (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

Re: [clang] c1f7636 - [C++20] [Modules] Continue parsing after we found reserved module names

On Thu, Apr 13, 2023 at 9:54 PM chuanqi.xcq wrote: > > Hi Aaron, > >I don't think we need to backport this to 16.x. Since the previous patch > https://reviews.llvm.org/D146986 doesn't get backported too. The patch itself > is mainly for the implementation of std modules in libcxx. And the st

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > erichkeane wrote: > > craig.topper wrote: > > > aaron.ballman wrote: > > > > craig.topper wrote: > > > >

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 513543. sammccall added a comment. Extract reinflate() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files: clang/include/clang/Analysis/FlowSensitive/

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 513544. sammccall added a comment. oops, after testing this time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files: clang/include/clang/Analysis/FlowSensitive

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. In my opinion, it is not possible to have a competitive client if you limit yourself to the official LSP feature set; you just need language-specific extensions in practice. And while of course not every silly idea should be blindly accepted, I think this "lowest comm

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 513549. ipriyanshi1708 marked 5 inline comments as done. ipriyanshi1708 added a comment. Improved the logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Fil

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before checking that template partial specialization is "reachable", ensure it exists. Fixes https://github.com/llvm/ll

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native Won't the code above (line 580) make many file

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 513556. dkrupp marked 11 inline comments as done. dkrupp edited the summary of this revision. dkrupp added a comment. -All remarks from @steakhal was fixed. Thanks for the review! -Now we can generate diagnostics for all tainted values when they reach a sink.

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. All remarks from @steakhal has been fixed. Thanks for the review. This new version now can handle the tracking back of multiple symbols! Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:129-130 /// Given a pointer/reference argument

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); if (!hasReachableDefinition(PartialSpec)) diagnoseMissingImport(SS.getLastQualifierNameLoc(

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added a comment. This patch LGTM given the above compromise, but one of the clang-codegen needs to take a look to accept. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + aaron.ballman wrote: > crai

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); if (!hasReachableDefinition(PartialSpec)) diagnoseMissingImport(SS.getLastQualifierNameLoc()

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fdeazeve added a comment. Thanks for working on this! The idea looks good to me, but I am not familiar with this part of the codebase, so I'll defer the review to others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llv

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon marked an inline comment as not done. Fznamznon added inline comments. Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:12 +template +void boo::foo(){} // expected-error{{nested name specifier 'boo::' for declaration does not refer into a class, class

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa added a comment. In D143813#4258744 , @ahatanak wrote: > In D143813#4257943 , @jonpa wrote: > >> I don't understand the first argument - I thought it was supposed to be just >> an address... > > It's a stat

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); if (!hasReachableDefinition(PartialSpec)) diagnoseMissingImport(SS.getLastQualifierNameLoc(

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa updated this revision to Diff 513573. jonpa added a comment. > Should be straightforward to fix, though; just make CheckAtomicAlignment > return the computed pointer. Something like this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143813/new/ https://reviews.llvm.org/D143813

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon updated this revision to Diff 513575. Fznamznon added a comment. Rebase, fix error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148330/new/ https://reviews.llvm.org/D148330 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/S

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:12 +template +void boo::foo(){} // expected-error{{nested name specifier 'boo::' for declaration does not refer into a class, class template or class template partial specializat

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:1 +// RUN: %clang_cc1 -std=c++20 -verify %s + nit: can you add a c++17 run li

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon updated this revision to Diff 513581. Fznamznon added a comment. Test c++17 too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148330/new/ https://reviews.llvm.org/D148330 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCXXScope

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:1 +// RUN: %clang_cc1 -std=c++20 -verify %s + erichkeane wrote: > nit: can you add a c++17 run line here too? Only 20 crashed, but I want to > make sure these h

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

erichkeane accepted this revision. erichkeane added a comment. Thanks! still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148330/new/ https://reviews.llvm.org/D148330 ___ cfe-commits mailing list

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

AMS21 updated this revision to Diff 513582. AMS21 added a comment. Rename to `performance-avoid-endl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/Avoi

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513584. carlosgalvezp added a comment. Remove excessive newlines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/ https://reviews.llvm.org/D148340 Files: clang-tools-extra/clang-tidy/cppcoreg

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

tbaeder added a comment. So, if I understand the code correctly, we call `CheckEvaluationResult` with `SubObjectDecl=nullptr` when we're not checking an actual field but just an array/record, so we can't run into this problem anyway, so the assert seems fine. I don't fully understand the probl

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob updated this revision to Diff 513586. dougpuob added a comment. Herald added a subscriber: aheejin. Against trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 Files: clang-tools-extra/docs/

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

carlosgalvezp added a comment. Thank you for the contribution! Looks good in general, have minor comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/avoid-endl.rst:1 +.. title:: clang-tidy - performance-avoid-endl + Please wrap file to 8

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob added a comment. In D148314#4267567 , @PiotrZSL wrote: > And you forget to attach changes in unit tests. My bad, I against to a wrong one. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264-267 +- Improved readability fo

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/avoid-endl.cpp:47 + std::cout << "World" << std::endl; + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use std::endl with iostreams; use '\n' instead + std::cerr <<

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidByValueCaptureDefaultWhenCapturingThisCheck.h:1 -//===--- AvoidCaptureDefaultWhenCapturingThisCheck.h - clang-tidy*- C++ -*-===// +//===--- AvoidByValueCaptureDefaultWhenCaptur

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 513589. hnrklssn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test case emitting !annotation from clang. Make annotation matching a generic metadata fallback. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

PiotrZSL added a comment. Consider extending this check to suport also std::ends, maybe name it performance-avoid-endl-ends. Comment at: clang-tools-extra/clang-tidy/performance/DontUseEndlCheck.cpp:26 + callee(cxxMethodDecl(ofClass( + hasAnyName("::std::

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp:1 +//===--- AvoidEndlCheck.cpp - clang-tidy ===// +// rename script got problem with this comment, you may need to align it man

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch refines the matching of the re

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55 +AvoidByValueCaptureDefaultWhenCapturingThisCheck>( + "cppcoreguidelines-avoid-by-value-capture-default-when-capturing-this"); Check

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Change in tests is ok, change in release notes not needed (please remove). Change title into [clang-tidy][NFC] Improved ... NFC - Non Functional Change Repository: rG LLVM Github Monore

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 513599. TIFitis added a comment. Updated to use opaque pointers, removed BitCast Insts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGO

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. Commit details as follows as per other diffs: Name: Jon Phillips Email: jonap2...@gmail.com Would appreciate someone committing for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D14

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186-194 + if (const auto *Destructor = llvm::dyn_cast(FD)) { +if (auto Err = Declarati

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

kadircet added a comment. there's actually a slight difference between an inline defaulted special member function and an out-of-line defaulted one. the latter makes the special member "user-defined" which might cause various headaches (e.g. type is no longer "trivial"). i don't think we should

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 513611. zequanwu added a comment. Added clang-cl option test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files: clang/include/clang/Basic/LangOptions.h clan

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > Won't the code above (line 5

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 513610. jrmolin added a comment. changing the added option from a boolean to an enum that takes `Leave`, `Always`, and `Never`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.or

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 4 inline comments as done. jrmolin added inline comments. Comment at: clang/lib/Format/Format.cpp:1336 LLVMStyle.AlwaysBreakAfterDefinitionReturnType = FormatStyle::DRTBS_None; + LLVMStyle.AlwaysBreakBeforeFunctionParameters = false; LLVMStyle.AlwaysBreakBef

[PATCH] D78644: [LSan] Enable for SystemZ

iii added a comment. That's where the mappings normally end. Example: $ cat /proc/self/maps 2aa-2aa2000 r--p 5e:01 668061 /usr/bin/cat 2aa2000-2aa6000 r-xp 2000 5e:01 668061 /usr/bin/cat 2aa6000-2aa8000

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

rampitec added a comment. In D147732#4267553 , @foad wrote: > Changing the existing intrinsics to use type mangling could break clients > like LLPC and Mesa. I've put up a patch for LLPC to protect it against this > change: https://github.com/GPUOpen-Dr

[PATCH] D78644: [LSan] Enable for SystemZ

iii added a comment. I guess the intention is dropping the special case? The following patch passes regtests: --- a/compiler-rt/lib/lsan/lsan_allocator.h +++ b/compiler-rt/lib/lsan/lsan_allocator.h @@ -68,9 +68,6 @@ using PrimaryAllocator = PrimaryAllocatorASVT; # if SANITIZER_FUCHSIA

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

foad added a comment. In D147732#4268661 , @rampitec wrote: > In D147732#4267553 , @foad wrote: > >> Changing the existing intrinsics to use type mangling could break clients >> like LLPC and Mesa. I've put up a

[PATCH] D78644: [LSan] Enable for SystemZ

MaskRay added a comment. In D78644#4268685 , @iii wrote: > I guess the intention is dropping the special case? The following patch > passes regtests: > > --- a/compiler-rt/lib/lsan/lsan_allocator.h > +++ b/compiler-rt/lib/lsan/lsan_allocator.h > @@

[clang-tools-extra] 2eb9cc7 - [clangd] Handle destructors in DefineOutline tweak

Author: Nathan James Date: 2023-04-14T17:51:45+01:00 New Revision: 2eb9cc76a6c0b61fcf75b747258e27b7b7683ca1 URL: https://github.com/llvm/llvm-project/commit/2eb9cc76a6c0b61fcf75b747258e27b7b7683ca1 DIFF: https://github.com/llvm/llvm-project/commit/2eb9cc76a6c0b61fcf75b747258e27b7b7683ca1.diff

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eb9cc76a6c0: [clangd] Handle destructors in DefineOutline tweak (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D147802?vs=511780&id=513644#toc Repository: rG LLVM Github M

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Just going to rip out llvm::StringView. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148181/new/ https://reviews.llvm.org/D148181 __

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob updated this revision to Diff 513648. dougpuob added a comment. - Removed unnecessary information from ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 Files: clang-tools-extra

[PATCH] D148314: [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review

dougpuob marked an inline comment as done. dougpuob added a comment. In D148314#4268460 , @PiotrZSL wrote: > Change in tests is ok, change in release notes not needed (please remove). > Change title into [clang-tidy][NFC] Improved ... > > NFC - Non Functi

[PATCH] D148354: [clang-tidy] Remove reference to Visual studio native plugin

sousajo created this revision. sousajo added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:262 /// Returns true if and only if `Type` is an optional type. bool isOptionalType(QualType Type) { if (!Type->isRecordType()) Why do we n

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

njames93 added a comment. In D147808#4268523 , @kadircet wrote: > there's actually a slight difference between an inline defaulted special > member function and an out-of-line defaulted one. the latter makes the > special member "user-defined" which mig

[PATCH] D148354: [clang-tidy] Remove reference to Visual studio native plugin

PiotrZSL added a comment. LGTM, as I undestand you don't have commit access, i will push this... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148354/new/ https://reviews.llvm.org/D148354 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy created this revision. donat.nagy added reviewers: steakhal, NoQ, gamesh411, Szelethus. donat.nagy added a project: clang-tools-extra. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a proje

  1   2   >