[PATCH] D146809: [clang-repl] Implement Value pretty printing

v.g.vassilev added subscribers: sunho, sgraenitz, lhames. v.g.vassilev added a comment. I believe this is heading in a good direction. Here are some comments from a partial review. Also perhaps we should extend the patch description (future commit message) to capture the idea of the pretty-print

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. Note that we are using the "de-facto" ABI throwing away this empty struct since the first release of GCC supporting LoongArch, and also Clang. So is there an imperative reason we must change it? And IIUC we've agreed to revise the ABI since Apr 2022 for this, but unfor

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 requested changes to this revision. xry111 added a comment. This revision now requires changes to proceed. Blocking this as it's a deliberate decision made in D132285 . Is there any imperative reason we must really pass the empty struct? The C++ standar

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin. Herald added a project: All. wangleiat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, paramter or return value whose t

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. Yeah, makes sense. Thank you for your insight! I missed the fact that this time include AST build time. I manually injected a time region into `inlayHints`, here's part of logs printed for scrolling "offsetToPosition" build: I[23:36:43.055] <-- textDocument/hove

[PATCH] D151297: [clang][test][LoongArch] Pre-commit test for empty struct in C++ mode

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin. Herald added a subscriber: mstorsjo. Herald added a project: All. wangleiat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prelim

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df77ac20a1e: [clang][X86] Add __cpuidex function to cpuid.h (authored by aidengrossman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2df77ac - [clang][X86] Add __cpuidex function to cpuid.h

Author: Aiden Grossman Date: 2023-05-24T06:27:46Z New Revision: 2df77ac20a1ed996706b164b0c4ed5ad140f635f URL: https://github.com/llvm/llvm-project/commit/2df77ac20a1ed996706b164b0c4ed5ad140f635f DIFF: https://github.com/llvm/llvm-project/commit/2df77ac20a1ed996706b164b0c4ed5ad140f635f.diff LOG

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:136 +// Removes matching instances of given token preceeding the function defition. +llvm::Expected +getDelKeywordReplacements(const FunctionDecl *FD, This was

[clang] 651b40e - Revert "[C++20] [Modules] Serialize the evaluated constant values for VarDecl"

Author: Chuanqi Xu Date: 2023-05-24T13:56:09+08:00 New Revision: 651b40e8ffa67efcc6f59cdd7715817678c6b632 URL: https://github.com/llvm/llvm-project/commit/651b40e8ffa67efcc6f59cdd7715817678c6b632 DIFF: https://github.com/llvm/llvm-project/commit/651b40e8ffa67efcc6f59cdd7715817678c6b632.diff LO

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

bgluzman created this revision. bgluzman added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. bgluzman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. `in

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor SerializerBase and SymbolGraphSerializer to use a

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); + }

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder updated this revision to Diff 525010. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. Ok, sorry, the test failures are on me. There is a lesson learned for me: I naively ran only the formatter unit tests, not the whole test suite of llvm. I somehow assumed that my code changes only affected clang-format, since the UnwrappedLineFormatter is in the "Form

[clang] 8e16365 - Revert "[clang-format] Fix indentation for selective formatting"

Author: Owen Pan Date: 2023-05-23T22:18:13-07:00 New Revision: 8e16365cb6162a29a2a8d26f2d5f0081a651d73a URL: https://github.com/llvm/llvm-project/commit/8e16365cb6162a29a2a8d26f2d5f0081a651d73a DIFF: https://github.com/llvm/llvm-project/commit/8e16365cb6162a29a2a8d26f2d5f0081a651d73a.diff LOG:

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

dyung added a comment. Hi @owenpan and @Sedeniono, this change is causing test failures across many bots, can you take a look and fix or revert if you need time to investigate? Failing bots: - https://lab.llvm.org/buildbot/#/builders/139/builds/41339 - https://lab.llvm.org/buildbot/#/builders/2

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added a comment. In D150635#4366730 , @daiyousei-qz wrote: > I'm not sure but 18ms is definitely wrong here, especially for a debug build. > In your log, even semantic highlighting builds in 60ms, which looks > incorrect. I tried again with T

[PATCH] D151286: [clang][Diagnostics][NFC] Don't create oversized CaretLine

tbaeder created this revision. tbaeder added reviewers: clang, cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of creating a CaretLine the size of the SourceLine, just leav

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

rjmccall added a comment. Apologies for misunderstanding what this patch was doing. This all seems reasonable, and the code changes look good. I think the documentation needs significant reorganization; I've attached a draft. Please review for correctness. Comment at: cla

[clang] 597dd1f - [NFC] Fix the warning for dangling pointer for c0d6f85e3ae8bc

Author: Chuanqi Xu Date: 2023-05-24T11:42:55+08:00 New Revision: 597dd1f91d9f3823e4184f1fe73d8125fa16c026 URL: https://github.com/llvm/llvm-project/commit/597dd1f91d9f3823e4184f1fe73d8125fa16c026 DIFF: https://github.com/llvm/llvm-project/commit/597dd1f91d9f3823e4184f1fe73d8125fa16c026.diff LO

[PATCH] D151281: [NFC][CLANG] Fix issue with dereference null return value found by Coverity

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool, Coverity: Inside "SemaDeclCXX.cpp" file, in clang::​Sema::​CheckExplicitlyDefaultedSpecialMember

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

pcwang-thead added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:41 +// Helper function to get the largest LMUL from MxList +// Precondition: MxList is sorted in ascending LMUL order. michaelmaitland wrote: > michaelmaitland wrote: > > pc

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. I'm not sure but 18ms is definitely wrong here, especially for a debug build. In your log, even semantic highlighting builds in 60ms, which looks incorrect. I tried again with TOT clangd and noticed the following pattern. - If I scroll with vscode, inlay hints typi

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static An

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72ab89e3197c: [clang-format] Fix indentation for selective formatting (authored by Sedeniono, committed by owenpan). Repository: rG LLVM Github Mo

[clang] 72ab89e - [clang-format] Fix indentation for selective formatting

Author: Sedenion Date: 2023-05-23T19:40:24-07:00 New Revision: 72ab89e3197cc1bee3b9774edb504690e3e43ed0 URL: https://github.com/llvm/llvm-project/commit/72ab89e3197cc1bee3b9774edb504690e3e43ed0 DIFF: https://github.com/llvm/llvm-project/commit/72ab89e3197cc1bee3b9774edb504690e3e43ed0.diff LOG:

[clang] c0d6f85 - [C++20] [Modules] Serialize the evaluated constant values for VarDecl

Author: Chuanqi Xu Date: 2023-05-24T10:17:33+08:00 New Revision: c0d6f85e3ae8bcfdb7217d165314f01c1a4af9ae URL: https://github.com/llvm/llvm-project/commit/c0d6f85e3ae8bcfdb7217d165314f01c1a4af9ae DIFF: https://github.com/llvm/llvm-project/commit/c0d6f85e3ae8bcfdb7217d165314f01c1a4af9ae.diff LO

[PATCH] D151278: [mlir][sparse][gpu] adding cuSparse sddmm support

K-Wu abandoned this revision. K-Wu added a comment. Sorry for the disruption. THis seems to be someone else's work that already in the github tree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151278/new/ https://reviews.llvm.org/D151278

[PATCH] D151278: [mlir][sparse][gpu] adding cuSparse sddmm support

K-Wu created this revision. Herald added subscribers: cfe-commits, bzcheeseman, rriddle. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. K-Wu requested review of this revision. Herald added a subscriber: stephenneuendorff

[clang] d39929b - [clang-format] Adjust braced list detection (reland 6dcde65)

Author: Galen Elias Date: 2023-05-23T18:50:41-07:00 New Revision: d39929b925ff45348645669e5091bdb03396384b URL: https://github.com/llvm/llvm-project/commit/d39929b925ff45348645669e5091bdb03396384b DIFF: https://github.com/llvm/llvm-project/commit/d39929b925ff45348645669e5091bdb03396384b.diff L

[clang] dc4ab97 - [clang-format] Revert 6dcde65 due to missing commit message title

Author: Owen Pan Date: 2023-05-23T18:48:52-07:00 New Revision: dc4ab97085c052e99cb4218f8250ee8d064c1be3 URL: https://github.com/llvm/llvm-project/commit/dc4ab97085c052e99cb4218f8250ee8d064c1be3 DIFF: https://github.com/llvm/llvm-project/commit/dc4ab97085c052e99cb4218f8250ee8d064c1be3.diff LOG:

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In `clang-scan-deps` co

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. I used the patch to compile LLVM, apache/arrow, apache/trafficserver, folly, tensorstore, protobuf. I did not see any cases with pointer arithmetic in these repos. I see there is some value for the patch in terms of readability (will be helpful to someone who is new

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

michaelmaitland added a comment. In D150253#4355730 , @jacquesguan wrote: > @michaelmaitland , I update this revision with my local branch. May you have > a look and see what missed compared with you version? I have left some comments on the clang side

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

SR_team updated this revision to Diff 524946. SR_team added a comment. Extract formatting to lambda, for simplify code modification CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151128/new/ https://reviews.llvm.org/D151128 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. Hi @dblaikie , Could you please take a look at this revision (and the previous one in the stack, D143966 ) or suggest some other reviewer familiar with this part of the code base? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

SR_team updated this revision to Diff 524938. SR_team added a comment. Stores `Offset`, `Size` and `Padding` fields of HoverInfo in bits. When hover present bits converted to bytes, if possible. Examle: struct test { char a; char b : 3; char c : 5; int d;

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

SR_team updated this revision to Diff 524933. SR_team added a comment. Stores `Offset`, `Size` and `Padding` fields of HoverInfo in bits. When hover present bits converted to bytes, if possible. Examle: struct test { char a; char b : 3; char c : 5; int d; };

[PATCH] D151172: [CodeGen] Fix the type of the constant that is used to zero-initialize a flexible array member

This revision was automatically updated to reflect the committed changes. Closed by commit rG6796053723a6: [CodeGen] Fix the type of the constant that is used to zero-initialize a (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 6796053 - [CodeGen] Fix the type of the constant that is used to zero-initialize a

Author: Akira Hatanaka Date: 2023-05-23T16:32:27-07:00 New Revision: 6796053723a68b99149737439856e6da25953975 URL: https://github.com/llvm/llvm-project/commit/6796053723a68b99149737439856e6da25953975 DIFF: https://github.com/llvm/llvm-project/commit/6796053723a68b99149737439856e6da25953975.diff

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 524909. SlaterLatiao added a comment. Test -packed-non-pod not omitting warnings of "packed attribute is unnecessary". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D15

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

michaelmaitland added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/zvfhmin-error.c:15 + + + Do we need a test that checks calls to `__riscv_vfwcvt_f` and `__riscv_vfncvt_f` using type `vfloat16m1_t` without zvfh nor zvfhmin l

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

michaelmaitland added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1856 def vfwcvt_f_x_v : RVVConvBuiltin<"Fw", "Fwv", "csi", "vfwcvt_f">; - def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "xf", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] i

[PATCH] D151264: Test -Wpacked-non-pod does not emit warnings of "packed attribute is unnecessary"

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151264 Files: clang/test/CodeGenCXX/warn-padde

[PATCH] D150892: Reland: [clang][ExprConstant] fix __builtin_object_size for flexible array members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG804af933f731: Reland: [clang][ExprConstant] fix __builtin_object_size for flexible array… (authored by nickdesaulniers). Repository: rG LLVM Githu

[clang] 804af93 - Reland: [clang][ExprConstant] fix __builtin_object_size for flexible array members

Author: Nick Desaulniers Date: 2023-05-23T14:41:46-07:00 New Revision: 804af933f7310f78d91e13ad8a13b64b00249614 URL: https://github.com/llvm/llvm-project/commit/804af933f7310f78d91e13ad8a13b64b00249614 DIFF: https://github.com/llvm/llvm-project/commit/804af933f7310f78d91e13ad8a13b64b00249614.di

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:316 + unsigned getInterestingIdentifierID() { +if (ObjCOrBuiltinID >= 1341 && ObjCOrBuiltinID < 1343) + return ObjCOrBuiltinID; rjmccall wrote: > This is closer to

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 524882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/Bu

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > hnrklssn wrote: > > hnrklssn wr

[PATCH] D151253: [clangd] Move completion signatures and insertion markers into labelDetails

sammccall added a comment. Hmm, having looked at that screenshot more, the bullets are not rendered properly on some lines... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151253/new/ https://reviews.llvm.org/D151253 _

[PATCH] D151253: [clangd] Move completion signatures and insertion markers into labelDetails

sammccall added a comment. Looks like this: F27614864: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151253/new/ https://reviews.llvm.org/D151253 ___ cfe-co

[PATCH] D151253: [clangd] Move completion signatures and insertion markers into labelDetails

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. (Wh

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

shafik added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:27 #include "clang/Sema/ParsedTemplate.h" -#include "clang/Sema/Scope.h" #include "clang/Sema/SemaDiagnostic.h" This looks like an unrelated change after removing the change below. Reposi

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1018 +if (VT.getVectorElementType() == MVT::f16 && +!Subtarget.hasVInstructionsF16()) { This needs to be below `By default everything must be expande

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca9683651e52: [Sema] `setInvalidDecl` for error deduction declaration (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] ca96836 - [Sema] `setInvalidDecl` for error deduction declaration

Author: Congcong Cai Date: 2023-05-23T22:14:12+02:00 New Revision: ca9683651e52196f590bc244d9c506ed39fe1d92 URL: https://github.com/llvm/llvm-project/commit/ca9683651e52196f590bc244d9c506ed39fe1d92 DIFF: https://github.com/llvm/llvm-project/commit/ca9683651e52196f590bc244d9c506ed39fe1d92.diff

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 524849. HerrCai0907 added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

aaron.ballman added a comment. In general, I think this is looking pretty good, thank you! I'll leave it to @erichkeane to do the final sign-off as attributes code owner since this is making a fair number of changes in that area. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:44

[PATCH] D151172: [CodeGen] Fix the type of the constant that is used to zero-initialize a flexible array member

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151172/new/ https://reviews.llvm.org/D151172 ___

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm updated this revision to Diff 524846. rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Update onto current main. Only change is to replace C++2b with C++23. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1487

[PATCH] D151172: [CodeGen] Fix the type of the constant that is used to zero-initialize a flexible array member

aaron.ballman added a comment. LGTM, but I'll leave it to @efriedma to do the final sign-off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151172/new/ https://reviews.llvm.org/D151172 ___ cfe-commits ma

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. In D148700#4364229 , @aaron.ballman wrote: > This basically LGTM, but we should add documentation to the internals manual > too: https://clang.llvm.org/docs/InternalsManual.htm

[PATCH] D151133: [clang-tidy] Ignore implicit code in bugprone-branch-clone

This revision was automatically updated to reflect the committed changes. Closed by commit rG42c83e32706e: [clang-tidy] Ignore implicit code in bugprone-branch-clone (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D151133?vs=524764&id=524845#toc Repository: rG LLVM

[PATCH] D147889: [clang-tidy] Improve bugprone-branch-clone with support for fallthrough attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG77f191e81ed4: [clang-tidy] Improve bugprone-branch-clone with support for fallthrough… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 42c83e3 - [clang-tidy] Ignore implicit code in bugprone-branch-clone

Author: Piotr Zegar Date: 2023-05-23T19:32:36Z New Revision: 42c83e32706e2284acb880468295701743d437c6 URL: https://github.com/llvm/llvm-project/commit/42c83e32706e2284acb880468295701743d437c6 DIFF: https://github.com/llvm/llvm-project/commit/42c83e32706e2284acb880468295701743d437c6.diff LOG: [

[clang-tools-extra] 77f191e - [clang-tidy] Improve bugprone-branch-clone with support for fallthrough attribute

Author: Piotr Zegar Date: 2023-05-23T19:32:36Z New Revision: 77f191e81ed475fbbc8eaa2e2dbe6a0a02f3b0c2 URL: https://github.com/llvm/llvm-project/commit/77f191e81ed475fbbc8eaa2e2dbe6a0a02f3b0c2 DIFF: https://github.com/llvm/llvm-project/commit/77f191e81ed475fbbc8eaa2e2dbe6a0a02f3b0c2.diff LOG: [

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm updated this revision to Diff 524843. rsandifo-arm added a comment. Add internals documentation. Add FIXME to temporary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148700/new/ https://reviews.llvm.org/D148700 Files: clang-t

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

MaskRay added a comment. I suspect that OpenBSD uses `-nopie`, but this is never adopted by other OSes / GCC. And Clang should not add a new alias that has no significant uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://revi

[PATCH] D151243: [CUDA] Fix wrappers for sm_80 functions

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra published this revision for review. tra added a reviewer: jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previous implementation provided wrapp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

aaron.ballman added a comment. Basically LG though I had a question about the test case. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__A

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added a comment. In D151047#4363127 , @owenpan wrote: > In D151047#4361205 , @Sedeniono > wrote: > >> Also, should it be merged into the LLVM 16.x branch? > > +1. @MyDeveloperDay and @HazardyKn

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, rymiel, HazardyKnusperkeks. HazardyKnusperkeks added a comment. As stated on Github I don't think we have a bug. Comment at: clang/unittests/Format/FormatTestRawStrings.cpp:79 +)format"; +llvm::MemoryBufferRef Co

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:106-113 +CI.setSema(nullptr); +CI.setASTConsumer(nullptr); +if (CI.getASTReader()) { + CI.getASTReader()->setDeserializationListener(nullptr); + /* This just sets consumer to nul

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 524836. kuganv marked an inline comment as done. kuganv added a comment. Set just PrecompilePreambleConsumer/PCHGenerator and ASTMutationListener to null. Set the FileManager VFS to consuming FS so that it is thread safe. Repository: rG LLVM Github Monorep

[PATCH] D151214: [clang][Sema] `-Wshadow` warns about shadowings by static local variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/SemaCXX/warn-shadow.cpp:33 void foo() { int i; // expected-warning {{declaration shadows a variable in namespace '(anonymous)'}} int j; //

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

mcgrathr added a comment. In GCC the spelling is `-no-pie`. `-nopie` is not documented as an alias, and I don't think it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 ___

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 524824. HerrCai0907 added a comment. add std option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sem

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 reopened this revision. HerrCai0907 added a comment. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 _

[PATCH] D151054: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG806b0cd5ab56: [NFC][CLANG] Fix issue with dereference null return value found by Coverity… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 806b0cd - [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Author: Manna, Soumi Date: 2023-05-23T11:44:06-07:00 New Revision: 806b0cd5ab5686c1a90d4f13f33517f858fcf4e0 URL: https://github.com/llvm/llvm-project/commit/806b0cd5ab5686c1a90d4f13f33517f858fcf4e0 DIFF: https://github.com/llvm/llvm-project/commit/806b0cd5ab5686c1a90d4f13f33517f858fcf4e0.diff

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 524820. PiotrZSL added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-to

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 524817. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra/cla

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 524815. mikecrowe added a comment. Make needParensAfterUnaryOperator static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 Files: clang-tools-extra/clang-tidy/re

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe marked an inline comment as done. mikecrowe added a comment. Thanks for the review. New version with the `static` added coming shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 __

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. @owenpan Here is the name and mail in the <> format: `Sedenion <39583823+sedeni...@users.noreply.github.com>` @HazardyKnusperkeks Ok, I will remember it for the next one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1510

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. (Moving this off the review queue per above comments. There is a missing include in a unit test.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.ll

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

craig.topper added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:456 +/// j := i*128 +/// result[j+31:j] := __a[j+63:j+32] - __a[j+31:j] +/// result[j+63:j+32] := __a[j+127:j+96] - __a[j+95:j+64] Intel intrinsics guide says ``` dst[31:0] := a

[clang] 1c5a749 - Reland "[clang] Add tests for CWG issues 977, 1482, 2516"

Author: Vlad Serebrennikov Date: 2023-05-23T21:04:23+03:00 New Revision: 1c5a749754a1c352a7efa0e8be26c1d4132fe9c7 URL: https://github.com/llvm/llvm-project/commit/1c5a749754a1c352a7efa0e8be26c1d4132fe9c7 DIFF: https://github.com/llvm/llvm-project/commit/1c5a749754a1c352a7efa0e8be26c1d4132fe9c7.

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, code compiles locally, restarted CI job (maybe will pass). Add [NFC] to change title before committing as this changes does not impact functionality. Comment at: c

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

erichkeane added a comment. Change looks good, test is overly specific IMO. Comment at: clang/test/CodeGenCXX/gh62818.cpp:27 + // CHECK: %[[ASSIGN:.+]] = call noundef nonnull align 1 dereferenceable(1) %struct.A* @_ZNR1AaSES_(%struct.A* noundef nonnull align 1 dereferenceable

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

shafik added a subscriber: NoQ. shafik added inline comments. Comment at: clang/test/Analysis/missing-bind-temporary.cpp:10 namespace variant_0 { -// This variant of the code works correctly. Function foo() is not a template -// function. Note that there are two destructors with

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. In some cases we are using `TransformExpr` instead of `TransformInitializer`, this results in `ExprWithCleanups` being dropped and we are

[PATCH] D147889: [clang-tidy] Improve bugprone-branch-clone with support for fallthrough attribute

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147889/new/ https://reviews.llvm.org/D147889 __

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

tschuett added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:194 + NoMovt = false; +assert(hasV6MOps() && "Cannot generate execute-only code for this target"); } What happens in release mode? At the top you now claim that ARMV6M is

[PATCH] D151133: [clang-tidy] Ignore implicit code in bugprone-branch-clone

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. If this freshly added testcase passes, then there is no reason to delay merging this commit. Thanks for the contribution :) ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

craig.topper added a comment. Please split clang and llvm codegen into separate patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 ___ cfe-commits mailing

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

michaelmaitland added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2049 +!TI.hasFeature("experimental-zvfhmin")) + Diag(Loc, diag::err_riscv_type_requires_extension, FD) << Ty << "zvfh"; if (Ty->isRVVType(/* Bitwidth */ 32, /* IsFloat */ true) && ---

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

Icantjuddle removed a reviewer: craig.topper. Icantjuddle added a comment. Sorry @craig.topper for some reason `git blame` locally attributed much of the edits to you, doesn't match what I see online at github. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 8fc0dcf - Add a reminder to update docs when updating default; NFC

Author: Aaron Ballman Date: 2023-05-23T13:38:59-04:00 New Revision: 8fc0dcf036bf199b2af2e10a4f81215dbd706daf URL: https://github.com/llvm/llvm-project/commit/8fc0dcf036bf199b2af2e10a4f81215dbd706daf DIFF: https://github.com/llvm/llvm-project/commit/8fc0dcf036bf199b2af2e10a4f81215dbd706daf.diff

  1   2   3   >