[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. The tests are failing on main. Check the CI bots if they pass on your mach

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1078 +const MemRegion *R) { +return MemRegion::FieldRegio

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske added a comment. The success/failure note tags are not added to all functions, `dup` is one of these, this means at `dup` no note tag is shown. A next patch can be made to add these messages to all functions. The other places look good, but CodeChecker is a bit tricky, you must select

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie updated this revision to Diff 536662. OikawaKirie added a comment. Sorry for the formatting error... :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152435/new/ https://reviews.llvm.org/D152435 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp clang/test/Anal

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:475 +/// Whether to emit all variables that have a persisent storage duration, +/// including global, static and thread local variables. Minor nit: Typo. ==

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new/ https://reviews.llvm.org/D154301 _

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

MitalAshok updated this revision to Diff 536648. MitalAshok edited the summary of this revision. MitalAshok added a comment. Add status for CWG2681 and fixed aggregate-deduction-candidate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4463426 , @v.g.vassilev wrote: > In D153003#4462388 , @ChuanqiXu > wrote: > >>> Oh, I guess we're somehow adding a semi-resolved form of the base class >>> type of D into t

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536645. FreddyYe marked an inline comment as done. FreddyYe added a comment. Rebase, especially for D151696 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb026c9eb1051: [X86] Add missing features for ivybridge, sandybridge and knl in… (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANG

[clang] b026c9e - [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

Author: Freddy Ye Date: 2023-07-03T08:13:17+08:00 New Revision: b026c9eb1051c854ff13980cd30369f60b9a88c3 URL: https://github.com/llvm/llvm-project/commit/b026c9eb1051c854ff13980cd30369f60b9a88c3 DIFF: https://github.com/llvm/llvm-project/commit/b026c9eb1051c854ff13980cd30369f60b9a88c3.diff LOG

[PATCH] D154270: [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4bae3fd8ede: [clang][CodeGen] Fix global variables initialized with an inheriting… (authored by efriedma). Repository: rG LLVM Github Monorepo C

[clang] b4bae3f - [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

Author: Eli Friedman Date: 2023-07-02T14:25:25-07:00 New Revision: b4bae3fd8ede10026a6f6e1caaec476125f5ac67 URL: https://github.com/llvm/llvm-project/commit/b4bae3fd8ede10026a6f6e1caaec476125f5ac67 DIFF: https://github.com/llvm/llvm-project/commit/b4bae3fd8ede10026a6f6e1caaec476125f5ac67.diff

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song added a comment. In D144829#4465193 , @eddyz87 wrote: > Hi Yonghong, > > What is the current plan for these changes? > I'd like to refresh D140804 to make BPF_ST > instruction available for cpu v4. > I see

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 536623. philnik edited the summary of this revision. philnik added a comment. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langua

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo updated this revision to Diff 536622. sousajo added a comment. Thanks ^^ added the release note. Can someone please land it for me? Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154297/new/ https://reviews.llvm.org/D154297 Files: clang-tools-extra/clang-t

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 536620. philnik marked 16 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langu

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

aaron.ballman added a comment. FWIW, the precommit CI Windows bot found an issue with the newly added test case. Maybe test the Itanium and MS ABIs separately? (Uncertain if an Itanium-only test is appropriate but that's another option.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D154284: [C11] Correct global atomic pointer initialization from an integer constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b69eabdc187: [C11] Correct global atomic pointer initialization from an integer constant (authored by aaron.ballman). Changed prior to commit: ht

[clang] 7b69eab - [C11] Correct global atomic pointer initialization from an integer constant

Author: Aaron Ballman Date: 2023-07-02T14:41:21-04:00 New Revision: 7b69eabdc18799e4a6c61b79b52d330c6ada URL: https://github.com/llvm/llvm-project/commit/7b69eabdc18799e4a6c61b79b52d330c6ada DIFF: https://github.com/llvm/llvm-project/commit/7b69eabdc18799e4a6c61b79b52d330c6ada.diff

[PATCH] D154284: [C11] Correct global atomic pointer initialization from an integer constant

aaron.ballman added a comment. In D154284#4467154 , @efriedma wrote: > The testcase doesn't actually trigger the assertion... but I guess it still > tests the output, so that's probably okay? Maybe add a case `static > _Atomic(int *) glob_pointer_from_

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks good, probably hasCanonicalType would be sufficient but hasUnqualifiedDesugaredType will also do a job. Release notes need to be updated. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D154284: [C11] Correct global atomic pointer initialization from an integer constant

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. The testcase doesn't actually trigger the assertion... but I guess it still tests the output, so that's probably okay? Maybe add a case `static _Atomic(int *) glob_pointer_from_long = 0LL

[PATCH] D154270: [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2459 + if (!isa(Arg.getAnyValue())) +Arg.getAnyValue()->setName(D.getName()); rsmith wrote: > Is it feasible to only set the name if the value doesn't already have a name, > or do we

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen added a comment. `clang/test/SemaTemplate/aggregate-deduction-candidate.cpp` seems need updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new/ https://reviews.llvm.org/D154301 ___ cfe-c

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen added a comment. Thanks for catching this. The change LGTM. I think this is https://wg21.link/cwg2681. Could you please move the test to `clang/test/CXX/drs/dr26xx.cpp` and keep only these tests that are in the DR? Then you could run `clang/www/make_cxx_dr_status` to update `clang/www/cx

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/docs/ReleaseNotes.rst:552 (`#63503 `_) +- Fixed parsing of elaborated t

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73 + // puts the width and preicision first. + std::vector> ArgRotates; + PiotrZSL wrote: > mikecrowe wrote: > > PiotrZSL wrote: > > > NOTE: You can use std:

[PATCH] D153881: Create diagnostic group for definition deprecation warning

aaron.ballman added a comment. I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but separate `constexpr` out into its own warning flag, but I'm also not opposed. Can you explain the need a bit more though? I think our belief was that silencing this diagnostic was pretty trivi

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

PiotrZSL added a comment. To be honest, I do not see to much use case for this check. But that's fine. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp:46-51 + StatementMatcher StrFormatMatcher = + callExpr(callee(functionDecl(matchers::matchesAnyL

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73 + // puts the width and preicision first. + std::vector> ArgRotates; + mikecrowe wrote: > PiotrZSL wrote: > > NOTE: You can use std::pair here. > True, but

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a subscriber: rjmccall. aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3879 + + Out << "9__RVV_VLSI" << 'u' << TypeNameStr.size() << TypeNameStr << "Lj" << VecSizeInBits << "EE

[PATCH] D147888: Update declaration message of extern linkage

aaron.ballman added a comment. In D147888#4467002 , @Krishna-13-cyber wrote: > In D147888#4466998 , @aaron.ballman > wrote: > >> I think the existing wording is pretty reasonable, changing "non-static >> declar

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4466998 , @aaron.ballman wrote: > I think the existing wording is pretty reasonable, changing "non-static > declaration" into "extern declaration" isn't really giving the user any more > information to help

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

aaron.ballman added a comment. In D153510#4441541 , @craig.topper wrote: > @aaron.ballman The backend crashes at -O0 when scalable vector variables are > declared because the stack frame code doesn't expect to see them when the > vector extension isn't

[PATCH] D147888: Update declaration message of extern linkage

aaron.ballman added a comment. I think the existing wording is pretty reasonable, changing "non-static declaration" into "extern declaration" isn't really giving the user any more information to help them resolve the issue. "please pick exactly one" doesn't seem likely to help the user either -

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

MitalAshok created this revision. Herald added a project: All. MitalAshok edited the summary of this revision. MitalAshok added reviewers: ychen, aaron.ballman, cor3ntin. MitalAshok added a subscriber: cfe-commits. MitalAshok retitled this revision from "Fix CTAD with string literals adding extra

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad96f25b9365: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Gi

[clang] ad96f25 - [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

Author: Yaxun (Sam) Liu Date: 2023-07-02T11:10:06-04:00 New Revision: ad96f25b9365d65459740142a24db4a339705099 URL: https://github.com/llvm/llvm-project/commit/ad96f25b9365d65459740142a24db4a339705099 DIFF: https://github.com/llvm/llvm-project/commit/ad96f25b9365d65459740142a24db4a339705099.dif

[PATCH] D153017: [analyzer] Fix false negative when using a nullable parameter directly without binding to a variable

tripleCC added a comment. In D153017#4428432 , @steakhal wrote: > LGTM; I'll commit this on Monday. Oops, It seems that I missed the invitation, I just noticed the invitation email in my gmail now ... I will request Chris to send the invitation again. T

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

mikecrowe updated this revision to Diff 536595. mikecrowe added a comment. Use emplace_back rather than push_back(make_tuple()) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154283/new/ https://reviews.llvm.org/D154283 Files: clang-tools-extra/c

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

mikecrowe added a comment. Thanks for the review. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:356-357 + if (ArgCount) +ArgRotates.push_back( +std::make_tuple(FS.getArgIndex() + ArgsOffset, ArgCount)); +} PiotrZSL wrote:

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f986bffc51a: [clang] Remove CGBuilderTy::CreateElementBitCast (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 6f986bf - [clang] Remove CGBuilderTy::CreateElementBitCast

Author: Youngsuk Kim Date: 2023-07-02T10:40:16-04:00 New Revision: 6f986bffc51a243a1f4328b11624a0f21918a78f URL: https://github.com/llvm/llvm-project/commit/6f986bffc51a243a1f4328b11624a0f21918a78f DIFF: https://github.com/llvm/llvm-project/commit/6f986bffc51a243a1f4328b11624a0f21918a78f.diff

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

Eugene.Zelenko added a comment. Please mention this change in Release Notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154297/new/ https://reviews.llvm.org/D154297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. Thank you for adding this new documentation! In general, this is looking fantastic. Given how closely tied the C indexing APIs are with the rest of the compiler internals, I think it'd be helpful to add links to https://clang.llvm.org/docs/InternalsManual.html to

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

yaxunl created this revision. yaxunl added reviewers: tra, rsmith. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. nvcc allows using std::malloc and std::free in device code. When std::malloc or std::free is passed as a templat

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

PiotrZSL added a comment. Just few nits, from functionally point of view looks fine. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:356-357 + if (ArgCount) +ArgRotates.push_back( +std::make_tuple(FS.getArgIndex() + ArgsOffset, ArgCount));

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. friendly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. In D145302#4441334 , @kadircet wrote: > thanks LG and seems to be working in a couple build configurations I tried. > but there might still be breakages in different configs, so please be on the > watchout after landing thi

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/tool/CMakeLists.txt:37 + +target_link_libraries(clangdMain + PRIVATE kadircet wrote: > you can merge this with the previous rule fixed Comment at: clang-tools-extra/clang

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko marked an inline comment as not done. ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/tool/CMakeLists.txt:11 + ClangdToolMain.cpp $ ) kadircet wrote: > we should move this into `clangdMain` target now Unfortunately it

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1054 +SVal SizeV, QualType SizeTy) { + return InvalidateBufferAux( + C, S, BufE, BufV, steakhal wrote: > OikawaKirie wrote: > > steakhal wrote: > > > Sho

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie updated this revision to Diff 536578. OikawaKirie marked 12 inline comments as done and an inline comment as not done. OikawaKirie added a comment. 1. Function and variable names: functions: lower camel, variables: upper camel, lambdas: upper camel 2. std::function -> llvm::function_r

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 536577. ivanmurashko added a comment. Fixed clangd unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/tool/CMakeLists.t

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, jeroen.dobbelaere, arphaman, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154285/new/ https://reviews.llvm.org/D154285 ___ c

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:16384 + Expr *SizeExpression, + Expr *PtrExpression, ASTContext &Ctx, + EvalResult &Status)

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin updated this revision to Diff 536571. cor3ntin added a comment. Make EvaluateCharPointerAsString parameters const. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154290/new/ https://reviews.llvm.org/D154290 Files: clang/docs/ReleaseNotes