[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

dyung added a comment. Hi @yaxunl, your change appears to have broken the LLDB build. Can you take a look and revert if you time to investigate? https://lab.llvm.org/buildbot/#/builders/243/builds/9581 FAILED: tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.di

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

MaskRay added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:568 + // Group all the custom attributes by name. + StringMap> CustomSections; + const ConstantArray *CA = cast(V->getOperand(0)); "StringMap iteration order, howe

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When tests fail in UncheckedOptionalAccessModelTest.cpp, this prints the name

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

mboehme updated this revision to Diff 542330. mboehme added a comment. Format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155788/new/ https://reviews.llvm.org/D155788 Files: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessM

[clang-tools-extra] 528447f - [clang-tools-extra] the message in a static_assert is not always a string literal

Author: Corentin Jabot Date: 2023-07-20T09:23:08+02:00 New Revision: 528447ff265a6c58b43af6cff2a3ee0ce5784331 URL: https://github.com/llvm/llvm-project/commit/528447ff265a6c58b43af6cff2a3ee0ce5784331 DIFF: https://github.com/llvm/llvm-project/commit/528447ff265a6c58b43af6cff2a3ee0ce5784331.diff

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir updated this revision to Diff 542333. schittir added a comment. Please consider these changes for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 Files: clang/lib/AST/APValue.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme updated this revision to Diff 542337. mboehme marked 11 inline comments as done. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155446/new/ https://reviews.llvm.org/D155446 Fil

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

MaskRay added a comment. `registerTargetGlobalVariable` has a iteration order issue using StringMap, caught by D155789 curl -L 'https://reviews.llvm.org/D155789?download=1' | patch -p1 cmake ... -DLLVM_ENABLE_REVERSE_ITERATION=on ninja -C ... check-llvm-u

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked 3 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:466 + return; +Env.setStorageLocationStrict(*S, *MemberLoc); } ymandel wrote: > This diff makes me very happy. :) Me too

[PATCH] D155361: [Tooling] Avoid boilerplate in common cases

sammccall added a comment. Example of using conusmeASTs + executeFromCommandLine (It's not that many extra lines of code, but they're not really easy ones to write, and to work out whether they're minimal/correct) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra created this revision. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. raghavendhra requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. > This commit is in support of future uninitialized memory handling and adds > alloca instruction support to getInitialValueOfAllocation. This unifies > initial > memory state querying

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 542360. FreddyYe added a comment. add clang releasenote Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Target

[clang] 1ff1cbb - [LoongArch][NFC] Revise preprocessor test init-loongarch.c

Author: Weining Lu Date: 2023-07-20T16:20:44+08:00 New Revision: 1ff1cbb595f0181360abbcfb54dacbe54f6301c8 URL: https://github.com/llvm/llvm-project/commit/1ff1cbb595f0181360abbcfb54dacbe54f6301c8 DIFF: https://github.com/llvm/llvm-project/commit/1ff1cbb595f0181360abbcfb54dacbe54f6301c8.diff LO

[PATCH] D155802: [clang][dataflow] Print the source line if we saw unexpected diagnostics in tests.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it easier to determine which line the unexpected happened on; previ

[clang] 443f490 - Revert "[CUDA][HIP] Use the same default language std as C++"

Author: Sylvestre Ledru Date: 2023-07-20T10:54:54+02:00 New Revision: 443f490b6aac4af28500f4b09b68a13260f4fba9 URL: https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 DIFF: https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9.dif

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

sylvestre.ledru added a comment. I reverted the patch for causing https://github.com/llvm/llvm-project/issues/63974 https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

balazske updated this revision to Diff 542383. balazske added a comment. using clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/new/ https://reviews.llvm.org/D155574 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin updated this revision to Diff 542389. cor3ntin added a comment. Correctly track constructor location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155175/new/ https://reviews.llvm.org/D155175 Files: clang/include/clang/AST/RecursiveAST

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon added a comment. > Can you explain why the fix fixes the bug? Sure, let me try. To be honest, I'm not very familiar with the code either, so I'll describe how I came to the fix. I'll be using added test `clang/test/SemaTemplate/gh61159.cpp` as example of failing code. The issue happe

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 added a comment. Herald added a subscriber: wangpc. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139267/new/ https://reviews.llvm.org/D139267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 marked 3 inline comments as done. strimo378 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org/D154186 ___ cfe-commits mailing list cfe-com

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

kiranchandramohan added a comment. Please check the failing test. Comment at: flang/test/Driver/fsave-optimization-record.f90:14 +! RUN: rm -f %t.opt.yaml +! RUN: %flang -fsave-optimization-record -S -o %t.o %s +! RUN: cat %t.opt.yaml | FileCheck %s

[clang] 578b0bd - [Clang][AArch64][SME] Add ZA zeroing intrinsics

Author: Bryan Chan Date: 2023-07-20T06:06:34-04:00 New Revision: 578b0bd4e621304a1ce367e87a53e59e404dec9b URL: https://github.com/llvm/llvm-project/commit/578b0bd4e621304a1ce367e87a53e59e404dec9b DIFF: https://github.com/llvm/llvm-project/commit/578b0bd4e621304a1ce367e87a53e59e404dec9b.diff LO

[clang] f225898 - [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

Author: Bryan Chan Date: 2023-07-20T06:06:35-04:00 New Revision: f225898a7c6105aa34e64f9c7dbfed7ce3443331 URL: https://github.com/llvm/llvm-project/commit/f225898a7c6105aa34e64f9c7dbfed7ce3443331 DIFF: https://github.com/llvm/llvm-project/commit/f225898a7c6105aa34e64f9c7dbfed7ce3443331.diff LO

[clang] 15d16a7 - [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

Author: Bryan Chan Date: 2023-07-20T06:06:35-04:00 New Revision: 15d16a79a01f4fac718556809ecd00914dd7d7a2 URL: https://github.com/llvm/llvm-project/commit/15d16a79a01f4fac718556809ecd00914dd7d7a2 DIFF: https://github.com/llvm/llvm-project/commit/15d16a79a01f4fac718556809ecd00914dd7d7a2.diff LO

[clang] 4ae900c - [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

Author: Bryan Chan Date: 2023-07-20T06:06:36-04:00 New Revision: 4ae900c063634e19346b88913e28204a3fc47825 URL: https://github.com/llvm/llvm-project/commit/4ae900c063634e19346b88913e28204a3fc47825 DIFF: https://github.com/llvm/llvm-project/commit/4ae900c063634e19346b88913e28204a3fc47825.diff LO

[clang] aebde82 - [Clang][AArch64][SME] Add outer product intrinsics

Author: Bryan Chan Date: 2023-07-20T06:06:36-04:00 New Revision: aebde82b29a80b2849e2b5b1b0030f598edee9a4 URL: https://github.com/llvm/llvm-project/commit/aebde82b29a80b2849e2b5b1b0030f598edee9a4 DIFF: https://github.com/llvm/llvm-project/commit/aebde82b29a80b2849e2b5b1b0030f598edee9a4.diff LO

[clang] 2c38740 - [Clang][AArch64][SME] Generate target features from +(no)sme.* options

Author: Bryan Chan Date: 2023-07-20T06:06:37-04:00 New Revision: 2c38740ca661a10866a796db105752e15372ddce URL: https://github.com/llvm/llvm-project/commit/2c38740ca661a10866a796db105752e15372ddce DIFF: https://github.com/llvm/llvm-project/commit/2c38740ca661a10866a796db105752e15372ddce.diff LO

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG578b0bd4e621: [Clang][AArch64][SME] Add ZA zeroing intrinsics (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf225898a7c61: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR) (authored by bryanpkc). Repository: rG LLVM Github Monorepo

[PATCH] D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15d16a79a01f: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length (authored by bryanpkc). Changed prior to commit: https://re

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ae900c06363: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile (authored by bryanpkc). Repository: rG LLVM Github Monore

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaebde82b29a8: [Clang][AArch64][SME] Add outer product intrinsics (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c38740ca661: [Clang][AArch64][SME] Generate target features from +(no)sme.* options (authored by bryanpkc). Repository: rG LLVM Github Monorepo

[PATCH] D155808: [clang][driver] Missing the condition in ISARMBigEndain function.

simpal01 created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. simpal01 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. IsARMBIgEndian function returns true only if: 1. The triples are either

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542404. victorkingi added a comment. Attempt to fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark created this revision. Herald added a project: All. danlark requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In sorting elements can compare with themselves and sometimes assert further down the line was triggered Repository: rG

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542407. victorkingi added a comment. Addressed kiranchandramohan comment on fsave-optimization-record.f90 test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1922 +// RUN: --target=x86_64 \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_GNRD_M64 // CHECK_GNR_M64: #define __AES__ 1 Maybe create a common CHE

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 542412. RIscRIpt marked 5 inline comments as done. RIscRIpt added a comment. Addressed review comments, rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1310-1311 + case tok::kw_L__FUNCSIG__: // primary-expression: L__FUNCSIG__ [MS] +if (!getLangOpts().MicrosoftExt || +!TokenIsLikeStringLiteral(NextToken(), getLangOpts())) { + Res = Actio

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. @jacquesguan yes I agree, let's hold off on merging this until that PR is merged as it looks like it's quite close. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 __

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

sgraenitz added a comment. That's an excellent patch! I didn't expect it could be so compact. Thanks for working on this! Please find below 2 inline comments on details. On July 25th release/17.x will branch away. It would be great to land this before and have it in the upcoming release.

[PATCH] D155808: [clang][driver] Missing the condition in IsARMBigEndain function.

peter.smith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:39 // normalized triple so we must handle the flag here. bool arm::isARMBigEndian(const llvm::Triple &Triple, const ArgList &Args) { + if ((Triple.getArch() == llvm::Triple::arm ||

[clang] 7d4e14c - [clang][OpenMP] Add interop support for multiple depend clauses

Author: Michael Halkenhaeuser Date: 2023-07-20T06:26:19-04:00 New Revision: 7d4e14c76b4e79a8718f3cb434cfcacfabd700c3 URL: https://github.com/llvm/llvm-project/commit/7d4e14c76b4e79a8718f3cb434cfcacfabd700c3 DIFF: https://github.com/llvm/llvm-project/commit/7d4e14c76b4e79a8718f3cb434cfcacfabd700

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4e14c76b4e: [clang][OpenMP] Add interop support for multiple depend clauses (authored by mhalk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked an inline comment as done. mboehme added a comment. CI failures look unrelated: - Windows failure is in SemaCXX/static-assert-cxx26.cpp. I can't see a way in which this patch should affect the failure of this test (the dataflow framework isn't used in Clang itself) - check-format

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} cor3ntin wrote: > tbaeder wrote: > > tbaeder wrote: > > > cor3ntin wrote: > > > > what is missing to enable the existing s

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder updated this revision to Diff 542420. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D155813: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that the redundancy between these two classes has been eliminated, these c

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214 + if (BO->isPtrMemOp()) +return this->visit(RHS); + aaron.ballman wrote: > Do we need similar changes for unary operators, pointer arithmetic operators, > etc? In

[PATCH] D155814: Fix the linting problems which caused `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 created this revision. AMP999 added a reviewer: clang. AMP999 added a project: clang. Herald added a reviewer: NoQ. Herald added a project: All. AMP999 requested review of this revision. Herald added a subscriber: cfe-commits. `clang/utils/ci/run-buildbot check-format` command in build proc

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155165/new/ https://reviews.llvm.org/D155165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155816: [Tooling/Inclusion] Make the Recognizer work for C99 code.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. C99 is the the earliest C version provided by the language opt. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1922 +// RUN: --target=x86_64 \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_GNRD_M64 // CHECK_GNR_M64: #define __AES__ 1 RKSimon wrote: > Maybe c

[clang] 465f65a - [clang][Interp][NFC] Add a debugging assertion

Author: Timm Bäder Date: 2023-07-20T14:06:09+02:00 New Revision: 465f65a549e5fd092f6da8b09d0f1d50ca7f4ddc URL: https://github.com/llvm/llvm-project/commit/465f65a549e5fd092f6da8b09d0f1d50ca7f4ddc DIFF: https://github.com/llvm/llvm-project/commit/465f65a549e5fd092f6da8b09d0f1d50ca7f4ddc.diff LO

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin updated this revision to Diff 542435. cor3ntin added a comment. Remove an assert (added in a previous iteration of this PR). Unfortunately, we sometimes do emit the address of an immediate function, after we establish the program is ill-formed - as we still proceed to code gen. cpp

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 542436. RIscRIpt marked 3 inline comments as done. RIscRIpt added a comment. Herald added a subscriber: MaskRay. Addressed review comments and rebased onto main. I have limited support of this attribute to `-fms-compatibility-version` 19.33+ (Visual Studio

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3609-3611 +.. Note:: To use a ``[[msvc::constexpr]]`` function in a constant context, + one may want to create a ``constexpr`` function-wrapper and invoke the + ``[[msvc::constexpr]]`` function

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 542438. RIscRIpt added a comment. add HEAD~2 patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475/new/ https://reviews.llvm.org/D134475 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

cor3ntin added a comment. @aaron.ballman any opinion on that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 542441. RIscRIpt added a comment. Fix clang/test/SemaCXX/ms-constexpr.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475/new/ https://reviews.llvm.org/D134475 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. A verbatim header usually corresponds to a symbol from a header with a

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

sammccall updated this revision to Diff 542444. sammccall added a comment. Herald added a subscriber: ormris. clean up some leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155819/new/ https://reviews.llvm.org/D155819 Files: clang-tools-e

[clang] 3e3cdf9 - [LoongArch][NFC] Remove incorrect notes in clang tests

Author: Weining Lu Date: 2023-07-20T20:26:12+08:00 New Revision: 3e3cdf9a480f0c54e94b011a05443c60a7b20375 URL: https://github.com/llvm/llvm-project/commit/3e3cdf9a480f0c54e94b011a05443c60a7b20375 DIFF: https://github.com/llvm/llvm-project/commit/3e3cdf9a480f0c54e94b011a05443c60a7b20375.diff LO

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 542446. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/Rel

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

kadircet added a comment. there are unittests for tweaks under `clang-tools-extra/clangd/unittests/tweaks/` can you create one for `OrganizeImports` there and test this in there? i've got another concern around triggering of this interaction. in theory code-action context has a `only` field, di

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

michaelplatings added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +// SME-SUBFEATURE-CONFLICT-REV

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

pengfei added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2496 // CHECK_SRF_M32: #define __PTWRITE__ 1 +// CHECK_GRR_M32: #define __RAOINT__ 1 // CHECK_SRF_M32: #define __RDPID__ 1 This is easy to be confused. How about add a n

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, hev, wangleiat. Herald added a subscriber: hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, L

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added a comment. FYI, my current aim is to land that early in the Clang 18 cycle, that should give us time to find any remaining issue and maybe improve debugger support! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://r

[PATCH] D155826: [Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

AlexVlx created this revision. AlexVlx added reviewers: yaxunl, arsenm. AlexVlx added a project: clang. Herald added a project: All. AlexVlx requested review of this revision. Herald added subscribers: cfe-commits, wdng. This patch adds the Driver changes needed by the standard algorithm offload

[clang] 8b5d3ba - [clang][dataflow] Print the source line if we saw unexpected diagnostics in tests.

Author: Martin Braenne Date: 2023-07-20T12:40:22Z New Revision: 8b5d3ba829c162fd4890fd65a4629ce0715825ee URL: https://github.com/llvm/llvm-project/commit/8b5d3ba829c162fd4890fd65a4629ce0715825ee DIFF: https://github.com/llvm/llvm-project/commit/8b5d3ba829c162fd4890fd65a4629ce0715825ee.diff LOG

[PATCH] D155802: [clang][dataflow] Print the source line if we saw unexpected diagnostics in tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b5d3ba829c1: [clang][dataflow] Print the source line if we saw unexpected diagnostics in… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155788/new/ https://reviews.llvm.org/D155788 ___

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

xry111 added a comment. Do we need to convert Xuerui's label alignment change to use the -mtune framework? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 ___

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

jplehr added a comment. Not an expert here, only some minor comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1008 + std::vector *getLLVMCompilerUsed() { +return &LLVMCompilerUsed; Return a reference instead of pointer here? Comm

[clang] 477ee05 - [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

Author: Martin Braenne Date: 2023-07-20T12:52:53Z New Revision: 477ee05f83c6cc4f11b45e61e606934b99e72290 URL: https://github.com/llvm/llvm-project/commit/477ee05f83c6cc4f11b45e61e606934b99e72290 DIFF: https://github.com/llvm/llvm-project/commit/477ee05f83c6cc4f11b45e61e606934b99e72290.diff LOG

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG477ee05f83c6: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155788

[clang] 3203d3e - [clang][Interp][NFC] Add InterpStack::dump()

Author: Timm Bäder Date: 2023-07-20T14:56:44+02:00 New Revision: 3203d3eac4d14f44d6e660d8835c10a42a07fee2 URL: https://github.com/llvm/llvm-project/commit/3203d3eac4d14f44d6e660d8835c10a42a07fee2 DIFF: https://github.com/llvm/llvm-project/commit/3203d3eac4d14f44d6e660d8835c10a42a07fee2.diff LO

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

FreddyYe updated this revision to Diff 542476. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 Files: clang/test/Pre

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

AlexVlx created this revision. AlexVlx added reviewers: yaxunl, jlebar, tra. AlexVlx added a project: clang. Herald added subscribers: ChuanqiXu, s.egerton, simoncook, asb, dschuff. Herald added a project: All. AlexVlx requested review of this revision. Herald added subscribers: cfe-commits, wangpc

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat abandoned this revision. wangleiat added a comment. We have decided to keep it unchanged. Thank you, everyone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151298/new/ https://reviews.llvm.org/D151298 ___

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1 +// CHECK_GNRD_M64: #define __AMX_COMPLEX__ 1 -

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

antoniofrighetto updated this revision to Diff 542483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155716/new/ https://reviews.llvm.org/D155716 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

antoniofrighetto added a comment. Thanks a lot for the reviews and for pointing out clang tests as well, there was a minor update to do there too! Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1424 +MCSection *TargetLoweringObjectFileMachO::getSectionForCommand

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4517882 , @sylvestre.ledru wrote: > I reverted the patch for causing > https://github.com/llvm/llvm-project/issues/63974 > https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 Thanks. I

[clang] 5522e31 - [clang][NFC] Simplify SourceLocExpr::EvaluateInContext

Author: Timm Bäder Date: 2023-07-20T15:15:57+02:00 New Revision: 5522e316f91ef490b34ffdf2c21fc8fed8affe5f URL: https://github.com/llvm/llvm-project/commit/5522e316f91ef490b34ffdf2c21fc8fed8affe5f DIFF: https://github.com/llvm/llvm-project/commit/5522e316f91ef490b34ffdf2c21fc8fed8affe5f.diff LO

[PATCH] D155584: [clang][NFC] Simplify SourceLocExpr::EvaluateInContext

This revision was automatically updated to reflect the committed changes. Closed by commit rG5522e316f91e: [clang][NFC] Simplify SourceLocExpr::EvaluateInContext (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155584/new/ https:

[clang] f8a36d8 - [IR] Mark add constant expressions as undesirable

Author: Nikita Popov Date: 2023-07-20T15:24:19+02:00 New Revision: f8a36d8c3e264c4fccf8058e699201a452ea7bb7 URL: https://github.com/llvm/llvm-project/commit/f8a36d8c3e264c4fccf8058e699201a452ea7bb7 DIFF: https://github.com/llvm/llvm-project/commit/f8a36d8c3e264c4fccf8058e699201a452ea7bb7.diff

[clang] af67614 - [clang][Interp] Call dtor of Floating values

Author: Timm Bäder Date: 2023-07-20T15:27:16+02:00 New Revision: af67614f79059686399e2808c80658af783f48d3 URL: https://github.com/llvm/llvm-project/commit/af67614f79059686399e2808c80658af783f48d3 DIFF: https://github.com/llvm/llvm-project/commit/af67614f79059686399e2808c80658af783f48d3.diff LO

[PATCH] D154928: [clang][Interp] Call dtor of Floating values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf67614f7905: [clang][Interp] Call dtor of Floating values (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d6b0af0 - [clang][Interp] Add more shift error checking

Author: Timm Bäder Date: 2023-07-20T15:35:47+02:00 New Revision: d6b0af0574ca21ae7b0fa6aa364345159f451da1 URL: https://github.com/llvm/llvm-project/commit/d6b0af0574ca21ae7b0fa6aa364345159f451da1 DIFF: https://github.com/llvm/llvm-project/commit/d6b0af0574ca21ae7b0fa6aa364345159f451da1.diff LO

[PATCH] D150209: [clang][Interp] Add more shift error checking

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6b0af0574ca: [clang][Interp] Add more shift error checking (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews

  1   2   3   >