[clang] ce16c3c - [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter

Author: Justin Bogner Date: 2023-08-13T23:58:27-07:00 New Revision: ce16c3cf30f5e63a395927ede95161393383d636 URL: https://github.com/llvm/llvm-project/commit/ce16c3cf30f5e63a395927ede95161393383d636 DIFF: https://github.com/llvm/llvm-project/commit/ce16c3cf30f5e63a395927ede95161393383d636.diff

[PATCH] D157146: [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce16c3cf30f5: [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter (authored by bogner). Changed prior to commit: https://reviews.llvm

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

nridge added a comment. Haven't looked at everything yet, but wanted to mention one thing I noticed. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:91 + +// Local variables declared inside of the selected lambda cannot go out of +// scope. The

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski created this revision. awarzynski added a reviewer: bogner. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, wangpc, jplehr, sstefan1, jdoerfert, MaskRay. Herald added a reviewer:

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

kadircet added a comment. In D154503#4576481 , @aaron.ballman wrote: > In D154503#4576475 , @kadircet > wrote: > >> In D154503#4576442 , >> @aaron.ballman wrote: >> >>>

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

awarzynski added a comment. In D157151#4582441 , @bogner wrote: > This is a little bit complicated by the fact that the Option library is > already partially extracted out of clang (and used for other drivers, like > lld and lldb). The "Default" visibil

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Missing storeOptions metod, everyting else looks +- fine. Comment at: clang-tools-extra/clang-tidy/bugprone/LambdaFunctionNameCheck.cpp:81 Result.Sourc

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM (+-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 __

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, rsmith. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Member functions and static variable definitions may use typedefs that are

[clang] ba475a4 - [clang-repl] Disambiguate global namespace identifiers

Author: Jonas Hahnfeld Date: 2023-08-14T10:11:27+02:00 New Revision: ba475a4a3440a21e5de6a39a16215836f2614f04 URL: https://github.com/llvm/llvm-project/commit/ba475a4a3440a21e5de6a39a16215836f2614f04 DIFF: https://github.com/llvm/llvm-project/commit/ba475a4a3440a21e5de6a39a16215836f2614f04.diff

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGba475a4a3440: [clang-repl] Disambiguate global namespace identifiers (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157480/new/ https

[PATCH] D157497: feat: Migrate isArch16Bit

asb added a comment. Is there some separate discussion thread or proposal about this refactoring and its motivations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497 _

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

tblah added inline comments. Comment at: clang/lib/Driver/Driver.cpp:6472-6473 if (IsFlangMode()) { // TODO: Does flang really want *all* of the clang driver options? // We probably need to annotate more specifically. +return llvm::opt::Visibility(options::FlangO

[PATCH] D154382: [ClangRepl] support code completion at a REPL

sammccall added a comment. This mostly looks good. My main concern is adding code to the parser to suppress errors when code completing: this is unlikely to be the only such place. Existing consumers seem happy to ignore errors, if this doesn't work for clang-repl it'd be good to understand wh

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 549853. bogner added a comment. Use "ClangOption" rather than "Default" in Options.td, as per the conversation in https://reviews.llvm.org/D157151 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/ https

[PATCH] D157855: [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. BEFORE this patch, compound assignment operator against uninitialized object such as `uninit += 1` was

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

nikic added a comment. @jmciver Thanks for the context. I would recommend you to put up the patch you have based on top of this, because it's pretty hard to tell whether this API design makes sense without seeing the use. I have some doubts about that, for two reasons: - If I understand correc

[clang] 00158ae - [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

Author: Alejandro Aguirre Date: 2023-08-14T11:33:33+01:00 New Revision: 00158ae236ddfdc7dda5ea7a8a20e3921007ba86 URL: https://github.com/llvm/llvm-project/commit/00158ae236ddfdc7dda5ea7a8a20e3921007ba86 DIFF: https://github.com/llvm/llvm-project/commit/00158ae236ddfdc7dda5ea7a8a20e3921007ba86.d

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG00158ae236dd: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics (authored by alexguirre, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4583904 , @awarzynski wrote: > This can be tweaked in `getOptionVisibilityMask` (extracted from this patch): > > llvm::opt::Visibility > Driver::getOptionVisibilityMask(bool UseDriverMode) const { > if (!UseDriv

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

bogner added a comment. I can't speak to which flags should be present in flang-new or not, but in principle this looks great. You'll need to update the patch to use the "ClangOption" spelling rather than "Default" of course, as discussed in https://reviews.llvm.org/D157151

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 549878. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Hubert's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156237/new/ https://reviews.llvm.org/D156237 Files: clang

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:431-436 +if (Expr.isInvalid()) { + SawError = true; + break; +} else { + Exprs.push_back(Expr.get()); +} hubert.reinterpretcast wrote: > cor3ntin wrote: > > aaron

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549879. victorkingi marked 6 inline comments as done. victorkingi added a comment. code refactoring in reference to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.or

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy updated this revision to Diff 549881. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157104/new/ https://reviews.llvm.org/D157104 Files: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp clang/test/Analysis/out-of-bounds.c In

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

efocht accepted this revision. efocht added a comment. This revision is now accepted and ready to land. Looks good. The default should be able to use intrinsics, hiding this only makes things complicated and gets users confused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy marked 2 inline comments as done. donat.nagy added a comment. I didn't upload the test results yet because right now there is some incompatibility between our local fork and the upstream. I hope that it'll be fixed soon, but until then I can't use our automated tools to run the analys

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549882. victorkingi added a comment. added tests for "no" variants of Rpass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549887. victorkingi added a comment. added comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h flang/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:156-158 +/// Parse a remark command line argument. It may be missing, disabled/enabled by +/// '-R[no-]group' or specified with a regular expression by '-Rgroup=regexp'. +/// On top of that,

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:169-171 + clang::ProcessWarningOptions(flang->getDiagnostics(), + flang->getDiagnosticOpts()); + victorkingi wrote: > awarzynski wro

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi marked 6 inline comments as done. victorkingi added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:927 +class StandaloneBackendConsumer : public llvm::DiagnosticHandler { + awarzynski wrote: > Why `StandaloneBackendConsumer`? Is

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

pengfei added a comment. In D157297#4583802 , @lygstate wrote: > In D157297#4571572 , @pengfei wrote: > >> The description is not clear to me. You should describe the reason rather >> than phenomenon. >> >> My un

[PATCH] D152423: [RISCV] Add function that check extension name with version

BeMg updated this revision to Diff 549892. BeMg added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebase and update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152423/new/ https://reviews.llvm.org/D1

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

DavidTruby added a comment. This looks good to me (minus the issue @tblah mentioned), while this will mean that we also error on gfortran options we don't recognize, I don't personally think that's a problem as in my personal experience Fortran users are used to different compilers accepting di

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 549896. yronglin added a comment. Add test to check generated LLVM IR, and fix crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/include/clang/Se

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16869 +/// The code point needs to be zero-extended to 32-bits. +void ConvertCharToString(uint32_t CodePoint, const BuiltinType *BTy, + unsigned TyWidth, llvm::raw_ostream &OS) { --

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. @cor3ntin I have reused `EnsureImmediateInvocationInDefaultArgs` to rewrite `CXXDefaultArgExpr`, does this is a correct approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701

[PATCH] D86993: Document Clang's expectations of the C standard library.

nikic added a comment. @aaron.ballman I wanted to check back whether the linked document is what you had in mind, or whether some more/else would be needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86993/new/ https://reviews.llvm.org/D86993

[PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. This discussion was the main motivation for this change. https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 As a result, Triple should become a data class, and its dependencies such as Architecture, Operating System etc. represent in the form of inte

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 added a comment. Thanks @efocht . I appreciate if someone working on clang can review this patch too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 ___

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

balazske added a comment. A simple test should be added to StructuralEquivalenceTest.cpp too to check if ignore (and not ignore) depth works. I think this solution is not always correct, but is still an improvement. Comment at: clang/include/clang/AST/ASTStructuralEquivalence

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157814/new/ https://reviews.llvm.org/D157814

[PATCH] D157795: [clang] Add missing field to SectionAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157795/new/ https://reviews.llvm.org/D157795

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

sammccall added a comment. LSP is fairly clear here and our behavior here seems to be pretty correct. - `name` is "the name of this symbol", - detail is "More detail for this symbol, e.g the signature of a function.". We're providing the type as detail: `void()` (for functions just `()` might be

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

aaron.ballman added inline comments. Comment at: clang/lib/AST/JSONNodeDumper.cpp:541-548 +void JSONNodeDumper::VisitDeprecatedAttr(const DeprecatedAttr *DA) { + JOS.attribute("message", DA->getMessage()); + JOS.attribute("replacement", DA->getReplacement()); +} + +void JSONNod

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added a comment. In D112921#4581641 , @rnk wrote: > What are the next steps here? Have concerns been addressed? The CI failures > seem unrelated (libcxx tests is an AIX bot out of disk, clang CI is an > interpreter test that seems unrelate

[PATCH] D157775: [clang] Add aliasee field to AliasAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157775/new/ https://reviews.llvm.org/D157775

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157781/new/ https://reviews.llvm.org/D157781

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot abandoned this revision. florianhumblot added a comment. @sammccall I guess you're right, I'll look into getting a fix into vscode instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157080/new/ https://reviews.llvm.org/D157080 ___

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

kadircet created this revision. kadircet added reviewers: sammccall, aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This makes sure

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

ealcdan created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ealcdan requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Some options ta

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

asb accepted this revision. asb added a comment. LGTM, this seems like a good workaround. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157663/new/ https://reviews.llvm.org/D157663 ___ cfe-commits mailin

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, recoveryexpr is a better fit here. These changes tend to cause occasional new error-handling crashes on under-tested paths, but I guess it's a good time in the release cycle for th

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added a comment. Pre-merge check fails are unrelated - fatal error C1060: compiler is out of heap space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157454/new/ https://reviews.llvm.org/D157454 ___ cfe-commits mailing list cfe-comm

[clang] 421c9bb - [NFC][Clang] Fix static analyzer concern

Author: Elizabeth Andrews Date: 2023-08-14T07:14:32-07:00 New Revision: 421c9bbf65b78e3410415cac2edf4e00bd4d38ca URL: https://github.com/llvm/llvm-project/commit/421c9bbf65b78e3410415cac2edf4e00bd4d38ca DIFF: https://github.com/llvm/llvm-project/commit/421c9bbf65b78e3410415cac2edf4e00bd4d38ca.d

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421c9bbf65b7: [NFC][Clang] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. In D153701#4563919 , @yronglin wrote: > Sorry for the late reply. I tried to investigate the memory impact of > creating these additional materializations by build the whole llvm-project > and compare the number of `Materializ

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 549925. ro added a comment. Herald added a subscriber: mgrang. Updated based on discussions in Issue #53709: - Sort Solaris GCC prefixes in reverse version order so the latest version is picked. - Update testcase to match. Tested on `amd64-pc-solaris2.11` and `x

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); Anastasia wrote: > pmatos wrote: > > Keenuts wrote: > > > pmatos wrote: > > > > I am not well-versed in SPIRV

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille updated this revision to Diff 549929. serge-sans-paille added a comment. Only output extra fields if they are not empty CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783 Files: clang/include/clang/AST/JSONNodeDumper.h clang

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Review taken into account. Thanks for handling this batch of patches o/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this change clang didn't emit missing-field-initializers warning for designated initializers. The comments say

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

PiotrZSL added a comment. This wont fix issue, simply because problem happen during reading -1, not during dumping, and per documentation -1 was a valid value. Same issue happen in other checks that use -1. Most probably best way would be to change those variables into std::int64_t, in C++ crea

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

PiotrZSL added a comment. I agree that this change is an improvement that is welcome, but that's not a fix for a #60217. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157869/new/ https://reviews.llvm.org/D157869 __

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 549938. DiggerLin marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

kadircet updated this revision to Diff 549939. kadircet marked 2 inline comments as done. kadircet added a comment. - Use Expr* instead of ExprResult - Add dump test to demonstrate new RecoveryExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15786

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

kadircet added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3026 + void ActOnParamDefaultArgumentError(Decl *param, SourceLocation EqualLoc, + ExprResult DefaultArg); ExprResult ConvertParamDefaultArgument(ParmVarDecl *Para

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added inline comments. Comment at: clang/test/lit.cfg.py:391 if "system-aix" in config.available_features: -config.substitutions.append(("llvm-nm", "env OBJECT_MODE=any llvm-nm")) -config.substitutions.append(("llvm-ar", "env OBJECT_MODE=any llvm-ar")) + conf

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157783/new/ https://reviews.llvm.org/D157783 ___ cfe-commits mailing lis

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. eandrews requested review of this revision. https://reviews.llvm.org/D15

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay added a comment. Thanks for the update. Regarding testing, it seems that unittests will be more convenience than creating so many placeholder files in `Inputs/`. `clang/unittests/Driver/ToolChainTest.cpp` `TEST(ToolChainTest, VFSGCCInstallation)` has an example for Linux. You can add an

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157808/new/ https://reviews.llvm.org/D157808 ___ cfe-commits mailing lis

[clang] bbc0f99 - [Driver] Default riscv*- triples to -fdebug-default-version=4

Author: Fangrui Song Date: 2023-08-14T08:26:52-07:00 New Revision: bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6 URL: https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6 DIFF: https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6.diff

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc0f99f3bc9: [Driver] Default riscv*- triples to -fdebug-default-version=4 (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D157663?vs=549233&id=549956#toc Repository: rG LLV

[clang] d7fcb5b - clang: Don't use grep in a test

Author: Matt Arsenault Date: 2023-08-14T11:28:41-04:00 New Revision: d7fcb5b6b5280dc61d5afe0920bb78a82cfe2f27 URL: https://github.com/llvm/llvm-project/commit/d7fcb5b6b5280dc61d5afe0920bb78a82cfe2f27 DIFF: https://github.com/llvm/llvm-project/commit/d7fcb5b6b5280dc61d5afe0920bb78a82cfe2f27.diff

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added a subscriber: ldionne. aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:16 +defined(__need_wint_t) || \ +(defined(__STDC_WANT_LIB_EXT1__) && __STDC_WANT_LIB_EXT1__ >= 1) ---

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

ealcdan added a comment. Thanks for the review. How should I procceed? Should I remove the "Fixes:" entry from the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157869/new/ https://reviews.llvm.org/D157869

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4581219 , @ellis wrote: > In D157632#4580576 , @zequanwu > wrote: > >> BTW, I noticed something strange with `-pgo-function-entry-coverage` when >> merging via llvm-profdata.

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews updated this revision to Diff 549960. eandrews added a comment. Applied review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 Files: clang/lib/Sema/SemaExprCXX.cpp Index: clang/lib/Sema/SemaExprCXX.cpp ==

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman added a comment. In D157793#4583698 , @iana wrote: > In D157793#4583663 , @MaskRay wrote: > >>> Apple needs a __need_ macro for va_list. Add one, and also ones for >>> va_start/va_arg/va_end, __va_c

[PATCH] D157855: [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

tbaeder added a comment. Generally LGTM, but I feel like the changes aren't c++2a specific (except for uninitialized variables in constexpr functions). Comment at: clang/lib/AST/ExprConstant.cpp:4447 + Info.FFDiag(E, diag::note_constexpr_access_uninit) + << /*rea

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, abrachet, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews reque

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks fine to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157885/new/ https://reviews.llvm.org/D157885 ___ cfe-commits mai

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits mai

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157888/new/ https://reviews.llvm.org/D157888 ___ cfe-commits mai

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske added a comment. It is better to add a test to ASTImporterTests.cpp with the same code, and check the properties of DeclContext and LexicalDeclContext in the From and To AST (should be the same in "From" and "To" side). Comment at: clang/lib/AST/ASTImporter.cpp:6451

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 13 inline comments as done. donat.nagy added a comment. I handled the inline comments, I'll check the example code and edit the release notes tomorrow. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:272 + if (const auto ConcreteRight =

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 549978. donat.nagy marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 Files: clang/docs/analyzer/checkers.rst clang/include/clang/

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549979. aaron.ballman added a comment. Tweaked wording to link to the policy about adding links to github issues in commit messages instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files:

[clang] 0c3a02b - Function multi-versioning: disable ifunc for ELF targets other than glibc/Android/FreeBSD

Author: Fangrui Song Date: 2023-08-14T08:59:59-07:00 New Revision: 0c3a02b8c09bb408a74a638a263e51d67c92ca74 URL: https://github.com/llvm/llvm-project/commit/0c3a02b8c09bb408a74a638a263e51d67c92ca74 DIFF: https://github.com/llvm/llvm-project/commit/0c3a02b8c09bb408a74a638a263e51d67c92ca74.diff

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

nridge added a comment. I understood https://github.com/clangd/clangd/issues/1344 as being about `workspace/symbol` rather than `textDocument/documentSymbol`, though I see now that both are affected. The analysis is a bit different for the two, though: unlike `DocumentSymbol`, the result types

[clang] 989ce06 - [clang][WebAssembly] Link crt1 even in case of -shared

Author: YAMAMOTO Takashi Date: 2023-08-14T09:36:44-07:00 New Revision: 989ce069a4638fd561bebc95f478ca9e45154fec URL: https://github.com/llvm/llvm-project/commit/989ce069a4638fd561bebc95f478ca9e45154fec DIFF: https://github.com/llvm/llvm-project/commit/989ce069a4638fd561bebc95f478ca9e45154fec.di

[PATCH] D156205: wasm: link crt1 even in case of -shared

This revision was automatically updated to reflect the committed changes. Closed by commit rG989ce069a463: [clang][WebAssembly] Link crt1 even in case of -shared (authored by yamt, committed by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4584619 , @nikic wrote: > @aaron.ballman I wanted to check back whether the linked document is what you > had in mind, or whether some more/else would be needed. Sorry about the delayed review; this fell off my ra

[PATCH] D155081: Specify the developer policy around links to external resources

tonic added a comment. @lattner Please review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

reames added inline comments. Comment at: llvm/docs/RISCVUsage.rst:120 ``Zicboz`` Assembly Support + ``Zicfilp`` Assembly Support ``Zicntr`` (`See Note <#riscv-i2p1-note>`__) This in the wrong place; this is not a ratified extensi

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. In D155290#4582825 , @MaskRay wrote: > Using `%p` should not magically change the behavior and I am unsure the > result is better for PGO. > If we decide to provide such a mode, it needs to be opt-in by adding a new > format

[PATCH] D156784: [AArch64][PAC] Declare FPAC subtarget feature

atrosinenko planned changes to this revision. atrosinenko added a comment. Looks like adding FeatureFPAC may require changes in more places - need to investigate whether I have to add something like AEK_FPAC constant, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

  1   2   3   >