[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

ChuanqiXu added a comment. In D108905#4654411 , @MaskRay wrote: > In D108905#4654410 , @smeenai wrote: > >> In D108905#4654403 , @ChuanqiXu >> wrote: >> >>> In

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

mzyKi wrote: > > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > > assertion but it will not result in crash. > > Have you find the exact commit to break this case? @mzyKi @HerrCai0907 after this commit 610ec954e1f81c0e8fcadedcd25afe643f5a094e , clang will crash in

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

MaskRay added a comment. In D108905#4654410 , @smeenai wrote: > In D108905#4654403 , @ChuanqiXu > wrote: > >> In D108905#4654393 , @smeenai >> wrote: >> >>> In

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

smeenai added a comment. In D108905#4654403 , @ChuanqiXu wrote: > In D108905#4654393 , @smeenai wrote: > >> In D108905#2975712 , @rsmith wrote: >> >>> No decision as yet,

[clang] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 817519058a986794e6acc06e4386fa183c4472a0 c61f6fb37e5d8ad0b7dfa68803f5a0161d542867 --

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/2] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b858309ddc977d5e70de54f3fa3888915b5fbc0c 96f6b90ed4a70430f94eab2d9ca317dd8367022a --

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

goldsteinn wrote: Rebase you other patch then I can review. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

goldsteinn wrote: Rebase you other patch then I can review. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Shivam Gupta (xgupta) Changes This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak --- Full diff: https://github.com/llvm/llvm-project/pull/69557.diff 3 Files Affected: - (modified)

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/69557 This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69555 >From 86663a35a7af039f9440af2cc1896e8b4cf33310 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 19 Oct 2023 11:28:01 +0800 Subject: [PATCH] [C++20] [Modules] Warn if we found #include in module purview

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/68615. It is generally wrong to include filename in the module purview. Although there are cases to include files in the module purview, generally these

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69555 Close https://github.com/llvm/llvm-project/issues/68615. It is generally wrong to include in the module purview. Although there are cases to include files in the module purview, generally these use cases

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

ldionne wrote: The CI failure is the bootstrapping build agent dying, definitely not related to this. Shipping. https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

ldionne wrote: The CI failure is the bootstrapping build agent dying, definitely not related to this. Shipping. https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

jcsxky wrote: > Thanks, looks good! > > You can submit as is, but if you're up for it, it would actually be better to > add the new test case directly to the model's unittests. Something like this > test (though just one case is enough -- please put it in a separate TEST_P): > >

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/68510 >From a5c5fc7a17f57a0b6ae328f7138435b4aaf7f9b5 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 8 Oct 2023 16:00:29 +0800 Subject: [PATCH] [clang][analysis]Use dyn_cast_or_null instead of cast to prevent crash

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

ChuanqiXu added a comment. In D108905#4654393 , @smeenai wrote: > In D108905#2975712 , @rsmith wrote: > >> No decision as yet, but so far it looks very likely that we'll settle on the >> rule that exceptions

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/69439. This patch tries to reuse the codes to generate make style dependencies information with P1689 format directly. --- Full diff:

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69551 Close https://github.com/llvm/llvm-project/issues/69439. This patch tries to reuse the codes to generate make style dependencies information with P1689 format directly. >From

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/3] [clang]Transform uninstantiated ExceptionSpec in

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/68502 >From 5b3b1bbb5b263bc5711adde031d85b1461ccbab6 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Sat, 7 Oct 2023 13:48:32 +0800 Subject: [PATCH 1/2] [InstCombine] Refactor matchFunnelShift to allow more pattern

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

ChuanqiXu9 wrote: > Does MSVC have the delayed template parsing effects when using modules? If > not, perhaps we should just disable the flag/not allow it to be composed > together? As far as I can reach, (from the issue reports in MSVC community), MSVC don't have problems with the delayed

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

https://github.com/HaohaiWen closed https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

smeenai added a comment. Herald added subscribers: pmatos, asb. Herald added a project: All. In D108905#2975712 , @rsmith wrote: > No decision as yet, but so far it looks very likely that we'll settle on the > rule that exceptions cannot have

[clang] [Driver][DragonFly] Fixes for linker path and command-line option handling (PR #69095)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0913a2d - [Driver][DragonFly] Fixes for linker path and command-line option handling (#69095)

Author: Brad Smith Date: 2023-10-18T20:47:04-04:00 New Revision: 0913a2d07d06b66780e4a1e4361f9159ce0013f8 URL: https://github.com/llvm/llvm-project/commit/0913a2d07d06b66780e4a1e4361f9159ce0013f8 DIFF: https://github.com/llvm/llvm-project/commit/0913a2d07d06b66780e4a1e4361f9159ce0013f8.diff

[clang] 2172eea - [clang-format][NFC] Take a constant conjunct out of a loop condition

Author: Owen Pan Date: 2023-10-18T17:37:41-07:00 New Revision: 2172eeaa52bec211b255e9cb4d8464a8908ff709 URL: https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709 DIFF: https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709.diff

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

@@ -66,6 +66,11 @@ using namespace clang; using namespace CodeGen; using namespace llvm; +static llvm::cl::opt ClSanitizeAlignmentBuiltin( +"sanitize-alignment-builtin", llvm::cl::Hidden, +llvm::cl::desc("Instrument builtin functions for -fsanitize=alignment"), +

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

vabridgers wrote: > LGTM! Btw, if you're just repairing tests like you had to do here, you > generally are okay to not go through another round of review unless you want > an extra set of eyes on things. The original approval is fine so long as > you're not making substantial changes to the

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

brad0 wrote: > Ah, I meant potential changes to `llvm/lib/Target` and `llvm/lib/MC`. But I > did search in backend using FreeBSD as keyword for example, few places need > to support it explicitly. If Haiku uses similar ABI and binary format to > Linux or FreeBSD, that makes sense. Yes, Haiku

[clang] cfbf0a5 - [X86][RFC] Support AVX10 options (#67278)

Author: Phoebe Wang Date: 2023-10-19T07:52:50+08:00 New Revision: cfbf0a500f173b532f64fcb856af2fb0cb7ba725 URL: https://github.com/llvm/llvm-project/commit/cfbf0a500f173b532f64fcb856af2fb0cb7ba725 DIFF: https://github.com/llvm/llvm-project/commit/cfbf0a500f173b532f64fcb856af2fb0cb7ba725.diff

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

HerrCai0907 wrote: > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > assertion but it will not result in crash. Have you find the exact commit to break this case? @mzyKi https://github.com/llvm/llvm-project/pull/69106 ___

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

https://github.com/kyulee-com closed https://github.com/llvm/llvm-project/pull/69489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7aa2491 - [clang] Expand invalid PCM diagnostic (#69489)

Author: Nuri Amari Date: 2023-10-18T16:19:54-07:00 New Revision: 7aa24915cb66c51bab7c15854877136930d3ed17 URL: https://github.com/llvm/llvm-project/commit/7aa24915cb66c51bab7c15854877136930d3ed17 DIFF: https://github.com/llvm/llvm-project/commit/7aa24915cb66c51bab7c15854877136930d3ed17.diff

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

HerrCai0907 wrote: friendly ping @erichkeane https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

HerrCai0907 wrote: friendly ping @erichkeane https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in

[clang] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/69465 >From 627f68e57b2526fb72285ef4831fc3c02a6ee6d0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 18 Oct 2023 08:47:02 +0800 Subject: [PATCH 1/7] [clang-tidy]Add new check bugprone-casting-through-void

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave closed https://github.com/llvm/llvm-project/pull/67863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

@@ -0,0 +1,50 @@ +//===--- CastingThroughVoidCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/8] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/8] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/7] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/7] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Fazlay Rabbi (mdfazlay) Changes The syntax of modifiers without comma separators in the map clause was deprecated in OpenMP 5.2. Reference: OpenMP 5.2 Spec, page 627, line 19 --- Patch is 26.39 KiB, truncated to 20.00 KiB below, full

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

https://github.com/mdfazlay created https://github.com/llvm/llvm-project/pull/69534 The syntax of modifiers without comma separators in the map clause was deprecated in OpenMP 5.2. Reference: OpenMP 5.2 Spec, page 627, line 19 >From 4b21bd09b1f1e3d5c68bd3e0c4701d7cb912631e Mon Sep 17

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

https://github.com/dwblaikie approved this pull request. Looks good. I wonder how this happened in the first place - that the author of the diagnostic was already adding the 3rd parameter into the arguments but there was no `%2` in the diagnostic text/template... It'd be great if we had

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/6] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/6] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/69489 >From 3fa795fae47d00ece00e9414a268610d3c4a6bf3 Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Fri, 22 Sep 2023 12:03:23 -0700 Subject: [PATCH 1/2] Expand invalid PCM diagnostic Summary: When a PCM file is

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

ilovepi wrote: Hi, is there a way to disable this check w/o disabling all `-Wconversion` warnings? We'd like to disable this one on some third_party code(e.g. the vulkansdk), but keep `-Wconversion` as a whole in place whenever we can. Unfortunately, `-Wno-bitfield-conversion` doesn't seem to

[clang-tools-extra] [clang-tidy] Add StrictMode to cppcoreguidelines-pro-type-static-cast-downcast (PR #69529)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Add StrictMode option that controls behavior whatever warnings are emitted for casts on non-polymorphic types. Fixes: #69414 --- Full diff: https://github.com/llvm/llvm-project/pull/69529.diff 5

[clang-tools-extra] [clang-tidy] Add StrictMode to cppcoreguidelines-pro-type-static-cast-downcast (PR #69529)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/69529 Add StrictMode option that controls behavior whatever warnings are emitted for casts on non-polymorphic types. Fixes: #69414 >From 641a1daf6cd969a697c3cb4f0f7e168ca9187fe9 Mon Sep 17 00:00:00 2001 From: Piotr

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

dwblaikie wrote: Does MSVC have the delayed template parsing effects when using modules? If not, perhaps we should just disable the flag/not allow it to be composed together? https://github.com/llvm/llvm-project/pull/69431 ___ cfe-commits mailing

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

philnik777 wrote: > > > One thing I REALLY hate about our pattern of using bitfields for enums, > > > is that it becomes pretty trivial to add an entry to an enum and forget > > > to increase the size of the bitfield. I think such a attribute could > > > cause a diagnostic of `bitfield says

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

@@ -60,10 +60,7 @@ using namespace llvm; #define DEBUG_TYPE "instrprof" namespace llvm { -cl::opt -DebugInfoCorrelate("debug-info-correlate", - cl::desc("Use debug info to correlate profiles."), - cl::init(false));

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

david-xl wrote: Can you send a RFC for this enhancement ? The first 2 paragraph of this PR can be expanded a little more to show motivations (RAM saving, or raw profile size saving and why) and the savings data. https://github.com/llvm/llvm-project/pull/69493

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

@@ -62,7 +62,7 @@ def err_ast_file_out_of_date : Error< "%select{PCH|module|AST}0 file '%1' is out of date and " "needs to be rebuilt%select{|: %3}2">, DefaultFatal; def err_ast_file_invalid : Error< - "file '%1' is not a valid precompiled %select{PCH|module|AST}0 file">,

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Karl-Johan Karlsson (karka228) Changes Constant values of _BitInt have the bitwith to exactly fit the constant number. This patch fix a problem in Sema when building an APInt where the supplied bitwidth can become too small and simply

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

@@ -0,0 +1,11 @@ +; RUN: opt < %s -passes=instrprof -profile-correlate=binary -S | FileCheck %s + +; CHECK: @__profd_foo = private global { i64, i64, i64, ptr, ptr, i32, [2 x i16] } { i64 {{.*}}, i64 {{.*}}, i64 ptrtoint (ptr @__profc_foo to i64) ZequanWu wrote:

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

https://github.com/karka228 created https://github.com/llvm/llvm-project/pull/69521 Constant values of _BitInt have the bitwith to exactly fit the constant number. This patch fix a problem in Sema when building an APInt where the supplied bitwidth can become too small and simply truncate the

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/69493 >From 3a394ce5d4d7d91251337bd0a2c1c1a074eb37e6 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Tue, 17 Oct 2023 19:24:12 -0400 Subject: [PATCH 1/5] [Profile] Add binary profile correlation. ---

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0ae998c - [clang-format] Fix a bug in annotating TrailingReturnArrow (#69249)

Author: Owen Pan Date: 2023-10-18T14:04:51-07:00 New Revision: 0ae998c4aebbae7193b13ccc7ca525241b571be4 URL: https://github.com/llvm/llvm-project/commit/0ae998c4aebbae7193b13ccc7ca525241b571be4 DIFF: https://github.com/llvm/llvm-project/commit/0ae998c4aebbae7193b13ccc7ca525241b571be4.diff

[clang-tools-extra] [AMDGPU] Make S_MOV_B64_IMM_PSEUDO foldable (PR #69483)

https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/69483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make S_MOV_B64_IMM_PSEUDO foldable (PR #69483)

https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/69483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore deleted functions in cppcoreguidelines-rvalue-reference-param-not-moved (PR #69514)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Ignore functions and constructors that are maked deleted or defaulted in cppcoreguidelines-rvalue-reference-param-not-moved check. Fixes #69412 --- Full diff:

[clang-tools-extra] [clang-tidy] Ignore deleted functions in cppcoreguidelines-rvalue-reference-param-not-moved (PR #69514)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/69514 Ignore functions and constructors that are maked deleted or defaulted in cppcoreguidelines-rvalue-reference-param-not-moved check. Fixes #69412 >From 1b32a05c1de0b22749e6f4c2754ade8f7544acce Mon Sep 17

[clang] [libc++] Move the check-generated-files job to Github Actions (PR #68920)

https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/68920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

@@ -66,6 +66,11 @@ using namespace clang; using namespace CodeGen; using namespace llvm; +static llvm::cl::opt ClSanitizeAlignmentBuiltin( +"sanitize-alignment-builtin", llvm::cl::Hidden, +llvm::cl::desc("Instrument builtin functions for -fsanitize=alignment"), +

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

@@ -1872,7 +1872,8 @@ example: passes make choices that keep the code size of this function as small as possible and perform optimizations that may sacrifice runtime performance in order to minimize the size of the generated code. -This attribute is

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

erichkeane wrote: > > One thing I REALLY hate about our pattern of using bitfields for enums, is > > that it becomes pretty trivial to add an entry to an enum and forget to > > increase the size of the bitfield. I think such a attribute could cause a > > diagnostic of `bitfield says it holds

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -7219,6 +7219,18 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def DebugInfoTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows to alter type of a bitfield in debug information. +Such a

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -7219,6 +7219,18 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def DebugInfoTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows to alter type of a bitfield in debug information. +Such a

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -107,6 +107,10 @@ def NonBitField : SubsetSubjectisBitField()}], "non-bit-field non-static data members">; +def BitField : SubsetSubjectisBitField()}], + "bit-field non-static data members">;

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

AaronBallman wrote: > @serge-sans-paille I'm still trying to understand whether this change will be > tested by CI - or at all. SSE4 is not enabled by default and i don't think > our cmake does that either - I did ping @AaronBallman and we are still > thinking about it I think we're in good

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

philnik777 wrote: > One thing I REALLY hate about our pattern of using bitfields for enums, is > that it becomes pretty trivial to add an entry to an enum and forget to > increase the size of the bitfield. I think such a attribute could cause a > diagnostic of `bitfield says it holds an ENUM

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -0,0 +1,14 @@ +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -verify -DMISMATCH %s AaronBallman wrote: I think we should split this into two test: one for testing what debug info is generated (here in

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema , Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema , Decl *D, const ParsedAttr ) { + if (!AL.hasParsedType()) { +S.Diag(AL.getLoc(),

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -3153,6 +3153,8 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

@@ -7219,6 +7219,18 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def DebugInfoTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows to alter type of a bitfield in debug information. +Such a

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

erichkeane wrote: > > > > Wouldn't it be better to go the other way around? i.e. have a > > > > `[[clang::compressed_bitfield]]` (or whatever) which influences the > > > > ABI, so it's possible to do stuff like > > > > ``` > > > > [[clang::compressed_bitfield]] bool IsSomething : 1; > > > >

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Improved cppcoreguidelines-pro-type-const-cast check to ignore casts to const type (controlled by option) and casts in implicitly invoked code. Fixes #69319 --- Full diff:

  1   2   3   4   >