[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel added inline comments. Comment at: openmp/libomptarget/test/CMakeLists.txt:23 +continue() + ENDIF() string(STRIP "${CURRENT_TARGET}" CURRENT_TARGET) jdoerfert wrote: > This is to disable the tests? Not sure this is a good way though. For one, >

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 405407. atmnpatel marked 7 inline comments as done. atmnpatel added a comment. updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/new/ https://reviews.llvm.org/D113359 Files: clang/lib/Basic/Targ

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel added inline comments. Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:231 + +compileDeviceRTLLibrary(x86_64 vgpu -target x86_64-vgpu -std=c++20 -stdlib=libc++ -I${devicertl_base_directory}/../plugins/vgpu/src) tianshilei1992 wrote: > It's not

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 401112. atmnpatel marked 9 inline comments as done. atmnpatel added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/new/ https://reviews.llvm.org/D113359 Files: clang/lib

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 398370. atmnpatel added a comment. - Fixed lifetime issue around ffi_call - Addressed comments The existing x86 plugin uses ffi, so this does as well, no explicit benefit in doing so. Is it worth keeping? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 386426. atmnpatel added a comment. small nit fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/new/ https://reviews.llvm.org/D113359 Files: clang/lib/Basic/Targets/X86.h clang/lib/CodeGen/CGOpenMP

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 386425. atmnpatel added a comment. I removed the shared var opt - might be best to keep this in a separate patch @tianshilei1992. Also addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385627. atmnpatel added a comment. small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp clang/lib/Code

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385626. atmnpatel added a comment. Yep yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp clang/lib/CodeGen

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385615. atmnpatel added a comment. Remove intrinsic includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385611. atmnpatel added a comment. Herald added projects: OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits. Updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://revie

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, JonChesterfield, tianshilei1992. Herald added subscribers: asavonic, guansong, yaxunl, mgorny, jvesely, jholewinski. atmnpatel requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a p

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: ormris, dexonsmith, pengfei, hiraditya, mgorny. atmnpatel requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. Wait actually, we're gonna need D94366 anyways, I'll get address @xbolva00's comments by eod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 __

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. @fhahn Sorry for the hold up, I don't think I'll get to this relatively soon, I'll abandon this one and D94366 to sweep the board. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/ne

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel updated this revision to Diff 315641. atmnpatel added a comment. Update CommandLineReference.rst to also include `-fno-finite-loops` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 Files: clang/

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. Herald added subscribers: dexonsmith, dang. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following D94366

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

atmnpatel updated this revision to Diff 315639. atmnpatel added a comment. `while(1)` case was mishandled for C++11 onwards, fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94366/new/ https://reviews.llvm.org/D94366 Files: clang/lib/Cod

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang does not emit the `mustprogress` loop or function attribute for loops with no

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

atmnpatel accepted this revision. atmnpatel added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/ https://reviews.llvm.org/D94327 __

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added a comment. I'm happy to add a patch amending this, the reason it wasn't done that way was because at the time and even now, out of icc/clang/msvc/gcc, gcc seems to be the only one that happily removed such loops in C++ (https://godbolt.org/z/W9vj99), and I didn't have a particul

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. In D86844#2484568 , @fhahn wrote: > In D86844#2481922 , @xbolva00 wrote: > >> int a, b; >> >> int f(void) { >> while (1) { >> if (a != b) return 1; >> } >>

[PATCH] D93952: [Clang][Misc] Fix fragile test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a65b8c739a0: [Clang][Misc] Change run line in fragile test (authored by adpatel6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel updated this revision to Diff 314195. atmnpatel added a comment. Better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952 Files: clang/test/Misc/loop-opt-setup.c Index: clang/test/Misc/loop-opt

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. In D86844#2475552 , @xbolva00 wrote: > Do you plan to implement gcc’s option in Clang as followup? I was not planning on it but I can if no one is planning on it and doesn't mind waiting a bit. Also, clang/test/Misc/loop-opt-s

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel updated this revision to Diff 314193. atmnpatel added a comment. Ah I see, I was never able to find clear documentation on what exactly the -cc1 flag does other than the conceptual description. This should fix it right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel added a comment. I can't say that I know with any certainty, I'm too inexperienced. This failure was missed by me locally, the pre-merge bot, and by most of the buildbots other than the ones I mentioned above. I have no idea under what configuration of CMake options will clang not emi

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel created this revision. atmnpatel added a reviewer: MaskRay. Herald added a subscriber: pengfei. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-with-thin-lto-ubuntu, clang-with-lto-ubuntu, clang-x86_64-debian-new-

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1503d59854: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel, committed by adpatel6). Changed prior to commit: https://reviews.llvm.org/D86844?vs=31359

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. Yep, sorry, I'm just waiting for a final stamp of approval from one of the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 313593. atmnpatel added a comment. As expected, @fhahn was right, adding willreturn to all those tests was an artifact from previous revisions of this patch and it passed the tests so I didn't pay them any mind, but I removed them now. Repository: rG L

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added inline comments. Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:621 } } nikic wrote: > Unrelated, but why do these updates happen before the branch from preheader > to exit is added in IR? Shouldn't it be the other way around a

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 313484. atmnpatel added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Tr

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added inline comments. Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:661 + } +} } nikic wrote: > These fixes look unrelated. Is it possible to test them separately? So my understanding is that the actual line that fixes the compile tim

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 308249. atmnpatel added a comment. I believe this happened becase when I removed the loop, I did not update MemorySSA. The exact error was from GVN, but this update seems to fix the stage 2 build compile time error locally (I checked by running the build b

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel reopened this revision. atmnpatel added a comment. This revision is now accepted and ready to land. This introduced a compile-time error that showed up during a stage 2 build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https

[PATCH] D91075: [clang] Fix ForStmt mustprogress handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling (authored by atmnpatel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91075: [clang] Fix ForStmt mustprogress handling

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, aqjune, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. atmnpatel requested review of this revision. D86841 had an error where for statements with no cond

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel). Repository: rG LLVM Github Monor

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 303597. atmnpatel added a comment. final fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transfor

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac73b73c1652: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction (authored by atmnpatel). Repository: rG LLVM Github Monorepo

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302606. atmnpatel added a comment. Hopefully the unrelated hwasan test failure is now fixed on master, trying again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302461. atmnpatel added a comment. try 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302459. atmnpatel added a comment. ignore, testing pre-build bots again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp c

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302458. atmnpatel added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302407. atmnpatel added a comment. - Added triple to fix mangling errors in test - Modified (unrelated) recently added test to have the mustprogress attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8684

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 300559. atmnpatel added a comment. Added word back in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/T

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added a comment. ping. @jyknight @aaron.ballman @rjmccall any more thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 ___ cfe-commits mailing lis

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 299823. atmnpatel added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298740. atmnpatel added a comment. fixed splice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transfo

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298736. atmnpatel added a comment. nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transforms/Utils

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298734. atmnpatel added a comment. Reverted to prior diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/ll

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 297070. atmnpatel added a comment. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 297069. atmnpatel added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 296752. atmnpatel added a comment. Bump for bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopI

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 296747. atmnpatel added a comment. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +LoopMustProgress = true; aqjune wrote: > A s

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 295149. atmnpatel added a comment. Fixing buildkite build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeG

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel marked 3 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +MustProgress = tr

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 295119. atmnpatel added a comment. NFC fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294864. atmnpatel added a comment. more fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInf

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294794. atmnpatel added a comment. attempt 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294773. atmnpatel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294575. atmnpatel added a comment. rebase to hopefully fix buildbot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294570. atmnpatel added a comment. All language standards (minus gnu extensions) are now tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/Co

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added inline comments. Comment at: clang/test/CodeGen/attr-mustprogress-0.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-attributes +// RUN: %clang_cc1 -S -emit-llvm %s -o - | FileCheck %s + chang

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294569. atmnpatel added a comment. Split them into pre and post forward progress requirement tests, now the difference is much easier to catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https:

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 291581. atmnpatel added a comment. Tests renamed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoop

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 291567. atmnpatel added a comment. Fixed failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/C

[PATCH] D86841: [clang] Add mayprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 291471. atmnpatel added a comment. Flipped direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CG

[PATCH] D86841: [clang] Add mayprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 291249. atmnpatel added a comment. More tightly follows both the C and C++ standards. `maynotprogress` is only added to C functions when compiled with C11 or later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D86841: [clang] Add mayprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 289997. atmnpatel added a comment. Renamed `mayprogress` to `maynotprogress`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cp

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 289849. atmnpatel added a comment. In Summary: - I changed the llvm loop metadata name to `mustprogress`, to indicate that loops with this attribute are required to have side-effects. - The `mayprogress` function attribute is applied to functions where an

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

atmnpatel marked an inline comment as done. atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.h:211 llvm::ArrayRef Attrs, const llvm::DebugLoc &StartLoc, -const llvm::DebugLoc &EndLoc); +const llvm::DebugLoc &EndLoc, co

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 289821. atmnpatel added a comment. Herald added a subscriber: zzheng. Renamed llvm loop metadata, changed deduction rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 288818. atmnpatel added a comment. Fixed comment in C++ test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/Co

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 288817. atmnpatel edited the summary of this revision. atmnpatel added a comment. Sorry, Fixed the test, added a C++ test. I checked the C++, OpenCL C, and OpenCL C++ specs and couldn't find anything that diverged from C spec in this regard, but none of th

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, aqjune, RalfJung. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. atmnpatel requested review of this revision. The `noprogress` LLVM IR attribute currently under discussion is deduced for func

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked an inline comment as done. atmnpatel added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) {

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) { ABataev wrote: > ABataev wrote: > > No

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. Herald added a subscriber: aaron.ballman. Ping @ABataev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 265788. atmnpatel added a comment. Herald added a subscriber: sstefan1. Updated tests and includes changes made by @ABataev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3434-3435 + if (Stack->getDefaultDSA() == DSA_firstprivate && + VD->getStorageDuration() == SD_Static && + CanonicalVD->getDeclContext()->isFileContext() && !Stack->isLoop

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 264365. atmnpatel added a comment. Necessary cleanups and adds a basic check for static local variables and static data members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 263832. atmnpatel added a comment. Addresses inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/checks/openmp

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 263326. atmnpatel added a comment. Fixed check for scalar types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/checks/ope

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2016-2023 + if (DSAStack->getDefaultDSA() == DSA_firstprivate && + VarsWithInheritedDSAType().count(D) == 0 && + !DSAStack->hasExplicitDSA( + D, [](OpenMPClauseKind K) -> bool { return

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 259122. atmnpatel added a comment. Add capture by value for scalars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/checks

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || + !VD->isLocalVarDeclOrParm())) { ABataev wrote: > atmnpate

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked 2 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || + !VD->isLocalVarDeclOrParm()))

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 259073. atmnpatel marked 3 inline comments as done. atmnpatel added a comment. Addresses inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: cla

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked an inline comment as done and an inline comment as not done. atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || +

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 256152. atmnpatel added a comment. Addresses D77731 and fixes the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 254917. atmnpatel added a comment. Fixes clang-tidy check, and hopefully the other unrelated test failure too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 254392. atmnpatel added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/checks/openmp-use-default-none.r

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 254379. atmnpatel added a comment. Herald added a subscriber: yaxunl. Fixes to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 253498. atmnpatel added a comment. Second try at generating a patch file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/c

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 253470. atmnpatel added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/checks/openmp-use-default-none.

  1   2   >