[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. Build failures seem unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG535f34dd80c2: [index][clangd] Consider labels when indexing function bodies (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 545551. ckandeler added a comment. Addressed another review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files:

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } kadircet wrote: > nridge wrote: > > `NameReference` was

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 545054. ckandeler added a comment. Addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files:

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143260: [clangd] Add semantic token for labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGe72baa76b91f: [clangd] Add semantic token for labels (authored by ckandeler). Changed prior to commit: https://reviews.llvm.org/D143260?vs=494583=529234#toc Repository: rG LLVM Github Monorepo

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG008cb29f87f3: [clangd] Renaming: Treat member functions like other functions (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler updated this revision to Diff 524214. ckandeler added a comment. Fixed clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files:

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler updated this revision to Diff 524206. ckandeler added a comment. Formatting glitch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler updated this revision to Diff 524203. ckandeler added a comment. Added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519 +if (RenameDecl.getKind() != Decl::Function && +RenameDecl.getKind() != Decl::CXXMethod) { if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName))

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler created this revision. ckandeler added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 521577. ckandeler marked 2 inline comments as done. ckandeler added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files:

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. In D150124#4329163 , @ilya-biryukov wrote: > In `clangd` we also have `findExplicitReferences` and `targetDecl` functions > that seem to handle the `GoToStmt`. According to the commit message of the patch that added this, it

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. In D143260#4328948 , @kadircet wrote: > Considering that we have added a bunch of token kinds, let me ask you another > question then, how many more new token kinds do we expect to have? e.g. if > label is the last one sure,

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler created this revision. ckandeler added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, clang-tools-extra. It's

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. In my opinion, it is not possible to have a competitive client if you limit yourself to the official LSP feature set; you just need language-specific extensions in practice. And while of course not every silly idea should be blindly accepted, I think this "lowest

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. Hello? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143260/new/ https://reviews.llvm.org/D143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143260/new/ https://reviews.llvm.org/D143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. In D143260#4122523 , @kadircet wrote: > at hindsight i can't see why `goto X;` and `X:` is not enough for clients to > implement this without any need for semantic analysis. are there contexts > where this kind of syntactical

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D139926: [clangd] Add semantic token for angle brackets

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbddbe580bca: [clangd] Add semantic token for angle brackets (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493610. ckandeler added a comment. Incorporated review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files:

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:382 + +// For the inner element of a nested template instantiation with no space +// between the '>' characters, TemplateSpecializationLocInfo::RAngleLoc has

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493594. ckandeler marked an inline comment as done. ckandeler added a comment. Improved implementation as per review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493247. ckandeler added a comment. Support more cases as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files:

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1026 +concept $Concept_decl[[C2]] = true; +template $Bracket[[<]]C2$Bracket[[<]]int$Bracket[[>]] $TemplateParameter_def[[A]]$Bracket[[>]] +

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4084868 , @nridge wrote: > I figured I might as well look through the AST API for classes with > getLAngleLoc/getRAngleLoc methods. > > It looks like we've got almost all of them (including the ones mentioned in >

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 492670. ckandeler marked 3 inline comments as done. ckandeler added a comment. Handled more cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files:

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4084801 , @nridge wrote: > Function calls are still missing some cases: > > I would have expected these to be handled by VisitDeclRefExpr(), but they aren't. Any idea? Repository: rG LLVM Github Monorepo

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4076057 , @nridge wrote: > One other thought that has occurred to me is that as we add more semantic > tolens for punctuation, the test cases in `GetsCorrectTokens` become harder > to read. > > What would you think

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. Thanks for the test cases! All fixed, except: > // variable template specialization > // parameter and argument lists are missing semantic tokens > template <> > constexpr int V = 5; Argument list fixed. I didn't manage to make the parameter list work. Repository:

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 491718. ckandeler marked an inline comment as done. ckandeler added a comment. Added test cases from review comment and made them pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

ckandeler added a comment. With this, I now get: FAILED: bin/clangd-fuzzer : && /usr/lib/icecream/libexec/icecc/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4064769 , @kadircet wrote: >> We can easily check the actual character at the given position in the >> client, so I could just merge the two highlighting kinds. > > Thanks! Note that it might not be as easy at the

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 490457. ckandeler marked 2 inline comments as done. ckandeler added a comment. Made token name more generic, added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 489722. ckandeler marked 2 inline comments as done. ckandeler retitled this revision from "[clangd] Add semantic tokens for angle brackets" to "[clangd] Add semantic token for angle brackets". ckandeler added a comment. Added test cases, merged the two

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4056585 , @kadircet wrote: > Especially as this comes as two different `HighlightingKind`s and they're > likely to get colored differently, and having your matching brackets in > different colors is quite annoying.

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4033152 , @nridge wrote: > In D139926#4032473 , @ckandeler > wrote: > >> In D139926#4030782 , @nridge wrote: >> >>> It's true that

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4030782 , @nridge wrote: > It's true that there is an ambiguity between `<` and `>` as operators, vs. > template arg/param list delimiters, but, at least in terms of user > understanding of code, my sense is that

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler updated this revision to Diff 482422. ckandeler added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3991530 , @hokein wrote: > This patch causes a clangd crash on dependent code (e.g. running on > `ASTMatchers.h`), fixed in > https://github.com/llvm/llvm-project/commit/bcb457c68e20120f0bdd0a59e4b4ce90b8121310.

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

This revision was automatically updated to reflect the committed changes. Closed by commit rG647d314eb059: [clangd] Add support for semantic token type operator (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 482103. ckandeler added a comment. Renamed modifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3987852 , @nridge wrote: > - Does the implementation handle explicit operator calls, e.g. > `a.operator+(b)`? If so, it would be nice to add some test coverage. It does now. Repository: rG LLVM Github Monorepo

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 482055. ckandeler added a comment. Added more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files:

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3973812 , @sammccall wrote: > For my part, I still need to understand why we want the > `builtin`/`UserModified` modifier. (The `operator` highlight kind seems > obvious to me). We make this distinction in our

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. Now seems to do what we want. Should I switch the modifier around? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 ___ cfe-commits

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 478146. ckandeler added a comment. Using operators on expressions with dependent types now considered "complex", Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > ckandeler wrote: > > sammccall wrote: > > > sammccall wrote: > > > > nridge wrote: > > > > >

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > nridge wrote: > > > ckandeler wrote: > > > > ckandeler wrote: > > > > > sammccall

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 477919. ckandeler added a comment. Added template example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files:

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3950334 , @nridge wrote: > The current patch will produce an operator token in the operator case but not > the declarator case, thereby achieving an effect that client-side > highlighting couldn't. As such, I guess

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. > Should I perhaps add the augmentsSyntaxTokens option and rebase this patch to > make it its first user? So I went ahead and did this. Opinions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 477178. ckandeler added a comment. Make highlighting of built-in operators conditional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files:

[PATCH] D137943: [clangd] Mark "override" and "final" as modifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG699a59aa5865: [clangd] Mark override and final as modifiers (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137943: [clangd] Mark "override" and "final" as modifiers

ckandeler updated this revision to Diff 476843. ckandeler marked 3 inline comments as done. ckandeler retitled this revision from "[clangd] Mark "override" and "final" as keywords" to "[clangd] Mark "override" and "final" as modifiers". ckandeler edited the summary of this revision. ckandeler

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > sammccall wrote: > > > Can you give some background here or on the bug tracker

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3940143 , @nridge wrote: > A couple of high-level thoughts on this: > > 1. Based on the discussion in https://github.com/clangd/clangd/issues/1115, I > believe highlighting of **built-in** operators should be out of

[PATCH] D137943: [clangd] Mark "override" and "final" as keywords

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf960aef08e: [clangd] Add usedAsMutablePointer highlighting modifier (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler updated this revision to Diff 473603. ckandeler marked an inline comment as done. ckandeler added a comment. Rebased and updated comment as indicated in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:592 + Arg = IC->getSubExprAsWritten(); +if (auto *UO = dyn_cast(Arg)) { + if (UO->getOpcode() == UO_AddrOf) nridge wrote: > Could you add a test case

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ed4a543b8b3: [clangd] Make file limit for textDocument/rename configurable (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136454: [clangd] Make file limit for textDocument/rename configurable

ckandeler created this revision. ckandeler added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Without

[PATCH] D134728: [clangd] Add highlighting modifier "constructorOrDestructor"

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b3668754c88: [clangd] Add highlighting modifier constructorOrDestructor (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134728/new/

[PATCH] D134728: [clangd] Add highlighting modifier "constructorOrDestructor"

ckandeler updated this revision to Diff 468465. ckandeler retitled this revision from "[clangd] Add highlighting modifiers "constructor" and "destructor"" to "[clangd] Add highlighting modifier "constructorOrDestructor"". ckandeler edited the summary of this revision. ckandeler added a comment.

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. In D127403#3863713 , @nridge wrote: > In D127403#3863686 , @thakis wrote: > >> In D127403#3863641 , @nridge wrote: >> >>> Landed

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. Could you please land it for me? I don't have the privileges. (How does one attain those, by the way?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. Everything good now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 466731. ckandeler added a comment. Template parameters are definitions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files:

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 466510. ckandeler marked 2 inline comments as done. ckandeler added a comment. Use modifier also for parameters, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. So, is this okay to merge now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:79 + if (auto *Var = dyn_cast(Decl)) +return !isa(Var) && Var->isThisDeclarationADefinition(); + return isa(Decl) || isa(Decl); I'm not 100% sure about this one,

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 464170. ckandeler marked 3 inline comments as done. ckandeler added a comment. Adapted according to latest comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822898 , @sammccall wrote: > If the distinction isn't important, maybe we should add a single "constructor > or destructor" modifier... No, it's not. I will update the patch accordingly. Repository: rG LLVM

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822653 , @sammccall wrote: > It doesn't scale very well though: we're limited to 30 modifiers in total, > this patch brings us up to 16, if we followed this class.constructor > precedent for function.operator,

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:863 + Tok.addModifier(HighlightingModifier::Declaration); +if (const auto Func = dyn_cast(Decl)) { + if (Func->isThisDeclarationADefinition())

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler added a comment. By the way: How do I change the commit message when using arc? It seems to ignore all subsequent changes other than in the code itself, and now the patch is in the repo with a misleading commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132135: [clangd] Support hover on __func__ etc (PredefinedExpr)

ckandeler accepted this revision. ckandeler added a comment. This revision is now accepted and ready to land. Works fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132135/new/ https://reviews.llvm.org/D132135

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler marked an inline comment as not done. ckandeler added a comment. Thanks for the review. Can you please merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler updated this revision to Diff 453648. ckandeler added a comment. Use variable instead of macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131175/new/ https://reviews.llvm.org/D131175 Files:

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:546 + bool VisitPredefinedExpr(PredefinedExpr *E) { +H.addToken(E->getLocation(), HighlightingKind::Macro); +return true; sammccall wrote: > actually, would

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:603 H.addExtraModifier(*Location, - HighlightingModifier::UsedAsMutableReference); + IsRef ?

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler updated this revision to Diff 451420. ckandeler marked an inline comment as done. ckandeler added a comment. Fixed style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llvm.org/D130015 Files:

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added a comment. IMO the relevant point is the (non-)const-ness of the corresponding parameter, i.e. can the passed object get mutated or not. The fact that there's an ampersand at the call site (which is not even the case if the variable is itself a pointer) does not tell me that.

[PATCH] D131175: [clangd] Use the "macro" semantic token for pre-defined identifiers

ckandeler created this revision. ckandeler added reviewers: sammccall, nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/ https://reviews.llvm.org/D130015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 448655. ckandeler added a comment. Addressed remaining Objective-C issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files:

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Counterpart to

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. In D128977#3638198 , @nridge wrote: > Yes, I plan to. I'm just building it locally to verify the tests are passing. > (And sometimes, for reasons I don't understand, LLVM's build system triggers > a full rebuild even though

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Can you please merge it as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977 ___ cfe-commits mailing list

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Note that the build failure seems unrelated, as it's due to a failing clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return Base::TraverseConstructorInitializer(Init); +if (const auto Member = Init->getMember()) { + const auto MemberType = Member->getType();

  1   2   >