[PATCH] D159383: [Headers] Remove musl-related comment about NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rG666098c5b3ea: [Headers] Remove musl-related comment about NULL (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

aheejin added a comment. In D159383#4635703 , @dschuff wrote: > Suggested edit to the commit description: > "use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at > the same time" Done (Both the CL description and the commit

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I uploaded D159383 , which removes the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

aheejin created this revision. aheejin added reviewers: iana, aaron.ballman, dalias. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes a comment added in

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. In D159312#4634617 , @dalias wrote: > Please report what you're actually trying to do that's breaking rather than > sending patches to align definitions that are not intended to be aligned. Basically, we tried to use `stddef.h`

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I believe this is better solved downstream, i.e., in musl. I'm not a musl developer but a user, but I can consider contributing a patch there. I'd like to remove the whitespace for now because it is currently breaking us and it had been that way for a long time anyway,

[PATCH] D159312: [Headers] Remove a space in NULL define

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef8121b109ef: [Headers] Remove a space in NULL define (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. Done. Btw musl defines `NULL` in several places, not only `stdio.h`. It defines `NULL` in `local.h`, `stddef.h`, `stdio.h`, `stdlib.h`, `string.h`, `time.h`, `unistd.h`, and `wchar.h`. Not sure why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin updated this revision to Diff 555201. aheejin added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 Files: clang/lib/Headers/__stddef_null.h Index:

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aheejin added a comment. The added space in `((void *)0)` in `__stddef_null.h` broke Emscripten CI. I added the space back in D159312

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. The added space actually caused emscripten's CI to break: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8771230198259238865/+/u/Build_Emscripten__upstream_/stdout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin created this revision. aheejin added reviewers: iana, dschuff. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was no space in `((void *)0)` before

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"],

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM % nit and the name resolution (multimemory vs. multi-memory) Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"],

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

aheejin added a comment. Nice! Just some drive-by nitpicking, sorry  Comment at: lld/test/wasm/async.ll:11 + +define void @bar() #1 { +ret void Comment at: lld/test/wasm/async.ll:21-22 + +attributes #0 = { "wasm-async" } +attributes #1

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

aheejin accepted this revision. aheejin added a comment. All Wasm atomics are sequentially consistent; If that's supported by this macro, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

aheejin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:190 +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_s_i16x8, "V8sV16ScV16Sc", "nc", "relaxed-simd") +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_add_s_i32x4, "V4iV16ScV16Sc", "nc",

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aheejin added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). If we push `nullptr` and then pop

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4625b848793f: [WebAssembly] Support clang -fwasm-exceptions for bitcode (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395025. aheejin added a comment. Remove an unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscripten-cxx-exceptions", - cl::desc("WebAssembly Emscripten-style

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395024. aheejin marked 2 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files:

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 394951. aheejin added a comment. Revert a function name change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, pengfei, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aheejin added a comment. After this patch, `-print-stats` started erroring out. I filed a bug at https://bugs.llvm.org/show_bug.cgi?id=52193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

aheejin accepted this revision. aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:14 // Instructions requiring HasSIMD128 and the simd128 prefix byte +multiclass ABSTRACT_SIMD_Ihttps://reviews.llvm.org/D110295/new/

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa947b40cafa8: [WebAssembly] Add Wasm SjLj option support for clang (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin updated this revision to Diff 368519. aheejin added a comment. This revision is now accepted and ready to land. Remove multivalue setting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 Files:

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin added a comment. As we discussed offline, I'll remove `+multivalue` part for now; it doesn't have reliable support in the Wasm LLVM backend and Binaryen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b921b870aa: [WebAssembly] Tidy up EH/SjLj options (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449 + // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires + // Emscripten libraries and processed together in LowerEmscriptenEHSjLJ pass. + if

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin updated this revision to Diff 368237. aheejin marked 3 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/ https://reviews.llvm.org/D107685 Files:

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin planned changes to this revision. aheejin added a comment. Oh sorry I clicked the wrong button Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 ___

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Oh, I fortot I made this currently set `+multivalue` feature... Maybe we have to rethink that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for Wasm

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin updated this revision to Diff 368203. aheejin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `-wasm-enable-eh` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106612/new/ https://reviews.llvm.org/D106612

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), Sorry I asked this in

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/simd-unsupported.ll:13 ; CHECK-LABEL: ctlz_v16i8: -; CHECK: i32.clz +; CHECK: i8x16.popcnt declare <16 x i8>

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:174 +static __inline__ v128_t __DEFAULT_FN_ATTRS wasm_v128_load8_lane( +const void *__ptr, v128_t __vec, int __i) __REQUIRE_CONSTANT(__i) { + struct __wasm_v128_load8_lane_struct {

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128")

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb12b0ae11f: [WebAssembly] Warn on exception spec for Emscripten EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin added a comment. In D102791#2769892 , @dschuff wrote: > BTW Is there a way to disable this warning? The warning is like test.cpp:3:6: warning: dynamic exception specifications with types are currently ignored in wasm [-Wwasm-exception-spec]

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out we have not correctly

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin added a comment. @dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if `-exception-model=wasm` reaches the backend compilation.

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. > To improve hygiene, consistency, and usability, it would be good to replace > all > the macro intrinsics in wasm_simd128.h with functions. The reason for using > macros in the first place

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I see, thanks. Then other load instructions are OK not to be fixed? - `v128.load` - `v128.loadN_splat` - `v128.loadNxM_s/u` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin added a comment. Why do only these instructions have `const`? It doesn't apply to other read-only arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ https://reviews.llvm.org/D101884

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1406f24d8b: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101735/new/

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was temporarily

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. In D101684#2732551 , @dblaikie wrote: > In D101684#2732522 , @aheejin wrote: > >> I think there's a clear upside on keeping this within clang/. >> >> 1. As @tlively said, there are many

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. I think there's a clear upside on keeping this within clang/. 1. As @tlively said, there are many number of instructions to test and keeping "C function - LLVM intrinsic" and "LLVM intrinsic - Wasm instruction" tests in sync without autogeneration will be hard and

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Wow these are really a lot of instructions! Comment at: clang/test/Headers/wasm.c:2 +// REQUIRES: webassembly-registered-target // expected-no-diagnostics

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ tlively wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added a comment. General question about SIMD intrinsics: So we make dedicated wasm intrinsics only for the cases there are not general intrinsics people can use instead? Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec,

[PATCH] D100596: [WebAssembly] Remove saturating fp-to-int target intrinsics

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:124-127 + if (Subtarget->hasNontrappingFPToInt()) +for (auto Op : {ISD::FP_TO_SINT_SAT,

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1104-1107 +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" :

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6aae5f7fcd1: [WebAssembly] Dont inline -emscripten-cxx-exceptions-allowed functions (authored by aheejin). Repository: rG LLVM Github Monorepo

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin updated this revision to Diff 333041. aheejin added a comment. Add break Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin updated this revision to Diff 332957. aheejin added a comment. Comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin created this revision. aheejin added a reviewer: sbc100. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Functions specified in

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1243 // Prototype f64x2 conversions defm "" : SIMDConverthttps://reviews.llvm.org/D98676/new/

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561abd83ffec: [WebAssembly] Disable uses of __clang_call_terminate (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

aheejin updated this revision to Diff 328116. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97834/new/ https://reviews.llvm.org/D97834 Files: clang/lib/CodeGen/CGException.cpp

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, mgorny. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D96903: [WebAssembly] Remove dependency of reference types from EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b5d2b0efd3e: [WebAssembly] Remove dependency of reference types from EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96903/new/

[PATCH] D96903: [WebAssembly] Remove dependency of reference types from EH

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new spec does not have

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. This does not yet have i64x2 version of the instructions in https://github.com/WebAssembly/simd/pull/395 yet, right? Comment at:

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9724c3cff46f: [WebAssembly] Update WasmEHPrepare for the new spec (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin updated this revision to Diff 315392. aheejin marked an inline comment as done. aheejin added a comment. Delete `declare void @_ZSt9terminatev()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94039/new/ https://reviews.llvm.org/D94039

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin marked an inline comment as done. aheejin added a comment. In D94039#2480002 , @tlively wrote: > In the description I think "but LLVM does not have a way of that kind of > behavior" is missing the word "modeling" => "but LLVM does not have a way

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG7be271537e97: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94038/new/

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

aheejin updated this revision to Diff 315366. aheejin added a comment. Remove an extra word Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94038/new/ https://reviews.llvm.org/D94038 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, dexonsmith, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-prefetch-offset.ll:126 +;=== +; v128.load64_zero

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:318 + Intrinsic<[], [llvm_ptr_ty], +[IntrInaccessibleMemOrArgMemOnly, IntrWillReturn, +

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG902ea588eab8: [WebAssembly] Rename atomic.notify and *.atomic.wait (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01d871536940: [WebAssembly] Remove a temporarily added RUN line (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. This RUN line was added as a temporary measure to undo

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, jfb, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. aheejin requested review of this revision. - atomic.notify ->

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98941279b90e: [WebAssembly] Clang-format builtins generation (NFC) (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:263 +// TODO: Add a new LLVMMatchType that can describe the relationship between the +// result and parameter

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_popcnt, "V16ScV16Sc", "nc", "simd128") + - Even if

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

aheejin added a comment. Do loads need the vector argument? The proposal has that but I'm wondering why... Can that possibly be an error from the author's side? Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane,

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane, "V4iIii*", "nU", "simd128")

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_q15mulr_saturate_s_i8x16, "V8UsV8UsV8Us", "nc", "simd128") +

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198 +[LLVMPointerType], +[IntrReadMem, IntrArgMemOnly, IntrSpeculatable], +

[PATCH] D84876: [clangd] Add clangdSupport to indexer target libraries

aheejin abandoned this revision. aheejin added a comment. It looks it was already addressed by https://github.com/llvm/llvm-project/commit/1603470e59a99a39ebdc4bf62a3a16c8c4ebea36#diff-761bab5bd4145e54cef902c493740880. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84876: [clangd] Add clangdSupport to indexer target libraries

aheejin created this revision. aheejin added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. aheejin requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. After D84697

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + tlively wrote: > aheejin wrote: > > tlively wrote: > > > aheejin wrote: > > > > It'd be clearer to

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + tlively wrote: > aheejin wrote: > > It'd be clearer to say starting indices of these don't start

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

aheejin added a comment. This looks fine to me, but I haven't worked on this part of code myself, so probably others who have can provide better review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + It'd be clearer to

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/wasm_simd128.h:1040 + (__c4)*2 + 1, (__c5)*2, (__c5)*2 + 1, (__c6)*2, (__c6)*2 + 1, (__c7)*2, \ + (__c7)*2 + 1))

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG48acac362938: [WebAssembly] Warn on exception spec only when Wasm EH is used (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin updated this revision to Diff 265645. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/lib/CodeGen/CGException.cpp

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin updated this revision to Diff 265432. aheejin added a comment. - Fix warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In D80061 we added warning for exception specifications with types (such as `throw(int)`),

  1   2   3   >