[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1727484 , @beanz wrote: > We should not be adding more variables that are passed around by CMake's > scope inheritance. Instead if we need to change this we should do it > correctly. Just to clarify,

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1727381 , @beanz wrote: > (1) dead stripping support is useful independent of plugins, so it is > valuable to have that option be separate Okay. >> Just because the current implementation of plug-in

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1726354 , @beanz wrote: > Can you please explain how the "no dead strip" semantic is harmful for > plug-in support, and how implying no dead strip for plugins is any different > from the current

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1726121 , @lhames wrote: > In D69356#1726074 , @beanz wrote: > > > ... It seems to me that maybe a more appropriate approach is that > > `LLVM_SUPPORT_PLUGINS`

[PATCH] D68340: Add AIX toolchain and basic linker functionality

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:1 +//===--- AIX.cpp - AIX ToolChain Implementations *- C++ -*-===// +// See Jason's comment about the line length. Comment at:

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1686887 , @vitalybuka wrote: > I would be happy to update the patch to enable it only for > -ftrivial-auto-var-init=pattern, if we want "bumper" version. It seems to be a separable feature (although it

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1686837 , @jfb wrote: > The entire point of this feature is to add guardrails to the language. I agree, and guardrails have a tendency to scratch paint if one drives against them. > What do people

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i32 36, i1 false) + // CHECK:

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i32 36, i1 false) + // CHECK:

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i32 36, i1 false) + // CHECK:

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL368690: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: xingxue, daltenty, jasonliu. Herald added subscribers: jfb, arphaman. Herald added a project: clang. Some tests perform deep recursion, which requires a larger pthread stack size than the relatively low default

[PATCH] D65668: [Driver][test] Avoid undefined grep in darwin-ld.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL367709: [Driver][test] Avoid undefined grep in darwin-ld.c (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D65668: [Driver][test] Avoid undefined grep in darwin-ld.c

hubert.reinterpretcast added a comment. In D65668#1612711 , @rnk wrote: > I assume this is affecting a real platform that you care about, but I'm > curious what it is. Yes, this is affecting our tests on AIX. `\?` there matches a literal `?`

[PATCH] D65668: [Driver][test] Avoid undefined grep in darwin-ld.c

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rnk, daltenty, xingxue, jasonliu. Herald added a project: clang. question-mark is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the interpretation of `\?` as used by rC366282

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

hubert.reinterpretcast added a comment. In D64301#1603499 , @thakis wrote: > Which platforms doesn't it work on? `ln -n` means something different on AIX: https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/l_commands/ln.html `-n` is not

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

hubert.reinterpretcast added a comment. `ln -n` is not a standard option that is portably supported. I'll be restoring the use of `rm` (with `-f` instead of `-rf`) and the associated comment for removing `%t.fake`. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64222: [sanitizers] Use covering ObjectFormatType switches

This revision was automatically updated to reflect the committed changes. Closed by commit rL366544: [sanitizers] Use covering ObjectFormatType switches (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D64222?vs=208085=210772#toc

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

hubert.reinterpretcast added a comment. In D64597#1582950 , @jfb wrote: > On 32-bit platforms the only region that's likely to trap is the zero page. > This seems to be the best choice, but platforms with other regions should be > able to tune this

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

hubert.reinterpretcast added a comment. In D64597#1581605 , @pcc wrote: > The problem with `0x` on 32-bit is that it is likely to be a valid > address. > > When I discussed this with JF I proposed a pointer initialization of > `0x` which

[PATCH] D64222: [sanitizers] Use covering ObjectFormatType switches

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, jasonliu, daltenty. Herald added subscribers: sunfish, aheejin, hiraditya. Herald added projects: clang, LLVM. This patch removes the `default` case from some switches on

[PATCH] D63767: [NFC] Make some ObjectFormatType switches covering

This revision was automatically updated to reflect the committed changes. Closed by commit rL365160: [NFC] Make some ObjectFormatType switches covering (authored by hubert.reinterpretcast, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D63767: [NFC] Make some ObjectFormatType switches covering

hubert.reinterpretcast added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63767/new/ https://reviews.llvm.org/D63767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63786: Print NULL as "(null)" in diagnostic message

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. I have some minor style comments that could be fixed as part of the commit. Comment at: clang/tools/c-index-test/c-index-test.c:4648

[PATCH] D63767: [NFC] Make some ObjectFormatType switches covering

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, jasonliu, daltenty. Herald added subscribers: jsji, aheejin. Herald added projects: clang, LLVM. This patch removes the `default` case from some switches on `llvm::Triple::ObjectFormatType`, and cases

[PATCH] D62952: [analyzer] SARIF: Add EOF newline; replace diff_sarif

This revision was automatically updated to reflect the committed changes. Closed by commit rL363822: [analyzer] SARIF: Add EOF newline; replace diff_sarif (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast updated this revision to Diff 205590. hubert.reinterpretcast added a comment. Update based on review comments from D62949 as confirmed in D62952 Normalized versions of the reference expected SARIF output

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548593 , @aaron.ballman wrote: > But is there a reason to not keep `%diff_sarif` and define it in terms of > `%normalize_sarif | diff -U1 -b` within lit.local.cfg? I guess I don't see > the benefit to

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548377 , @aaron.ballman wrote: > In general, that seems reasonable, but I would prefer to take care of more of > the work in lit.local.cfg than have to deal with that atrocious RUN line in > every test

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62952/new/ https://reviews.llvm.org/D62952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362998: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases) (authored by hubert.reinterpretcast,

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362996: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases) (authored by hubert.reinterpretcast,

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

This revision was automatically updated to reflect the committed changes. Closed by commit rL362994: [analyzer][tests] Add normalize_plist to replace diff_plist (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

This revision was automatically updated to reflect the committed changes. Closed by commit rL362992: [PlistSupport] Produce a newline to end plist output files (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rL362991: [CUDA] Fix grep pattern in cuda-types.cu (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. @NoQ, I've updated the patches based on the changes you suggested. This patch, D62950 , and D62951 now looks much cleaner. These are now dependent on the approval of D63041

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

hubert.reinterpretcast updated this revision to Diff 203708. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

hubert.reinterpretcast updated this revision to Diff 203707. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast updated this revision to Diff 203706. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, `__VERSION__` returns the Clang version instead of 4.2.1. I think this needs double backquotes

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, __VERSION__ returns the Clang version instead of 4.2.1. Use code font for `__VERSION__`.

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. @aaron.ballman, for similar cases in the plist output, it has been proposed - that the reference expected file be committed into the tree pre-normalized, and - that tool be modified such that the output file has a newline at the end of the file. Does

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. I've tested the pre-normalization and it looks like I can commit it tomorrow. I noticed that the following three files appear to be unreferenced: clang/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added a subscriber: jsji. Herald added a project: clang. As suggested in the review of D62949 , this patch updates the plist

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast updated this revision to Diff 203659. hubert.reinterpretcast added a comment. Fix grep pattern in cuda-types.cu As requested, further fix so that the `SIZEOF` and `WIDTH` macros are checked. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep 'define __[^ ]*\(TYPE\|MAX\|SIZEOF|WIDTH\)\|define

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: jlebar, daltenty, xingxue, jasonliu. Herald added subscribers: jsji, jfb. Herald added a project: clang. vertical-line is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533605 , @NoQ wrote: > Ok! I'll be happy to have this addressed incrementally. I think it should be safe to at least commit the pre-normalization directly first. I'll take a look, and update the patch

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533574 , @NoQ wrote: > I think we should: > > - Pre-normalize our expected outputs so that we didn't have to normalize them > in every run-line. Okay; I think this might be possible to do in a separate

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a comment. > I think the name `ppc_wrappers` is accurate to describe its meaning that > wrapping the headers under standard library path or standard header search > path. Thanks for clarifying this for me. In the case where all of the headers are expected to be

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 I'm not particularly concerned about the scoping of the work; however, the `ppc_wrappers` directory is not at all indicative of that scoping. It neither indicates the scope in terms of purpose

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a subscriber: cfe-commits. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. @daltenty, I believe that you have had a good number of patches committed into the project already (rL360898 , rL361410

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/CMakeLists.txt:862 +# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to +# break things. In this case we need to enable the LARGE FILE API as well +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/stdint.h:16 +#endif // _STD_TYPES_T /* mclow.lists wrote: > I don't think that this will do what you want it to. > Is this a supported use case? > > ``` > #include > #define

[PATCH] D59741: [lit] Set shlibpath_var on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rC357334: [lit] Set shlibpath_var on AIX (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D59741?vs=192014=192942#toc Repository: rC Clang

[PATCH] D59741: [lit] Set shlibpath_var on AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: xingxue, jasonliu, sfertile. Herald added a reviewer: serge-sans-paille. Herald added subscribers: cfe-commits, jsji. Herald added a project: clang. When building the `check-all` target on AIX, lit produces

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked 3 inline comments as done. Closed by commit rC356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library (authored by hubert.reinterpretcast, committed by ). Changed prior to

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Herald added a subscriber: jsji. Thanks @xingxue for the review. I will update for the error handling before committing. Comment at: tools/libclang/CIndexer.cpp:61 +if (errno

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added subscribers: asb, majnemer, lhames. hubert.reinterpretcast added a comment. @asb @lhames @majnemer, based on D36826 , I believe that your guidance would be helpful here regarding the use of `llvm_unreachable`, `report_fatal_error`,

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics lebedev.ri wrote: > hubert.reinterpretcast wrote: > > We may need to explicitly specify C11. It also

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics We may need to explicitly specify C11. It also seems that we should XFAIL Windows targets.

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added a comment. I believe that the conditions being checked for with `llvm_unreachable` in this patch are of the debug-only variety; however, some input would be appreciated regarding the choice of using `llvm_unreachable` instead of `report_fatal_error` or `assert`.

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, xingxue, jasonliu. Herald added a subscriber: arphaman. Herald added a project: clang. `dladdr` is not available on AIX. Similar functionality is presented through `loadquery`. This patch replaces a

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a subscriber: WuZhao. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. I think all comments have been addressed or otherwise responded to. @jasonliu: Since this patch is dependent

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:640 + +// Define _WCHAR_T when it is a fundamental type (i.e., for C++ without -fno-wchar). +if (Opts.CPlusPlus && Opts.WChar) { Line is longer than 80

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added a comment. @jasonliu, you have had a number of patches committed into the project already (D22698 , D22702 , D34649 ). Please go ahead with requesting commit access,

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/init.c:6420 +// PPC64-AIX:#define _LONG_LONG 1 +// PPC64-AIX:#define _POWER 1 +// PPC64-AIX:#define __64BIT__ 1 hubert.reinterpretcast wrote: > apaprocki wrote: > > XL on AIX emits

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); apaprocki wrote: > hubert.reinterpretcast wrote: > > Comments should be full

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. D59048 has been posted with some initial `OSTargetInfo` changes. Noticeable differences include not defining `_ALL_SOURCE` and focus on 64-bit long double. This is consistent with the invocation provided with the recent

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added a subscriber: rsmith. hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); Comments should be full

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; davide wrote: >

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; JDevlieghere wrote: >

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Triple.cpp:537 return StringSwitch(EnvironmentName) +// FIXME: We have to put XCOFF before COFF; +// perhaps an order-independent pattern matching is desired? If the conclusion

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. In D18360#1406455 , @apaprocki wrote: > @hubert.reinterpretcast Yes, this patch is available under the new license. Thank you, @apaprocki. We will be splitting this into updated and more granular patches.

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. Herald added subscribers: jdoerfert, arphaman. @apaprocki, as mentioned in our recent RFC ( http://lists.llvm.org/pipermail/llvm-dev/2019-February/130175.html ), IBM is working on AIX support for Clang and LLVM. We would like to continue the work on this

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rC353975: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D58128?vs=186480=186715#toc

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: echristo, hfinkel, kbarton, nemanjai, wschmidt. Herald added a subscriber: jsji. Herald added a project: clang. The predefined macro `_ARCH_PWR6X` is associated with GCC's `-mcpu=power6x` option, which enables

[PATCH] D57896: Variable names rule

hubert.reinterpretcast added a comment. In D57896#1391611 , @zturner wrote: > Is this actually any better? Whereas before we can’t differentiate type > names and variable names, under this proposal we can’t differentiate type > names and function

[PATCH] D57896: Variable names rule

hubert.reinterpretcast added a comment. I am generally in favour of this direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://reviews.llvm.org/D57896 ___ cfe-commits mailing

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rL348938: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element… (authored by hubert.reinterpretcast, committed by ). Herald

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177796. hubert.reinterpretcast added a comment. Recast representation-sensitive tests as SemaCXX tests using array bounds Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55510/new/

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added a comment. I'll update the tests to be in terms of constant/variable array length tomorrow. I think I've gotten through the rest of the comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55510/new/

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177656. hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added a comment. Address remaining ExprConstant.cpp review comments Use BytesRemaining/BytesPerElement to improve readability; tweak FIXME comment to refer

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177618. hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Use lvalue designator, add assertions for type matching Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177597. hubert.reinterpretcast marked 11 inline comments as done. hubert.reinterpretcast added a comment. Make an initial pass at addressing the review comments Address comments on style and code comments Repository: rC Clang CHANGES

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6159-6160 +// Give up on byte-oriented matching against multibyte elements. +if (IsRawByte && Info.Ctx.getTypeSize(CharTy) > Info.Ctx.getCharWidth()) + return false; // Figure

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, aaron.ballman, hfinkel. `memchr` and `memcmp` operate upon the character units of the object representation; that is, the `size_t` parameter expresses the number of character units. The constant

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Sema/altivec-generic-overload.c:73 + + __v16sc *gv1_p = convert1(gv1); + __v16uc *gv2_p = convert1(gv2);

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); wuzish wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); Checking that the call is to the expected target in

<    2   3   4   5   6   7   8   >