[clang] 0c8b26b - [clang] Remove a superfluous semicolon, silencing GCC warnings. NFC.

Author: Martin Storsjö Date: 2021-02-25T14:54:19+02:00 New Revision: 0c8b26bf530b3fc65af9205c593583f26549da3e URL: https://github.com/llvm/llvm-project/commit/0c8b26bf530b3fc65af9205c593583f26549da3e DIFF:

[clang] c17fdca - [clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

Author: Martin Storsjö Date: 2020-12-04T11:34:12+02:00 New Revision: c17fdca1883ddee94c6b7e055428d4445ab13e42 URL: https://github.com/llvm/llvm-project/commit/c17fdca1883ddee94c6b7e055428d4445ab13e42 DIFF:

[clang] d3bd06f - [clang] Fix the fsanitize.c testcase after eaae6fdf67e1f. NFC.

Author: Martin Storsjö Date: 2020-11-03T10:21:29+02:00 New Revision: d3bd06f5c709fe073739a06e0d5a22020f0bf90c URL: https://github.com/llvm/llvm-project/commit/d3bd06f5c709fe073739a06e0d5a22020f0bf90c DIFF:

[clang] eaae6fd - [clang] [MinGW] Allow using the vptr sanitizer

Author: Martin Storsjö Date: 2020-11-03T09:59:09+02:00 New Revision: eaae6fdf67e1f61599331d69a41a7dafe6199667 URL: https://github.com/llvm/llvm-project/commit/eaae6fdf67e1f61599331d69a41a7dafe6199667 DIFF:

[libunwind] df6d2e8 - [libunwind] Add -Wno-dll-attribute-on-redeclaration when building for windows

Author: Martin Storsjö Date: 2020-10-26T23:23:01+02:00 New Revision: df6d2e8ab1a4212284e4763724a2211df2c7394a URL: https://github.com/llvm/llvm-project/commit/df6d2e8ab1a4212284e4763724a2211df2c7394a DIFF:

[clang] 5eece13 - [clang] Automatically link against oldnames just as linking against libcmt

Author: Martin Storsjö Date: 2020-10-20T00:07:00+03:00 New Revision: 5eece137bc76f349cefc8922447694bea29ae101 URL: https://github.com/llvm/llvm-project/commit/5eece137bc76f349cefc8922447694bea29ae101 DIFF:

[clang] 3b1d018 - [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

Author: Mateusz Mikuła Date: 2020-10-12T23:28:23+03:00 New Revision: 3b1d018c0dba45408164f5e69cb400976efa350f URL: https://github.com/llvm/llvm-project/commit/3b1d018c0dba45408164f5e69cb400976efa350f DIFF:

[libunwind] fc5e68f - [libunwind] [SEH] Don't interact with foreign exceptions

Author: Martin Storsjö Date: 2020-10-12T23:28:22+03:00 New Revision: fc5e68fab965bdc8fdf6db9ae2603f9dd02dec5b URL: https://github.com/llvm/llvm-project/commit/fc5e68fab965bdc8fdf6db9ae2603f9dd02dec5b DIFF:

[clang] 3fec6dd - Reapply: [clang-cl] Always interpret the LIB env var as separated with semicolons

Author: Martin Storsjö Date: 2020-09-22T10:51:25+03:00 New Revision: 3fec6ddc276a595e4409f04dabdd50c84f5f2a2d URL: https://github.com/llvm/llvm-project/commit/3fec6ddc276a595e4409f04dabdd50c84f5f2a2d DIFF:

[clang] 8c3ef08 - Revert "[clang-cl] Always interpret the LIB env var as separated with semicolons"

Author: Martin Storsjö Date: 2020-09-22T00:14:45+03:00 New Revision: 8c3ef08f8a4eb40609af55d541e5135856fde086 URL: https://github.com/llvm/llvm-project/commit/8c3ef08f8a4eb40609af55d541e5135856fde086 DIFF:

[clang] ead7c3c - [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

Author: Martin Storsjö Date: 2020-09-21T23:42:59+03:00 New Revision: ead7c3cdc34c63d8df78d8e333b7cc64d03236ea URL: https://github.com/llvm/llvm-project/commit/ead7c3cdc34c63d8df78d8e333b7cc64d03236ea DIFF:

[clang] 4d85444 - [clang-cl] Always interpret the LIB env var as separated with semicolons

Author: Martin Storsjö Date: 2020-09-21T23:42:59+03:00 New Revision: 4d85444b317a00a3e15da63cdb693d272c99a0cc URL: https://github.com/llvm/llvm-project/commit/4d85444b317a00a3e15da63cdb693d272c99a0cc DIFF:

[clang] 7da9419 - [MinGW][libclang] Allow simultaneous shared and static lib

Author: Mateusz Mikuła Date: 2020-09-12T22:03:43+03:00 New Revision: 7da941939902768af25ffa45149695a0a5f15951 URL: https://github.com/llvm/llvm-project/commit/7da941939902768af25ffa45149695a0a5f15951 DIFF:

[clang] bb61304 - [MinGW][clang-shlib] Build by default on MinGW

Author: Mateusz Mikuła Date: 2020-09-12T22:02:31+03:00 New Revision: bb613044b6800b8ccc238232677f905bda423819 URL: https://github.com/llvm/llvm-project/commit/bb613044b6800b8ccc238232677f905bda423819 DIFF:

[clang] cc76965 - [MinGW] Use lib prefix for libraries

Author: Mateusz Mikuła Date: 2020-09-12T22:01:29+03:00 New Revision: cc76965b19085519278bff1052059e03769b71e8 URL: https://github.com/llvm/llvm-project/commit/cc76965b19085519278bff1052059e03769b71e8 DIFF:

[clang] 28b9ace - [clang] Remove a stray semicolon, fixing pedantic GCC warnings. NFC.

Author: Martin Storsjö Date: 2020-09-08T09:26:39+03:00 New Revision: 28b9ace85f6871cdb48f1483314d8342e099b136 URL: https://github.com/llvm/llvm-project/commit/28b9ace85f6871cdb48f1483314d8342e099b136 DIFF:

[libunwind] e524daa - [libunwind] Convert x86, x86_64, arm64 register restore functions to C calling convention and name mangling

Author: Martin Storsjö Date: 2020-08-26T14:32:32+03:00 New Revision: e524daa7e8719f4b43e6ebcf25fd4e7d74c5d1c4 URL: https://github.com/llvm/llvm-project/commit/e524daa7e8719f4b43e6ebcf25fd4e7d74c5d1c4 DIFF:

[libunwind] 542db87 - [libunwind] Ensure enough alignment for unw_cursor_t for SEH build configurations

Author: Martin Storsjö Date: 2020-08-22T22:48:57+03:00 New Revision: 542db87f1ac67087aeb5cf572b1f9744d482da69 URL: https://github.com/llvm/llvm-project/commit/542db87f1ac67087aeb5cf572b1f9744d482da69 DIFF:

[clang] cb6cf18 - [clang] Remove stray semicolons, fixing GCC warnings. NFC.

Author: Martin Storsjö Date: 2020-08-19T10:41:03+03:00 New Revision: cb6cf18ff5e0e5bb751e10549accc0f035f697ac URL: https://github.com/llvm/llvm-project/commit/cb6cf18ff5e0e5bb751e10549accc0f035f697ac DIFF:

Re: [clang] 6170072 - Improve modeling of variable template specializations with dependent

On Tue, 11 Aug 2020, Richard Smith wrote: On Tue, 11 Aug 2020 at 00:29, Martin Storsjö wrote: On Sun, 9 Aug 2020, Richard Smith via cfe-commits wrote: > > Author: Richard Smith > Date: 2020-08-09T23:22:26-07:00 > New Revision:

Re: [clang] 6170072 - Improve modeling of variable template specializations with dependent

On Sun, 9 Aug 2020, Richard Smith via cfe-commits wrote: Author: Richard Smith Date: 2020-08-09T23:22:26-07:00 New Revision: 617007240cbfb97c8ccf6d61b0c4ca0bb62d43c9 URL: https://github.com/llvm/llvm-project/commit/617007240cbfb97c8ccf6d61b0c4ca0bb62d43c9 DIFF:

[clang] a41af6e - [clang] Fix libdl linking for libclang in standalone mode

Author: Tobias Hieta Date: 2020-07-24T00:10:22+03:00 New Revision: a41af6e41e6fcf3e7030feaf24057cbe8291b748 URL: https://github.com/llvm/llvm-project/commit/a41af6e41e6fcf3e7030feaf24057cbe8291b748 DIFF: https://github.com/llvm/llvm-project/commit/a41af6e41e6fcf3e7030feaf24057cbe8291b748.diff

[clang] beeed36 - [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: beeed368b60252178f66ab117d8a96ecdc35f60e URL: https://github.com/llvm/llvm-project/commit/beeed368b60252178f66ab117d8a96ecdc35f60e DIFF:

[clang] 7b3fe96 - [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: 7b3fe969927731c69ba4d8a428442e1e191f49b5 URL: https://github.com/llvm/llvm-project/commit/7b3fe969927731c69ba4d8a428442e1e191f49b5 DIFF:

[clang] e3fd9dc - [clang] Enable -mms-bitfields by default for mingw targets

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: e3fd9dc9734c5775dc6824d0a839702e8d43e7f6 URL: https://github.com/llvm/llvm-project/commit/e3fd9dc9734c5775dc6824d0a839702e8d43e7f6 DIFF:

[clang] ab4d02c - [clang] [MinGW] Fix libunwind extension

Author: Mateusz Mikuła Date: 2020-05-29T15:23:14+03:00 New Revision: ab4d02cf265982d4c03123d2f52b9d5ee8df575d URL: https://github.com/llvm/llvm-project/commit/ab4d02cf265982d4c03123d2f52b9d5ee8df575d DIFF:

[clang] ac1f7ab - [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

Author: Martin Storsjö Date: 2020-05-29T15:23:14+03:00 New Revision: ac1f7ab007e347dc4a542aa3415e6378289480f4 URL: https://github.com/llvm/llvm-project/commit/ac1f7ab007e347dc4a542aa3415e6378289480f4 DIFF:

[clang] 0073c29 - [clang] Avoid linking libdl unless needed

Author: Tobias Hieta Date: 2020-05-28T21:08:00+03:00 New Revision: 0073c293a401774ac96b4b3d27f05e13f379f98e URL: https://github.com/llvm/llvm-project/commit/0073c293a401774ac96b4b3d27f05e13f379f98e DIFF: https://github.com/llvm/llvm-project/commit/0073c293a401774ac96b4b3d27f05e13f379f98e.diff

[clang] 609ef94 - [CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw

Author: Martin Storsjö Date: 2020-05-11T23:51:14+03:00 New Revision: 609ef948387ba40e3693c2bd693d82ca34dcdc02 URL: https://github.com/llvm/llvm-project/commit/609ef948387ba40e3693c2bd693d82ca34dcdc02 DIFF:

[clang] a0e53de - [clang] [MinGW] Add the compiler rt libdirs to the search path

Author: Martin Storsjö Date: 2020-04-29T20:35:50+03:00 New Revision: a0e53de472c5b9538884f23eb8f47c3bc734b345 URL: https://github.com/llvm/llvm-project/commit/a0e53de472c5b9538884f23eb8f47c3bc734b345 DIFF:

[clang] 6fb80d9 - libclang: Add static build support for Windows

Author: Cristian Adam Date: 2020-04-25T20:19:17+03:00 New Revision: 6fb80d9383e415c35204b62569972f70ae7dcb0a URL: https://github.com/llvm/llvm-project/commit/6fb80d9383e415c35204b62569972f70ae7dcb0a DIFF: https://github.com/llvm/llvm-project/commit/6fb80d9383e415c35204b62569972f70ae7dcb0a.diff

[clang] 7ff1f55 - libclang: Add static build support for Windows

Author: Cristian Adam Date: 2020-02-20T00:05:46+02:00 New Revision: 7ff1f55a1219719f57a6f7905c26ce41d1767e4c URL: https://github.com/llvm/llvm-project/commit/7ff1f55a1219719f57a6f7905c26ce41d1767e4c DIFF: https://github.com/llvm/llvm-project/commit/7ff1f55a1219719f57a6f7905c26ce41d1767e4c.diff

Re: r368348 - Fix up fd limit diagnosis code

Thanks for the fix, Qt does seem to build correctly now again. // Martin On Fri, 9 Aug 2019, Reid Kleckner wrote: Let me know if the problem persists after r368475. Someone else filed  https://bugs.llvm.org/show_bug.cgi?id=42948 as well. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö

Re: r368348 - Fix up fd limit diagnosis code

This change broke compiling Qt. A repro case looks like this: mkdir -p fake-qtincl/5.13.1/QtCore/private touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h touch fake-qtincl/QtCore echo "#include " > qtincl.cpp bin/clang++ -c qtincl.cpp -Ifake-qtincl -Ifake-qtincl/5.13.1 Previously this

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

This broke building of Qt when using PCH. Selfcontained repro is a bit hard to make though... // Martin On Tue, 4 Jun 2019, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Jun 4 14:29:28 2019 New Revision: 362551 URL: http://llvm.org/viewvc/llvm-project?rev=362551=rev Log:

Re: [PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

FWIW, this was fixed by SVN r354201. Thanks David! // Martin On Sat, 16 Feb 2019, Martin Storsjö via cfe-commits wrote: It broke on the first commit and is broken even after all of them. // Martin On Fri, 15 Feb 2019, Yitzhak Mandelbaum wrote: Was it the complete diff or one

Re: [PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

It broke on the first commit and is broken even after all of them. // Martin On Fri, 15 Feb 2019, Yitzhak Mandelbaum wrote: Was it the complete diff or one of the intermediate commits? I accidentally committed the diff as a series of commits rather than one (squashed) commit.  On Fri, Feb

Re: [PATCH] D49922: [P0936R0] add [[clang::lifetimebound]] attribute

On Thu, 2 Aug 2018, Richard Smith via cfe-commits wrote: On Thu, 2 Aug 2018, 06:10 Martin Storsjö via Phabricator via cfe-commits, wrote: mstorsjo added a comment. This change made clang to start trigger failed asserts for me (although they seem to not be reproducible with

Re: r338749 - Work around more GCC miscompiles exposed by r338464.

Hans, I think this commit should be merged to the 7.0 release branch; the first half of the GCC workaround made it in before the branch happened, but there was another identical case missing. // Martin On Thu, 2 Aug 2018, Martin Storsjo via cfe-commits wrote: Author: mstorsjo Date: Thu

Re: r334208 - [X86] Add back builtins for _mm_slli_si128/_mm_srli_si128 and similar intrinsics.

On Thu, 7 Jun 2018, Craig Topper via cfe-commits wrote: Author: ctopper Date: Thu Jun 7 10:28:03 2018 New Revision: 334208 URL: http://llvm.org/viewvc/llvm-project?rev=334208=rev Log: [X86] Add back builtins for _mm_slli_si128/_mm_srli_si128 and similar intrinsics. We still lower them to

Re: r333978 - Reimplement the bittest intrinsic family as builtins with inline asm

On Tue, 5 Jun 2018, Reid Kleckner via cfe-commits wrote: Author: rnk Date: Mon Jun 4 18:33:40 2018 New Revision: 333978 URL: http://llvm.org/viewvc/llvm-project?rev=333978=rev Log: Reimplement the bittest intrinsic family as builtins with inline asm We need to implement

Re: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Hej Henrik, On Thu, 19 Apr 2018, Henrik Gramner via cfe-commits wrote: The force_align_arg_pointer attribute was using a hardcoded 16-byte alignment value which in combination with -mstack-alignment=32 (or larger) would produce a misaligned stack which could result in crashes when accessing

RE: r330244 - [MinGW] Look for a cross sysroot relative to the clang binary

Hi Douglas, I wasn't able to reproducd the issue myself, but I think I know what the issue was, and I committed a fix attempt. // Martin On Wed, 18 Apr 2018, Martin Storsjö via cfe-commits wrote: Hi Douglas, Yes, I saw it - trying to look into it right now. // Martin On Wed, 18 Apr 2018

RE: r330244 - [MinGW] Look for a cross sysroot relative to the clang binary

Hi Douglas, Yes, I saw it - trying to look into it right now. // Martin On Wed, 18 Apr 2018, douglas.y...@sony.com wrote: Hi Martin, Your commit is causing a few test failures on the PS4 Windows bot, can you take a look?

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

On Wed, 29 Nov 2017, Martin Storsjö via cfe-commits wrote: On Wed, 29 Nov 2017, Reid Kleckner wrote: On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö <mar...@martin.st> wrote: On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote: Thanks for letting me kno

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

On Wed, 29 Nov 2017, Reid Kleckner wrote: On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote: On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote: Thanks for letting me know Reid. I’ll in work and won’t be able to access the repo

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote: Thanks for letting me know Reid. I’ll in work and won’t be able to access the repo until lunch time. (~3 hours) Feel free to revert if it is not trivial. The easy fix might be to change to == x86_64 from != x86 For is Windows in the

Re: [libunwind] r316745 - Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

On Fri, 27 Oct 2017, John Baldwin wrote: On 10/27/17 8:59 AM, Martin Storsjo via cfe-commits wrote: Author: mstorsjo Date: Fri Oct 27 00:59:01 2017 New Revision: 316745 URL: http://llvm.org/viewvc/llvm-project?rev=316745=rev Log: Express Registers_*::lastDwarfReg using

[PATCH] D25576: Add 64-bit MS _Interlocked functions as builtins again

mstorsjo added a comment. > (should they be also on AArch64? I had problems with testing it for AArch64, > so I left it) Technically, I think they should be on AArch64 as well. But clang/LLVM probably doesn't support AArch64/Windows yet (I guess?), so testing it probably is impossible.

[PATCH] D24986: [MS] Implement __iso_volatile loads/stores as builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL282900: [MS] Implement __iso_volatile loads/stores as builtins (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D24986?vs=72988=73113#toc Repository: rL LLVM

[PATCH] D24986: [MS] Implement __iso_volatile loads/stores as builtins

mstorsjo added inline comments. > majnemer wrote in ms-volatile-arm.c:2 > You don't need -fms-volatile. Well, originally, the point was to clarify that these volatile stores end up without atomic semantics, regardless of whether -volatile:ms has been specified. The original version of this

[PATCH] [Updated, 56 lines] D24986: [MS] Implement __iso_volatile loads/stores as builtins

mstorsjo updated this revision to Diff 72988. mstorsjo added a comment. Implemented using `CreateAlignedStore` and `CreateAlignedLoad` instead. I'm less confident in what this actually does though - e.g. is the `CreateBitCast` part necessary at all? I just based this on code I found in the

Re: [PATCH] D24986: [MS] Implement __iso_volatile loads/stores as builtins

mstorsjo retitled this revision from "Headers: Add iso_volatile load/store intrinsics" to "[MS] Implement __iso_volatile loads/stores as builtins". mstorsjo updated the summary for this revision. mstorsjo updated this revision to Diff 72782. mstorsjo added a comment. Changed to implement it as

[PATCH] D24986: Headers: Add iso_volatile load/store intrinsics

mstorsjo created this revision. mstorsjo added a reviewer: majnemer. mstorsjo added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This implements what is missing for PR30394, making it possible to compile C++ for ARM in MSVC mode with MSVC headers.

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added a comment. Ping, can someone commit this one now? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added a comment. Can someone commit this patch now after it has been rebased? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo updated the summary for this revision. mstorsjo updated this revision to Diff 72025. mstorsjo added a comment. Rebased on top of the latest master https://reviews.llvm.org/D24609 Files: lib/Headers/intrin.h Index: lib/Headers/intrin.h

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added a comment. Thanks! Can you/someone commit it? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1;

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1;

[PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo created this revision. mstorsjo added a reviewer: compnerd. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. On ARM, there are multiple versions of each of the intrinsics, with acquire/relaxed/release barrier semantics. The 64 bit

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added a comment. Can someone commit this for me? https://reviews.llvm.org/D22774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added a comment. In https://reviews.llvm.org/D22774#507014, @compnerd wrote: > Why `include_next` the header if not on Windows? Mostly because intrin.h uses the same logic. Normally, there's probably no such system header in other SDKs, but say if you happen to have a custom one

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added a comment. Ping @compnerd https://reviews.llvm.org/D22774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added a comment. Ping - any reply from @compnerd? In any case, feel free to formulate the ifdefs whichever way you want on commit as well (since I don't have commit access), as long as the included test passes. https://reviews.llvm.org/D22774

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added inline comments. Comment at: lib/Headers/armintr.h:26 @@ +25,3 @@ +#ifndef _MSC_VER +#include_next +#else compnerd wrote: > Hmm, why not do __has_header instead? armv7-windows-itanium won't define > `_MSC_VER` but you may have the header from

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo updated this revision to Diff 66306. mstorsjo added a comment. Added a test, added "windows" to the header title line, added an `#ifndef _MSC_VER #include_next` to the header. https://reviews.llvm.org/D22774 Files: lib/Headers/CMakeLists.txt lib/Headers/armintr.h

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added inline comments. Comment at: lib/Headers/armintr.h:27 @@ +26,3 @@ + +typedef enum +{ rengolin wrote: > mstorsjo wrote: > > rengolin wrote: > > > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix > > > environments? > > I can add the

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added a comment. In https://reviews.llvm.org/D22774#501993, @rengolin wrote: > Can you add a test on test/Headers, like the others, please? Sure, there seems to be a good spot for that in ms-intrin.cpp. Comment at: lib/Headers/armintr.h:1 @@ +1,2 @@ +/*===

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo abandoned this revision. mstorsjo added a comment. This test isn't strictly necessary, thus abandoning https://reviews.llvm.org/D22857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo added a comment. In https://reviews.llvm.org/D22857#497719, @rengolin wrote: > I'll just echo @compnerd comments, since Phab didn't get it. > > - Change the syntax to __asm__, to be more portable > - Add Microsoft asm block syntax MSVC doesn't support inline assembly on ARM at all

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

mstorsjo updated this revision to Diff 65725. mstorsjo added a comment. Updated the test to only check what triplet is passed to the assembler https://reviews.llvm.org/D22855 Files: lib/Driver/ToolChain.cpp test/Driver/windows-thumb.s Index: test/Driver/windows-thumb.s

Re: [PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

mstorsjo added inline comments. Comment at: test/Driver/thumb-attributes.s:1 @@ +1,2 @@ +@ RUN: %clang -target armv7-windows-itanium -c -o - %s \ +@ RUN: | llvm-readobj -s - | FileCheck %s rengolin wrote: > But we don't usually do asm tests in Clang. I can add

[PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo created this revision. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This test uses an immediate constant, which was previously broken in inline assembly, prior to LLVM r276859. https://reviews.llvm.org/D22857 Files:

[PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

mstorsjo created this revision. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This makes sure that the thumb section flag gets set by the assembler. This is an alternative fix to D22776. https://reviews.llvm.org/D22855 Files:

[PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo created this revision. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This fixes compiling with headers from the Windows SDK for ARM, where the YieldProcessor function (in winnt.h) refers to _ARM_BARRIER_ISHST. The actual MSVC

<    1   2   3   4