[PATCH] D155335: Revert 245d10b7a2c12ec25e7b5860a38c61991543a739

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9543f7de697: Revert "[clang][Interp][NFC] Trim Source.h includes"

[PATCH] D155335: Replace forward-declarations with proper headers for Decl and Stmt

saugustine updated this revision to Diff 540552. saugustine added a comment. Switch to pure revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155335/new/ https://reviews.llvm.org/D155335 Files: clang/lib/AST/Interp/Source.h Index: clang/li

[PATCH] D155335: This fixes an issue with 245d10b7a2c12ec25e7b5860a38c61991543a739, where on slightly older versions of clang, we get the below error and several others similar.

saugustine created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. saugustine requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In file included from .../clang/lib/AST/Interp/Source.h:17: In file included fro

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

saugustine added a comment. This change causes an assertion failure on the following test case. The memset is important for some reason. saugustine@saugustine-desktop:~/llvm/build $ cat t.c struct foo { unsigned char x; unsigned char data[]; }; extern void *memset (void

[PATCH] D138792: [AArch64] Improve TargetParser API

saugustine added a comment. We are seeing constexpr failures with this change. They look like this: In file included from llvm-project/llvm/lib/Support/AArch64TargetParser.cpp:14: In file included from llvm-project/llvm/include/llvm/Support/AArch64TargetParser.h:160: llvm-project/llvm/inc

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

saugustine added a comment. The newly added test func-attr.c fails when run in opt mode. If it is expected to run only at a certain optimization level, it should probably include that level in the test itself. I don't think it seriously blocks anything, but would be good to fix. /usr/local/g

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

saugustine added a comment. This change ends up leaving some unhandled enum with switches inside lldb, and it isn't obvious to me how to fix them. Can you take a quick look? llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4098:11: error: enumeration value 'BTFTagAttribu

[PATCH] D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType

saugustine added a comment. Committed as 3e55f55048387a8efef01e445d46fc5cf100285d . Thanks again for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103039/new/ https://r

[PATCH] D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType

saugustine accepted this revision. saugustine added a comment. This revision is now accepted and ready to land. This is a long-standing bug that needed to be fixed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103039/new/ https://review

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

saugustine added a comment. This commit introduced an unused variable warning when built without asserts. (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 . Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85231: Protect against filenames with no extension at all.

saugustine added a comment. The darwin-dsymutil.c tests this code path right now on line 33. I found this error by running it under asan; otherwise it was fully latent. It seems pretty clear to me that when End == -1 (StringRef::npos), creating a string ref from that is obviously a bug. I'm no

[PATCH] D85231: Protect against filenames with no extension at all.

saugustine created this revision. saugustine added a reviewer: echristo. Herald added a reviewer: JDevlieghere. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine requested review of this revision. Such as the one in the darwin-dsymutil.c test. Repository: rG LLV

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

saugustine added a comment. This is a reasonable workaround, as it seems to be checking the position of various arguments, and as things work today, lgcc and the compiler-rt variants appear in exactly the same places. If we wanted to be really strict, we would add some new test that tested that

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64059828f19: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics" (authored by saugustine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

saugustine created this revision. saugustine added reviewers: echristo, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This reverts

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

saugustine added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:43 #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" #include "llvm/ADT/ArrayRef.h" Unfortun

[PATCH] D81522: Fix variables used only in asserts.

saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine edited the summary of this revision. saugustine added a reviewer: baloghadamsoftware. Herald added a subscriber: rnkovacs. Fix variables used only in asserts. For post-commit review

[PATCH] D81522: Fix variables used only in asserts.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGccd192204da4: Fix variables used only in asserts. (authored by saugustine). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

saugustine added a comment. Unfortunately, after this change there are several variables only used in asserts, which creates build failures when assertions are disabled. I will be submitting https://reviews.llvm.org/D81522 shortly to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf07b3d41e739: Add #includes so that ROCm.h is compilable stand-alone. (authored by saugustine). Repository: rG LLVM Git

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

saugustine added a comment. For post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81432/new/ https://reviews.llvm.org/D81432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine added reviewers: jyknight, echristo. saugustine added a comment. For post-commit review. ROCm.h had been getting the declarations for various data structures by being #included nex

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

saugustine added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break; itollefsen wrote: > If you are building with `-DLIBUNWIND_ENABLE_SHARED:OFF > -DLIBUNWIND_ENABLE_STAT

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

saugustine added a comment. Reverted in a4b88c044980337bb14390be654fe76864aa60ec . Happy to approve an updated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ h

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

saugustine added a comment. This change breaks the lldb build with lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3958:11: error: enumeration values 'DependentExtInt' and 'ExtInt' not handled in switch [-Werror,-Wswitch] switch (qual_type->getTypeClass()) { ^ lldb/source

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

saugustine accepted this revision. saugustine added a comment. This looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/new/ https://reviews.llvm.org/D75890 ___ cfe-commits mailing li

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

saugustine added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1169 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI = TL.getClassTInfo()) +TRY_TO(TraverseTypeLoc(TSI->g

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

saugustine added a comment. When I try to run tablegen on this file for clang/docs (as described in clang/docs/InternalsManual.rst), I get an error, introduced by this change: $ ./bin/clang-tblgen -gen-attr-docs -I ../llvm-project/clang/include ../llvm-project/clang/include/clang/Basic/Attr.td

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

saugustine added a comment. In D70416#1750978 , @joerg wrote: > This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See > `tools::addOpenMPRuntime`. Historically, the unwind library is a little different. Gcc uses -llibgcc_eh for

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. From the failure mode I was seeing, any value at all for __VERSION__ will be fine, as long as it is a valid preprocessor string. It would also solve this particular problem to not define __GNUC__, but I as that would create other, more severe, problems, as long as cl

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. The revert is at https://reviews.llvm.org/D64687, which I will commit shortly if there are no objections. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 _

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert. The file is getcompiler.c: /* Return the compiler identification, if possible. */ #include "Python.h" #ifndef COMPILER #ifdef __G

[PATCH] D59841: [Gnu Driver] If -pie and -static-pie are both passed, let -static-pie win.

saugustine added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || - Args.hasArg(options::OPT_r)) + Args.hasArg(options::OPT_r) || Args.hasArg(options::OPT_static_pie))

[PATCH] D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

saugustine accepted this revision. saugustine added a comment. This revision is now accepted and ready to land. This looks correct to me, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59387/new/ https://reviews.llvm.org/D59387

[PATCH] D55016: Correctly support -shared-libgcc.

saugustine closed this revision. saugustine added a comment. Committed with r350900. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55016/new/ https://reviews.llvm.org/D55016 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55016: Correctly support -shared-libgcc.

saugustine created this revision. saugustine added a reviewer: echristo. Herald added subscribers: cfe-commits, srhines. Correctly support -shared-libgcc. Repository: rC Clang https://reviews.llvm.org/D55016 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/linux-ld.c Index: test

[PATCH] D51521: Refactor Addlibgcc to make the when and what logic more straightfoward.

saugustine closed this revision. saugustine added a comment. commited as r341231. Repository: rC Clang https://reviews.llvm.org/D51521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D51521: Refactor Addlibgcc to make the when and what logic more straightfoward.

saugustine created this revision. saugustine added a reviewer: srhines. Herald added a subscriber: cfe-commits. Refactor Addlibgcc to make the when and what logic more straightfoward. No functional change. A forthcoming change will add support for -shared-libgcc. Repository: rC Clang https:/

[PATCH] D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker.

saugustine closed this revision. saugustine added a comment. Committed as https://reviews.llvm.org/rL341083 Repository: rC Clang https://reviews.llvm.org/D51007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker.

saugustine added a comment. I am refactoring the code that does this, in preparation for adding support for -shared-libgcc, and, after that, shared compiler-rt. These tests are to defend against mistakes in that refactoring and prepare for correct handling of the other cases. Repository: rC

[PATCH] D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker.

saugustine created this revision. saugustine added a reviewer: echristo. Herald added a subscriber: cfe-commits. NFC. Add tests to verify how the driver passes libgcc arguments to the linker Repository: rC Clang https://reviews.llvm.org/D51007 Files: test/Driver/linux-ld.c Index: test/Dr

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

saugustine added a comment. In https://reviews.llvm.org/D36610#1083952, @mikhail.ramalho wrote: > Ping. Given that richard smith is the only non-approver, and that he hasn't responded, and that I contributed this code, I'm going to make an executive decision and say that this is OK to submit.

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

saugustine closed this revision. saugustine added a comment. Committed as https://reviews.llvm.org/rL319474. https://reviews.llvm.org/D36431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine closed this revision. saugustine added a comment. Committed as R319464. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

saugustine added a comment. In https://reviews.llvm.org/D36431#940169, @nemanjai wrote: > This has been sitting in approved state for more than 2 months. As far as I > can tell, it wasn't committed. Do you plan to commit this soon or are you > abandoning it for some reason? My apologies. I ha

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine updated this revision to Diff 112244. saugustine added a comment. Remove two files inadvertantly included in last patch. https://reviews.llvm.org/D36555 Files: compiler-rt/lib/builtins/CMakeLists.txt Index: compiler-rt/lib/builtins/CMakeLists.txt ==

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine added a reviewer: weimingz. saugustine added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223 + cpu_model.c + divxc3.c + fixxfdi.c mgorny wrote: > This and the following files have only: > > ``` > #if !_ARCH_PPC > ``` > > s

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine updated this revision to Diff 112242. saugustine added a comment. Thanks for the various comments. Please take another look. https://reviews.llvm.org/D36555 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/lib/builtins

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

saugustine added a comment. OK. I understand how these should work now. As they are 80-bit specific, I am going to abandon this change and add them to my other patch which moves 80-bit specific floats and tests to x86-specific lists. https://reviews.llvm.org/D36764

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

saugustine added a comment. Anyone have any opinions on this? https://reviews.llvm.org/D36764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

saugustine created this revision. These functions were disabled for powerpc in the initial checkin all the way back in 2009. The reasons why are lost to history, but they work fine with modern clang and powerpc64. I have no way to test them on 32-bit systems, but will clean this up if the someone

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine added a comment. I've cleaned up this patch a bit. Now the only files that are in the x86_ARCH group are those that require 80 bits floats and cpu_model.c. Tests for all of these were already disabled on arm and powerpc (because neither has 80-bit floats), so we knew these library fu

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

saugustine accepted this revision. saugustine added a comment. This revision is now accepted and ready to land. This is a good change as far as functionality, but I defer to others on the style and other details. https://reviews.llvm.org/D36610 ___

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D36555 Files: compiler-rt/lib/builtins/CMakeLists.txt Index: compiler-rt/lib/builtins/CMakeLists.txt === --- compiler-rt/lib/builtins/C

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

saugustine added a comment. In https://reviews.llvm.org/D36431#835165, @nemanjai wrote: > This patch appears to be perfectly fine. However, it triggers a large number > of warnings. Namely, there's a large number of `warning: ISO C forbids an > empty translation unit [-Wpedantic]` warnings prod

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine added a comment. Landed as r309973 Repository: rL LLVM https://reviews.llvm.org/D36249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine added a comment. In https://reviews.llvm.org/D36249#830121, @weimingz wrote: > I tried to address it via checking pre-defined macros: > https://reviews.llvm.org/D31573 > > As long as the macros are defined correctly by clang, we don't need to worry > about the specific target machine

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine created this revision. These tests assume intel-80 bit floats, as noted in their comments. Rather than having each target discover the incompatibility and disable them ad-hoc, mark them as requiring x86. Repository: rL LLVM https://reviews.llvm.org/D36249 Files: compiler-rt/te

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309634: Add powerpc64 to compiler-rt build infrastructure. (authored by saugustine). Changed prior to commit: https://reviews.llvm.org/D36108?vs=109015&id=109017#toc Repository: rL LLVM https://revi

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine added a comment. In https://reviews.llvm.org/D36108#826673, @timshen wrote: > Offline discussion discovered that __clear_cache() is not implemented for > powerpc64 (the big-endian target). I think it's correct to use the same > implementation of __clear_cache() for both endianness. W

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine updated this revision to Diff 109015. saugustine added a comment. - The current powerpc implementation of clear cache works for big endian. https://reviews.llvm.org/D36108 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake compiler-

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine created this revision. Herald added subscribers: aheejin, mgorny, dberris, nemanjai. Add powerpc64 to compiler-rt build infrastructure. https://reviews.llvm.org/D36108 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/l

[PATCH] D35959: Summary: For powerpc64, disable tests that assume long double is 80-bits.

saugustine updated this revision to Diff 108727. saugustine added a comment. Herald added subscribers: aheejin, mgorny. - Add clear_cache implementation for ppc64. Fix buffer to meet ppc64 alignment. - Merge branch 'master' of https://github.com/llvm-project/llvm-project-20170507 - Merge branch 'm

[PATCH] D35959: Summary: For powerpc64, disable tests that assume long double is 80-bits.

saugustine created this revision. Herald added a subscriber: nemanjai. https://reviews.llvm.org/D35959 Files: compiler-rt/test/builtins/Unit/fixunsxfti_test.c compiler-rt/test/builtins/Unit/fixxfti_test.c compiler-rt/test/builtins/Unit/floattixf_test.c compiler-rt/test/builtins/Unit/float

[PATCH] D35131: Prevent ClangTools from generating dependency files.D34304 created a way for ToolInvocations to conditionally generatedependency files, and updated call sites to preserve the old behav

saugustine added a comment. Manuel, What do you think? https://reviews.llvm.org/D35131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35131: Prevent ClangTools from generating dependency files.D34304 created a way for ToolInvocations to conditionally generatedependency files, and updated call sites to preserve the old behav

saugustine created this revision. ...are yet another call-path that needs updating to preserve the old behavior. https://reviews.llvm.org/D35131 Files: lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp === --- lib/Tooling/

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine updated this revision to Diff 104307. saugustine added a comment. Rework this patch to use argument adjusters. It turns out that the call to newInvocation from ClangFuzzer has a very limited set of hard-coded arguments, so I don't think it is necessary to do the hand-adjusting there. An

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine added a comment. In https://reviews.llvm.org/D34304#787699, @klimek wrote: > I mean, arguments need to be adjusted before converting to ArgStringList and > calling newInvocation? I'm not sure I fully understand the problem, can you > elaborate? This gets back to why the original pa

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine added a comment. > Actually, now that I figured out you mean ArgumentAdjusters, I am making > progress. Unfortunately, ArgumentAdjusters only work on vector, and while ToolInvocation::Invocation takes its arguments in that form, tooling::newInvocation (which returns a CompilerInvoca

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine added a comment. In https://reviews.llvm.org/D34304#785984, @saugustine wrote: > In https://reviews.llvm.org/D34304#785083, @klimek wrote: > > > I think it's cleaner, because it uses a concept we already have (argument > > adapters). > > > Will you point me to an example of these. Goo

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine added a comment. In https://reviews.llvm.org/D34304#785083, @klimek wrote: > I think it's cleaner, because it uses a concept we already have (argument > adapters). Will you point me to an example of these. Google is coming up empty. https://reviews.llvm.org/D34304 _

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine added a subscriber: klimek. saugustine added a comment. In https://reviews.llvm.org/D34304#783675, @klimek wrote: > I think a better way might be to generally leave dependency options alone, > add a default argument adapter to filter out all deps related flags, and > allow users to a