[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG125abbdc9767: [flang][driver] Ensure negative flags have the same visibility as positive (authored by tblah). Changed prior to commit:

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

tblah updated this revision to Diff 552723. tblah added a comment. Thanks for taking a look. Changes: add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158612/new/ https://reviews.llvm.org/D158612 Files:

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

tblah created this revision. tblah added reviewers: awarzynski, bogner, MaskRay. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang.

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

tblah accepted this revision. tblah added a comment. Looks good to me, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 ___ cfe-commits mailing

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

tblah added inline comments. Comment at: clang/lib/Driver/Driver.cpp:6472-6473 if (IsFlangMode()) { // TODO: Does flang really want *all* of the clang driver options? // We probably need to annotate more specifically. +return

[PATCH] D157410: [Flang] Enable Rpass flag

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. LGTM, thanks for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for your efforts on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

tblah added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:398 + if (const Arg *A = Args.getLastArg(options::OPT_fsave_optimization_record_EQ)) +Format = A->getValue(); + What happens if an invalid or unsupported format is specified. Is

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153281/new/ https://reviews.llvm.org/D153281

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

This revision was automatically updated to reflect the committed changes. Closed by commit rG39ecf9d8a153: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah updated this revision to Diff 527386. tblah added a comment. Thanks again for review! Now there are two actions: - EmitFIR - EmitHLFIR EmitHLFIR will assert that lowering was set up to emit HLFIR. EmitFIR will use the HLFIR to FIR pipeline if lowering was set up to emit HLFIR.

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah added inline comments. Comment at: flang/include/flang/Frontend/FrontendOptions.h:42 + /// resulting FIR + EmitHLFIRToFIR, + awarzynski wrote: > To me having `EmitFIR` and `EmitHLFIR` would make more sense. With 2 > dialects, `EmitMLIR` becomes rather

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah updated this revision to Diff 526681. tblah marked an inline comment as done. tblah added a comment. Thanks for review! Changes: - Fix assertion comment - Change the -emit-mlir flag to be an alias for -emit-fir (previously they were the other way around). This does not address review

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah added a comment. @awarzynski ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/ https://reviews.llvm.org/D151088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah added inline comments. Herald added a subscriber: bviyer. Comment at: flang/include/flang/Tools/CLOptions.inc:251 +bool stackArrays = false, bool underscoring = true, bool useHLFIR = false) { + if (useHLFIR) +fir::createHLFIRToFIRPassPipeline(pm, optLevel);

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir

tblah created this revision. tblah added reviewers: awarzynski, vzakhari, jeanPerier, clementval. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert.

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

tblah added a comment. Thanks for adding this flang. Please could you add a test checking that the pass is actually run when the flag is given. For example, see the tests on this patch https://reviews.llvm.org/D146278 Comment at: flang/include/flang/Tools/CLOptions.inc:21

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacf6a3224955: [flang] add -flang-experimental-hlfir flag to flang-new (authored by tblah). Changed prior to commit:

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507321. tblah added a comment. Thanks for the suggestion - Added a test to check that hlfir is not output without the flag - clang-formatted CLOptions.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507026. tblah added a comment. Added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 Files: clang/include/clang/Driver/Options.td

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager , +llvm::OptimizationLevel optLevel = defaultOptLevel) { vzakhari wrote: > Would you mind

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 506544. tblah marked 2 inline comments as done. tblah added a comment. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah created this revision. tblah added reviewers: jeanPerier, vzakhari, clementval. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers:

[PATCH] D142420: [Flang] Add support to use LTO specific pipelines

tblah added a comment. In D142420#4080619 , @mnadeem wrote: > We have tried full LTO on Aarch64 (without this patch) and have seen a few > 3-8% improvements in SPEC and a 100+% improvement in leslie3d. > There were a couple of additional failures in

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah added a comment. Please could you add tests for the flag forwarding logic in flang/tests/Driver/frontend-forwarding.f90. For example see https://reviews.llvm.org/rGd0d4b635786d510cd919cadbeb7e5e19983242cf Comment at: clang/lib/Driver/ToolChains/Flang.cpp:69 + Arg

[PATCH] D140972: [flang] Add -fstack-arrays flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf81ba372628: [flang] add -fstack-arrays flag (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140415: [flang] stack arrays pass

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc14bf22bddf: [flang] add a pass to move array temporaries to the stack (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 495073. tblah added a comment. Changes: inline mlir::blockIsInLoop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:732 + mlir::applyPartialConversion(func, target, std::move(patterns { +mlir::emitError(func->getLoc(), "error in stack arrays optimization\n"); +signalPassFailure();

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4098170 , @kiranchandramohan wrote: > Looks OK. I have a few questions and some minor comments inline. It might be > good to pull in a bit of info from the RFC into the Summary, particularly > saying why a dataflow

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 494283. tblah marked 8 inline comments as done. tblah added a comment. Changes: fix nits from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files:

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:433 + llvm::DenseSet freedValues; + func->walk([&](mlir::func::ReturnOp child) { +const LatticePoint *lattice = solver.lookupState(child); kiranchandramohan wrote: > Do

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 493692. tblah marked 10 inline comments as done. tblah added a comment. Thanks for review. Changes: - Join the lattices at each return operation to ensure that values are freed at *all* returns, not only *some* return - Add tests with multiple return

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah marked an inline comment as done. tblah added inline comments. Comment at: flang/test/Driver/fast_math.f90:59-62 +! Check that -ffast-math causes us to link to crtfastmath.o +! UNSUPPORTED: system-windows +! RUN: %flang -ffast-math -### %s -o %t 2>&1 \ +! RUN: |

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4080080 , @jdoerfert wrote: > Did you check LLVM's heap2stack and the corresponding tests? >

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4080080 , @jdoerfert wrote: > Thanks for taking a look, see my responses inline. For more information, the RFC is at https://reviews.llvm.org/D139617 > Quick questions, and they might not apply here since you seem to

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:352 + LLVM_DEBUG(llvm::dbgs() + << "--Allocation is not for an array: skipping\n"); +} jeanPerier wrote: > I think the early return may be missing

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 492044. tblah marked 5 inline comments as done. tblah added a comment. - Add missing early return for allocations not for arrays - Remove braces from if statement with a single statement in its body - Assert that a correct insertion point is found for the

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. Ping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 491267. tblah added a comment. - Rename option macro to make it clear that it doesn't do marshalling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 Files:

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 490810. tblah added a comment. Fix newly added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490801. tblah added a comment. Update to ensure that generated code for Options.td does not try to reference clang::CodegenOpts::StackArrays. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490100. tblah marked 4 inline comments as done. tblah added a comment. Clarified a comment in stack-arrays.f90 and clarified the choice of FileCheck prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:120 + // which operations we intend to rewrite before it calls the pattern rewriter + llvm::SmallDenseMap insertionPoints; + jeanPerier wrote: > It is definitely weird to

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 489753. tblah marked 7 inline comments as done. tblah added a comment. - Implement operator!= as !(operator==) - Move insertion point computation to StackArraysAnalysisWrapper::analyseFunction - Remove special-casing for join(allocated, unknown) - Add

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:159 inline void createDefaultFIROptimizerPassPipeline( -mlir::PassManager , llvm::OptimizationLevel optLevel = defaultOptLevel) { +mlir::PassManager , bool stackArrays = false,

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 489484. tblah marked 6 inline comments as done. tblah added a comment. Update to address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 Files:

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 488914. tblah added a comment. Updating patch context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 488686. tblah added a comment. Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Updated to construct StackArrays as a ModuleOp pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 488685. tblah added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, Flang. - Do not move allocations outside of openmp regions - Detect loops in the control flow graph - Attempt to

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3995282 , @probinson wrote: > See D139967 for why `UNSUPPORTED: powerpc` > didn't work. That patch will put it back, and also update the lit config so > the check will work now.

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3989826 , @amyk wrote: > Thanks for the follow up patch! I tested the patch locally and also saw the > buildbot results, and it doesn't appear like the follow up patch marked > `powerpc` as unsupported as the error

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3989403 , @amyk wrote: > Hi, > > The ppc64le-flang-rhel-clang > bot is also experiencing some failures with the `Driver/fast_math.f90` test > case. In particular,

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3987836 , @clementval wrote: > I have the `Driver/fast_math.f90` failing on my side. > > llvm-project/flang/test/Driver/fast_math.f90:63:14: error: CHECK-CRT: > expected string not found in input > ! CHECK-CRT:

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b6660243d1: [flang] Add -ffast-math and -Ofast (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137329: [flang] Add -f[no-]associative-math and -mreassociate

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4dc3c029416: [flang] Add -f[no-]associative-math and -mreassociate (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D137330: [flang] add -f[no-]reciprocal-math

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d4b635786d: [flang] add -f[no-]reciprocal-math (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137328: [flang] Add -f[no-]signed-zeros

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b8a8cfbe1e: [flang] Add -f[no-]signed-zeros (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137326: [flang] Add -f[no-]approx-func

This revision was automatically updated to reflect the committed changes. Closed by commit rG36b37a1ed561: [flang] Add -f[no-]approx-func (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137325: [flang] Add -f[no-]honor-nans and -menable-no-nans

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e93e390c06: [flang] Add -f[no-]honor-nans and -menable-no-nans (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D137072: [flang] Add -f[no-]honor-infinities and -menable-no-infs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb763e7d0a4: [flang] Add -f[no-]honor-infinities and -menable-no-infs (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 471958. tblah added a comment. I've updated the patch with @awarzynski's nit and an up-to-date context. @kiranchandramohan please could you commit for me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 471163. tblah edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 470496. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 470184. tblah marked 2 inline comments as not done. tblah edited the summary of this revision. tblah added a comment. Updated diff with a further reduced help text after discussions with @awarzynski CHANGES SINCE LAST ACTION

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 469556. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, vzakhari wrote: > tblah wrote: > > vzakhari wrote: > > > tblah wrote: > > > > awarzynski wrote: > > > > > What are

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, vzakhari wrote: > tblah wrote: > > awarzynski wrote: > > > What are these pragmas? Perhaps you can add a test that

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 468840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/include/flang/Frontend/CompilerInvocation.h

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah marked 8 inline comments as done. tblah added a comment. >> The omission of the fast-honor-pragmas argument from the compiler driver is >> deliberate. > > Where is it omitted? This argument is only supported in the frontend driver, not the compiler driver: flang-new

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah added a comment. Linux CI is passing. I suspect the CI failure on windows is unrelated to my code: the test failure is for clang-scan-deps and the previous version of the patch passed CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 468475. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/include/flang/Frontend/CompilerInvocation.h

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah marked 5 inline comments as done. tblah added a comment. Thanks for taking a look. I've updated accordingly and will upload the patch soon. > are you confident that we will need LangOptions.def? Clang places this flag (and many other floating point options) in LangOptions so I thought I

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 468258. tblah added a comment. clang-format plus cleaning up typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah created this revision. tblah added reviewers: kiranchandramohan, MatsPetersson, DavidTruby, rovka, vzakhari. tblah added a project: Flang. Herald added a subscriber: jdoerfert. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a project: All. tblah

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah added a comment. Yes please commit on my behalf. My details are Tom Eccles tom.ecc...@codethink.co.uk Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah added a comment. I'm not able to reproduce the test failure in CI. It looks spurious to me because I have not changed anything related to openmp. The only change in behaviour after my patch should be to avoid a null pointer dereference. In tests which did not hit that null pointer

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah updated this revision to Diff 422906. tblah added a comment. Added a unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123667/new/ https://reviews.llvm.org/D123667 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tblah created this revision. tblah added a reviewer: rsmith. Herald added a project: All. tblah requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NamedDecl::getIdentifier can return a nullptr when DeclarationName::isIdentifier is false,