[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

serge-sans-paille created this revision. serge-sans-paille added a reviewer: sylvestre.ledru. Herald added a subscriber: whisperity. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix

[PATCH] D109693: Driver: Remove major release version detection for RHEL

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, please reformat the code though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 374290. serge-sans-paille added a comment. Set default as suggested by @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. In D109967#3013552 , @nickdesaulniers wrote: > Looks reasonable. Can you give us some time to test this on the Linux kernel? Sure, who can refuse some extra testing?

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille marked 6 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s +//

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 373801. serge-sans-paille added a comment. Herald added a subscriber: whisperity. Update formatting / extra comments Update test to be more explicit about their intent / run them through update_cc_test_checks CHANGES SINCE LAST ACTION

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees this does fix https://bugs.llvm.org/show_bug.cgi?id=50322 , but only if the memcpy "inline definition" is flagged as a `__attribute__((always_inline))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, nickdesaulniers, efriedma. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is a common practice in glibc header to provide an inline

[PATCH] D109686: Check supported architectures in sseXYZ/avxXYZ headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9aeecdfa8e91: Check supported architectures in sseXYZ/avxXYZ headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D109686: Check supported architectures in sseXYZ/avxXYZ headers

serge-sans-paille created this revision. serge-sans-paille added reviewers: craig.topper, RKSimon. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It doesn't make sense to include those headers on the wrong architecture,

[PATCH] D109659: Fix scan-build-py executable lookup path

This revision was automatically updated to reflect the committed changes. Closed by commit rGc84755a046bb: Fix scan-build-py executable lookup path (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109659/new/

[PATCH] D109659: Fix scan-build-py executable lookup path

serge-sans-paille created this revision. serge-sans-paille added reviewers: sylvestre.ledru, isthismyaccount, phosek. Herald added a subscriber: whisperity. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Once installed,

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. You know your platform better than I do, and you already ran the patch without any issue, so LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108571/new/

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

serge-sans-paille added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:2 +# In the main branch, LLVM_ABI_REVISION should always be 0. In the release +# branches, this should be incremented before each release candidate every +# time the ABI of

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ada884cbc2f: SubstTemplateTypeParmType can contain an auto type in their replacement type (authored by serge-sans-paille). Changed prior to

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

serge-sans-paille created this revision. serge-sans-paille added reviewers: rsmith, aaron.ballman. Herald added a subscriber: kristof.beyls. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes bug 36064

[PATCH] D103849: Fix undeduced type when instanciating template member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b219051a331: Fix undeduced type assert (authored by serge-sans-paille). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille added a comment. @rsmith : gentle ping ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. serge-sans-paille marked 2 inline comments as done. Closed by commit rGa0d05ed84899: Handle interactions between reserved identifier and user-defined suffixes

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille added a comment. @rsmith : any opinion on that one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352938. serge-sans-paille added a comment. Reviews taken into account, I'm just not 100% sure of the fixit part. The out is the following: a.cpp:4:16: warning: identifier '_Bye' is reserved because it starts with '_' followed by a capital

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352423. serge-sans-paille added a comment. Tried another not-so-intrusive approach. @rsmith? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Sema/Sema.h

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Basic/IdentifierTable.h clang/lib/Basic/IdentifierTable.cpp clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. Herald added a subscriber: dexonsmith. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

serge-sans-paille added a comment. In D104116#2816291 , @RKSimon wrote: > This leaves the question - what hardware should we align each of the > CK_x86_64_v* targets with? I'm not quite sure I get it. If I understand correctly, each `CK_x86_64_v*`

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

This revision was automatically updated to reflect the committed changes. Closed by commit rG092c303955cd: AMD k8 family does not support SSE4.x which are required by x86-64-v2+ (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille updated this revision to Diff 351191. serge-sans-paille added a comment. Added test + fix suggested by @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 Files: clang/lib/AST/Expr.cpp

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, sorry for the late review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53014/new/ https://reviews.llvm.org/D53014

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille added inline comments. Comment at: docs/CommandGuide/clang.rst:319 + + Specify the architecture to build for (Linux and others) To be clear: this is probably misleading and should be `(all platforms)` Repository: rC Clang CHANGES SINCE

[PATCH] D102168: Use an allow list on reserved macro identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6045cb89e5e8: Use an allow list on reserved macro identifiers (authored by serge-sans-paille). Herald added a project: clang. Repository: rG LLVM

[PATCH] D102168: Use an allow list on reserved macro identifiers

serge-sans-paille updated this revision to Diff 344840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c Index: clang/test/Preprocessor/macro-reserved.c

[PATCH] D102168: Use an allow list on reserved macro identifiers

serge-sans-paille updated this revision to Diff 344825. serge-sans-paille added a comment. Minor nits as suggested by reviewers + extend the list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 Files: clang/lib/Lex/PPDirectives.cpp

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91a919e8994a: [NFC] Synchronize reserved identifier code between macro and variables / symbols (authored by serge-sans-paille). Herald added a

[PATCH] D93095: Introduce -Wreserved-identifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb83b23275b74: Introduce -Wreserved-identifier (authored by serge-sans-paille). Herald added a project: clang. Changed prior to commit:

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 341853. serge-sans-paille marked 10 inline comments as done. serge-sans-paille added a comment. Take into account latest reviews CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files:

[PATCH] D99299: Normalize interaction with boolean attributes

serge-sans-paille added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:660-663 +bool AttributeImpl::getValueAsBool() const { + assert(getValueAsString().empty() || getValueAsString() == "false" || getValueAsString() == "true"); + return getValueAsString() == "true";

[PATCH] D99299: Normalize interaction with boolean attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. serge-sans-paille marked an inline comment as done. Closed by commit rGd6de1e1a7140: Normalize interaction with boolean attributes (authored by serge-sans-paille).

[PATCH] D99409: [clang] Speedup line offset mapping computation

serge-sans-paille added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1262 + unsigned char n) { + return ((x - ~0UL / 255 * (n + 1)) & ~x & + (x & ~0UL / 255 * 127) + ~0UL / 255 * (127 - (m - 1))) &

[PATCH] D99409: [clang] Speedup line offset mapping computation

serge-sans-paille added a comment. Thanks @thakis, inestigating the issue is likely to take some time as it seems to be arch or system dependent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99409/new/ https://reviews.llvm.org/D99409

[PATCH] D99409: [clang] Speedup line offset mapping computation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6951b72334bb: [clang] Speedup line offset mapping computation (authored by serge-sans-paille). Herald added a project: clang. Herald added a

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille added a comment. Reading through the source, it's relatively clear that `-arch` is specific to the Mach0 format, but -target seems applicable to OSX too, see https://godbolt.org/z/j8jvjbo84 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D99715: [CMake] Fix Python 3 lookup when building LLVM with tests

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334662. serge-sans-paille added a comment. Warn on friend functions. I failed to support friend classes, but they are only declared and not defined, so that should be fine, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334660. serge-sans-paille added a comment. Do not use lexical parent, as suggested by @rsmith Add test case for extern function worward-declared in function body, as suggested by @rsmith CHANGES SINCE LAST ACTION

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

serge-sans-paille added a comment. Did you try just removing that `find_package`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715 ___ cfe-commits mailing list

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:1097 + // ignored values) that we don't warn on it. + if (Name.size() <= 1) +return ReservedIdentifierStatus::NotReserved; rsmith wrote: > Would it make sense to move the rest of

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334445. serge-sans-paille added a comment. Herald added a subscriber: dexonsmith. Another round of review :-) I addressed both the scattering of `warnOnReservedIdentifier` and the code split between `Decl.cpp` and `IdentifierInfo.cpp`. CHANGES

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13640 + warnOnReservedIdentifier(New); + aaron.ballman wrote: > rsmith wrote: > > serge-sans-paille wrote: > > > serge-sans-paille wrote: > > > > rsmith wrote: > > > > > Is there

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334261. serge-sans-paille marked 10 inline comments as done. serge-sans-paille added a comment. Address all the needed changes pointed out by @aaron.ballman *except* the most critical one on the call to warnOnReservedIdentifier being spread at

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 333812. serge-sans-paille added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked 10 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/Decl.h:82 +enum ReservedIdentifierReason { + StartsWithUnderscoreAtGlobalScope, + StartsWithDoubleUnderscore, aaron.ballman wrote:

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 333810. serge-sans-paille added a comment. Adress final(?) comments from @rsmith and @aaron.ballman : Don't warn on argument (or template argument) of top-level decl. Extra test cases Return an enumeration as part of the test CHANGES SINCE LAST

[PATCH] D97846: Allow __ieee128 as an alias to __float128 on ppc

serge-sans-paille added a comment. Thanks @hubert.reinterpretcast , @jwakely and @hubert.reinterpretcast for the feedback on that review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97846/new/ https://reviews.llvm.org/D97846

[PATCH] D97846: Allow __ieee128 as an alias to __float128 on ppc

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa510be78a7: Allow __ieee128 as an alias to __float128 on ppc (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D98637: [NFC] Use higher level constructs to check for whitespace/newlines in the lexer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9628cb1feef6: [NFC] Use higher level constructs to check for whitespace/newlines in the lexer (authored by serge-sans-paille). Herald added a

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

serge-sans-paille added a comment. would it make sense to syndicate the minimal version in a single variable, say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of hard-coding the value across multiple files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:639 + # We want LLD for LTO, but LLD does not support SystemZ, so disable + # LTO here and use the installed system linker + if ("${LLVM_NATIVE_ARCH}" MATCHES "SystemZ") I guess you're

[PATCH] D98175: [NFC] Remove duplicate isNoBuiltinFunc method

serge-sans-paille added a comment. That was a very convincing argument :-) tag added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98175/new/ https://reviews.llvm.org/D98175 ___ cfe-commits mailing

[PATCH] D98175: [NFC] Remove duplicate isNoBuiltinFunc method

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8e5b87acba: [NFC] Remove duplicate isNoBuiltinFunc method (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329361. serge-sans-paille added a comment. Fix some formatting Support literal operator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329318. serge-sans-paille added a comment. Updated error message to report the reason why an identifier is reserved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files:

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329242. serge-sans-paille added a comment. Patch rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. @tbaeder sorry for the delay. I don't see any reason why we should keep that one in review any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97320: Use a fast path when initializing LineOffsetMapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80e8efd563fd: Use a fast path when initializing LineOffsetMapping (authored by serge-sans-paille). Herald added a project: clang. Herald added a

[PATCH] D96788: Support standalone build of clang-tidy unittest

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e461057221: Support standalone build of clang-tidy unittest (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D96400: Reduce the number of attributes attached to each function

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8bf29f14e4: Reduce the number of attributes attached to each function (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. @rsmith I did my bet to address your comments. What do you think of current state? Comment at: clang/lib/Sema/SemaDecl.cpp:13640 + warnOnReservedIdentifier(New); +

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 320212. serge-sans-paille added a comment. Extra test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd47ee525f9e9: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 319929. serge-sans-paille added a comment. Back to the previous version, as suggested by @rsmith . I made a few updates to `NamedDecl::isReserved` which get me close to the expected result, without too much overhead. CHANGES SINCE LAST ACTION

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 317677. serge-sans-paille added a comment. As suggested by @aaron.ballman base the detection of top-level-ness on `Sema::LookupName` to avoid re-implementing the wheel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:1099 +const DeclContext *CurrentContext = getDeclContext(); +while (true) { + if (isa(CurrentContext)) aaron.ballman wrote: > Rather than trying to manually decide whether

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 315390. serge-sans-paille marked 2 inline comments as done. serge-sans-paille added a comment. Ignore forward declaration of tagdecl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files:

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/Sema/reserved-identifier.cpp:58 +// we skip this one because it's not at top-level. +int _barbatruc; // no-warning +} aaron.ballman wrote: > This

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 315373. serge-sans-paille added a comment. Update codebase and testbed to reflect recent discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/test/Sema/reserved-identifier.c:9 +int _foo() { return 0; }// expected-warning {{'_foo' is a reserved identifier}} + +// This one is explicitly skipped by

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 315313. serge-sans-paille added a comment. Address some of the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 314329. serge-sans-paille added a comment. Rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. @sylvestre.ledru I: double checked and there's nothing in the original advisory against Darwin, but nothing that clearly states it's protected either (unlike Windows-based system). And there's also nothing specific to Darwin in the stack clash protection

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. In D92245#2425817 , @emaste wrote: >> How do things go wrong on Darwin? I was under the impression that this was >> implemented in LLVM as strictly inline code, no runtime support required. > > That is my impression as

[PATCH] D92291: clang/test: Remove platform-linker feature

serge-sans-paille added a comment. If that's okay with @leonardchan in terms of RISCV validation, I'm fine with that one. Any branch removed is less path to cover! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:276-277 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_stack_clash_protection_unsupported_on_toolchain : Error< +

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added inline comments. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + thakis wrote: > Why do you need this feature? clang invocations that want to use the

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) +return; + emaste wrote: > Is there anything OS-dependent here? > > I plan to add `EffectiveTriple.isOSFreeBSD()` to

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added a comment. @beanz This patch looks good to me, can you confirm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llvm.org/D89942 ___ cfe-commits mailing

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:668 +message(STATUS "Using system linker for stage3 builds on Apple") +set(BOOTSTRAP_LLVM_ENABLE_LLD OFF CACHE BOOL "") + else() Should you also disable LTO here? Repository:

[PATCH] D88990: Update documentation on stage3 cmake build

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ffc40d622b: Update documentation and implementation of stage3 build (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. Commited on your behalf using what I expect to be your official email address :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984

[PATCH] D83984: Explicitly use utf-8 in send_string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3205e2ace43: [scan-view] Explicitly use utf-8 in send_string (authored by Tomas Rix t...@juniper.net, committed by serge-sans-paille).

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM then :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984

[PATCH] D85485: Fix quiet mode in git-clang-format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG294e1900f281: Fix quiet mode in git-clang-format (authored by Gvald, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille added a comment. I'll need a contact email to preserve authorship information, can you send me one at `sguel...@redhat.com`? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Sure, thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/git-clang-format:151 if not changed_lines: -print('no modified files to format') +if opts.verbose

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. According to the doc, `'utf-8'` is already the default encoding, at least on py3, but not on py2. i guess that the problem you're trying to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, I still would appreciate @calixte feedback here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/

[PATCH] D83857: Harmonize python shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille). Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, libc-project. Herald added subscribers: libc-commits,

<    1   2   3   4   5   6   7   8   9   >