[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Thanks, @tra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94cba5b4e4: [HIPSPV][2/4] Add HIPSPV tool chain (authored by linjamaki, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. This patch should be ready to land. @tra, could you please commit this to the LLVM for us. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 _

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 394208. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 392665. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. In D110618#3152939 , @linjamaki wrote: > In D110618#3148501 , @Anastasia > wrote: > >> Could you please clarify the interface to SPIRV-LLVM-Translator tool, >> specifically: >> >> - Do

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389702. linjamaki added a comment. Disable debug info generation for device code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. In D110618#3148501 , @Anastasia wrote: > Could you please clarify the interface to SPIRV-LLVM-Translator tool, > specifically: > > - Does clang lookup the path to the translator or assume any default path? HIPSPV primarily rel

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. Could you please clarify the interface to SPIRV-LLVM-Translator tool, specifically: - Does clang lookup the path to the translator or assume any default path? - Is there any diagnostic provided if the translator not installed/found? - How does clang synchronize with th

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki marked 4 inline comments as done. linjamaki added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits ma

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389118. linjamaki added a comment. Retry push changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389112. linjamaki added a comment. Combine options with append(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDrive

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general, modulo push_back/append nits. Comment at: clang/include/clang/Driver/Options.td:3701 " do not include the default CUDA/HIP wrapper headers">; +def nohipwrapperi

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

yaxunl added a comment. LGTM. I will leave to @tra about -nohipwrapperinc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commi

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 387508. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 382932. linjamaki added a comment. Update for changes in D112404 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-c

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 381854. linjamaki added a comment. Rebase and use SPIRV::constructTranslateCommand() to contruct the LLVM-SPIR-V translation command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. In D110618#3054257 , @pekka.jaaskelainen wrote: >> I don't feel it is different for OpenCL though... I am not in favour of >> repeating the same functionality for every language since the requirement >> will be likely identic

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

pekka.jaaskelainen added a comment. > I don't feel it is different for OpenCL though... I am not in favour of > repeating the same functionality for every language since the requirement > will be likely identical. There is no timeline for when this functionality > will be dropped so we have to

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. In D110618#3039275 , @linjamaki wrote: > In D110618#3032899 , @Anastasia > wrote: > >> Considering that SPIR-V translation step is also required for other >> languages would it make se

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 376822. linjamaki added a comment. Update option description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKin

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. In D110618#3032899 , @Anastasia wrote: > Considering that SPIR-V translation step is also required for other languages > would it make sense to add `llvm-spirv` as a common tool like for example > C/C++ linkers and create a bi

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. Considering that SPIR-V translation step is also required for other languages would it make sense to add `llvm-spirv` as a common tool like for example C/C++ linkers and create a bit of common infrastructure? It might be something we can do as a separate step too but

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:3701 " do not include the default CUDA/HIP wrapper headers">; +def nohipwrapperinc : Flag<["-"], "nohipwrapperinc">, + HelpText<"Do not include the default HIP wrapper headers">; Is

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki created this revision. Herald added subscribers: dang, kerbowa, yaxunl, mgorny, nhaehnle, jvesely. linjamaki updated this revision to Diff 375526. linjamaki added a comment. linjamaki published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits