[PATCH] D128645: Update developer policy.

vext01 closed this revision. vext01 added a comment. Just pushed this to main (04f6bf482b8641533274d28af5fdac7107da3344 ) Thanks everyone! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/

[PATCH] D128645: Update developer policy.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM! Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U99 main`). +

[PATCH] D128645: Update developer policy.

vext01 updated this revision to Diff 440887. vext01 added a comment. Fixed grammar bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llvm.org/D128645 Files: llvm/docs/DeveloperPolicy.rst Index: llvm/docs/DeveloperPolicy.rst

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U99 main`). + hubert.reinterpretcast wrote: > Using `git diff` like this, there

[PATCH] D128645: Update developer policy.

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:403-405 +Note, these mailing lists are moderated and it is not unusual for a large +commit to require a moderator to approve the email, so do not be concerned if a +commit does not

[PATCH] D128645: Update developer policy.

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U99 main`). + Using `git diff` like this, there are risks that

[PATCH] D128645: Update developer policy.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, but you should wait a bit before landing in case other reviewers/subscribers want to chime in if they still have opinions. Comment at:

[PATCH] D128645: Update developer policy.

xbolva00 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + vext01 wrote: > xbolva00 wrote: > > vext01 wrote: > > > xbolva00

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + xbolva00 wrote: > vext01 wrote: > > xbolva00 wrote: > > > main is

[PATCH] D128645: Update developer policy.

vext01 updated this revision to Diff 440647. vext01 added a comment. I've addressed the comments. I only linked `llvm-commits` (reusing the already defined rst link) as the other lists are referenced elsewhere. Typo also fixed. After fixing my `-U 99`, grepping the tree for `` in rst

[PATCH] D128645: Update developer policy.

xbolva00 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + vext01 wrote: > xbolva00 wrote: > > main is weird example here

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinte context" (i.e. using something + like `git diff -U 99 main`). + xbolva00 wrote: > main is weird example here imho. How comes? The

[PATCH] D128645: Update developer policy.

xbolva00 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:419-421 -Your first commit to a repository may require the autogenerated email to be -approved by a moderator of the mailing list. -This is normal and will be done when the mailing list owner has time.

[PATCH] D128645: Update developer policy.

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:419-421 -Your first commit to a repository may require the autogenerated email to be -approved by a moderator of the mailing list. -This is normal and will be done when the mailing list owner has time.

[PATCH] D128645: Update developer policy.

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87-91 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool,

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87-91 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:112-114 -When submitting patches, please do not add confidentiality or non-disclosure -notices to the patches themselves. These notices conflict with the LLVM -licensing terms and may result in your

[PATCH] D128645: Update developer policy.

aaron.ballman added subscribers: cfe-commits, aaron.ballman. aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87-91 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the