[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. In D129156#3949194 , @awarzynski wrote: > > Sorry that you are hitting this - things like this happen, sadly. I think > that the easiest to resolve it would be to tweak the expected error so that > it works on Solaris as well

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3949156 , @ro wrote: > This introduced a new failure on Solaris: > > FAIL: Flang :: Driver/pass-plugin-not-found.f90 > > Running the failing command manually shows: > > error: unable to load plugin 'X.Y': 'Could

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. This introduced a new failure on Solaris: FAIL: Flang :: Driver/pass-plugin-not-found.f90 Running the failing command manually shows: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu marked 2 inline comments as done. tarunprabhu added a comment. Yes, I am aware of the other patch which also adds `test/Driver/pass-plugin.f90`. I will keep an eye out for it. Comment at: flang/test/CMakeLists.txt:65 ) +if (NOT WIN32) + list(APPEND

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. Please be aware of https://reviews.llvm.org/D137673 - you may need to rebase if it lands before this patch. Please just go ahead and merge, but please keep `WIN32` in the final version of "flang/test/CMakeLists.txt" (see my comment inline). LGTM

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474382. tarunprabhu added a comment. Previous revision was missing the tests. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files:

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474381. tarunprabhu added a comment. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files: clang/include/clang/Driver/Options.td

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added inline comments. Comment at: flang/test/CMakeLists.txt:65 ) +if (NOT WIN32) + list(APPEND FLANG_TEST_DEPENDS Bye) IIUC, `Bye` is only needed when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 472161. tarunprabhu added a comment. Added a dependence for the flang tests on LLVM's Bye plugin. This results in the Bye plugin being built when check-flang is run, even if building examples has been explicitly disabled. Removed the dependency on

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3853045 , @tarunprabhu wrote: > The tests still passed. No, it wasn't run. We need to understand why before proceeding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3851843 , @awarzynski wrote: > @tarunprabhu Could you confirm that with the build command above > "pass-plugin.f90" is failing for you? It is for me. The tests still passed. Some relevant output from the test is

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3852553 , @tarunprabhu wrote: > In D129156#3851843 , @awarzynski > wrote: > >> @tarunprabhu Could you confirm that with the build command above >> "pass-plugin.f90" is

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3851843 , @awarzynski wrote: > @tarunprabhu Could you confirm that with the build command above > "pass-plugin.f90" is failing for you? It is for me. What compiler do you use to build this? gcc doesn't seem to

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. @tarunprabhu Could you confirm that with the build command above "pass-plugin.f90" is failing for you? It is for me. In order to fix that, you will have to add this

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In @clementval 's CMake invocation `LLVM_BUILD_EXAMPLES` is not set, which means that the examples (e.g. the `Bye` plugin) are not built. Adding `! REQUIRES: examples` to the test should fix the failure in this case. I did verify locally. However, the pre-commit

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3848728 , @awarzynski wrote: > Thanks Valentin! Switching between generators will definitely change the > order in which libraries will built (and, AFAIK, the order is > non-deterministic to begin with). I will

[PATCH] D129156: Add -fpass-plugin option to Flang

Leporacanthicus added a comment. > @MatsPetersson & @clementval , could you share you build command so that the > failure can be reproduced before this re-lands? I can't share the same command that I used, because it's some old CMAKE command that I no longer have in my history. But I tested

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3848704 , @clementval wrote: >>> I still cannot reproduce the build failure on my end. @MatsPetersson tested >>> this patch and the tests passed. >> >> @MatsPetersson & @clementval , could you share you build

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. In D129156#3848692 , @awarzynski wrote: > In D129156#3847396 , @tarunprabhu > wrote: > >> Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. > > Thanks for the update! >

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3847396 , @tarunprabhu wrote: > Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. Thanks for the update! > I still cannot reproduce the build failure on my end. @MatsPetersson tested > this patch

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. I tried an out-of-tree flang build. check-flang passes in that case too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 466561. tarunprabhu added a comment. Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. I still cannot reproduce the build failure on my end. @MatsPetersson tested this patch and the tests passed. Could someone else test this on their build

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. As @awarzynski mentioned, it is likely a missing dependency on the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___

[PATCH] D129156: Add -fpass-plugin option to Flang

MatsPetersson added a comment. In D129156#3837709 , @awarzynski wrote: > I suspect that this fails when running `ninja check-flang`, right? > > Most likely `Bye` needs to be added as a dependency for Flang tests, > something akin to this >

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. I suspect that this fails when running `ninja check-flang`, right? Most likely `Bye` needs to be added as a dependency for Flang tests, something akin to this

[PATCH] D129156: Add -fpass-plugin option to Flang

DavidTruby added a comment. This is also causing phabricator's pre-commit CI builds to fail, for example this build for my patch: https://buildkite.com/llvm-project/premerge-checks/builds/115370#0183a8a5-6684-4602-952f-81bde55220ea Could we revert this until it is fixed? I think the CI passing

[PATCH] D129156: Add -fpass-plugin option to Flang

MatsPetersson added a comment. In D129156#3836895 , @tarunprabhu wrote: > In D129156#3836838 , @clementval > wrote: > >> I probably didn't copy the error correctly .. this is the correct libs that >> is not

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3836838 , @clementval wrote: > I probably didn't copy the error correctly .. this is the correct libs that > is not found `llvm-project/build/lib/Bye.so` I need some help with this. The failing build is

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. In D129156#3836768 , @tarunprabhu wrote: > I think there is a typo somehow. It should be "Bye.so". Not sure how that > happened. I'm looking into this. I probably didn't copy the error correctly .. this is the correct libs

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. I think there is a typo somehow. It should be "Bye.so". Not sure how that happened. I'm looking into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. I get a failure since this commit. `Could not load library By.so` ... `cannot open shared object file: No such file or directory`. Maybe a missing dependency? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. Thanks for the review and the comments. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list

[PATCH] D129156: Add -fpass-plugin option to Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rG43fe6f7cc35d: [flang] Add -fpass-plugin option to Flang frontend (authored by tarunprabhu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo