[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

tstellar added a comment. The revert doesn't apply cleanly, can someone try to fix it up: https://github.com/llvm/llvm-project/issues/56928#issuecomment-1205483442 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

vient added a comment. FWIW this also causes compilation error on correct code using Boost: https://github.com/llvm/llvm-project/issues/56878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 _

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

Hahnfeld added a comment. FWIW this also causes a `static_assert` failure while building ROOT : In file included from /home/jhahnfel/ROOT/src/tmva/tmva/src/DNN/Architectures/Cpu/CpuBuffer.cxx:17: In file included from /opt/rh/gcc-toolset-11/root/usr/l

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

tstellar added a comment. In D129973#3699055 , @kadircet wrote: > Reverted in df48e3fbcc8be1f4c04bd97517d12e662f54de75 > , > @tstellar it needs to be cherry-picked into release branch

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

kadircet added a comment. Reverted in df48e3fbcc8be1f4c04bd97517d12e662f54de75 , @tstellar it needs to be cherry-picked into release branch as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

kadircet added a comment. Reverting for @bgraur as he's having some issues with his commit access ATM. To sum up the reproducer attached by @joanahalili triggers a crash https://reviews.llvm.org/rG4e94f6653150511de434fa7e29b684ae7f0e52b6 with stack trace and error: $ ~/repos/llvm/build/bin/c

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

bgraur added a subscriber: tstellar. bgraur added a comment. @tstellar FYI the clang crash report from @joanahalili and the new compilation errors report from @asmok-g, both introduced by this patch. Is a revert warranted here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

bgraur added a comment. @SimplyDanny given the reports from @joanahalili and @asmok-g are you considering a revert for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

asmok-g added a comment. This is also causing a compilation error in some google third-party code. Compiling with older clang doesn't give that error. Error: error: no matching function for call to object of type 'key_compare_adapter::IntervalLess>::checked_compare' comp(__trans_tmp_3,

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

joanahalili added a comment. In D129973#3696189 , @joanahalili wrote: > Heads up: This commit causes clang crashes on our end. We are currently > working on a reproducer and will post it as soon as its ready. Here is the reduced code: template stru

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

joanahalili added a comment. Heads up: This commit causes clang crashes on our end. We are currently working on a reproducer and will post it as soon as its ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

yvvan added a comment. In D129973#3688329 , @SimplyDanny wrote: > In D129973#3684940 , @yvvan wrote: > >> With this change we don't pass "LocInfo" directly and it seems to break the >> locations when calling "ge

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. In D129973#3684940 , @yvvan wrote: > With this change we don't pass "LocInfo" directly and it seems to break the > locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later > on. Please fix it. You can intr

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

yvvan added a comment. With this change we don't pass "LocInfo" directly and it seems to break the locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later on. Please fix it. You can introduce another "Create" static method for DeclRefExpr that accepts LocInfo and passes it t

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94f6653150: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads (authored by SimplyDanny). Changed prior to commit: https://rev

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

shafik added a comment. In D129973#3673094 , @SimplyDanny wrote: > Thank you for the review! Before I push the change into main I may add an > entry to `clang/docs/ReleaseNotes.rst`, right? Yes, please add an entry in the release notes. > And do you a

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. In D129973#3673094 , @SimplyDanny wrote: > Thank you for the review! Before I push the change into main I may add an > entry to `clang/docs/ReleaseNotes.rst`, right? > > And do you agree that the test failures are unrelated

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. Thank you for the review! Before I push the change into main I may add an entry to `clang/docs/ReleaseNotes.rst`, right? And do you agree that the test failures are unrelated to my change? It looks like they are all located in `libomptarget` caused by a linker error

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Index/annotate-operator-call-expr.cpp:21 +// CHECK1: Punctuation: "(" [7:6 - 7:7] CallExpr=operator():3:7 +// CHECK1: Punctuation: ")" [7:7 - 7:8]

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446718. SimplyDanny added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 Files: clang-tools-extra/test/clang-tidy/checkers/misc/un

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446629. SimplyDanny added a comment. Rebased commit onto current main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 Files: clang-tools-extra/test/clan

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:65 +// CHECK-NEXT: |-ImplicitCastExpr {{.*}} 'void (*)(E, E)' +// CHECK-NEXT: | `-DeclRefExpr {{.*}} 'void (E, E)' lvalue

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang/test/Index/annotate-operator-call-expr.cpp:21 +// CHECK1: Punctuation: "(" [7:6 - 7:7] CallExpr=operator():3:7 +// CHECK1: Punctuation: ")" [7:7 - 7:8] CallExpr=operator():3:7 // C

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446592. SimplyDanny added a comment. Herald added a subscriber: arphaman. Added a test for the AST dump and updated some test references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://re

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

shafik added a comment. Thank you for working on this. It looks like there are some pre-commit test failures, did you confirm whether they were related to your change or not? Also you mentioned that this changes the output of `-ast-dump` it might be worth adding a test to capture this behavior

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. SimplyDanny requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Without the "found declaration" it is