This revision was automatically updated to reflect the committed changes.
Closed by commit rL255515: [Power PC] add soft float support for ppc32
(authored by petarj).
Changed prior to commit:
http://reviews.llvm.org/D13351?vs=41736&id=42733#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
hfinkel added inline comments.
Comment at: lib/Driver/Tools.cpp:1477
@@ +1476,3 @@
+ // If unspecified, choose the default based on the platform.
+ if (ABI == ppc::FloatABI::Invalid) {
+ABI = ppc::FloatABI::Hard;
rjmccall wrote:
> hfinkel wrote:
> > rjmccall
rjmccall added inline comments.
Comment at: lib/Driver/Tools.cpp:1477
@@ +1476,3 @@
+ // If unspecified, choose the default based on the platform.
+ if (ABI == ppc::FloatABI::Invalid) {
+ABI = ppc::FloatABI::Hard;
hfinkel wrote:
> rjmccall wrote:
> > hfinkel
hfinkel added inline comments.
Comment at: lib/Driver/Tools.cpp:1477
@@ +1476,3 @@
+ // If unspecified, choose the default based on the platform.
+ if (ABI == ppc::FloatABI::Invalid) {
+ABI = ppc::FloatABI::Hard;
rjmccall wrote:
> hfinkel wrote:
> > Don't ne
rjmccall added inline comments.
Comment at: lib/Driver/Tools.cpp:1477
@@ +1476,3 @@
+ // If unspecified, choose the default based on the platform.
+ if (ABI == ppc::FloatABI::Invalid) {
+ABI = ppc::FloatABI::Hard;
hfinkel wrote:
> Don't need the { } here.
We
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
One minor comment, otherwise LGTM.
Comment at: lib/Driver/Tools.cpp:1477
@@ +1476,3 @@
+ // If unspecified, choose the default based on the platform.
+ if (ABI == ppc::Flo
spetrovic added a comment.
ping
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic added inline comments.
Comment at: lib/Driver/Tools.cpp:1439
@@ -1437,1 +1438,3 @@
+ ppc::FloatABI FloatABI = ppc::getPPCFloatABI(D, Args);
+ if (FloatABI == ppc::FloatABI::Soft &&
I'm planning to support soft float for ppc64. At this moment I don't
spetrovic updated this revision to Diff 41736.
spetrovic marked 3 inline comments as done.
http://reviews.llvm.org/D13351
Files:
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/ppc-sfvarargs.c
test/Driver/ppc-features.cpp
Index: test/Driver/ppc-features.
hfinkel added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:3421
@@ -3419,3 +3420,3 @@
public:
- PPC32_SVR4_ABIInfo(CodeGen::CodeGenTypes &CGT) : DefaultABIInfo(CGT) {}
+ PPC32_SVR4_ABIInfo(CodeGen::CodeGenTypes &CGT, bool SoftFloatABI) :
DefaultABIInfo(CGT), IsSoftF
spetrovic added a comment.
ping
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic set the repository for this revision to rL LLVM.
spetrovic updated this revision to Diff 40143.
spetrovic marked 2 inline comments as done.
spetrovic added a comment.
Comments addressed.
Repository:
rL LLVM
http://reviews.llvm.org/D13351
Files:
include/clang/Basic/DiagnosticDrive
hfinkel added a comment.
Can you please make sure we produce some sensible error should someone try to
use soft float with ppc64 (since we don't support that), and add an associated
test.
Comment at: lib/Driver/Tools.h:739
@@ +738,3 @@
+ Soft,
+ SoftFP,
+ Hard,
spetrovic added a comment.
ping
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic updated this revision to Diff 3.
spetrovic added a comment.
added test case
http://reviews.llvm.org/D13351
Files:
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/ppc-sfvarargs.c
test/Driver/ppc-features.cpp
Index: test/Driver/ppc-features
spetrovic updated this revision to Diff 38882.
spetrovic marked 5 inline comments as done.
spetrovic added a comment.
Comments addressed.
http://reviews.llvm.org/D13351
Files:
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/ppc-sfvarargs.c
test/Driver/p
hfinkel added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:688
@@ -687,1 +687,3 @@
+ virtual bool isSoftFloatABI() const {
+return false;
Instead of adding this function, please use the same mechanism as
X86_32TargetCodeGenInfo and X86_32A
spetrovic updated this revision to Diff 36763.
http://reviews.llvm.org/D13351
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/ppc-sfvarargs.c
test/Driver/ppc-features.cpp
Index: test/Drive
02.10.2015, 00:00, "Alex Rosenberg via cfe-commits"
:
> alexr added a subscriber: alexr.
> alexr added a comment.
>
> PowerPC has floating point hardware by definition. Is this some new variant?
Some cores from ppc400 series do not have hardware FP (for example, ppc 405)
--
Regards,
Konstanti
On Thu, Oct 01, 2015 at 09:00:46PM +, Alex Rosenberg via cfe-commits wrote:
> alexr added a subscriber: alexr.
> alexr added a comment.
>
> PowerPC has floating point hardware by definition. Is this some new variant?
e500MC for example only has SPE, not "normal" FPU.
Joerg
__
alexr added a subscriber: alexr.
alexr added a comment.
PowerPC has floating point hardware by definition. Is this some new variant?
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
spetrovic created this revision.
spetrovic added a reviewer: hfinkel.
spetrovic added a subscriber: cfe-commits.
This patch enables soft float support for ppc32 architecture and fixes the ABI
for variadic functions. This is first in set of patches for soft float support
in LLVM.
http://reviews
22 matches
Mail list logo
