[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe002a38b20e3: [Flang][OpenMP][MLIR][Driver][bbc] Add -fopenmp-is-device flag to Flang -fc1 … (authored by agozillon). Repository: rG LLVM Github

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 ___ cfe-commits mailing list

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. Cleaned up the test, thank you both for teaching me more about the compiler and test infrastructure! If you're happy with the test changes @kiranchandramohan I'll commit the changes upstream to close out the review? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 503070. agozillon added a comment. - [Flang][Driver] Tidy up omp-is-device.f90 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files:

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski accepted this revision. awarzynski added a comment. In D144864#4175001 , @agozillon wrote: > And then provided @awarzynski is happy with the current state of the patch LGTM, thanks for the updates and for working on this! Repository: rG

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan added a comment. In D144864#4175332 , @agozillon wrote: > In D144864#4175257 , > @kiranchandramohan wrote: > >> LG. See one minor comment in the tests. >> >> I would prefer having an Interface

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. In D144864#4175257 , @kiranchandramohan wrote: > LG. See one minor comment in the tests. > > I would prefer having an Interface for Target Modules if that could be made > to work. I guess this can be taken up separately after

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. See one minor comment in the tests. I would prefer having an Interface for Target Modules if that could be made to work. I guess this can be taken up separately after https://reviews.llvm.org/D144883.

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. The recent update removed the added offload related code from Flang.h/.cpp and removed the related test. Would it be possible to have an extra sign-off as requested by @awarzynski (or more review points to correct/discuss if we aren't happy with the state/direction

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 503008. agozillon added a comment. - [Flang][ToolChain][OpenMP][Driver] Reduce changes to only add -fc1 support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised awarzynski wrote: > agozillon wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised awarzynski wrote: > agozillon wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised awarzynski wrote: > agozillon wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > agozillon wrote: > >

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > > This

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. Thank you very much @awarzynski I will wait for further approval! Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. > Thank you very much @awarzynski for suggesting them that was a great help. I'm happy that I could help :) The driver logic LGTM, but please wait for either @jdoerfert and/or

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. The new update adds the suggested new tests! Thank you very much @awarzynski for suggesting them that was a great help. Hopefully the new additions cover what you have requested, if not I am of course happy to change or add more tests as needed.

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 502139. agozillon added a comment. - [Flang][MLIR][Test] Add newline at end of test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files:

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 502134. agozillon added a comment. - [MLIR][OpenMP] Fix attribute helpers to apply to more than builtin.module - [Flang][mlir] Adding space at the end of the omp-is-device test file - [Clang][Flang][Driver][Test] Add flang-omp.f90 to test

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:121-125 + if (IsOpenMPDevice) { +// -fopenmp-is-device is passed along to tell the frontend that it is +// generating code for a device, so that only the relevant declarations are +

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. After asking @jsjodin and @skatrak for some input on additional tests that could be added and having a look around the existing tests we couldn't really come up with any additional tests to add to the ones that are in the patch at the moment (inside of

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 501645. agozillon added a comment. - [Flang][mlir] Adding space at the end of the omp-is-device test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files:

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 501141. agozillon added a comment. - [MLIR][OpenMP] Fix attribute helpers to apply to more than builtin.module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. In D144864#4156764 , @jdoerfert wrote: > Tests? Happy to add more, I am just a little unsure what the best way to test this is other than application of the attribute to the module when the flag was used and verification

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

jdoerfert added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

kiranchandramohan added a comment. Could you update the discourse thread (https://discourse.llvm.org/t/rfc-omp-module-and-omp-function-vs-dialect-attributes-to-encode-openmp-properties/67998) with the chosen approach and reasons before proceeding? Repository: rG LLVM Github Monorepo

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 500744. agozillon added a comment. Forgot to add an additional test in initial patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files:

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon created this revision. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,