This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e9b1effac34: [clangd] Implement cross reference request for
#include lines. (authored by VitaNuo).
Changed prior to commit:
https://reviews.llvm.
VitaNuo updated this revision to Diff 515227.
VitaNuo marked 3 inline comments as done.
VitaNuo added a comment.
Add a test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:398
+ )cpp",
+ {include_cleaner::Header{"bar.h"}, include_cleaner::Header{"foo.h
VitaNuo marked an inline comment as done.
VitaNuo added inline comments.
Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87
+std::optional
+firstMatchedProvider(const include_cleaner::Includes &Includes,
+ llvm::ArrayRef Providers);
kadi
VitaNuo updated this revision to Diff 514901.
VitaNuo added a comment.
Extract a test for th firstMatchedProvider method.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87
+std::optional
+firstMatchedProvider(const include_cleaner::Includes &Includes,
+ llvm::ArrayRef Providers);
VitaNuo wrote:
> kadircet wrote:
> > can you
VitaNuo added a comment.
Thanks for the comments!
Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87
+std::optional
+firstMatchedProvider(const include_cleaner::Includes &Includes,
+ llvm::ArrayRef Providers);
kadircet wrote:
> can you
VitaNuo updated this revision to Diff 510484.
VitaNuo marked 5 inline comments as done.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-too
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443
+ // No match for this provider in the includes list.
+ return {};
+}
`return std::nullopt`
Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87
+
VitaNuo updated this revision to Diff 510042.
VitaNuo added a comment.
Simplify.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/Incl
VitaNuo added a comment.
Thanks for the comments!
Comment at: clang-tools-extra/clangd/XRefs.cpp:1348
+ auto Loc = SM.getFileLoc(Ref.RefLocation);
+ for (const auto &H : Providers) {
+auto MatchingIncludes = ConvertedMainFileIncludes.match(H);
VitaNuo updated this revision to Diff 510039.
VitaNuo added a comment.
Rename function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clan
VitaNuo updated this revision to Diff 510036.
VitaNuo added a comment.
Remove extra formatting changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/Hover.cpp
clang-
VitaNuo updated this revision to Diff 510032.
VitaNuo added a comment.
Simplify.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/Incl
VitaNuo updated this revision to Diff 510027.
VitaNuo marked 10 inline comments as done.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-to
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1338
+
+auto ReferencedInclude = convertIncludes(SM, Inc);
+include_cleaner::walkUsed(
can we put the rest into a separate function (I know this function is already
quite long
VitaNuo updated this revision to Diff 509017.
VitaNuo added a comment.
Formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/un
VitaNuo updated this revision to Diff 509015.
VitaNuo added a comment.
Remove redundant code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extr
VitaNuo updated this revision to Diff 508986.
VitaNuo added a comment.
Formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/un
VitaNuo updated this revision to Diff 508975.
VitaNuo added a comment.
Smaller improvements.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra
VitaNuo created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
http
21 matches
Mail list logo
