yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1092
ShouldParseIf;
+defm hip_uniform_block : BoolFOption<"hip-uniform-block",
+ LangOpts<"HIPUniformBlock">, DefaultTrue,
arsenm wrote:
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1092
ShouldParseIf;
+defm hip_uniform_block : BoolFOption<"hip-uniform-block",
+ LangOpts<"HIPUniformBlock">, DefaultTrue,
arsenm wrote:
arsenm added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1092
ShouldParseIf;
+defm hip_uniform_block : BoolFOption<"hip-uniform-block",
+ LangOpts<"HIPUniformBlock">, DefaultTrue,
scchan wrote:
> arsenm wrote:
> > Can we avoid adding
scchan added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1092
ShouldParseIf;
+defm hip_uniform_block : BoolFOption<"hip-uniform-block",
+ LangOpts<"HIPUniformBlock">, DefaultTrue,
arsenm wrote:
> Can we avoid adding yet another
arsenm added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1092
ShouldParseIf;
+defm hip_uniform_block : BoolFOption<"hip-uniform-block",
+ LangOpts<"HIPUniformBlock">, DefaultTrue,
Can we avoid adding yet another language flag for
yaxunl updated this revision to Diff 540397.
yaxunl marked an inline comment as done.
yaxunl added a comment.
revised by comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155213/new/
https://reviews.llvm.org/D155213
Files:
clang/include/clang/Basic/LangOptions.def
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7226
+ } else {
+Args.claimAllArgs(options::OPT_fhip_uniform_block,
+ options::OPT_fno_hip_uniform_block);
MaskRay
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7226
+ } else {
+Args.claimAllArgs(options::OPT_fhip_uniform_block,
+ options::OPT_fno_hip_uniform_block);
yaxunl wrote:
> MaskRay wrote:
> > Why is the
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7226
+ } else {
+Args.claimAllArgs(options::OPT_fhip_uniform_block,
+ options::OPT_fno_hip_uniform_block);
MaskRay wrote:
> Why is the
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7226
+ } else {
+Args.claimAllArgs(options::OPT_fhip_uniform_block,
+ options::OPT_fno_hip_uniform_block);
Why is the -Wunused-command-line-argument
yaxunl created this revision.
yaxunl added reviewers: tra, b-sumner, MaskRay, arsenm, scchan.
Herald added subscribers: jdoerfert, kerbowa, jvesely.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
By default, clang assumes HIP kernels are
11 matches
Mail list logo