Fixed in r276889 by Simon Pilgrim!
On 27/07/16 22:03, Vassil Vassilev wrote:
Looking into it.
On 27/07/16 18:34, Jun Bum Lim wrote:
junbuml added a subscriber: junbuml.
junbuml added a comment.
It appears that build fails due to this change :
Looking into it.
On 27/07/16 18:34, Jun Bum Lim wrote:
junbuml added a subscriber: junbuml.
junbuml added a comment.
It appears that build fails due to this change :
llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label
in switch which covers all enumeration values
junbuml added a subscriber: junbuml.
junbuml added a comment.
It appears that build fails due to this change :
llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label
in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]
default:
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r276878.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
CrisCristescu updated this revision to Diff 65528.
CrisCristescu added a comment.
Wrong indentation update.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsumer.h
lib/Lex/Lexer.cpp
v.g.vassilev requested changes to this revision.
v.g.vassilev added a reviewer: v.g.vassilev.
This revision now requires changes to proceed.
Comment at: lib/Lex/Preprocessor.cpp:748
@@ +747,3 @@
+ if (Result.is(tok::code_completion))
+
CrisCristescu updated this revision to Diff 65508.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
Some more cosmetics.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsumer.h
CrisCristescu updated this revision to Diff 65403.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
PP CodeCompletionII initialisation.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
CrisCristescu updated this revision to Diff 65401.
CrisCristescu marked 3 inline comments as done.
CrisCristescu added a comment.
Addressing some sugesstions.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
akyrtzi added a comment.
Thanks for making the changes; I'd recommend to go ahead and commit and we can
iterate post-commit if necessary.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
___
cfe-commits mailing list
v.g.vassilev added a subscriber: v.g.vassilev.
Comment at: include/clang/Lex/Preprocessor.h:270
@@ +269,3 @@
+ /// on the stem that is to be code completed.
+ IdentifierInfo *CodeCompletionII;
+
Can you initialize this variable in the PP's ctor?
Repository:
karies added a comment.
Regarding the concerns raised by @akyrtzi : maybe it's a question of making the
completer interface useful at low cost (with filtering for generic use cases
and less ASTReading) versus not breaking existing use cases (fuzzy match).
Would you still object to this change
benlangmuir added a comment.
LGTM with one comment about the doxygen comments, but you should probably wait
to hear from @akyrtzi too.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:916
@@ +915,3 @@
+ /// \name Code-completion filtering
+ //@{
+ /// \brief Check if
CrisCristescu updated this revision to Diff 56115.
CrisCristescu added a comment.
Addresses the previous comments and adds testing for filtering.
All the tests already in CodeCompletion are testing both the backward
compatibility and the new functionality itself.
Repository:
rL LLVM
CrisCristescu added a comment.
For the filtering itself the motivation for not doing it on the client side is
the following in our use case:
- we do not re-filter on every key stroke, we only filter when the key is
pressed i.e there is one completion point;
- we have a PCH which will help
CrisCristescu updated this revision to Diff 51404.
CrisCristescu added a comment.
The code_completion token now stores the information, if there is one,
about the identifier that it is lexing.
During the parsing there is a common entry point which is ConsumerToken
where we can set the information
akyrtzi added a comment.
In http://reviews.llvm.org/D17820#366638, @milianw wrote:
> But, we currently always request code completion at a word start boundary so
> nothing would change for us. That said, I see how this patch could be seen as
> a breaking behavior change, and thus should
milianw added a comment.
@akyrtzi raises a very valid point - I did not think about that. KDevelop uses
the clang-c API and does fuzzy matching on top of the results, e.g. for
camel-case matching. But, we currently always request code completion at a word
start boundary so nothing would change
milianw added a subscriber: milianw.
milianw added a comment.
I'm not yet acquainted enough with the code at hand, but I wonder whether I'm
understanding the code correctly:
Could it be that you only filter before printing to the output stream? The
other consumers, e.g. the one used by the
akyrtzi added a comment.
We should not bake-in filtering into the clang CodeComplete API. What kind of
filtering to use should be on a higher level, different clients may want
different filtering, e.g. prefix filtering, fuzzy filtering, etc.
Repository:
rL LLVM
CrisCristescu created this revision.
CrisCristescu added reviewers: clang-c, benlangmuir, akyrtzi.
CrisCristescu added a subscriber: cfe-commits.
CrisCristescu set the repository for this revision to rL LLVM.
CrisCristescu changed the visibility of this Differential Revision from "Public
(No
21 matches
Mail list logo
