smeenai abandoned this revision.
smeenai added a comment.
The warning was removed from `-Wall`.
Repository:
rCXX libc++
https://reviews.llvm.org/D41368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
bcain added a comment.
In https://reviews.llvm.org/D41368#959579, @smeenai wrote:
> @mclow.lists are you okay with this approach? I'm also fine using a cast to
> silence the warning, as @zturner suggested, but we should suppress the
> warning in some way, otherwise libc++ 6 is gonna have compil
smeenai added a comment.
Also FWIW I agree with you that the warning is completely bogus here, but it
looks like the fix to that warning isn't gonna make it into clang 6, at least,
so we have to adjust accordingly.
Repository:
rCXX libc++
https://reviews.llvm.org/D41368
_
smeenai added a comment.
@mclow.lists are you okay with this approach? I'm also fine using a cast to
silence the warning, as @zturner suggested, but we should suppress the warning
in some way, otherwise libc++ 6 is gonna have compile warnings with clang 6 out
of the box, which isn't great.
A t
mclow.lists added a comment.
In https://reviews.llvm.org/D41368#958865, @zturner wrote:
> It would be better if we could just fix the code.
I disagree (See discussion of https://reviews.llvm.org/D39149). Even if it was
"just this one place" (which it isn't), this affects users of clang, not ju
zturner added a comment.
It would be better if we could just fix the code. If another compiler comes
along and implements this same warning, we're going to have to fix it again.
The only difference between any of this function is which cstdlib function is
called. Why not just wrap all of thi
smeenai updated this revision to Diff 127416.
smeenai added a comment.
Remove stray comment
Repository:
rCXX libc++
https://reviews.llvm.org/D41368
Files:
include/istream
src/string.cpp
Index: src/string.cpp
===
--- src/st
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
Herald added a subscriber: cfe-commits.
clang 6 has a new diagnostic -Wtautological-constant-compare, which
fires for the code in question when int and long have the same size (for
example, when compiling for a 32-bit tar
