[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-09 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski abandoned this revision. krytarowski added a comment. Better patch in https://reviews.llvm.org/D70048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69755/new/ https://reviews.llvm.org/D69755

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-05 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. > burden with the upstream We are the part of mainstream and have 4 developers in LLVM + few others contributing. We run the NetBSD buildbot that builds and runs test of LLD. http://lab.llvm.org:8014/builders/netbsd-amd64 Repository: rG LLVM Github Monorepo

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-05 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. I don't want to diverge this patch on offtopic or general discussion. Does it look good for landing? We need this support to be functional out of the box and as a part of LLVM. E.g. `clang -fuse-ld=` currently tries to call `ld.lld`, with this patch it will go

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-05 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D69755#1731420 , @krytarowski wrote: > In D69755#1731394 , @MaskRay wrote: > > > I still have the feeling that such configurations should be added to > > clangDriver/gcc specs or a

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In D69755#1731394 , @MaskRay wrote: > I still have the feeling that such configurations should be added to > clangDriver/gcc specs or a shell script wrapper of lld. OK, as you allow now a shell wrapper of lld, this is a

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski marked an inline comment as done. krytarowski added inline comments. Comment at: lld/tools/nb.lld/nb.lld.cpp:94 + + // disable superfluous RUNPATH on NetBSD + args.push_back("--disable-new-dtags"); MaskRay wrote: > You can't use DT_RUNPATH probably

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I still have the feeling that such configurations should be added to clangDriver/gcc specs or a shell script wrapper of lld. How do you decide to handle "Handling of indirect shared library dependencies"? It does not seem to be favored by lld contributors.

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski updated this revision to Diff 227593. krytarowski added a comment. - upload diff with wider context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69755/new/ https://reviews.llvm.org/D69755 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski created this revision. krytarowski added reviewers: ruiu, joerg, mgorny, MaskRay. krytarowski added a project: lld. Herald added subscribers: llvm-commits, cfe-commits, fedor.sergeev, aheejin, emaste, dschuff. Herald added projects: clang, LLVM. The NetBSD target wraps the default