[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3e81f43f01: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D69853?vs=232987&id=233003#toc Repository: rG LLVM Github M

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

merge_guards_bot added a comment. Build result: pass - 60659 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 232987. jdoerfert added a comment. Add missing files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/clang/AST/OpenMPClause.h clang/include/c

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 232984. jdoerfert added a comment. Rebase and creation of libFrontendOpenMP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/clang/AST/OpenMPCla

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 4 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23 /// OpenMP directives. -enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, -#define OPENMP_DIRECTIVE_EXT(Name, Str) \ -

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23 /// OpenMP directives. -enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, -#define OPENMP_DIRECTIVE_EXT(Name, Str) \ - OMPD_##Name, -#include "clang/Basic/OpenMP

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228788. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Create llvm/libFrontend, move code there, make shared library builds work. llvm/IR/ is an unfortunate location as we cannot use llvm utility functions without introducing depende

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: llvm/include/llvm/IR/OpenMPConstants.h:1 +//===- IR/OpenMPConstants.h - OpenMP related constants & helper - C++ -*-===// +// Just

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D69853#1737426 , @ABataev wrote: > In D69853#1737319 , @jdoerfert wrote: > > > In D69853#1737264 , @

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. In D69853#1737319 , @jdoerfert wrote: > In D69853#1737264 , @ABataev wrote: > > > In D69853#1737218 , @jdoerfert > > wrote: > > > > > Are there blo

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228275. jdoerfert marked an inline comment as done. jdoerfert added a comment. Use an llvm::IndexedMap instead of std::map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D69853#1737264 , @ABataev wrote: > In D69853#1737218 , @jdoerfert wrote: > > > Are there blocking issues on this one or can we go ahead and

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. In D69853#1737218 , @jdoerfert wrote: > Are there blocking issues on this one or can we go ahead and adjust minor > details as we go? I still think it would be good to separate patches into the LLVM part and into the clang par

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert added a comment. Are there blocking issues on this one or can we go ahead and adjust minor details as we go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 ___

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228126. jdoerfert marked an inline comment as done. jdoerfert added a comment. working version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknow

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 227985. jdoerfert added a comment. More updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); ABataev wrote: >

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); jdoerfert wrote: > A

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. In D69853#1734760 , @jdoerfert wrote: > In D69853#1734620 , @ABataev wrote: > > > Again, better to split into 2 patches, one for LLVM and one for clang. > > > I split the other patch, but th

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknow

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert added a comment. In D69853#1734620 , @ABataev wrote: > Again, better to split into 2 patches, one for LLVM and one for clang. I split the other patch, but this one cannot be split in a reasonable (=testable) manner. Splitting a patch only to h

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); jdoerfert wrote: > A

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknow

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. Again, better to split into 2 patches, one for LLVM and one for clang. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 227948. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Addressed review comments, simplified some changes, moved file, ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ http

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

JonChesterfield added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); I wonder if

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:408 OpenMPClauseKind CKind) { - assert(DKind <= OMPD_unknown); assert(CKind <= OMPC_unknown); ABa

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:408 OpenMPClauseKind CKind) { - assert(DKind <= OMPD_unknown); assert(CKind <= OMPC_unknown); Why assert is removed? Comment

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added a subscriber: jholewinski. Herald added projects: clang, LLVM. The new OpenMPConstants.h is a location for all Op