[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

2019-12-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In addition to that, NFC is also often used as a way to tag commits that should not cause any problems. wrt to this change, I don't think anything was done wrong. It even went through review, although often we don't send reviews for NFC changes. Downstream

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

2019-12-17 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In D71455#1787266 , @MaskRay wrote: > Renaming `handleDeclOccurence`, `handleMacroOccurence` and > `handleModuleOccurence` are definitely not NFC because they are public APIs > that can be used by downstream projects. I'm

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

2019-12-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Renaming `handleDeclOccurence`, `handleMacroOccurence` and `handleModuleOccurence` are definitely not NFC because they are public APIs that can be used by downstream projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

2019-12-16 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9715cb2193: [NFC] Fix typos in Clangd and Clang (authored by kbobyrev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

2019-12-16 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 234001. kbobyrev added a comment. Rebase on top of master, fix the build and apply formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71455/new/ https://reviews.llvm.org/D71455 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

2019-12-13 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. https://reviews.llvm.org/D71455 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdServer.cpp