https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/91498
Fixes [this
crash](https://github.com/llvm/llvm-project/pull/90152#issuecomment-2100688849)
caused by #90152.
Will add tests shortly.
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Fixes [this
crash](https://github.com/llvm/llvm-project/pull/90152#issuecomment-2100688849)
caused by #90152.
Will add tests shortly.
---
Full diff: https://github.com/llvm/llvm-project/pull/9149
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91498
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:18:49 -0400
Subject: [PATCH 1/2] [Clang][Sema] Fix lookup of dependent operator= outsi
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
few little things? Mostly looks ok.
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91498
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:18:49 -0400
Subject: [PATCH 1/4] [Clang][Sema] Fix lookup of dependent operator= outsi
@@ -1248,6 +1248,13 @@ static DeclContext *findOuterContext(Scope *S) {
return nullptr;
}
+static bool isDependentAssignmentOperator(DeclarationName Name,
erichkeane wrote:
a comment on this function similar to what you replied to me before woudl also
be a
@@ -1248,6 +1248,13 @@ static DeclContext *findOuterContext(Scope *S) {
return nullptr;
}
+static bool isDependentAssignmentOperator(DeclarationName Name,
erichkeane wrote:
Ah, perhaps I was confusing... i'd like this inside the `namespace {`, now
below.
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91498
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:18:49 -0400
Subject: [PATCH 1/5] [Clang][Sema] Fix lookup of dependent operator= outsi
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91498
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:18:49 -0400
Subject: [PATCH 1/5] [Clang][Sema] Fix lookup of dependent operator= outsi
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
glandium wrote:
This caused some breakage in something completely unrelated to operator= O_o
This is from webrtc code in Firefox:
```
/tmp/gecko/third_party/libwebrtc/rtc_base/containers/flat_map.h:331:49: error:
out-of-line definition of 'try_emplace' does not match any declaration in
'flat_m
glandium wrote:
Reverting just the SemaTemplate.cpp change fixes it.
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@glandium I've reduced it to the following:
```cpp
template
struct A
{
static constexpr bool B = true;
};
template
struct C { };
template
struct D
{
C::B> f();
};
template
auto D::f() -> C::B> { }
```
The problem is that we build a `DependentScopeDeclRefExpr` for `A::
aeubanks wrote:
Chromium is also seeing similar breakages. @sdkrystian is this breaking valid
code? I can't tell from your latest comment. (if it is breaking valid code we
should revert)
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits
sdkrystian wrote:
@aeubanks I think I'm going to revert this & maybe partially revert the changes
in #90152 which cause `operator=` to be treated as a dependent name when the
current class is templated. There are lots of edge cases that need to be
accounted for. Thoughts @erichkeane ?
https:/
erichkeane wrote:
> @aeubanks I think I'm going to revert this & maybe partially revert the
> changes in #90152 which cause `operator=` to be treated as a dependent name
> when the current class is templated. There are lots of edge cases that need
> to be accounted for. Thoughts @erichkeane ?
22 matches
Mail list logo
