[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @nathanchance , I could not reproduce your failure using the same revision and `build-llvm` script. Could you please attach your json report located at `/home/nathan/cbl/git/tc-build/build/llvm/stage1/tools/clang/test/Driver/Output/check-time-trace-sections.js

Re: r369641 - [OpenCL] Fix declaration of enqueue_marker

Sure. Merged to release_90 in r369738. On Thu, Aug 22, 2019 at 5:39 PM Anastasia Stulova wrote: > > Hi Hans, > > > Can this still be merged into the release branch please. > > > Thanks in advance, > > Anastasia > > > > > From: cfe-commits on behalf of Yaxun Liu

[PATCH] D66593: [analyzer] CastValueChecker: Fix some assertions

Charusso added a comment. In D66593#1642253 , @Charusso wrote: > Wow, it is great you could address every of the edge cases. Thanks you so > much! I believe only one problem left: we need to `return false` instead of > plain `return` in order to let the

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

balazske added a comment. In D66538#1641310 , @martong wrote: > > It looks like that the original code is correct in the decision of > > structural equivalence of the original pair. If we have an (A,B) and (A,C) > > to compare, B and C are in different d

[PATCH] D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.

hokein created this revision. hokein added reviewers: gribozavr, alexfh. Herald added a subscriber: xazax.hun. Herald added a project: clang. The macro are usually defined in the common/base headers which are hard for normal users to modify it. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM, although I'd be more comfortable with a whitelist of macros. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-references.cpp:156 +DEFINE_F(func) {} \

[PATCH] D66632: [clangd] Link more clang-tidy modules to clangd

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny, srhines. Herald added a reviewer: jdoerfert. Herald added a project: clang. There are two new clang-tidy modules being added recently. Reposit

[PATCH] D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.

hokein updated this revision to Diff 216777. hokein marked an inline comment as done. hokein added a comment. Add the missing back newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66631/new/ https://reviews.llvm.org/D66631 Files: clang-too

[clang-tools-extra] r369739 - [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.

Author: hokein Date: Fri Aug 23 01:47:27 2019 New Revision: 369739 URL: http://llvm.org/viewvc/llvm-project?rev=369739&view=rev Log: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros. Summary: The macro are usually defined in the common/base headers which

[PATCH] D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369739: [clang-tidy] Don't emit google-runtime-references warning for functions defined… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

martong added a comment. The link for the diff went off, sorry about that. Here is the new link which is going to work: https://github.com/martong/clang/compare/NonEqDecls_cache_in_an_upper_level_0...martong:NonEqDecls_cache_in_an_upper_level?expand=1 Repository: rG LLVM Github Monorepo CHANG

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

chill added a comment. In D36562#1641930 , @wmi wrote: > In D36562#1639441 , @chill wrote: > > > Shouldn't we disable `OPT_ffine_grained_bitfield_accesses` only if TSAN is > > active? > > > I don't remember why it

[clang-tools-extra] r369741 - [clangd] Link more clang-tidy modules to clangd

Author: hokein Date: Fri Aug 23 02:13:23 2019 New Revision: 369741 URL: http://llvm.org/viewvc/llvm-project?rev=369741&view=rev Log: [clangd] Link more clang-tidy modules to clangd Summary: There are two new clang-tidy modules being added recently. Reviewers: sammccall, jdoerfert Subscribers: s

[PATCH] D66632: [clangd] Link more clang-tidy modules to clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL369741: [clangd] Link more clang-tidy modules to clangd (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> more closely match the sort order

alexfh added a comment. In D66505#1641776 , @aaron.ballman wrote: > Given that the alphabetization we want really is based on the string literal, > would it make sense to look for that rather than the check name? Adding a few > more reviewers for a bett

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

balazske added a comment. The structural equivalency check works (with this patch) the following way: To check a `(A1,A2)` pair we collect further `(X1,X2)` pairs that should be checked and put these in `DeclsToCheck` (if not already there). The check succeeds if every pair is equivalent. The p

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. First patch for propogating multifile changes from tweak outputs to LSP WorkspaceEdits. Uses FS to convert toolin

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio updated this revision to Diff 216801. dnsampaio added a comment. - Consider BigEndianSafe intrinsics that all inputs and outputs are scalar or single element vectors Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://reviews.llvm.org/D665

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong marked an inline comment as done. martong added a comment. @shafik Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 ___ cfe-commits mailing list cfe

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216805. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

r369749 - [Docs][OpenCL] Several corrections to C++ for OpenCL

Author: stulova Date: Fri Aug 23 04:43:49 2019 New Revision: 369749 URL: http://llvm.org/viewvc/llvm-project?rev=369749&view=rev Log: [Docs][OpenCL] Several corrections to C++ for OpenCL Differential Revision:https://reviews.llvm.org/D64418 Modified: cfe/trunk/docs/LanguageExtensions.rst

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL369749: [Docs][OpenCL] Several corrections to C++ for OpenCL (authored by stulova, committed by ). Changed prior to commit: https://reviews.llvm.org/D64418?vs=215922&id=216808#toc Repository: rL LLVM

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

martong added a comment. Ok. I like this patch because it eliminates the need for checking the redeclaration chains. Seems like it handles cycles and the simple `f(A,B)` vs `f(A,A)` cases properly too. (Not talking about caching now, probably we must remove the `NonEquivalentDecls` cache.) I'

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the else after return nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm.org/D66186

[PATCH] D62571: Implement codegen for MSVC unions with reference members

aaron.ballman added a comment. In D62571#1642096 , @domdom wrote: > Thanks @aaron.ballman! > > I will need someone to commit this for me :) I'm happy to commit for you, but I get merge conflicts when trying to apply your patch. Can you rebase on trunk?

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:644 + assert(It.second.Edits && "TextEdits hasn't been generated?"); + if (auto Draft = DraftMgr.getDraft(It.first())) { +llvm::StringRef Contents = *Draft;

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 216815. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt clang-too

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. In D66186#1642607 , @aaron.ballman wrote: > LGTM aside from the else after return nit. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:644 + assert(It.second.Edits && "TextEdits hasn't been generated?"); + if (auto Draft = DraftMgr.getDraft(It.first())) { +llvm::StringRef Contents = *Draft; ---

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:644 + assert(It.second.Edits && "TextEdits hasn't been generated?"); + if (auto Draft = DraftMgr.getDraft(It.first())) { +

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D65433: [clangd] DefineInline action availability checks. Initial version of Defi

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:41 +/// Represents a set of edits generated for a single file. +struct Edit { + /// SHA1 hash of the file contents for the edits generated below. Clients Hmm, it is also attractiv

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:644 + assert(It.second.Edits && "TextEdits hasn't been generated?"); + if (auto Draft = DraftMgr.getDraft(It.first())) {

[PATCH] D66646: Ensure that statements, expressions and types are trivially destructible with a static_assert

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, lebedev.ri. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Since statements, expressions and types are allocated with the `BumpPtrAllocator` from `ASTContext` their destructor is not executed.

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

SureYeaah accepted this revision. SureYeaah added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/SourceCode.cpp:284 + return SM.getComposedLoc(IncludingFile, Offset); +if (Buf[Offset] == '\n' || Offset == 0) // no

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein added a comment. thanks, looks better now. Some more comments on the test code. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:3 import * as vscodelc from 'vscode-languageclient'; - +import * as SM from './semantic-highlighting'; /** --

[PATCH] D66646: Ensure that statements, expressions and types are trivially destructible with a static_assert

lebedev.ri added a comment. SGTM, but i wonder if this should be done one level up, in `BumpPtrAllocator` itself? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66646/new/ https://reviews.llvm.org/D66646 ___ cfe-comm

[PATCH] D66646: Ensure that statements, expressions and types are trivially destructible with a static_assert

riccibruno added a comment. In D66646#1642708 , @lebedev.ri wrote: > SGTM, but i wonder if this should be done one level up, in `BumpPtrAllocator` > itself? I don't understand. `BumpPtrAllocator` is only used to allocate raw memory and doesn't know any

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:214 +bool IsConst; +Parameter(std::string Name, std::string Type, bool IsConst) +: Name(Name), Type(Type), IsConst(IsConst) {} sammccall wrot

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:360 + +CapturedSourceInfo::DeclInformation & +CapturedSourceInfo::getDeclInformationFor(const Decl *D) { SureYeaa

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

Szelethus accepted this revision. Szelethus added a comment. @whisperity, any objections to this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66333/new/ https://reviews.llvm.org/D66333 ___ cfe-commits mailing list

[PATCH] D66650: clang-format: Disable across-block include reordering.

thakis created this revision. thakis added reviewers: sammccall, krasimir, ioeric. https://reviews.llvm.org/D66650 Files: clang/lib/Format/Format.cpp Index: clang/lib/Format/Format.cpp === --- clang/lib/Format/Format.cpp +++ clan

[PATCH] D66650: clang-format: Disable across-block include reordering.

thakis added a comment. How's the work going to undo r357695 btw? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66650/new/ https://reviews.llvm.org/D66650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 216823. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-ex

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

thakis added a comment. In D66397#1642012 , @Quuxplusone wrote: > @thakis wrote: > > > What was the motivation for firing on more than bare literals? > > Well, fundamentally, there is no difference in code quality between any of > these snippets: > > #d

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. What I meant is that the diff has to be made against the master branch or I won't be able to apply it locally. Say your repo is structured like this: * dcba2 (HEAD -> my_fix) * dcba1 * abcd4 (master) * abcd3 * abcd2 * abcd1 Then the diff has to be made wi

[PATCH] D66650: clang-format: Disable across-block include reordering.

sammccall accepted this revision. sammccall added a subscriber: gribozavr. sammccall added a comment. This revision is now accepted and ready to land. In D66650#1642747 , @thakis wrote: > How's the work going to undo r357695 btw? I'm not sure anyone's ch

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL369758: [Docs][OpenCL] Release 9.0 notes for OpenCL (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 216831. SureYeaah marked 2 inline comments as done. SureYeaah edited the summary of this revision. SureYeaah added a comment. Removed extra code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https:

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Every change triggered by a rewrite rule is anchored at a particular location in the source code. This patch refines how that location is chosen when the rule matches within a macro and defines it a

[PATCH] D66650: clang-format: chromium style: Disable across-block include reordering.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369759: clang-format: Disable across-block include reordering. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r369759 - clang-format: Disable across-block include reordering.

Author: nico Date: Fri Aug 23 07:04:09 2019 New Revision: 369759 URL: http://llvm.org/viewvc/llvm-project?rev=369759&view=rev Log: clang-format: Disable across-block include reordering. Differential Revision: https://reviews.llvm.org/D66650 Modified: cfe/trunk/lib/Format/Format.cpp Modified

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

ymandel updated this revision to Diff 216838. ymandel added a comment. comment tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66652/new/ https://reviews.llvm.org/D66652 Files: clang/include/clang/Tooling/Refactoring/Transformer.h clang/

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a subscriber: regehr. xbolva00 added a comment. >> I now agree that it makes sense to warn when the operands are macros or >> variables. I could re-add macro support and then @jfb or @regehr would blame this diagnostic because of macro support =] variables could open a new box of

r369760 - [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Author: szelethus Date: Fri Aug 23 07:21:13 2019 New Revision: 369760 URL: http://llvm.org/viewvc/llvm-project?rev=369760&view=rev Log: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts Summary: EnumCastOutOfRangeChecker should not perform enum range checks on LValueToRValue

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I am strongly in favour to just land this as is. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL369760: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. I seem to have been able to put this together by fetching the individual diffs and squashing them this time :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014 _

[PATCH] D66653: [clang-format] Turn include regrouping on for Google ObjC style

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Turns back include regrouping for Google ObjC style Repository: rC Clang https://reviews.llvm.org/D66653 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp Index: unit

[PATCH] D66653: [clang-format] Turn include regrouping on for Google ObjC style

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66653/new/ https://reviews.llvm.org/D66653 ___ cfe-commits

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

martong added a comment. There is a third test which could be useful to test whether there is no faulty cache entries there: +TEST_F(StructuralEquivalenceCacheTest, DISABLED_NonEq) { + auto Decls = + makeTuDecls( + R"( +class A {}; +class B {

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong marked an inline comment as done. martong added a comment. In D62131#1639168 , @balazske wrote: > Example about how to get wrong things into `NonEquivalentDecls`: > We want to compare `class C` for structural equivalence in the following > codes:

[clang-tools-extra] r369763 - [clang-tidy] Possibility of displaying duplicate warnings

Author: szelethus Date: Fri Aug 23 07:57:27 2019 New Revision: 369763 URL: http://llvm.org/viewvc/llvm-project?rev=369763&view=rev Log: [clang-tidy] Possibility of displaying duplicate warnings Summary: In case a checker is registered multiple times as an alias, the emitted warnings are uniqued

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL369763: [clang-tidy] Possibility of displaying duplicate warnings (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

balazske updated this revision to Diff 216851. balazske added a comment. - Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66538/new/ https://reviews.llvm.org/D66538 Files: clang/include/clang/AST/ASTStructuralEquivalence.h clang/

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong abandoned this revision. martong added a comment. @a_sidorin Alexei, With Balazs we had a long discussion and I think we reached a consensus and common understanding. Now I try to summarize it. It turned out that this patch essentially renders the `NonEquivalentDecls` cache to be compl

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong added a comment. > ... it is highly probable that if some pairs were ever non-equivalent they > will stay non-equivalent. This may not be true in case of LLDB, because usually they do a minimal import, and in a later phase they do a normal import which imports e.g. the members of a cla

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

balazske added a comment. In D66538#1642883 , @martong wrote: > There is a third test which could be useful to test whether there is no > faulty cache entries there: > > +TEST_F(StructuralEquivalenceCacheTest, DISABLED_NonEq) { > ... > +} > This i

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

yamauchi added a comment. Nice. In D66621#1642142 , @rsmith wrote: > This seems subtle, but I believe it is correct. > > I wonder whether we should provide a warning for a non-final class has a > final destructor, since moving the `final` from the destru

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

nathanchance added a comment. Done, thanks for looking into this! F9847579: check-time-trace-sections.json Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325

r369773 - [NFC] Move some variable declarations into their 'if' conditions.

Author: erichkeane Date: Fri Aug 23 08:58:35 2019 New Revision: 369773 URL: http://llvm.org/viewvc/llvm-project?rev=369773&view=rev Log: [NFC] Move some variable declarations into their 'if' conditions. A couple of variables are being declared outside of the 'if' condition that is their only actu

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, owenpan. MyDeveloperDay added a project: clang. Addresses https://bugs.llvm.org/show_bug.cgi?id=43100 Formatting using statement in C# with clang-format removes the space between using and paren even when Spac

r369775 - [OPENMP5.0]Add support for device_type clause in declare target

Author: abataev Date: Fri Aug 23 09:11:14 2019 New Revision: 369775 URL: http://llvm.org/viewvc/llvm-project?rev=369775&view=rev Log: [OPENMP5.0]Add support for device_type clause in declare target construct. OpenMP 5.0 introduced new clause for declare target directive, device_type clause, whic

r369777 - Fixed a typo.

Author: tra Date: Fri Aug 23 09:24:17 2019 New Revision: 369777 URL: http://llvm.org/viewvc/llvm-project?rev=369777&view=rev Log: Fixed a typo. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sem

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra marked an inline comment as done. tra added inline comments. Comment at: cfe/trunk/lib/Sema/SemaDecl.cpp:8416 +// in the CheckFunctionTemplateSpecialization() call below. +if (getLangOpts().CUDA & !isFunctionTemplateSpecialization) + maybeAddCUDAHostDeviceAttrs(N

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66511/new/ https://reviews.llvm.org/D66511 ___ cfe-commit

r369779 - [OpenCL] Renamed value of std flag in C++ mode.

Author: stulova Date: Fri Aug 23 10:10:33 2019 New Revision: 369779 URL: http://llvm.org/viewvc/llvm-project?rev=369779&view=rev Log: [OpenCL] Renamed value of std flag in C++ mode. Clang should accept -std=clc++ (not -std=c++!) for OpenCL. This was forgotten in r367008. Modified: cfe/tru

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

dexonsmith added inline comments. Comment at: lib/Lex/DependencyDirectivesSourceMinimizer.cpp:822 bool Minimizer::minimizeImpl(const char *First, const char *const End) { + skipUTF8ByteOrderMark(First, End); while (First != End) Is skipping this the right th

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Nathan-Huckleberry updated this revision to Diff 216884. Nathan-Huckleberry added a comment. - Remove else Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm.org/D66186 Files: clang/lib/AST/FormatString.cpp clang/lib

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaChecking.cpp:8106 return true; +Pedantic = true; } `if (ImplicitMatch == analy

[PATCH] D66665: [CUDA] Use activemask.b32 instruction to implement __activemask w/ CUDA-9.2+

tra created this revision. tra added a reviewer: timshen. Herald added subscribers: sanjoy.google, bixia. vote.ballot instruction is gone in recent CUDA versions and vote.sync.ballot can not be used because it needs a thread mask parameter. Fortunately PTX 6.2 (introduced with CUDA-9.2) provides a

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Refactoring/Transformer.cpp:197 // Verify the existence and validity of the AST node that roots this rule. + SourceLocation Root

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Nathan-Huckleberry updated this revision to Diff 216893. Nathan-Huckleberry added a comment. - Add if without else Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm.org/D66186 Files: clang/lib/AST/FormatString.cpp c

[clang-tools-extra] r369783 - Fix clang-tidy warning in clang-tidy

Author: d0k Date: Fri Aug 23 10:27:04 2019 New Revision: 369783 URL: http://llvm.org/viewvc/llvm-project?rev=369783&view=rev Log: Fix clang-tidy warning in clang-tidy argument name 'FixDescription' in comment does not match parameter name 'Description' Patch by Nils Barth! Modified: clang-

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm.org/D66186 _

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

arphaman updated this revision to Diff 216898. arphaman added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66555/new/ https://reviews.llvm.org/D66555 Files: clang/include/clang/Driver/Options.td clang/lib/D

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

arphaman marked 5 inline comments as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2067 + const auto &Driver = C.getDriver(); + auto CWD = Driver.getVFS().getCurrentWorkingDirectory(); + if (!CWD) { jkorous wrote: > Do

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

shafik created this revision. shafik added a reviewer: aprantl. shafik added a project: debug-info. shafik added a parent revision: D66605: Debug Info: Support for DW_AT_export_symbols for anonymous structs. This implements the DWARF 5 feature described in: http://dwarfstd.org/ShowIssue.php?issu

[PATCH] D66668: [OPENMP][Analysis] Add analysis of the map clauses.

ABataev created this revision. ABataev added a reviewer: NoQ. Herald added a subscriber: guansong. Herald added a project: clang. Added basic analysis of map clauses. Only map clauses with to and tofrom map type must be analyzed since all other map types (alloc, delete, etc.) do not require to us

r369791 - [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Author: nathan-huckleberry Date: Fri Aug 23 11:01:57 2019 New Revision: 369791 URL: http://llvm.org/viewvc/llvm-project?rev=369791&view=rev Log: [Sema] Don't warn on printf('%hd', [char]) (PR41467) Summary: Link: https://bugs.llvm.org/show_bug.cgi?id=41467 Reviewers: rsmith, nickdesaulniers, aar

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

aprantl added inline comments. Comment at: test/CodeGenCXX/debug-info-export_symbols.cpp:3 + +// CHECK-DAG: !DICompositeType({{.*}}flags: DIFlagExportSymbols | DIFlagTypePassByValue +struct A { This should just be `CHECK:` if it stands by itself. It would be be

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

This revision was automatically updated to reflect the committed changes. Closed by commit rL369791: [Sema] Don't warn on printf('%hd', [char]) (PR41467) (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D66646: Ensure that statements, expressions and types are trivially destructible with a static_assert

lebedev.ri added a comment. In D66646#1642730 , @riccibruno wrote: > In D66646#1642708 , @lebedev.ri > wrote: > > > SGTM, but i wonder if this should be done one level up, in > > `BumpPtrAllocator` itself? > > > I

Re: r369616 - [analyzer] Enable control dependency condition tracking by default

I suspect that this patch makes analysis much slower in certain cases. For example, the clang/test/Analysis/pr37802.cpp test has become ~5 times slower in some configurations in our environment. This happened somewhere between r369520 and r369679, and your series of patches seems most suspicious :)

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1643023 , @nathanchance wrote: > Done, thanks for looking into this! > > F9847579: check-time-trace-sections.json Hmm, I still didn't manage to reproduce the issue using your

Re: r369616 - [analyzer] Enable control dependency condition tracking by default

Totally possible, thanks for letting me know! There should be plenty of room for caching, because I do calculate control dependencies in an excess for the same CFG, and the retrieval of a basic block from an ExplodedNode is anything but efficient, though I honestly didnt expect a performance hit th

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

JamesNagurne added a comment. Herald added a subscriber: ributzka. @arphaman you disabled this test on Windows, but did not specify exactly how it fails. My team works on an embedded ARM compiler (most similar to arm-none-eabi), and we're now seeing failures from DependencyScannerTest. I can't f

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

mgehre added a comment. > Also it feels a bit weird to change the ownership semantics in a derived > class, I bet that would violate the Liskov substitution principle. And then we see that llvm::OwningArrayRef inherits from llvm::ArrayRef ... But maybe this direction (strengthening a Pointer in

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun added a comment. In D66486#1643374 , @mgehre wrote: > > Also it feels a bit weird to change the ownership semantics in a derived > > class, I bet that would violate the Liskov substitution principle. > > And then we see that llvm::OwningArrayRef

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

ABataev created this revision. ABataev added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, jholewinski. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously critical regions were emitted with the barrier making it a worksharing construct though it i

  1   2   >