[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: clang/test/Driver/Wp-args.c:27 + +// RSP: inception hans wrote: > Why inception? I feel like I'm missing something :) Could be anything else :) Because `-rewrite-macros` prints thi

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/test/Driver/Wp-args.c:27 + +// RSP: inception hans wrote: > aganea wrote: > > hans wrote: > > > Why inception? I feel like I'm missing something :) > > Could be anything else

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rG68d7f06092e5: Clang] Fix expansion of response files in -Wp after integrated-cc1 change (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea created this revision. aganea added reviewers: arichardson, rnk, hans. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. As reported by @arichardson , this patch now makes `llvm::report_fatal_error()` to generate a preprocessed source + rep

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea created this revision. aganea added reviewers: mstorsjo, hans, kbobyrev, dexonsmith, zero9178. Herald added subscribers: kadircet, arphaman, hiraditya. Herald added a project: All. aganea requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added s

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea updated this revision to Diff 506820. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490 Files: clang-tools-extra/clangd/unittests/FSTests.cpp clang/include/clang/

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea added a comment. Fair enough. There are several choices forward: either we mark the issue as "Will Not Fix" or I can try only scoping this patch to only keep the handle for network drives/paths. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

aganea added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; erichkeane wrote: > This patch seems to cause a self-build Werror

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

aganea added subscribers: thieta, saudi. aganea added a comment. + @saudi @thieta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 ___ cfe-commits mailing list c

[PATCH] D115103: Leak Sanitizer port to Windows

aganea added a comment. @clemenswasser We hit this once in a while, when Microsoft update their libraries. But I'm surprised about the CC at the beginning. How can this issue be reproduced? Can you show a disassembly dump from the VS debugger, around the address of the function that fails? CH

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaba5b91b699c: Re-land [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aganea marked 3 inline comments as done. Closed by commit rG5af2433e1794: [clang-cl] Support the /HOTPATCH flag (authored by aganea). Changed prior to commit: https:

[PATCH] D118428: [clang-cl] Support the /JMC flag

aganea added a reviewer: mstorsjo. aganea added a subscriber: belkiss. aganea added a comment. Cool! :) Seems good generally. Sounds like an expensive flag for the runtime perf :-D But I guess it makes the debugging experience a bit nicer. Comment at: clang/lib/Driver/ToolChai

[PATCH] D118428: [clang-cl] Support the /JMC flag

aganea added inline comments. Comment at: clang/docs/ReleaseNotes.rst:155 +- Add support for MSVC-compatible ``/JMC``/``/JMC-`` flag in clang-cl, and + equivalent -cc1 flag ``-fjmc``. ``/JMC`` could only be used when ``/Zi`` or + ``/Z7`` is turned on. With this addition, clang

[PATCH] D118070: Make lld-link work in a non-MSVC shell

aganea added a comment. In D118070#3289227 , @MaskRay wrote: > I know that you want a place to be accessed by both clang driver and > lld-link but I am a bit nervous about the clang-driver style MSVC library > sitting inside llvm/lib/Support/. > Is the

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 396804. aganea added a comment. This revision is now accepted and ready to land. Herald added subscribers: abrachet, mgorny. Rebase & simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://re

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. @dexonsmith The issue with `-grecord-command-line`/`-frecord-command-line` is that it isn't producing a self-standing command-line. For example: > clang-cl /c main.cpp /clang:-grecord-command-line /Z7 would record: `d:\\git\\llvm-project\\stage1\\bin\\clang-cl.exe --d

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea created this revision. aganea added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter. Herald added subscribers: ormris, dexonsmith, dang, pengfei, hiraditya. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cf

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea updated this revision to Diff 397063. aganea added a subscriber: saudi. aganea added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116511/new/ https://reviews.llvm.org/D116511 Files: clang/include/clang/Basic/CodeGen

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea updated this revision to Diff 397069. aganea marked 2 inline comments as done. aganea added a comment. Herald added subscribers: hiraditya, mgorny. As suggested by @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://revie

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/PDB/DIA/DIASupport.h:34 +#endif #include +#ifdef __clang__ hans wrote: > I thought this warning should be suppressed for system headers. Isn't that > working here? Good point, because it was

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://reviews.llvm.org/D116313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe32936aef4a2: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added a subscriber: dblaikie. aganea added a comment. I was wondering, can we mandate `LLVM_ENABLE_WERROR=ON` for all bots at least? (or maybe enable it through cmake, if ever there's a setting to detect we're running as a bot) Or just reverse the default setting on the main branch, ie. m

[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

aganea added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp:104 + } +} + Hello! I commit a tiny fix here, please see: rGa5af260d3e8b00a3353e813b73f83391edbef493 Repository: rG LLVM Github Monorepo C

[PATCH] D115103: Leak Sanitizer port to Windows

aganea added a comment. It does work indeed. I am running under a "x64 Native Tools Command Prompt for VS 2019" prompt with MSVC 16.11.8. D:\git\llvm-project>mkdir release && cd release D:\git\llvm-project\release>cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lld;llvm;compiler-rt" -D

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

aganea added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" Hello @Anastasia, this line fails on my machine. It works with

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

aganea added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" svenvh wrote: > aganea wrote: > > Hello @Anastasia, this line

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea updated this revision to Diff 399168. aganea marked 4 inline comments as done. aganea edited the summary of this revision. aganea added a comment. Herald added a subscriber: kristof.beyls. As suggested by @hans Also added test coverage for ARM/ARM64. Repository: rG LLVM Github Monorepo

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea added inline comments. Comment at: clang/include/clang/Driver/Options.td:2493 MarshallingInfoInt>; +def fhotpatch : Flag<["-"], "fhotpatch">, Group, Flags<[CC1Option]>, + HelpText<"Ensure that all functions can be hotpatched at runtime">, hans wrote: >

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13 +// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH +// ERR-HOTPATCH: error: unsupported option '/hotpatch' for t

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

aganea added subscribers: hans, rnk, aganea. aganea added reviewers: hans, rnk. aganea added a comment. +@hans @rnk Since we discussed this in one of the past Windows/COFF calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://rev

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea removed a reviewer: deadalnix. aganea added a comment. Ping! Any further comments? Thanks in advance for your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 ___

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea created this revision. aganea added reviewers: hans, aheejin, jansvoboda11. Herald added a subscriber: dexonsmith. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. As reported in PR52704: https://github.com/ll

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf44e3fbadd15: [CodeView] Emit S_OBJNAME record (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D43002?vs=374884&id=395663#

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd26520f6f787: [Clang] Own the CommandLineArgs in CodeGenOptions (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D116011?vs

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:391 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). I changed this to match the behavior of

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). ---

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). ---

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added a comment. In D43002#3205190 , @MaskRay wrote: > Some test nits:) I don't know CodeView :( Fixed, thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llv

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea created this revision. aganea added reviewers: mstorsjo, amccarth, hans. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When building LLVM with Clang 13.0 on Windows, I see a bunch of `-Wnon-virtual-dtor` e

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

aganea added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:2470 +// Dynamic TLS initialization works by checking the state of a +// guard varibale (__tls_guard) to see whether TLS initialization +// for a thread has happend yet. s

[PATCH] D98824: [Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+

aganea added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:181 + // ...including when the inputs are passed after -- + if (Opt.matches(OPT__DASH_DASH)) { +continue; You can leave out the braces on a one-line

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe030ce3ec790: [Tooling] Handle compilation databases containing commands with double dashes (authored by jnykiel, committed by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96363: Mark output as text if it is really text

aganea added a comment. Hello! This patch breaks compilation when using `-frewrite-includes` on Windows. It adds an extra line with CRLF, which causes compilation failures with macros line-breaks: $ cat -A hello.cpp int foo();^M$ int bar();^M$ #define HELLO \^M$ foo(); \^M$ bar(

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. Sorry, but after this patch, I still see the issue mentioned in https://reviews.llvm.org/D96363#2650460 @abhina.sreeskantharajan are you be able to confirm the issue on your end? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. In D99363#2652907 , @abhina.sreeskantharajan wrote: > In D99363#2652899 , @aganea wrote: > >> Sorry, but after this patch, I still see the issue mentioned in >> https://reviews.llvm.org/D96

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. I'm just wondering if D96363 and all attached subsequent patches shouldn't be reverted for now. This is quite trivial case uncovered by tests. On re-land, I would then add a test validating the issue on Windows: $ cat -A rewrite-inclu

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. In D99363#2653476 , @abhina.sreeskantharajan wrote: > In D99363#2653201 , @aganea wrote: > >> I'm just wondering if D96363 and all >> attached subsequent p

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. In D99363#2653476 , @abhina.sreeskantharajan wrote: > There were a lot of similar patches so reverting all of them might be more > work than isolating the change that caused it and reverting that. It seems > that the patch you in

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. >> In D99363#2653476 , >> @abhina.sreeskantharajan wrote: >> >>> > > This was only other file from https://reviews.llvm.org/D96363 that was using > OF_TextWithCRLF instead of OF_Text. Please let me know if this latest patch > htt

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. I am still concerned by the fact that this patch doesn't fix the issue mentionned in https://reviews.llvm.org/D96363#2650460 Was the intention to fix that issue? Will the fix be done in a subsequent patch? Comment at: llvm/lib/Support/Windows/Path.inc:1

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. In D99426#2666141 , @abhina.sreeskantharajan wrote: > In D99426#2665361 , @aganea wrote: > >> I am still concerned by the fact that this patch doesn't fix the issue >> mentionned in https:/

[PATCH] D99837: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. It works now, thanks! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99837/new/ https://reviews.llvm.org/D99837

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

aganea created this revision. aganea added reviewers: abhina.sreeskantharajan, rnk, amccarth, MaskRay, mstorsjo. aganea requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Validate that we properly generating a single line ending on Windows wh

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15 +} \ No newline at end of file mstorsjo wrote: > I guess the missing newline at end of file isn't one of the aspects that > nee

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rG8fbc05acd553: [Windows] Add test coverage for line endings when rewriting includes (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D99973

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

This revision was automatically updated to reflect the committed changes. Closed by commit rG488a19d00cba: [clang-scan-deps] Support double-dashes in clang command lines (authored by saudi, committed by aganea). Changed prior to commit: https://reviews.llvm.org/D95099?vs=318304&id=338329#toc R

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26fa8c286b: [clang-scan-deps] Add support for clang-cl (authored by saudi, committed by aganea). Changed prior to commit: https://reviews.llvm.org/D92191?vs=318553&id=338330#toc Repository: rG LLVM

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. @gulfem We're taking a look now. Could you please post a link to the full build log, including the cmake flags used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. Thanks! We found the issue. I think I'll revert the patch, and will reland a fixed version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 _

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

aganea added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:94 + +ErrorOr findClang(const char *Argv0) { + StringRef Parent = llvm::sys::path::parent_path(Argv0); Since you're not using the `std::error_code` below in the call site, should this retu

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

aganea accepted this revision. aganea added a comment. LGTM. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:94 + +ErrorOr findClang(const char *Argv0) { + StringRef Parent = llvm::sys::path::parent_path(Argv0); mstorsjo wrote: > aganea wrote: > > Since you're not

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

aganea added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:259 -} // anonymous namespace +static bool consume_back_lower(StringRef &S, const char *str) { + if (!S.endswith_lower(str)) `s/str/Str/` Comment at: llvm/tools/llvm-rc

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

aganea added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:300 + +std::string unescape(StringRef S) { + std::string Out; mstorsjo wrote: > aganea wrote: > > I would also need this function in D43002 (see unescapeSlashes), do you > > think we can m

[PATCH] D93772: [Clang][Driver] Fix read-after-free when using /clang:

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3854b81b0fd2: [Clang][Driver] Fix read-after-free when using /clang: (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. In D86694#2463429 , @russell.gallop wrote: > - With scudo all lit tests (generally) pass, but there are some intermittent > failures (Access Violation) on the following tests: > >> ExecutionEngine/MCJIT/test-global-init-nonzero-sm

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

aganea added a comment. What are the exact conditions to repro Nick's failure? On Fedora 32, I ran `py llvm-lit sigpipe-handling.c` before this patch and before rGbf401256edd00e921a5d3a0bf4cf6ee66ae51cd6 , the test suceeds,

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea marked 8 inline comments as done. aganea added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:212 + /// Output filename used in the COFF debug information. + std::string COFFOutputFilename; + rnk wrote: > Let's bikeshed the name

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a subscriber: dexonsmith. aganea added a comment. In D80833#3052551 , @dexonsmith wrote: > In D80833#2069411 , @aganea wrote: > >> In D80833#2069246 , @amccarth

<    1   2   3   4   5