[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Update diff. Comment at: lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp:263-282 + mutable IdentifierInfo *II_BasicOstream, *II_Flags, *II_Setf, *II_Unsetf, + *II_Setiosflags, *II_Resetiosflags, *

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 updated this revision to Diff 101549. gamesh411 marked an inline comment as done. gamesh411 added a comment. Update diff. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checke

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

gamesh411 added a comment. Hi! Thanks for your reviews, although I haven't been active for some time now. I personally do not have commit rights, so could someone else take care of it? https://reviews.llvm.org/D33672 ___ cfe-commits mailing list cfe

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

gamesh411 added a comment. In my opinion, after migrating relevant test cases from D33826 , this is ready. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/new/ https://reviews.llvm.org/D48866

[PATCH] D58897: Make ODR error handling configurable

gamesh411 created this revision. Herald added subscribers: cfe-commits, jdoerfert, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. ODR errors are not necessarily true errors during the import of ASTs. ASTMerge and CrossTU should use the warning equivalent of eve

[PATCH] D58897: Make ODR error handling configurable

gamesh411 added a comment. This revision is the alternative of the abandoned D55646 . Now Sema uses the old behavior of emitting ODR errors while merging and importing is done in a more lenient way. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D59761: [ASTImporter] Covert ODR diagnostics inside ASTImporter implementation

gamesh411 created this revision. Herald added subscribers: cfe-commits, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. gamesh411 added a subscriber: martong. Herald added a subscriber: rnkovacs

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

gamesh411 added inline comments. Comment at: include/clang/AST/ASTStructuralEquivalence.h:81 EqKind(EqKind), StrictTypeSpelling(StrictTypeSpelling), -ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch), Complain(Complain) {} +Complain(Complain), ErrorOnTagType

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

gamesh411 updated this revision to Diff 192070. gamesh411 marked an inline comment as done. gamesh411 added a comment. - Revert member order to original Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58897/new/ https://reviews.llvm.org/D58897 Files: include/cla

[PATCH] D59761: [ASTImporter] Covert ODR diagnostics inside ASTImporter implementation

gamesh411 added a comment. Hi! During CTU analysis, not only StructuralEquivalence but the main implementation of ASTImporter can also emit ODR-related diagnostics. After some consideration, I have chosen not to make these dependent on a switch, as ASTImporter is not nearly as widely used as S

[PATCH] D59798: Add analyzer option to limit the number of imported TUs

gamesh411 created this revision. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, whisperity. Herald added a reviewer: martong. Herald added a project: clang. During CTU analysis of complex projects, the loaded AST-contents of importe

[PATCH] D59798: [WIP] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 192571. gamesh411 added a comment. Updated option handling location to use AnalyzerOptions instead of CC1 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/Cros

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

gamesh411 added a comment. ping @a_sidorin Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58897/new/ https://reviews.llvm.org/D58897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation

gamesh411 added a comment. ping @a_sidorin @shafik Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59761/new/ https://reviews.llvm.org/D59761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 created this revision. Herald added subscribers: cfe-commits, jdoerfert, Szelethus, dkrupp. Herald added a project: clang. The comparison of SourceLocations is extended to handle locations from different translation units, making the comparison based on the corresponding FileID. Reposi

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. Hi! This issue came up during the generation BugReports of BugPaths containing macro-expansions, where the spelling location and expansion locations were in different files. With this change, we make such SourceLocations comparable by their FileIDs. Repository: rC

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1446736 , @Szelethus wrote: > In D59934#1446051 , @gamesh411 wrote: > > > Hi! > > > > This issue came up during the generation BugReports of BugPaths containing > > macro-expans

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. Just have a bit more context, I have the following information from a debug session at the execution point of the unreachable: (rr) p LHS.dump(*this) ./tmux-2.8/compat/tree.h:721:9 (rr) p RHS.dump(*this) ./tmux-2.8/arg

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1446059 , @lebedev.ri wrote: > Test? Thanks for the remark :) I agree, that there should be at least a unit test asserting the right behaviour. I am working on it. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1449109 , @Szelethus wrote: > I would still like to learn more about this issue. I am somewhat afraid that > the our macro expansion is faulty. Can you provide a stacktrace maybe? The stack trace that belongs to the

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1449221 , @Szelethus wrote: > Hmm. Is your clang recent enough to contain @bruntib's patch D57892 > ? Is it possible that this patch solves the > same issue? With this patch applied, a

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

gamesh411 created this revision. gamesh411 added reviewers: a.sidorin, shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously only the fields were imported. Now every Decl is imported. This way the destructor decl is not missing after import. Patch by balazske (

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

gamesh411 updated this revision to Diff 185509. gamesh411 added a comment. Remove unnecessary ToTU variable from test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57740/new/ https://reviews.llvm.org/D57740 Files: lib/AST/ASTImporter.cpp unittests/AST/

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. I am going to abandon this modification, as setting ODR violations as warnings, seems like a change that could have unforeseen consequences. Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 abandoned this revision. gamesh411 added a comment. I am creating a new revision that keeps the old handling of ODR violations the same when used by parts of the Sema, but emit warnings when used by the ASTImporter. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D64748: Refactor threshold checking

gamesh411 created this revision. Herald added subscribers: cfe-commits, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. Herald added a subscriber: rnkovacs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64748 Files: clang/include/clang/Cros

[PATCH] D64749: Refactor CTUIndex lazy initialization

gamesh411 created this revision. Herald added subscribers: cfe-commits, Szelethus, arphaman, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64749 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h

[PATCH] D64748: Refactor threshold checking

gamesh411 updated this revision to Diff 209882. gamesh411 added a comment. Incremental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64748/new/ https://reviews.llvm.org/D64748 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h cl

[PATCH] D64748: Refactor threshold checking

gamesh411 updated this revision to Diff 209880. gamesh411 added a comment. Incremental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64748/new/ https://reviews.llvm.org/D64748 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h cl

[PATCH] D64748: Refactor threshold checking

gamesh411 updated this revision to Diff 209881. gamesh411 added a comment. Incremental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64748/new/ https://reviews.llvm.org/D64748 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h cl

[PATCH] D64748: Refactor threshold checking

gamesh411 updated this revision to Diff 209879. gamesh411 added a comment. Incremental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64748/new/ https://reviews.llvm.org/D64748 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h cl

[PATCH] D64748: Refactor threshold checking

gamesh411 updated this revision to Diff 209883. gamesh411 added a comment. Incremental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64748/new/ https://reviews.llvm.org/D64748 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h cl

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 created this revision. gamesh411 added a reviewer: martong. Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. Refactor loadExternalAST method of CrossTranslationUnitContext in order to reduce maintenance burden and so that features are eas

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 abandoned this revision. gamesh411 added a comment. Herald added subscribers: Charusso, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. There are multiple new additions to stream formatters, and this patch is way too old. I may consider creating a new che

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 abandoned this revision. gamesh411 added a comment. 32f220c5fbe5 is the more sophisticated solution to the problem. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59934/new/ https://

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 211361. gamesh411 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Refactor functionality into local classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ htt

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 211363. gamesh411 added a comment. Too much autoformat fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Files: clang/include/clang/CrossTU/CrossTranslationUnit

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 marked 11 inline comments as done. gamesh411 added a comment. Thanks for pointing out these issues. Most of them are agreed. Merging the RAII counter with the threshold checker class, however, does not seem like a good decision for me. What would be the benefits of merging the two?

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 212290. gamesh411 marked 5 inline comments as done. gamesh411 added a comment. - Merge RAII class - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Fi

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 marked 2 inline comments as done. gamesh411 added a comment. Updated the revision. I find this solution definitely more compact with responsibilities more separated. One more thing that comes to mind is that maybe the whole explicit passing of CTUDir and IndexName arguments is a bit ve

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 212788. gamesh411 added a comment. Specify the exact meaning of successful storage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Files: clang/include/clang/CrossT

[PATCH] D65573: Add User docs for ASTImporter

gamesh411 added a comment. Lovely documentation with practical use-cases! I left a few inline remarks. Also wouldn't it be nice to have a section which introduces the `-ast-merge` command-line option. It would be helpful to see an example where a PCH is dumped and merged into another TU. You cou

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 213311. gamesh411 added a comment. - Remove unused member Limit - Rebase to current master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Files: clang/include/clan

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

This revision was automatically updated to reflect the committed changes. Closed by commit rL367829: [CrossTU][NFCI] Refactor loadExternalAST function (authored by gamesh411, committed by ). Changed prior to commit: https://reviews.llvm.org/D64753?vs=213311&id=213315#toc Repository: rL LLVM

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

gamesh411 accepted this revision. gamesh411 added a comment. @chrish_ericsson_atx Thanks for fixing this! Your help is much appreciated :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

gamesh411 added a comment. Nice improvements! It was a good catch that a substantial part of the checker could be cut out. Accurate modelling of CString and related API-s is really important, and this is a good step in that direction. I would test this on a larger codebase as well before committ

[PATCH] D64120: Rebase onto current master

gamesh411 created this revision. Herald added subscribers: cfe-commits, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D64120 Files: include/clang/CrossTU/CrossTranslationUnit.h include/clang/StaticAnalyzer/

[PATCH] D64120: Rebase onto current master

gamesh411 abandoned this revision. gamesh411 added a comment. Missed arcanist diff. Disregard this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64120/new/ https://reviews.llvm.org/D64120 ___ cfe-commits ma

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 207711. gamesh411 added a comment. Rebase onto current master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTranslationUnit.h include/clang/S

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 207712. gamesh411 added a comment. Rebase again Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTranslationUnit.h include/clang/StaticAnalyzer/

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

This revision was automatically updated to reflect the committed changes. Closed by commit rL365314: [analyzer] Add analyzer option to limit the number of imported TUs (authored by gamesh411, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 199277. gamesh411 added a comment. Apply review suggestions by Xazax Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTranslationUnit.h include/

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 marked an inline comment as done. gamesh411 added a comment. I could greatly simplify the API of getCrossTUDefinition by injecting the threshold value in the constructor. A minor drawback with this approach is that testing code is a bit more complicated, as I had to patch the CompilerI

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

gamesh411 updated this revision to Diff 199278. gamesh411 added a comment. Revert unnecessary clang-formating of AnalysisConsumer.cpp Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 Files: include/clang/CrossTU/CrossTra

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 created this revision. Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. - Make ODR diagnostics warning by default After this change all odr-related diagnostics are considered warnings belonging to Dia

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 added a comment. In order to be able to handle ODR-related diagnostics with command line options, these diagnostics were moved from Error category to Warning. What are your thoughts? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55646/new/ https://rev

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 added a comment. Hey Aleksei! Thank you for the input! ODR violations being warnings would be beneficial from the code maintenance point of view, as we would not have to resort to duplicate some (if not most) of them as errors. There is also a flexibility advantage in the diagnostics,

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55646/new/ https://reviews.llvm.org/D55646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 added a comment. Please feel free to add more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 created this revision. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a project: clang. gamesh411 added a reviewer: Szelethus. gamesh411 added a

[PATCH] D78097: [analyzer][RetainCount] Remove the CheckOSObject option

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. I have no authority whatsoever, but if there is no breakage in buildbots, then it means explicitly providing `CheckOSObject` param is not really valid use-case. I vote for this cleanup.

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 266473. gamesh411 marked 29 inline comments as done. gamesh411 added a comment. Update functional changes, documentation update incoming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://review

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 2 inline comments as done. gamesh411 added a comment. The remaining documentation and test changes are also underway. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:227 +/// Identifier. +virtual LoadResultTy load(StringRef Identifier) =

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 267143. gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Fix documentation and commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Fi

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added a comment. In D83717#2155066 , @njames93 wrote: > In D83717#2152762 , @gamesh411 wrote: > > > In D83717#2150977 , @njames93 > > wrote: > > > > > Alternativel

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 marked 4 inline comments as done. gamesh411 added a comment. I am now experimenting with the suggestions. The other issues are on the worklist. Thanks for these so far. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:50 + if (is

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 278703. gamesh411 added a comment. move tests to one file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files: clang/include/clang/StaticAnalyzer/Checkers/Checker

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 278727. gamesh411 marked 3 inline comments as done. gamesh411 added a comment. extend test cases add comments to non-obvious cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 added inline comments. Comment at: clang/test/Analysis/sufficient-size-array-indexing-32bit.c:120 + +void test_symbolic_index_handling4(int choice) { + char c; balazske wrote: > Here "is a chance that indexing is correct". So no warning should occur? I

[PATCH] D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd02a86260b3: [analyzer] Add system header simulator a symmetric random access iterator… (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 278747. gamesh411 added a comment. rebase upon hotfix patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190 Files: clang/lib/StaticAnalyzer/Checkers/IteratorModelin

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 added a comment. It would be nice to see the measurements on llvm as this patch introduced some (IMO reasonable) asserts. Also in the unlikely case, there is an expression like `1 + iter`, there could be more results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Thanks for reviewing this patch this quickly! I have updated the diff according to your suggestions, but I will not land it till I run a llvm+clang analysis with it. Do you think non-ctu mode is enough to test the stability?

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 278853. gamesh411 marked an inline comment as done. gamesh411 added a comment. apply review suggestions - rename variables - remove 1 assert - rename tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 278870. gamesh411 added a comment. rename Offset -> Amount inside handleRandomIncrOrDecl minor local variable renaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 added a comment. I experienced 2 crashes with and without this patch using commit `1af9fc82132da7c876e8f70c4e986cc9c59010ee` on master: I have used the clang built on that revision to analyse itself, and also used the patched version (with this current revision applied) to do the same.

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 256212. gamesh411 added a comment. Herald added a subscriber: ASDenysPetrov. Refactored the test Copying the compile_commands.json in case of test for C files results in the extdef mapping tool finding the correct compiler flags for the C to be imported. R

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. In D75665#1907938 , @martong wrote: > > As the CTUDir string prefix is only needed in case of the old approach, I > > have refactored the external definition mapping storage to NOT include that. > > Both `ctu-main.c` and `ctu-on

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. In D75665#1907914 , @martong wrote: > The warning below suggests that we parse the ctu-other.c file (and presumably > every file) as a C++ file, even if it should be parsed as a C file. Perhaps > the invocation of the parser

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257622. gamesh411 added a comment. Reorganize test code to overcome testing infrastructure limitations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 23 inline comments as done. gamesh411 added a comment. Answered most review comments. Thanks for the reviewers @balazske, @martong so far. The question of absolute path policy is still up for debate. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 7 inline comments as done. gamesh411 added inline comments. Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5 +// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c" +// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility ctu-other.c","

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257896. gamesh411 marked an inline comment as done. gamesh411 added a comment. Implement review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: c

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 5 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:457 +return llvm::make_error( +index_error_code::ambiguous_compile_commands_database); + martong wrote: > Could we have

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257985. gamesh411 marked an inline comment as done. gamesh411 added a comment. Rebase and update the number of analyzer options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.or

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269439. gamesh411 added a comment. Extend index file format Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-doc

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269527. gamesh411 added a comment. Fix test case, and reorder warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTran

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269615. gamesh411 added a comment. use consumeError in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUni

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269639. gamesh411 added a comment. add ambiguous invocation list test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/Cros

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269644. gamesh411 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst clang/in

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269677. gamesh411 added a comment. add ambiguity checking during invocation list parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

This revision was automatically updated to reflect the committed changes. Closed by commit rG020815fafd15: [analyzer] On-demand parsing capability for CTU (authored by gamesh411). Changed prior to commit: https://reviews.llvm.org/D75665?vs=269677&id=269749#toc Repository: rG LLVM Github Mono

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. In D75665#2084889 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/mac/15258/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for reporting this, i think the output i

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

gamesh411 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.h:23 +/// Finds ``signal`` function calls when the program is multithreaded. It +/// founds a program multithreaded when it finds at least one function call +///

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

gamesh411 added a comment. Minor nits inline. Good job, I am not entitled to accept it, but LGTM! Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.h:23 +/// Finds ``signal`` function calls when the program is multithreaded. It +/// founds a p

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. Herald added a project: clang. In

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 275595. gamesh411 added a comment. remove unrelated comment formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190 Files: clang/lib/StaticAnalyzer/Checkers/Iter

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 marked 2 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:279 +// or on the RHS (eg.: 1 + it). Both cases are modeled. +bool IsItOnLHS = BO->getLHS()->getType()->isPointerType(); +Ex

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 275605. gamesh411 added a comment. Herald added subscribers: ASDenysPetrov, martong. change license Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files: clang/inc

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 275611. gamesh411 added a comment. move to core.alpha Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

  1   2   3   >