[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D143072: [NFC][clang] Fix static code analyzer complains

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Initializ

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 494221. Fznamznon added a comment. Apply suggestion and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driv

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 494222. Fznamznon added a comment. Fix incorrect conflict resolution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/li

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe082124faa8: [clang][driver] Emit an error for `/clang:-x` (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://revie

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. In D142757#4100167 , @thakis wrote: > This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for reporting. It seems I should have added

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. Should be fixed by https://github.com/llvm/llvm-project/commit/108fa70cd213e63a591adb87ce444fb74afc6786 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 _

[PATCH] D143411: [NFC][clang] Fix static analyzer concern about uninitialized variable

Fznamznon created this revision. Fznamznon added reviewers: NoQ, xazax.hun, gribozavr, ymandel, sgatev. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision.

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2441 bool Sema::CheckImmediateEscalatingFunctionDefinition( -FunctionDecl *FD, bool HasImmediateEscalatingExpression) { - if (!FD->hasBody() || !getLangOpts().CPlusPlus20 || - !FD->isImmediateE

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18441 SemaRef.Diag(ND->getLocation(), diag::note_declared_at); + if (auto Context = + SemaRef.InnermostDeclarationWithDelayedImmediateInvocations()) { cor3ntin wrote

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 541915. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp clang

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Explicit specialization doesn't increase depth of template parameters, so need to be careful when gathering template par

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon added a comment. > Can you explain why the fix fixes the bug? Sure, let me try. To be honest, I'm not very familiar with the code either, so I'll describe how I came to the fix. I'll be using added test `clang/test/SemaTemplate/gh61159.cpp` as example of failing code. The issue happe

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. HeaderInc

[PATCH] D155846: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Preproces

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OMPTransf

[PATCH] D155846: [NFC][clang] Fix static analyzer concerns

Fznamznon abandoned this revision. Fznamznon added a comment. Oh shoot, I trusted the tool too much to not double check that the copy ctor is already deleted. Thank you for the catch and for the bug report. I'll abandon this change then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 543417. Fznamznon added a comment. Rebase, fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155849/new/ https://reviews.llvm.org/D155849 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index: clang/lib

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 543420. Fznamznon added a comment. Rebase to maybe fix precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155842/new/ https://reviews.llvm.org/D155842 Files: clang/lib/Frontend/HeaderIncludeGen.cpp

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added a comment. Just a couple of NITs otherwise LGTM Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2506 + + for (auto A : E->arguments()) +if (!getDerived().TraverseStmt(A)) Comment at: clang/lib/Sema/SemaDeclCXX.cpp:254

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval-default-params.cpp:48 -struct InitWithLambda { -int b = [](int error = undefined()) { // expected-error {{cannot take address of consteval function 'undefined' outside of an immediate invocatio

[PATCH] D156108: Rebase, extend the test a bit

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156108 Files: clang/test/SemaTemplate/gh61159.cpp

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon updated this revision to Diff 543478. Fznamznon added a comment. Rebase, extend the test a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155705/new/ https://reviews.llvm.org/D155705 Files: clang/docs/ReleaseNotes.rst clang/lib/Se

[PATCH] D156108: Rebase, extend the test a bit

Fznamznon abandoned this revision. Fznamznon added a comment. Miss click! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156108/new/ https://reviews.llvm.org/D156108 ___ cfe-commits mailing list cfe-commi

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon added a comment. > Maybe we should think about tests that might exercise this code a bit more. I tried adding more checks, but the patch fixes a specific case. Do you have some examples in mind? Please note that in order to test new change there should be an instantiation of nested non

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc928c683058: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155849/new/ https://reviews.l

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb2906cdfb3: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155842/new/ https://reviews.l

[PATCH] D156133: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EHScopeSt

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb8911316be: [clang] Fix specialization of non-templated member classes of class templates (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D155705?vs=543478&id=543598#toc Re

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > should we try to land that today? I'm not sure. It causes failures in libc++ testing: Failed Tests (3): llvm-libc++-shared.cfg.in :: std/ranges/range.access/end.pass.cpp llvm-libc++-shared.cfg.in :: std/ranges/range.access/rbegin.pass.cpp llvm-libc++-sh

[PATCH] D156133: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5a13e2c7e4c: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156133/new/ https://reviews.l

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. TypeLocBu

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just exit instead. Fixes https://github.com/llvm/llvm-project/issues/42535 Repository: rG LLVM Github Monorepo http

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > It feels a bit weird that we are succeeding in finding the best viable > function and what w

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > Fznamznon wrote: > > shafik wrote: > > > shafik wrote: > > > > It feels a bit weird that we a

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); Fznamznon wrote: > shafik wrote: > > Fznamznon wrote: > > > shafik wrote: > > > > shafik wrote: > > > > > It

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 544262. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156222/new/ https://reviews.llvm.org/D156222 Files: clang/lib/Sema/TypeLocBuilder.h Index:

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > What do you mean with libstdc++ is fine? What I mean is when I do (current patch is applied to clang): source/llvm-project/build/bin/clang++ -std=c++20 t.cpp -c // compilation succeeds But when I do (libc++ is built together with clang) source/llvm-project/bui

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb63fa00d1f7: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156222/new/ https://reviews.l

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

Fznamznon added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1906-1908 + if (D.isConstexpr()) +// Note: constexpr already initializes everything correctly. +trivialAutoVarInit = LangOptions::TrivialAutoVarInitKind::Uninitialized; Should we h

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Delegatin

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Identifie

[PATCH] D156415: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

Fznamznon added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:422 + // There's nothing to suggest in here as we parsed a full expression. + // Instead fail and propogate the error since caller might have something + // the suggest, e.g. signature help

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this change clang didn't emit missing-field-initializers warning for designated initializers. The comments say

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551051. Fznamznon added a comment. Add a release note, apply feedback: - Do not report invalid initializers as missing - Fix wrong warning if record has bitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon marked 3 inline comments as done. Fznamznon added a comment. > Thank you for working on this! The changes should come with a release note. Thanks for feedback, I added a release note. > Can we silence the diagnostic in these cases? And this is done. Repository: rG LLVM Github Mono

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. In D157879#4594790 , @tbaeder wrote: > Tangentially related: Now that we have this `InitializedFields` set, would it > be easy to add a warning for double-initialization of fields (that would also > trigger in C)? Isn't a war

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551460. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.cpp clang

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551924. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 Files: clang/docs/ReleaseNotes.rst clang/lib/S

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. The failure is unrelated, since the patch doesn't touch modules and I've seen the test failing for other patches as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 __

[PATCH] D157879: [clang] Report missing designated initializers in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91088978d712: [clang] Report missing designated initializers in C++ (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use member's type when printing. This also fixes a bug in warning diagnostic for out of order initialization with design

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

Fznamznon added inline comments. Comment at: clang/include/clang/AST/Decl.h:3186 + + void printName(raw_ostream &OS, const PrintingPolicy &Policy) const override; }; shafik wrote: > So it looks like w/o this we would end up using `NamedDecl::printName(...)` >

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds an error if variable with incomplete type has initializer with incomplete type, so it is not possible to deduc

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13460 + // initializer. + Diag(VDecl->getLocation(), diag::err_typecheck_decl_incomplete_type) + << VDeclType; Not sure about the error message though, maybe i

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545079. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405 Files: clang/lib/Frontend/FrontendAction.cpp I

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545080. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406 Files: clang/include/clang/Sema/IdentifierResolv

[PATCH] D156415: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545082. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 Files: clang/include/clang/Analysis/CFGStmtMap.h

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa623f4c78498: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fe23fbb2318: [NFC][analyzer] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa457067d2c6b: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } aaron.ballman wrote: > I think it migh

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > I agree this is a bug in libc++ and we should fix it. As mentioned I'm not > too familiar with ranges. Thanks! I submitted https://github.com/llvm/llvm-project/issues/64250 so we don't forget about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } cor3ntin wrote: > aaron.ballman wrote:

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon updated this revision to Diff 546445. Fznamznon added a comment. Rebase, add more test cases, fix assertion on variadic functions inside of `haveSameParameterTypes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156244/new/ https://reviews

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } ---

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ToolInvoc

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. InterpSta

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. IdDeclInf

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG962deded6c30: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156904/new/ https://reviews.l

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4bb3e073548: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156900/new/ https://reviews.l

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A bunch o

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per CWG 2672 substitution failure within the body of a lambda inside a requires-expression should be a hard error. Fixe

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon updated this revision to Diff 546837. Fznamznon added a comment. Rebase, apply feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156993/new/ https://reviews.llvm.org/D156993 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon added a comment. > Can you add a test in dr26xx ? Sure, done. Hope I updated cxx_dr_status in the right way. The script wasn't happy until I added "open" to the test comment. > maybe we need a test like Because I think the intent is for that to work Seems to be working if I got it ri

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGf887cb10acc9: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156896/new/ https://reviews.l

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG25d6f9ddc191: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156975/new/ https://reviews.l

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added a comment. Hmm, clang-format reports failure, but applying git-clang-format to the commit doesn't give me anything. It seems the whole SemaOverload.cpp file has broken formatting, maybe that is the reason for the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf91092c449d: [clang] Do not crash on use of a variadic overloaded operator (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

Fznamznon added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int x2[__builtin_offsetof(struct X2, X2::a) == 0 ? 1 : -1]; +int x3[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no member named 'X2'}} + It probably makes se

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG38cf47f037b2: [clang] Error on substitution failure within lambda body inside a requires… (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a792e06e8e7: [clang] Fix new-expression with elaborated-type-specifier (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `__has_extension (cxx_defaulted_functions)` and `__has_extension (cxx_defaulted_functions)` since they are accepted

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon updated this revision to Diff 536715. Fznamznon added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154334/new/ https://reviews.llvm.org/D154334 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Feature

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

Fznamznon added a comment. In D154334#4468158 , @aaron.ballman wrote: > Thank you for this! LGTM. but can you also be sure to update this table: > https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst?plain=1#L1429 Hmm, I hav

[PATCH] D154334: [clang] Add `__has_extension ()` for C++11 features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d4f2890823f: [clang] Add `__has_extension ()` for C++11 features (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. Ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/paren-list-agg-init.cpp:276-285 +namespace gh62863 { +int (&&arr)[] = static_cast(42); +// beforecxx20-warning@-1 {{aggregate initialization of type 'int[1]' from a parenthesized list of values is a C++20 extension}

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to incorrect calculation false positive diagnostics were emitted. Fixes https://github.com/llvm/llvm-project/issues

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:625 auto D = E->getBase()->getDependence(); + D |= getDependenceInExpr(E->getMemberNameInfo()); + While implementing this patch I was following Richard's guide from https://gith

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); cor3ntin wrote: > Maybe we should do that now, by passing `TemplateArgs` to

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added a comment. In D154689#4480249 , @cor3ntin wrote: > I think this makes sense and it implements richard's suggestion. > However, it's missing a release note, can you add that before landing? > Thanks Thank you for the review. I think I ad

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 538165. Fznamznon added a comment. Rebase, move the logic, modify c-style casts as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/ReleaseN

<    1   2   3   4   5   >